From: Mark Brown <broonie@kernel.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: lgirdwood@gmail.com, alsa-devel@alsa-project.org,
kuninori.morimoto.gx@renesas.com, linus.walleij@linaro.org,
robh+dt@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] bindings: sound: pcm3168a: Document optional RST gpio
Date: Mon, 18 Nov 2019 13:08:55 +0000 [thread overview]
Message-ID: <20191118130855.GE9761@sirena.org.uk> (raw)
In-Reply-To: <20191113124734.27984-2-peter.ujfalusi@ti.com>
[-- Attachment #1: Type: text/plain, Size: 551 bytes --]
On Wed, Nov 13, 2019 at 02:47:33PM +0200, Peter Ujfalusi wrote:
> On boards where the RST line is not pulled up, but it is connected to a
> GPIO line this property must present in order to be able to enable the
> codec.
Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
kuninori.morimoto.gx@renesas.com, linus.walleij@linaro.org,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
robh+dt@kernel.org
Subject: Re: [alsa-devel] [PATCH 1/2] bindings: sound: pcm3168a: Document optional RST gpio
Date: Mon, 18 Nov 2019 13:08:55 +0000 [thread overview]
Message-ID: <20191118130855.GE9761@sirena.org.uk> (raw)
In-Reply-To: <20191113124734.27984-2-peter.ujfalusi@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 551 bytes --]
On Wed, Nov 13, 2019 at 02:47:33PM +0200, Peter Ujfalusi wrote:
> On boards where the RST line is not pulled up, but it is connected to a
> GPIO line this property must present in order to be able to enable the
> codec.
Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-11-18 13:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 12:47 [PATCH 0/2] ASoC: pcm3168a: Poor man's RST gpio handling Peter Ujfalusi
2019-11-13 12:47 ` [alsa-devel] " Peter Ujfalusi
2019-11-13 12:47 ` [PATCH 1/2] bindings: sound: pcm3168a: Document optional RST gpio Peter Ujfalusi
2019-11-13 12:47 ` [alsa-devel] " Peter Ujfalusi
2019-11-18 13:08 ` Mark Brown [this message]
2019-11-18 13:08 ` Mark Brown
2019-11-18 14:46 ` Peter Ujfalusi
2019-11-18 14:46 ` [alsa-devel] " Peter Ujfalusi
2019-11-18 16:01 ` Mark Brown
2019-11-18 16:01 ` [alsa-devel] " Mark Brown
2019-11-18 13:09 ` Applied "ASoC: pcm3168a: Document optional RST gpio" to the asoc tree Mark Brown
2019-11-18 13:09 ` [alsa-devel] " Mark Brown
2019-11-18 21:32 ` [PATCH 1/2] bindings: sound: pcm3168a: Document optional RST gpio Rob Herring
2019-11-18 21:32 ` [alsa-devel] " Rob Herring
2019-11-13 12:47 ` [PATCH 2/2] ASoC: pcm3168a: Add support for optional RST gpio handling Peter Ujfalusi
2019-11-13 12:47 ` [alsa-devel] " Peter Ujfalusi
2019-11-18 13:09 ` Applied "ASoC: pcm3168a: Add support for optional RST gpio handling" to the asoc tree Mark Brown
2019-11-18 13:09 ` [alsa-devel] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191118130855.GE9761@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.