From: Boris Brezillon <boris.brezillon@collabora.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org,
Lucas Stach <l.stach@pengutronix.de>,
Chris Healy <cphealy@gmail.com>,
Andrey Smirnov <andrew.smirnov@gmail.com>,
Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
kernel@collabora.com, Daniel Vetter <daniel@ffwll.ch>,
Inki Dae <inki.dae@samsung.com>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rob Clark <robdclark@gmail.com>,
Andrzej Hajda <a.hajda@samsung.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 06/21] drm: Stop accessing encoder->bridge directly
Date: Sun, 24 Nov 2019 14:40:06 +0100 [thread overview]
Message-ID: <20191124144006.7e2fc959@collabora.com> (raw)
In-Reply-To: <20191124103926.GG4727@pendragon.ideasonboard.com>
On Sun, 24 Nov 2019 12:39:26 +0200
Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
> > @@ -1346,7 +1355,7 @@ void drm_atomic_helper_commit_modeset_enables(struct drm_device *dev,
> > funcs->commit(encoder);
> > }
> >
> > - drm_atomic_bridge_chain_enable(encoder->bridge, old_state);
> > + drm_atomic_bridge_chain_enable(bridge, old_state);
> > }
> >
> > drm_atomic_helper_commit_writebacks(dev, old_state);
> > diff --git a/drivers/gpu/drm/drm_encoder.c b/drivers/gpu/drm/drm_encoder.c
> > index 80d88a55302e..4fe9e723e227 100644
> > --- a/drivers/gpu/drm/drm_encoder.c
> > +++ b/drivers/gpu/drm/drm_encoder.c
> > @@ -167,9 +167,10 @@ void drm_encoder_cleanup(struct drm_encoder *encoder)
> > */
> >
> > if (encoder->bridge) {
> > - struct drm_bridge *bridge = encoder->bridge;
> > + struct drm_bridge *bridge;
> > struct drm_bridge *next;
> >
> > + bridge = drm_bridge_chain_get_first_bridge(encoder);
> > while (bridge) {
> > next = bridge->next;
>
> Shouldn't this have been addressed in the previous patch ?
>
It should and I will update patch 6 accordingly. This being said, it's
not a big deal since the code is patched to use
list_for_each_entry_safe() in patch 7 ;-).
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Neil Armstrong <narmstrong@baylibre.com>,
dri-devel@lists.freedesktop.org,
Thierry Reding <thierry.reding@gmail.com>,
kernel@collabora.com, Sam Ravnborg <sam@ravnborg.org>,
Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
Andrey Smirnov <andrew.smirnov@gmail.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Chris Healy <cphealy@gmail.com>,
devicetree@vger.kernel.org, Jonas Karlman <jonas@kwiboo.se>,
Rob Herring <robh+dt@kernel.org>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Seung-Woo Kim <sw0312.kim@samsung.com>
Subject: Re: [PATCH v3 06/21] drm: Stop accessing encoder->bridge directly
Date: Sun, 24 Nov 2019 14:40:06 +0100 [thread overview]
Message-ID: <20191124144006.7e2fc959@collabora.com> (raw)
In-Reply-To: <20191124103926.GG4727@pendragon.ideasonboard.com>
On Sun, 24 Nov 2019 12:39:26 +0200
Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
> > @@ -1346,7 +1355,7 @@ void drm_atomic_helper_commit_modeset_enables(struct drm_device *dev,
> > funcs->commit(encoder);
> > }
> >
> > - drm_atomic_bridge_chain_enable(encoder->bridge, old_state);
> > + drm_atomic_bridge_chain_enable(bridge, old_state);
> > }
> >
> > drm_atomic_helper_commit_writebacks(dev, old_state);
> > diff --git a/drivers/gpu/drm/drm_encoder.c b/drivers/gpu/drm/drm_encoder.c
> > index 80d88a55302e..4fe9e723e227 100644
> > --- a/drivers/gpu/drm/drm_encoder.c
> > +++ b/drivers/gpu/drm/drm_encoder.c
> > @@ -167,9 +167,10 @@ void drm_encoder_cleanup(struct drm_encoder *encoder)
> > */
> >
> > if (encoder->bridge) {
> > - struct drm_bridge *bridge = encoder->bridge;
> > + struct drm_bridge *bridge;
> > struct drm_bridge *next;
> >
> > + bridge = drm_bridge_chain_get_first_bridge(encoder);
> > while (bridge) {
> > next = bridge->next;
>
> Shouldn't this have been addressed in the previous patch ?
>
It should and I will update patch 6 accordingly. This being said, it's
not a big deal since the code is patched to use
list_for_each_entry_safe() in patch 7 ;-).
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-11-24 13:40 UTC|newest]
Thread overview: 156+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 15:44 [PATCH v3 00/21] drm: Add support for bus-format negotiation Boris Brezillon
2019-10-23 15:44 ` Boris Brezillon
2019-10-23 15:44 ` [PATCH v3 01/21] drm/vc4: Declare the DSI encoder as a bridge element Boris Brezillon
2019-10-23 15:44 ` Boris Brezillon
2019-11-24 10:01 ` Laurent Pinchart
2019-11-24 10:01 ` Laurent Pinchart
2019-11-24 10:47 ` Boris Brezillon
2019-11-24 10:47 ` Boris Brezillon
2019-10-23 15:44 ` [PATCH v3 02/21] drm/exynos: Don't reset bridge->next Boris Brezillon
2019-10-23 15:44 ` Boris Brezillon
2019-10-28 12:19 ` Inki Dae
2019-10-28 12:19 ` Inki Dae
2019-10-23 15:44 ` [PATCH v3 03/21] drm/exynos: Declare the DSI encoder as a bridge element Boris Brezillon
2019-10-23 15:44 ` Boris Brezillon
2019-11-24 10:24 ` Laurent Pinchart
2019-11-24 10:24 ` Laurent Pinchart
2019-11-24 13:17 ` Boris Brezillon
2019-11-24 13:17 ` Boris Brezillon
2019-11-24 13:28 ` Boris Brezillon
2019-11-24 13:28 ` Boris Brezillon
2019-11-24 14:02 ` Laurent Pinchart
2019-11-24 14:02 ` Laurent Pinchart
2019-10-23 15:44 ` [PATCH v3 04/21] drm/bridge: Rename bridge helpers targeting a bridge chain Boris Brezillon
2019-10-23 15:44 ` Boris Brezillon
2019-10-25 13:26 ` Neil Armstrong
2019-10-25 13:26 ` Neil Armstrong
2019-11-24 10:28 ` Laurent Pinchart
2019-11-24 10:28 ` Laurent Pinchart
2019-10-23 15:44 ` [PATCH v3 05/21] drm/bridge: Introduce drm_bridge_chain_get_next_bridge() Boris Brezillon
2019-10-23 15:44 ` Boris Brezillon
2019-10-25 13:27 ` Neil Armstrong
2019-10-25 13:27 ` Neil Armstrong
2019-11-24 10:33 ` Laurent Pinchart
2019-11-24 10:33 ` Laurent Pinchart
2019-11-24 10:56 ` Boris Brezillon
2019-11-24 10:56 ` Boris Brezillon
2019-11-24 14:04 ` Laurent Pinchart
2019-11-24 14:04 ` Laurent Pinchart
2019-10-23 15:44 ` [PATCH v3 06/21] drm: Stop accessing encoder->bridge directly Boris Brezillon
2019-10-23 15:44 ` Boris Brezillon
2019-10-25 13:28 ` Neil Armstrong
2019-10-25 13:28 ` Neil Armstrong
2019-11-24 10:39 ` Laurent Pinchart
2019-11-24 10:39 ` Laurent Pinchart
2019-11-24 13:40 ` Boris Brezillon [this message]
2019-11-24 13:40 ` Boris Brezillon
2019-10-23 15:44 ` [PATCH v3 07/21] drm/bridge: Make the bridge chain a double-linked list Boris Brezillon
2019-10-23 15:44 ` Boris Brezillon
2019-10-25 13:29 ` Neil Armstrong
2019-10-25 13:29 ` Neil Armstrong
2019-11-05 16:02 ` Neil Armstrong
2019-11-05 16:02 ` Neil Armstrong
2019-11-24 7:48 ` Boris Brezillon
2019-11-24 7:48 ` Boris Brezillon
2019-11-24 13:57 ` Laurent Pinchart
2019-11-24 13:57 ` Laurent Pinchart
2019-10-23 15:44 ` [PATCH v3 08/21] drm/bridge: Add the drm_for_each_bridge_in_chain() helper Boris Brezillon
2019-10-23 15:44 ` Boris Brezillon
2019-10-25 13:30 ` Neil Armstrong
2019-10-25 13:30 ` Neil Armstrong
2019-11-24 14:07 ` Laurent Pinchart
2019-11-24 14:07 ` Laurent Pinchart
2019-10-23 15:45 ` [PATCH v3 09/21] drm/bridge: Add a drm_bridge_state object Boris Brezillon
2019-10-23 15:45 ` Boris Brezillon
2019-10-25 14:35 ` Neil Armstrong
2019-10-25 14:35 ` Neil Armstrong
2019-11-05 16:05 ` Neil Armstrong
2019-11-05 16:05 ` Neil Armstrong
2019-11-24 7:50 ` Boris Brezillon
2019-11-24 7:50 ` Boris Brezillon
2019-12-02 16:42 ` Laurent Pinchart
2019-12-02 16:42 ` Laurent Pinchart
2019-10-23 15:45 ` [PATCH v3 10/21] drm/bridge: Clarify the atomic enable/disable hooks semantics Boris Brezillon
2019-10-23 15:45 ` Boris Brezillon
2019-10-25 14:33 ` Neil Armstrong
2019-10-25 14:33 ` Neil Armstrong
2019-12-02 16:50 ` Laurent Pinchart
2019-12-02 16:50 ` Laurent Pinchart
2019-10-23 15:45 ` [PATCH v3 11/21] drm/bridge: Patch atomic hooks to take a drm_bridge_state Boris Brezillon
2019-10-23 15:45 ` Boris Brezillon
2019-12-02 16:57 ` Laurent Pinchart
2019-12-02 16:57 ` Laurent Pinchart
2019-10-23 15:45 ` [PATCH v3 12/21] drm/bridge: Add an ->atomic_check() hook Boris Brezillon
2019-10-23 15:45 ` Boris Brezillon
2019-10-25 14:35 ` Neil Armstrong
2019-10-25 14:35 ` Neil Armstrong
2019-12-02 17:03 ` Laurent Pinchart
2019-12-02 17:03 ` Laurent Pinchart
2019-12-03 10:11 ` Boris Brezillon
2019-12-03 10:11 ` Boris Brezillon
2019-12-03 10:15 ` Laurent Pinchart
2019-12-03 10:15 ` Laurent Pinchart
2019-10-23 15:45 ` [PATCH v3 13/21] drm/bridge: Add the drm_bridge_chain_get_prev_bridge() helper Boris Brezillon
2019-10-23 15:45 ` Boris Brezillon
2019-10-25 14:34 ` Neil Armstrong
2019-10-25 14:34 ` Neil Armstrong
2019-12-02 17:05 ` Laurent Pinchart
2019-12-02 17:05 ` Laurent Pinchart
2019-10-23 15:45 ` [PATCH v3 14/21] drm/bridge: Add the necessary bits to support bus format negotiation Boris Brezillon
2019-10-23 15:45 ` Boris Brezillon
2019-12-03 10:03 ` Laurent Pinchart
2019-12-03 10:03 ` Laurent Pinchart
2019-10-23 15:45 ` [PATCH v3 15/21] drm/imx: pd: Use bus format/flags provided by the bridge when available Boris Brezillon
2019-10-23 15:45 ` Boris Brezillon
2019-12-03 13:50 ` Philipp Zabel
2019-12-03 13:50 ` Philipp Zabel
2019-10-23 15:45 ` [PATCH v3 16/21] drm/bridge: lvds-encoder: Implement basic bus format negotiation Boris Brezillon
2019-10-23 15:45 ` Boris Brezillon
2019-12-03 10:14 ` Laurent Pinchart
2019-12-03 10:14 ` Laurent Pinchart
2019-10-23 15:45 ` [PATCH v3 17/21] dt-bindings: display: bridge: lvds-transmitter: Add new props Boris Brezillon
2019-10-23 15:45 ` Boris Brezillon
2019-10-25 19:57 ` Rob Herring
2019-10-25 19:57 ` Rob Herring
2019-10-31 13:04 ` Boris Brezillon
2019-10-31 13:04 ` Boris Brezillon
2019-12-02 17:11 ` Laurent Pinchart
2019-12-02 17:11 ` Laurent Pinchart
2019-12-03 12:38 ` Boris Brezillon
2019-12-03 12:38 ` Boris Brezillon
2019-12-03 13:22 ` Laurent Pinchart
2019-12-03 13:22 ` Laurent Pinchart
2019-10-23 15:45 ` [PATCH v3 18/21] drm/bridge: panel: Propage bus format/flags Boris Brezillon
2019-10-23 15:45 ` Boris Brezillon
2019-12-03 10:17 ` Laurent Pinchart
2019-12-03 10:17 ` Laurent Pinchart
2020-01-22 9:27 ` Boris Brezillon
2020-01-22 9:27 ` Boris Brezillon
2019-10-23 15:45 ` [PATCH v3 19/21] drm/panel: simple: Add support for Toshiba LTA089AC29000 panel Boris Brezillon
2019-10-23 15:45 ` Boris Brezillon
2019-12-02 17:17 ` Laurent Pinchart
2019-12-02 17:17 ` Laurent Pinchart
2019-12-03 12:42 ` Boris Brezillon
2019-12-03 12:42 ` Boris Brezillon
2019-12-03 13:28 ` Laurent Pinchart
2019-12-03 13:28 ` Laurent Pinchart
2019-10-23 15:45 ` [PATCH v3 20/21] dt-bindings: display: panel: Add the LTA089AC29000 variant Boris Brezillon
2019-10-23 15:45 ` Boris Brezillon
2019-10-25 19:58 ` Rob Herring
2019-10-25 19:58 ` Rob Herring
2019-10-25 19:58 ` Rob Herring
2019-12-02 17:19 ` Laurent Pinchart
2019-12-02 17:19 ` Laurent Pinchart
2019-10-23 15:45 ` [PATCH v3 21/21] ARM: dts: imx: imx51-zii-rdu1: Fix the display pipeline definition Boris Brezillon
2019-10-23 15:45 ` Boris Brezillon
2019-10-24 11:27 ` [PATCH v3 00/21] drm: Add support for bus-format negotiation Neil Armstrong
2019-10-24 11:27 ` Neil Armstrong
2019-10-24 13:22 ` Boris Brezillon
2019-10-24 13:22 ` Boris Brezillon
2019-11-24 0:46 ` Ezequiel Garcia
2019-11-24 0:46 ` Ezequiel Garcia
2019-11-24 0:46 ` Ezequiel Garcia
2019-11-24 7:32 ` Boris Brezillon
2019-11-24 7:32 ` Boris Brezillon
2019-11-24 9:34 ` Ezequiel Garcia
2019-11-24 9:34 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191124144006.7e2fc959@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=a.hajda@samsung.com \
--cc=andrew.smirnov@gmail.com \
--cc=cphealy@gmail.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=jy0922.shim@samsung.com \
--cc=kernel@collabora.com \
--cc=kyungmin.park@samsung.com \
--cc=l.stach@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=mark.rutland@arm.com \
--cc=narmstrong@baylibre.com \
--cc=nikita.yoush@cogentembedded.com \
--cc=p.zabel@pengutronix.de \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=sw0312.kim@samsung.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.