From: Inki Dae <daeinki@gmail.com> To: Boris Brezillon <boris.brezillon@collabora.com> Cc: DRI mailing list <dri-devel@lists.freedesktop.org>, Mark Rutland <mark.rutland@arm.com>, Neil Armstrong <narmstrong@baylibre.com>, Thierry Reding <thierry.reding@gmail.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, kernel@collabora.com, Sam Ravnborg <sam@ravnborg.org>, Nikita Yushchenko <nikita.yoush@cogentembedded.com>, Andrey Smirnov <andrew.smirnov@gmail.com>, Kyungmin Park <kyungmin.park@samsung.com>, Chris Healy <cphealy@gmail.com>, devicetree@vger.kernel.org, Jonas Karlman <jonas@kwiboo.se>, Rob Herring <robh+dt@kernel.org>, Jernej Skrabec <jernej.skrabec@siol.net>, Seung-Woo Kim <sw0312.kim@samsung.com> Subject: Re: [PATCH v3 02/21] drm/exynos: Don't reset bridge->next Date: Mon, 28 Oct 2019 21:19:17 +0900 [thread overview] Message-ID: <CAAQKjZMh3=5=8JzkHYTeEGrOKNfN=eULTuXx1ZTDbsL7u3HQEw@mail.gmail.com> (raw) In-Reply-To: <20191023154512.9762-3-boris.brezillon@collabora.com> 2019년 10월 24일 (목) 오전 12:45, Boris Brezillon <boris.brezillon@collabora.com>님이 작성: > > bridge->next is only points to the new bridge if drm_bridge_attach() > succeeds. No need to reset it manually here. > > Note that this change is part of the attempt to make the bridge chain > a double-linked list. In order to do that we must patch all drivers > manipulating the bridge->next field. > > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > Changes in v2: > * Add Laurent's R-b (I'd like to have a R-b from the DRM exynos > maintainers before applying that one) Acked-by: Inki Dae <inki.dae@samsung.com> Thanks, Inki Dae > --- > drivers/gpu/drm/exynos/exynos_dp.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_dp.c b/drivers/gpu/drm/exynos/exynos_dp.c > index 1e6aa24bf45e..4785885c0f4f 100644 > --- a/drivers/gpu/drm/exynos/exynos_dp.c > +++ b/drivers/gpu/drm/exynos/exynos_dp.c > @@ -110,7 +110,6 @@ static int exynos_dp_bridge_attach(struct analogix_dp_plat_data *plat_data, > if (ret) { > DRM_DEV_ERROR(dp->dev, > "Failed to attach bridge to drm\n"); > - bridge->next = NULL; > return ret; > } > } > -- > 2.21.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Inki Dae <daeinki@gmail.com> To: Boris Brezillon <boris.brezillon@collabora.com> Cc: Mark Rutland <mark.rutland@arm.com>, Nikita Yushchenko <nikita.yoush@cogentembedded.com>, devicetree@vger.kernel.org, Neil Armstrong <narmstrong@baylibre.com>, Andrey Smirnov <andrew.smirnov@gmail.com>, Jonas Karlman <jonas@kwiboo.se>, Seung-Woo Kim <sw0312.kim@samsung.com>, Jernej Skrabec <jernej.skrabec@siol.net>, DRI mailing list <dri-devel@lists.freedesktop.org>, Rob Herring <robh+dt@kernel.org>, Kyungmin Park <kyungmin.park@samsung.com>, Thierry Reding <thierry.reding@gmail.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, kernel@collabora.com, Sam Ravnborg <sam@ravnborg.org>, Chris Healy <cphealy@gmail.com> Subject: Re: [PATCH v3 02/21] drm/exynos: Don't reset bridge->next Date: Mon, 28 Oct 2019 21:19:17 +0900 [thread overview] Message-ID: <CAAQKjZMh3=5=8JzkHYTeEGrOKNfN=eULTuXx1ZTDbsL7u3HQEw@mail.gmail.com> (raw) In-Reply-To: <20191023154512.9762-3-boris.brezillon@collabora.com> 2019년 10월 24일 (목) 오전 12:45, Boris Brezillon <boris.brezillon@collabora.com>님이 작성: > > bridge->next is only points to the new bridge if drm_bridge_attach() > succeeds. No need to reset it manually here. > > Note that this change is part of the attempt to make the bridge chain > a double-linked list. In order to do that we must patch all drivers > manipulating the bridge->next field. > > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > Changes in v2: > * Add Laurent's R-b (I'd like to have a R-b from the DRM exynos > maintainers before applying that one) Acked-by: Inki Dae <inki.dae@samsung.com> Thanks, Inki Dae > --- > drivers/gpu/drm/exynos/exynos_dp.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_dp.c b/drivers/gpu/drm/exynos/exynos_dp.c > index 1e6aa24bf45e..4785885c0f4f 100644 > --- a/drivers/gpu/drm/exynos/exynos_dp.c > +++ b/drivers/gpu/drm/exynos/exynos_dp.c > @@ -110,7 +110,6 @@ static int exynos_dp_bridge_attach(struct analogix_dp_plat_data *plat_data, > if (ret) { > DRM_DEV_ERROR(dp->dev, > "Failed to attach bridge to drm\n"); > - bridge->next = NULL; > return ret; > } > } > -- > 2.21.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-10-28 12:19 UTC|newest] Thread overview: 156+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-23 15:44 [PATCH v3 00/21] drm: Add support for bus-format negotiation Boris Brezillon 2019-10-23 15:44 ` Boris Brezillon 2019-10-23 15:44 ` [PATCH v3 01/21] drm/vc4: Declare the DSI encoder as a bridge element Boris Brezillon 2019-10-23 15:44 ` Boris Brezillon 2019-11-24 10:01 ` Laurent Pinchart 2019-11-24 10:01 ` Laurent Pinchart 2019-11-24 10:47 ` Boris Brezillon 2019-11-24 10:47 ` Boris Brezillon 2019-10-23 15:44 ` [PATCH v3 02/21] drm/exynos: Don't reset bridge->next Boris Brezillon 2019-10-23 15:44 ` Boris Brezillon 2019-10-28 12:19 ` Inki Dae [this message] 2019-10-28 12:19 ` Inki Dae 2019-10-23 15:44 ` [PATCH v3 03/21] drm/exynos: Declare the DSI encoder as a bridge element Boris Brezillon 2019-10-23 15:44 ` Boris Brezillon 2019-11-24 10:24 ` Laurent Pinchart 2019-11-24 10:24 ` Laurent Pinchart 2019-11-24 13:17 ` Boris Brezillon 2019-11-24 13:17 ` Boris Brezillon 2019-11-24 13:28 ` Boris Brezillon 2019-11-24 13:28 ` Boris Brezillon 2019-11-24 14:02 ` Laurent Pinchart 2019-11-24 14:02 ` Laurent Pinchart 2019-10-23 15:44 ` [PATCH v3 04/21] drm/bridge: Rename bridge helpers targeting a bridge chain Boris Brezillon 2019-10-23 15:44 ` Boris Brezillon 2019-10-25 13:26 ` Neil Armstrong 2019-10-25 13:26 ` Neil Armstrong 2019-11-24 10:28 ` Laurent Pinchart 2019-11-24 10:28 ` Laurent Pinchart 2019-10-23 15:44 ` [PATCH v3 05/21] drm/bridge: Introduce drm_bridge_chain_get_next_bridge() Boris Brezillon 2019-10-23 15:44 ` Boris Brezillon 2019-10-25 13:27 ` Neil Armstrong 2019-10-25 13:27 ` Neil Armstrong 2019-11-24 10:33 ` Laurent Pinchart 2019-11-24 10:33 ` Laurent Pinchart 2019-11-24 10:56 ` Boris Brezillon 2019-11-24 10:56 ` Boris Brezillon 2019-11-24 14:04 ` Laurent Pinchart 2019-11-24 14:04 ` Laurent Pinchart 2019-10-23 15:44 ` [PATCH v3 06/21] drm: Stop accessing encoder->bridge directly Boris Brezillon 2019-10-23 15:44 ` Boris Brezillon 2019-10-25 13:28 ` Neil Armstrong 2019-10-25 13:28 ` Neil Armstrong 2019-11-24 10:39 ` Laurent Pinchart 2019-11-24 10:39 ` Laurent Pinchart 2019-11-24 13:40 ` Boris Brezillon 2019-11-24 13:40 ` Boris Brezillon 2019-10-23 15:44 ` [PATCH v3 07/21] drm/bridge: Make the bridge chain a double-linked list Boris Brezillon 2019-10-23 15:44 ` Boris Brezillon 2019-10-25 13:29 ` Neil Armstrong 2019-10-25 13:29 ` Neil Armstrong 2019-11-05 16:02 ` Neil Armstrong 2019-11-05 16:02 ` Neil Armstrong 2019-11-24 7:48 ` Boris Brezillon 2019-11-24 7:48 ` Boris Brezillon 2019-11-24 13:57 ` Laurent Pinchart 2019-11-24 13:57 ` Laurent Pinchart 2019-10-23 15:44 ` [PATCH v3 08/21] drm/bridge: Add the drm_for_each_bridge_in_chain() helper Boris Brezillon 2019-10-23 15:44 ` Boris Brezillon 2019-10-25 13:30 ` Neil Armstrong 2019-10-25 13:30 ` Neil Armstrong 2019-11-24 14:07 ` Laurent Pinchart 2019-11-24 14:07 ` Laurent Pinchart 2019-10-23 15:45 ` [PATCH v3 09/21] drm/bridge: Add a drm_bridge_state object Boris Brezillon 2019-10-23 15:45 ` Boris Brezillon 2019-10-25 14:35 ` Neil Armstrong 2019-10-25 14:35 ` Neil Armstrong 2019-11-05 16:05 ` Neil Armstrong 2019-11-05 16:05 ` Neil Armstrong 2019-11-24 7:50 ` Boris Brezillon 2019-11-24 7:50 ` Boris Brezillon 2019-12-02 16:42 ` Laurent Pinchart 2019-12-02 16:42 ` Laurent Pinchart 2019-10-23 15:45 ` [PATCH v3 10/21] drm/bridge: Clarify the atomic enable/disable hooks semantics Boris Brezillon 2019-10-23 15:45 ` Boris Brezillon 2019-10-25 14:33 ` Neil Armstrong 2019-10-25 14:33 ` Neil Armstrong 2019-12-02 16:50 ` Laurent Pinchart 2019-12-02 16:50 ` Laurent Pinchart 2019-10-23 15:45 ` [PATCH v3 11/21] drm/bridge: Patch atomic hooks to take a drm_bridge_state Boris Brezillon 2019-10-23 15:45 ` Boris Brezillon 2019-12-02 16:57 ` Laurent Pinchart 2019-12-02 16:57 ` Laurent Pinchart 2019-10-23 15:45 ` [PATCH v3 12/21] drm/bridge: Add an ->atomic_check() hook Boris Brezillon 2019-10-23 15:45 ` Boris Brezillon 2019-10-25 14:35 ` Neil Armstrong 2019-10-25 14:35 ` Neil Armstrong 2019-12-02 17:03 ` Laurent Pinchart 2019-12-02 17:03 ` Laurent Pinchart 2019-12-03 10:11 ` Boris Brezillon 2019-12-03 10:11 ` Boris Brezillon 2019-12-03 10:15 ` Laurent Pinchart 2019-12-03 10:15 ` Laurent Pinchart 2019-10-23 15:45 ` [PATCH v3 13/21] drm/bridge: Add the drm_bridge_chain_get_prev_bridge() helper Boris Brezillon 2019-10-23 15:45 ` Boris Brezillon 2019-10-25 14:34 ` Neil Armstrong 2019-10-25 14:34 ` Neil Armstrong 2019-12-02 17:05 ` Laurent Pinchart 2019-12-02 17:05 ` Laurent Pinchart 2019-10-23 15:45 ` [PATCH v3 14/21] drm/bridge: Add the necessary bits to support bus format negotiation Boris Brezillon 2019-10-23 15:45 ` Boris Brezillon 2019-12-03 10:03 ` Laurent Pinchart 2019-12-03 10:03 ` Laurent Pinchart 2019-10-23 15:45 ` [PATCH v3 15/21] drm/imx: pd: Use bus format/flags provided by the bridge when available Boris Brezillon 2019-10-23 15:45 ` Boris Brezillon 2019-12-03 13:50 ` Philipp Zabel 2019-12-03 13:50 ` Philipp Zabel 2019-10-23 15:45 ` [PATCH v3 16/21] drm/bridge: lvds-encoder: Implement basic bus format negotiation Boris Brezillon 2019-10-23 15:45 ` Boris Brezillon 2019-12-03 10:14 ` Laurent Pinchart 2019-12-03 10:14 ` Laurent Pinchart 2019-10-23 15:45 ` [PATCH v3 17/21] dt-bindings: display: bridge: lvds-transmitter: Add new props Boris Brezillon 2019-10-23 15:45 ` Boris Brezillon 2019-10-25 19:57 ` Rob Herring 2019-10-25 19:57 ` Rob Herring 2019-10-31 13:04 ` Boris Brezillon 2019-10-31 13:04 ` Boris Brezillon 2019-12-02 17:11 ` Laurent Pinchart 2019-12-02 17:11 ` Laurent Pinchart 2019-12-03 12:38 ` Boris Brezillon 2019-12-03 12:38 ` Boris Brezillon 2019-12-03 13:22 ` Laurent Pinchart 2019-12-03 13:22 ` Laurent Pinchart 2019-10-23 15:45 ` [PATCH v3 18/21] drm/bridge: panel: Propage bus format/flags Boris Brezillon 2019-10-23 15:45 ` Boris Brezillon 2019-12-03 10:17 ` Laurent Pinchart 2019-12-03 10:17 ` Laurent Pinchart 2020-01-22 9:27 ` Boris Brezillon 2020-01-22 9:27 ` Boris Brezillon 2019-10-23 15:45 ` [PATCH v3 19/21] drm/panel: simple: Add support for Toshiba LTA089AC29000 panel Boris Brezillon 2019-10-23 15:45 ` Boris Brezillon 2019-12-02 17:17 ` Laurent Pinchart 2019-12-02 17:17 ` Laurent Pinchart 2019-12-03 12:42 ` Boris Brezillon 2019-12-03 12:42 ` Boris Brezillon 2019-12-03 13:28 ` Laurent Pinchart 2019-12-03 13:28 ` Laurent Pinchart 2019-10-23 15:45 ` [PATCH v3 20/21] dt-bindings: display: panel: Add the LTA089AC29000 variant Boris Brezillon 2019-10-23 15:45 ` Boris Brezillon 2019-10-25 19:58 ` Rob Herring 2019-10-25 19:58 ` Rob Herring 2019-10-25 19:58 ` Rob Herring 2019-12-02 17:19 ` Laurent Pinchart 2019-12-02 17:19 ` Laurent Pinchart 2019-10-23 15:45 ` [PATCH v3 21/21] ARM: dts: imx: imx51-zii-rdu1: Fix the display pipeline definition Boris Brezillon 2019-10-23 15:45 ` Boris Brezillon 2019-10-24 11:27 ` [PATCH v3 00/21] drm: Add support for bus-format negotiation Neil Armstrong 2019-10-24 11:27 ` Neil Armstrong 2019-10-24 13:22 ` Boris Brezillon 2019-10-24 13:22 ` Boris Brezillon 2019-11-24 0:46 ` Ezequiel Garcia 2019-11-24 0:46 ` Ezequiel Garcia 2019-11-24 0:46 ` Ezequiel Garcia 2019-11-24 7:32 ` Boris Brezillon 2019-11-24 7:32 ` Boris Brezillon 2019-11-24 9:34 ` Ezequiel Garcia 2019-11-24 9:34 ` Ezequiel Garcia
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAAQKjZMh3=5=8JzkHYTeEGrOKNfN=eULTuXx1ZTDbsL7u3HQEw@mail.gmail.com' \ --to=daeinki@gmail.com \ --cc=andrew.smirnov@gmail.com \ --cc=boris.brezillon@collabora.com \ --cc=cphealy@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=jernej.skrabec@siol.net \ --cc=jonas@kwiboo.se \ --cc=kernel@collabora.com \ --cc=kyungmin.park@samsung.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=mark.rutland@arm.com \ --cc=narmstrong@baylibre.com \ --cc=nikita.yoush@cogentembedded.com \ --cc=robh+dt@kernel.org \ --cc=sam@ravnborg.org \ --cc=sw0312.kim@samsung.com \ --cc=thierry.reding@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.