From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> To: Fabio Estevam <festevam@gmail.com> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>, Sakari Ailus <sakari.ailus@iki.fi>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, c.barrett@framos.com, linux-kernel <linux-kernel@vger.kernel.org>, a.brela@framos.com, Peter Griffin <peter.griffin@linaro.org>, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>, linux-media <linux-media@vger.kernel.org> Subject: Re: [PATCH 3/5] media: i2c: imx290: Add RAW12 mode support Date: Sat, 30 Nov 2019 19:39:29 +0530 [thread overview] Message-ID: <20191130140929.GA23629@Mani-XPS-13-9360> (raw) In-Reply-To: <CAOMZO5Btkd0NLM5RBFZHD5dryE7mR5JZRLC2X__pQNmjHGCywA@mail.gmail.com> Hi Fabio, On Fri, Nov 29, 2019 at 04:49:25PM -0300, Fabio Estevam wrote: > Hi Manivannan, > > On Fri, Nov 29, 2019 at 4:07 PM Manivannan Sadhasivam > <manivannan.sadhasivam@linaro.org> wrote: > } > > + > > + imx290->bpp = 10; > > + > > + break; > > + case MEDIA_BUS_FMT_SRGGB12_1X12: > > + ret = imx290_set_register_array(imx290, imx290_12bit_settings, > > + ARRAY_SIZE( > > + imx290_12bit_settings)); > > Could you please write the ARRAY_SIZE and its parameter in the same line? > > It would improve readability. > I don't favor this change but Sakari did this to supress the checkpatch warning while applying my initial patch, so now I did this here itself to maintain the uniformity. Thanks, Mani > Thanks
WARNING: multiple messages have this Message-ID (diff)
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> To: Fabio Estevam <festevam@gmail.com> Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, c.barrett@framos.com, linux-kernel <linux-kernel@vger.kernel.org>, a.brela@framos.com, Peter Griffin <peter.griffin@linaro.org>, Sakari Ailus <sakari.ailus@iki.fi>, Mauro Carvalho Chehab <mchehab@kernel.org>, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>, linux-media <linux-media@vger.kernel.org> Subject: Re: [PATCH 3/5] media: i2c: imx290: Add RAW12 mode support Date: Sat, 30 Nov 2019 19:39:29 +0530 [thread overview] Message-ID: <20191130140929.GA23629@Mani-XPS-13-9360> (raw) In-Reply-To: <CAOMZO5Btkd0NLM5RBFZHD5dryE7mR5JZRLC2X__pQNmjHGCywA@mail.gmail.com> Hi Fabio, On Fri, Nov 29, 2019 at 04:49:25PM -0300, Fabio Estevam wrote: > Hi Manivannan, > > On Fri, Nov 29, 2019 at 4:07 PM Manivannan Sadhasivam > <manivannan.sadhasivam@linaro.org> wrote: > } > > + > > + imx290->bpp = 10; > > + > > + break; > > + case MEDIA_BUS_FMT_SRGGB12_1X12: > > + ret = imx290_set_register_array(imx290, imx290_12bit_settings, > > + ARRAY_SIZE( > > + imx290_12bit_settings)); > > Could you please write the ARRAY_SIZE and its parameter in the same line? > > It would improve readability. > I don't favor this change but Sakari did this to supress the checkpatch warning while applying my initial patch, so now I did this here itself to maintain the uniformity. Thanks, Mani > Thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-30 14:09 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-29 19:05 [PATCH 0/5] Improvements to IMX290 CMOS driver Manivannan Sadhasivam 2019-11-29 19:05 ` Manivannan Sadhasivam 2019-11-29 19:05 ` [PATCH 1/5] media: i2c: imx290: Add support for 2 data lanes Manivannan Sadhasivam 2019-11-29 19:05 ` Manivannan Sadhasivam 2019-12-03 8:45 ` Sakari Ailus 2019-12-03 8:45 ` Sakari Ailus 2019-12-15 17:34 ` Manivannan Sadhasivam 2019-12-15 17:34 ` Manivannan Sadhasivam 2019-11-29 19:05 ` [PATCH 2/5] media: i2c: imx290: Add support for test pattern generation Manivannan Sadhasivam 2019-11-29 19:05 ` Manivannan Sadhasivam 2019-12-03 8:48 ` Sakari Ailus 2019-12-03 8:48 ` Sakari Ailus 2019-12-15 17:35 ` Manivannan Sadhasivam 2019-12-15 17:35 ` Manivannan Sadhasivam 2019-11-29 19:05 ` [PATCH 3/5] media: i2c: imx290: Add RAW12 mode support Manivannan Sadhasivam 2019-11-29 19:05 ` Manivannan Sadhasivam 2019-11-29 19:49 ` Fabio Estevam 2019-11-29 19:49 ` Fabio Estevam 2019-11-30 14:09 ` Manivannan Sadhasivam [this message] 2019-11-30 14:09 ` Manivannan Sadhasivam 2019-12-03 8:54 ` Sakari Ailus 2019-12-03 8:54 ` Sakari Ailus 2019-12-15 17:46 ` Manivannan Sadhasivam 2019-12-15 17:46 ` Manivannan Sadhasivam 2019-12-27 15:28 ` Sakari Ailus 2019-12-27 15:28 ` Sakari Ailus 2019-11-29 19:05 ` [PATCH 4/5] media: i2c: imx290: Add support to enumerate all frame sizes Manivannan Sadhasivam 2019-11-29 19:05 ` Manivannan Sadhasivam 2019-12-03 8:56 ` Sakari Ailus 2019-12-03 8:56 ` Sakari Ailus 2019-12-15 17:48 ` Manivannan Sadhasivam 2019-12-15 17:48 ` Manivannan Sadhasivam [not found] ` <CAFP0Ok8Vqze8ZRyT1WvMXZeBLcx7oKcTO1Kad4kSFLbpHkok-A@mail.gmail.com> 2019-12-16 4:04 ` Manivannan Sadhasivam 2019-12-16 4:04 ` Manivannan Sadhasivam 2019-11-29 19:05 ` [PATCH 5/5] media: i2c: imx290: Add configurable link frequency and pixel rate Manivannan Sadhasivam 2019-11-29 19:05 ` Manivannan Sadhasivam
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191130140929.GA23629@Mani-XPS-13-9360 \ --to=manivannan.sadhasivam@linaro.org \ --cc=a.brela@framos.com \ --cc=c.barrett@framos.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=mchehab@kernel.org \ --cc=peter.griffin@linaro.org \ --cc=sakari.ailus@iki.fi \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.