From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> To: Sakari Ailus <sakari.ailus@iki.fi> Cc: mchehab@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, c.barrett@framos.com, a.brela@framos.com, peter.griffin@linaro.org Subject: Re: [PATCH 4/5] media: i2c: imx290: Add support to enumerate all frame sizes Date: Sun, 15 Dec 2019 23:18:34 +0530 [thread overview] Message-ID: <20191215174834.GD11427@Mani-XPS-13-9360> (raw) In-Reply-To: <20191203085604.GC5282@valkosipuli.retiisi.org.uk> Hi Sakari, On Tue, Dec 03, 2019 at 10:56:04AM +0200, Sakari Ailus wrote: > On Sat, Nov 30, 2019 at 12:35:40AM +0530, Manivannan Sadhasivam wrote: > > Add support to enumerate all frame sizes supported by IMX290. This is > > required for using with userspace tools such as libcamera. > > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > --- > > drivers/media/i2c/imx290.c | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c > > index d5bb3a59ac46..f26c4a0ee0a0 100644 > > --- a/drivers/media/i2c/imx290.c > > +++ b/drivers/media/i2c/imx290.c > > @@ -468,6 +468,25 @@ static int imx290_enum_mbus_code(struct v4l2_subdev *sd, > > return 0; > > } > > > > +static int imx290_enum_frame_size(struct v4l2_subdev *subdev, > > + struct v4l2_subdev_pad_config *cfg, > > + struct v4l2_subdev_frame_size_enum *fse) > > +{ > > + if ((fse->code != imx290_formats[0].code) && > > + (fse->code != imx290_formats[1].code)) > > Please use a loop over imx290_formats instead. > May I know why? What benefit does it provide over current method? Thanks, Mani > > + return -EINVAL; > > + > > + if (fse->index >= ARRAY_SIZE(imx290_modes)) > > + return -EINVAL; > > + > > + fse->min_width = imx290_modes[fse->index].width; > > + fse->max_width = imx290_modes[fse->index].width; > > + fse->min_height = imx290_modes[fse->index].height; > > + fse->max_height = imx290_modes[fse->index].height; > > + > > + return 0; > > +} > > + > > static int imx290_get_fmt(struct v4l2_subdev *sd, > > struct v4l2_subdev_pad_config *cfg, > > struct v4l2_subdev_format *fmt) > > @@ -820,6 +839,7 @@ static const struct v4l2_subdev_video_ops imx290_video_ops = { > > static const struct v4l2_subdev_pad_ops imx290_pad_ops = { > > .init_cfg = imx290_entity_init_cfg, > > .enum_mbus_code = imx290_enum_mbus_code, > > + .enum_frame_size = imx290_enum_frame_size, > > .get_fmt = imx290_get_fmt, > > .set_fmt = imx290_set_fmt, > > }; > > -- > Regards, > > Sakari Ailus
WARNING: multiple messages have this Message-ID (diff)
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> To: Sakari Ailus <sakari.ailus@iki.fi> Cc: devicetree@vger.kernel.org, c.barrett@framos.com, linux-kernel@vger.kernel.org, a.brela@framos.com, peter.griffin@linaro.org, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Subject: Re: [PATCH 4/5] media: i2c: imx290: Add support to enumerate all frame sizes Date: Sun, 15 Dec 2019 23:18:34 +0530 [thread overview] Message-ID: <20191215174834.GD11427@Mani-XPS-13-9360> (raw) In-Reply-To: <20191203085604.GC5282@valkosipuli.retiisi.org.uk> Hi Sakari, On Tue, Dec 03, 2019 at 10:56:04AM +0200, Sakari Ailus wrote: > On Sat, Nov 30, 2019 at 12:35:40AM +0530, Manivannan Sadhasivam wrote: > > Add support to enumerate all frame sizes supported by IMX290. This is > > required for using with userspace tools such as libcamera. > > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > --- > > drivers/media/i2c/imx290.c | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c > > index d5bb3a59ac46..f26c4a0ee0a0 100644 > > --- a/drivers/media/i2c/imx290.c > > +++ b/drivers/media/i2c/imx290.c > > @@ -468,6 +468,25 @@ static int imx290_enum_mbus_code(struct v4l2_subdev *sd, > > return 0; > > } > > > > +static int imx290_enum_frame_size(struct v4l2_subdev *subdev, > > + struct v4l2_subdev_pad_config *cfg, > > + struct v4l2_subdev_frame_size_enum *fse) > > +{ > > + if ((fse->code != imx290_formats[0].code) && > > + (fse->code != imx290_formats[1].code)) > > Please use a loop over imx290_formats instead. > May I know why? What benefit does it provide over current method? Thanks, Mani > > + return -EINVAL; > > + > > + if (fse->index >= ARRAY_SIZE(imx290_modes)) > > + return -EINVAL; > > + > > + fse->min_width = imx290_modes[fse->index].width; > > + fse->max_width = imx290_modes[fse->index].width; > > + fse->min_height = imx290_modes[fse->index].height; > > + fse->max_height = imx290_modes[fse->index].height; > > + > > + return 0; > > +} > > + > > static int imx290_get_fmt(struct v4l2_subdev *sd, > > struct v4l2_subdev_pad_config *cfg, > > struct v4l2_subdev_format *fmt) > > @@ -820,6 +839,7 @@ static const struct v4l2_subdev_video_ops imx290_video_ops = { > > static const struct v4l2_subdev_pad_ops imx290_pad_ops = { > > .init_cfg = imx290_entity_init_cfg, > > .enum_mbus_code = imx290_enum_mbus_code, > > + .enum_frame_size = imx290_enum_frame_size, > > .get_fmt = imx290_get_fmt, > > .set_fmt = imx290_set_fmt, > > }; > > -- > Regards, > > Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-15 17:48 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-29 19:05 [PATCH 0/5] Improvements to IMX290 CMOS driver Manivannan Sadhasivam 2019-11-29 19:05 ` Manivannan Sadhasivam 2019-11-29 19:05 ` [PATCH 1/5] media: i2c: imx290: Add support for 2 data lanes Manivannan Sadhasivam 2019-11-29 19:05 ` Manivannan Sadhasivam 2019-12-03 8:45 ` Sakari Ailus 2019-12-03 8:45 ` Sakari Ailus 2019-12-15 17:34 ` Manivannan Sadhasivam 2019-12-15 17:34 ` Manivannan Sadhasivam 2019-11-29 19:05 ` [PATCH 2/5] media: i2c: imx290: Add support for test pattern generation Manivannan Sadhasivam 2019-11-29 19:05 ` Manivannan Sadhasivam 2019-12-03 8:48 ` Sakari Ailus 2019-12-03 8:48 ` Sakari Ailus 2019-12-15 17:35 ` Manivannan Sadhasivam 2019-12-15 17:35 ` Manivannan Sadhasivam 2019-11-29 19:05 ` [PATCH 3/5] media: i2c: imx290: Add RAW12 mode support Manivannan Sadhasivam 2019-11-29 19:05 ` Manivannan Sadhasivam 2019-11-29 19:49 ` Fabio Estevam 2019-11-29 19:49 ` Fabio Estevam 2019-11-30 14:09 ` Manivannan Sadhasivam 2019-11-30 14:09 ` Manivannan Sadhasivam 2019-12-03 8:54 ` Sakari Ailus 2019-12-03 8:54 ` Sakari Ailus 2019-12-15 17:46 ` Manivannan Sadhasivam 2019-12-15 17:46 ` Manivannan Sadhasivam 2019-12-27 15:28 ` Sakari Ailus 2019-12-27 15:28 ` Sakari Ailus 2019-11-29 19:05 ` [PATCH 4/5] media: i2c: imx290: Add support to enumerate all frame sizes Manivannan Sadhasivam 2019-11-29 19:05 ` Manivannan Sadhasivam 2019-12-03 8:56 ` Sakari Ailus 2019-12-03 8:56 ` Sakari Ailus 2019-12-15 17:48 ` Manivannan Sadhasivam [this message] 2019-12-15 17:48 ` Manivannan Sadhasivam [not found] ` <CAFP0Ok8Vqze8ZRyT1WvMXZeBLcx7oKcTO1Kad4kSFLbpHkok-A@mail.gmail.com> 2019-12-16 4:04 ` Manivannan Sadhasivam 2019-12-16 4:04 ` Manivannan Sadhasivam 2019-11-29 19:05 ` [PATCH 5/5] media: i2c: imx290: Add configurable link frequency and pixel rate Manivannan Sadhasivam 2019-11-29 19:05 ` Manivannan Sadhasivam
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191215174834.GD11427@Mani-XPS-13-9360 \ --to=manivannan.sadhasivam@linaro.org \ --cc=a.brela@framos.com \ --cc=c.barrett@framos.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=mchehab@kernel.org \ --cc=peter.griffin@linaro.org \ --cc=sakari.ailus@iki.fi \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.