From: Nishad Kamdar <nishadkamdar@gmail.com>
To: "Andreas Färber" <afaerber@suse.de>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Sean Wang" <sean.wang@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Kevin Hilman" <khilman@baylibre.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@st.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Joe Perches" <joe@perches.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-amlogic@lists.infradead.org,
linux-renesas-soc@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] pinctrl: actions: Use the correct style for SPDX License Identifier
Date: Thu, 5 Dec 2019 20:18:48 +0530 [thread overview]
Message-ID: <20191205144844.GA2903@nishad> (raw)
In-Reply-To: <c76290a7-b9bb-7f70-e750-04fe6fdbb7e1@suse.de>
On Wed, Nov 27, 2019 at 10:02:08PM +0100, Andreas Färber wrote:
> Am 27.11.19 um 17:40 schrieb Nishad Kamdar:
> > This patch corrects the SPDX License Identifier style in
> > header file related Actions Semi OWL pinctrl driver.
>
> Owl
>
I used the same format mentioned below, which also says OWL.
Meybe we can change both of them in a separate patch.
> > For C header files Documentation/process/license-rules.rst
> > mandates C-like comments (opposed to C source files where
> > C++ style should be used).
> >
> > Changes made by using a script provided by Joe Perches here:
> > https://lkml.org/lkml/2019/2/7/46.
> >
> > Suggested-by: Joe Perches <joe@perches.com>
> > Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
> > ---
> > drivers/pinctrl/actions/pinctrl-owl.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pinctrl/actions/pinctrl-owl.h b/drivers/pinctrl/actions/pinctrl-owl.h
> > index dae2e8363fd5..feee7ad7e27e 100644
> > --- a/drivers/pinctrl/actions/pinctrl-owl.h
> > +++ b/drivers/pinctrl/actions/pinctrl-owl.h
> > @@ -1,4 +1,4 @@
> > -// SPDX-License-Identifier: GPL-2.0+
> > +/* SPDX-License-Identifier: GPL-2.0+ */
>
> This is not a uapi or asm header, which that /* */ rule was later added
> for, I thought?
>
I might be wrong but I think it applies to this file too as there as there is a SPDX
identifier in the first place.
> > /*
> > * OWL SoC's Pinctrl definitions
> > *
>
> Not objecting, just making sure we're not blindly refactoring code.
>
I am not sure what you are trying to say here, but the SPDX identifier
requires an independent block comment. Hence placed the obove code in a
separate block comment. Everything else is as it is.
> If doing this, I suggest updating to GPL-2.0-or-later.
>
We can do this in a separate patch as this patch only talks about
the style.
> Regards,
> Andreas
>
> --
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer
> HRB 36809 (AG Nürnberg)
Thanks very much for your time and review.
Regards,
Nishad
WARNING: multiple messages have this Message-ID (diff)
From: Nishad Kamdar <nishadkamdar@gmail.com>
To: "Andreas Färber" <afaerber@suse.de>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Sean Wang" <sean.wang@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Kevin Hilman" <khilman@baylibre.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@st.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Joe Perches" <joe@perches.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5] pinctrl: actions: Use the correct style for SPDX License Identifier
Date: Thu, 5 Dec 2019 20:18:48 +0530 [thread overview]
Message-ID: <20191205144844.GA2903@nishad> (raw)
In-Reply-To: <c76290a7-b9bb-7f70-e750-04fe6fdbb7e1@suse.de>
On Wed, Nov 27, 2019 at 10:02:08PM +0100, Andreas Färber wrote:
> Am 27.11.19 um 17:40 schrieb Nishad Kamdar:
> > This patch corrects the SPDX License Identifier style in
> > header file related Actions Semi OWL pinctrl driver.
>
> Owl
>
I used the same format mentioned below, which also says OWL.
Meybe we can change both of them in a separate patch.
> > For C header files Documentation/process/license-rules.rst
> > mandates C-like comments (opposed to C source files where
> > C++ style should be used).
> >
> > Changes made by using a script provided by Joe Perches here:
> > https://lkml.org/lkml/2019/2/7/46.
> >
> > Suggested-by: Joe Perches <joe@perches.com>
> > Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
> > ---
> > drivers/pinctrl/actions/pinctrl-owl.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pinctrl/actions/pinctrl-owl.h b/drivers/pinctrl/actions/pinctrl-owl.h
> > index dae2e8363fd5..feee7ad7e27e 100644
> > --- a/drivers/pinctrl/actions/pinctrl-owl.h
> > +++ b/drivers/pinctrl/actions/pinctrl-owl.h
> > @@ -1,4 +1,4 @@
> > -// SPDX-License-Identifier: GPL-2.0+
> > +/* SPDX-License-Identifier: GPL-2.0+ */
>
> This is not a uapi or asm header, which that /* */ rule was later added
> for, I thought?
>
I might be wrong but I think it applies to this file too as there as there is a SPDX
identifier in the first place.
> > /*
> > * OWL SoC's Pinctrl definitions
> > *
>
> Not objecting, just making sure we're not blindly refactoring code.
>
I am not sure what you are trying to say here, but the SPDX identifier
requires an independent block comment. Hence placed the obove code in a
separate block comment. Everything else is as it is.
> If doing this, I suggest updating to GPL-2.0-or-later.
>
We can do this in a separate patch as this patch only talks about
the style.
> Regards,
> Andreas
>
> --
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer
> HRB 36809 (AG Nürnberg)
Thanks very much for your time and review.
Regards,
Nishad
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Nishad Kamdar <nishadkamdar@gmail.com>
To: "Andreas Färber" <afaerber@suse.de>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Sean Wang" <sean.wang@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Kevin Hilman" <khilman@baylibre.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@st.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Joe Perches" <joe@perches.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5] pinctrl: actions: Use the correct style for SPDX License Identifier
Date: Thu, 5 Dec 2019 20:18:48 +0530 [thread overview]
Message-ID: <20191205144844.GA2903@nishad> (raw)
In-Reply-To: <c76290a7-b9bb-7f70-e750-04fe6fdbb7e1@suse.de>
On Wed, Nov 27, 2019 at 10:02:08PM +0100, Andreas Färber wrote:
> Am 27.11.19 um 17:40 schrieb Nishad Kamdar:
> > This patch corrects the SPDX License Identifier style in
> > header file related Actions Semi OWL pinctrl driver.
>
> Owl
>
I used the same format mentioned below, which also says OWL.
Meybe we can change both of them in a separate patch.
> > For C header files Documentation/process/license-rules.rst
> > mandates C-like comments (opposed to C source files where
> > C++ style should be used).
> >
> > Changes made by using a script provided by Joe Perches here:
> > https://lkml.org/lkml/2019/2/7/46.
> >
> > Suggested-by: Joe Perches <joe@perches.com>
> > Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
> > ---
> > drivers/pinctrl/actions/pinctrl-owl.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pinctrl/actions/pinctrl-owl.h b/drivers/pinctrl/actions/pinctrl-owl.h
> > index dae2e8363fd5..feee7ad7e27e 100644
> > --- a/drivers/pinctrl/actions/pinctrl-owl.h
> > +++ b/drivers/pinctrl/actions/pinctrl-owl.h
> > @@ -1,4 +1,4 @@
> > -// SPDX-License-Identifier: GPL-2.0+
> > +/* SPDX-License-Identifier: GPL-2.0+ */
>
> This is not a uapi or asm header, which that /* */ rule was later added
> for, I thought?
>
I might be wrong but I think it applies to this file too as there as there is a SPDX
identifier in the first place.
> > /*
> > * OWL SoC's Pinctrl definitions
> > *
>
> Not objecting, just making sure we're not blindly refactoring code.
>
I am not sure what you are trying to say here, but the SPDX identifier
requires an independent block comment. Hence placed the obove code in a
separate block comment. Everything else is as it is.
> If doing this, I suggest updating to GPL-2.0-or-later.
>
We can do this in a separate patch as this patch only talks about
the style.
> Regards,
> Andreas
>
> --
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer
> HRB 36809 (AG Nürnberg)
Thanks very much for your time and review.
Regards,
Nishad
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Nishad Kamdar <nishadkamdar@gmail.com>
To: "Andreas Färber" <afaerber@suse.de>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Sean Wang" <sean.wang@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Kevin Hilman" <khilman@baylibre.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@st.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Joe Perches" <joe@perches.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5] pinctrl: actions: Use the correct style for SPDX License Identifier
Date: Thu, 5 Dec 2019 20:18:48 +0530 [thread overview]
Message-ID: <20191205144844.GA2903@nishad> (raw)
In-Reply-To: <c76290a7-b9bb-7f70-e750-04fe6fdbb7e1@suse.de>
On Wed, Nov 27, 2019 at 10:02:08PM +0100, Andreas Färber wrote:
> Am 27.11.19 um 17:40 schrieb Nishad Kamdar:
> > This patch corrects the SPDX License Identifier style in
> > header file related Actions Semi OWL pinctrl driver.
>
> Owl
>
I used the same format mentioned below, which also says OWL.
Meybe we can change both of them in a separate patch.
> > For C header files Documentation/process/license-rules.rst
> > mandates C-like comments (opposed to C source files where
> > C++ style should be used).
> >
> > Changes made by using a script provided by Joe Perches here:
> > https://lkml.org/lkml/2019/2/7/46.
> >
> > Suggested-by: Joe Perches <joe@perches.com>
> > Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
> > ---
> > drivers/pinctrl/actions/pinctrl-owl.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pinctrl/actions/pinctrl-owl.h b/drivers/pinctrl/actions/pinctrl-owl.h
> > index dae2e8363fd5..feee7ad7e27e 100644
> > --- a/drivers/pinctrl/actions/pinctrl-owl.h
> > +++ b/drivers/pinctrl/actions/pinctrl-owl.h
> > @@ -1,4 +1,4 @@
> > -// SPDX-License-Identifier: GPL-2.0+
> > +/* SPDX-License-Identifier: GPL-2.0+ */
>
> This is not a uapi or asm header, which that /* */ rule was later added
> for, I thought?
>
I might be wrong but I think it applies to this file too as there as there is a SPDX
identifier in the first place.
> > /*
> > * OWL SoC's Pinctrl definitions
> > *
>
> Not objecting, just making sure we're not blindly refactoring code.
>
I am not sure what you are trying to say here, but the SPDX identifier
requires an independent block comment. Hence placed the obove code in a
separate block comment. Everything else is as it is.
> If doing this, I suggest updating to GPL-2.0-or-later.
>
We can do this in a separate patch as this patch only talks about
the style.
> Regards,
> Andreas
>
> --
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer
> HRB 36809 (AG Nürnberg)
Thanks very much for your time and review.
Regards,
Nishad
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-12-05 14:49 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 16:38 [PATCH 0/5] pinctrl: Use the correct style for SPDX License Identifier Nishad Kamdar
2019-11-27 16:38 ` Nishad Kamdar
2019-11-27 16:38 ` Nishad Kamdar
2019-11-27 16:38 ` Nishad Kamdar
2019-11-27 16:40 ` [PATCH 1/5] pinctrl: actions: " Nishad Kamdar
2019-11-27 16:40 ` Nishad Kamdar
2019-11-27 16:40 ` Nishad Kamdar
2019-11-27 16:40 ` Nishad Kamdar
2019-11-27 21:02 ` Andreas Färber
2019-11-27 21:02 ` Andreas Färber
2019-11-27 21:02 ` Andreas Färber
2019-11-27 21:02 ` Andreas Färber
2019-12-05 14:48 ` Nishad Kamdar [this message]
2019-12-05 14:48 ` Nishad Kamdar
2019-12-05 14:48 ` Nishad Kamdar
2019-12-05 14:48 ` Nishad Kamdar
2019-11-27 16:42 ` [PATCH 2/5] pinctrl: mediatek: " Nishad Kamdar
2019-11-27 16:42 ` Nishad Kamdar
2019-11-27 16:42 ` Nishad Kamdar
2019-11-27 16:42 ` Nishad Kamdar
2019-12-12 10:31 ` Linus Walleij
2019-12-12 10:31 ` Linus Walleij
2019-12-12 10:31 ` Linus Walleij
2019-12-12 10:31 ` Linus Walleij
2019-11-27 16:44 ` [PATCH 3/5] pinctrl: meson-axg: " Nishad Kamdar
2019-11-27 16:44 ` Nishad Kamdar
2019-11-27 16:44 ` Nishad Kamdar
2019-11-27 16:44 ` Nishad Kamdar
2019-12-12 10:33 ` Linus Walleij
2019-12-12 10:33 ` Linus Walleij
2019-12-12 10:33 ` Linus Walleij
2019-12-12 10:33 ` Linus Walleij
2019-11-27 16:45 ` [PATCH 4/5] pinctrl: sh-pfc: " Nishad Kamdar
2019-11-27 16:45 ` Nishad Kamdar
2019-11-27 16:45 ` Nishad Kamdar
2019-11-27 16:45 ` Nishad Kamdar
2019-11-27 20:37 ` Geert Uytterhoeven
2019-11-27 20:37 ` Geert Uytterhoeven
2019-11-27 20:37 ` Geert Uytterhoeven
2019-11-27 20:37 ` Geert Uytterhoeven
2019-11-27 20:55 ` Andreas Färber
2019-11-27 20:55 ` Andreas Färber
2019-11-27 20:55 ` Andreas Färber
2019-11-27 20:55 ` Andreas Färber
2019-11-27 20:59 ` Joe Perches
2019-11-27 20:59 ` Joe Perches
2019-11-27 20:59 ` Joe Perches
2019-11-27 20:59 ` Joe Perches
2019-11-27 21:12 ` Geert Uytterhoeven
2019-11-27 21:12 ` Geert Uytterhoeven
2019-11-27 21:12 ` Geert Uytterhoeven
2019-11-27 21:12 ` Geert Uytterhoeven
2019-11-27 21:32 ` Joe Perches
2019-11-27 21:32 ` Joe Perches
2019-11-27 21:32 ` Joe Perches
2019-11-27 21:32 ` Joe Perches
2019-12-12 10:32 ` Linus Walleij
2019-12-12 10:32 ` Linus Walleij
2019-12-12 10:32 ` Linus Walleij
2019-12-12 10:32 ` Linus Walleij
2019-11-27 16:47 ` [PATCH 5/5] pinctrl: stm32: " Nishad Kamdar
2019-11-27 16:47 ` Nishad Kamdar
2019-11-27 16:47 ` Nishad Kamdar
2019-11-27 16:47 ` Nishad Kamdar
2019-12-12 10:34 ` Linus Walleij
2019-12-12 10:34 ` Linus Walleij
2019-12-12 10:34 ` Linus Walleij
2019-12-12 10:34 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191205144844.GA2903@nishad \
--to=nishadkamdar@gmail.com \
--cc=afaerber@suse.de \
--cc=alexandre.torgue@st.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=khilman@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=sean.wang@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.