From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Nishad Kamdar <nishadkamdar@gmail.com>
Cc: "Andreas Färber" <afaerber@suse.de>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Sean Wang" <sean.wang@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Kevin Hilman" <khilman@baylibre.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@st.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Joe Perches" <joe@perches.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
linux-mediatek@lists.infradead.org,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
linux-stm32@st-md-mailman.stormreply.com,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] pinctrl: sh-pfc: Use the correct style for SPDX License Identifier
Date: Wed, 27 Nov 2019 21:37:47 +0100 [thread overview]
Message-ID: <CAMuHMdUqfRioTBV27AKx9zv9YuSqEod6x+A4aguf=h20TDXr6w@mail.gmail.com> (raw)
In-Reply-To: <5a7ed2e4b58ba7ff2f0638a2435a3a1e1c62c9f6.1574871463.git.nishadkamdar@gmail.com>
Hi Nishad,
On Wed, Nov 27, 2019 at 5:46 PM Nishad Kamdar <nishadkamdar@gmail.com> wrote:
> This patch corrects the SPDX License Identifier style in
> header files related to Reneses Soc pinctrl driver.
> It assigns explicit block comment for the SPDX License Identifier.
Is it incorrect to not have an explicit block comment?
Other recommendations have been to integrate the SPDX comment line
into an existing comment header, if it exists....
> Changes made by using a script provided by Joe Perches here:
> https://lkml.org/lkml/2019/2/7/46.
>
> Suggested-by: Joe Perches <joe@perches.com>
> Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
> ---
> drivers/pinctrl/sh-pfc/core.h | 4 ++--
> drivers/pinctrl/sh-pfc/sh_pfc.h | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/sh-pfc/core.h b/drivers/pinctrl/sh-pfc/core.h
> index b5b1d163e98a..5ad0ab8f9e14 100644
> --- a/drivers/pinctrl/sh-pfc/core.h
> +++ b/drivers/pinctrl/sh-pfc/core.h
> @@ -1,5 +1,5 @@
> -/* SPDX-License-Identifier: GPL-2.0
> - *
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> * SuperH Pin Function Controller support.
> *
> * Copyright (C) 2012 Renesas Solutions Corp.
> diff --git a/drivers/pinctrl/sh-pfc/sh_pfc.h b/drivers/pinctrl/sh-pfc/sh_pfc.h
> index 640d2a4cb838..fff9cbb7a0f8 100644
> --- a/drivers/pinctrl/sh-pfc/sh_pfc.h
> +++ b/drivers/pinctrl/sh-pfc/sh_pfc.h
> @@ -1,5 +1,5 @@
> -/* SPDX-License-Identifier: GPL-2.0
> - *
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> * SuperH Pin Function Controller Support
> *
> * Copyright (c) 2008 Magnus Damm
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Nishad Kamdar <nishadkamdar@gmail.com>
Cc: "Alexandre Torgue" <alexandre.torgue@st.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Kevin Hilman" <khilman@baylibre.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Sean Wang" <sean.wang@kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-stm32@st-md-mailman.stormreply.com,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"Joe Perches" <joe@perches.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
linux-mediatek@lists.infradead.org,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
"Andreas Färber" <afaerber@suse.de>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 4/5] pinctrl: sh-pfc: Use the correct style for SPDX License Identifier
Date: Wed, 27 Nov 2019 21:37:47 +0100 [thread overview]
Message-ID: <CAMuHMdUqfRioTBV27AKx9zv9YuSqEod6x+A4aguf=h20TDXr6w@mail.gmail.com> (raw)
In-Reply-To: <5a7ed2e4b58ba7ff2f0638a2435a3a1e1c62c9f6.1574871463.git.nishadkamdar@gmail.com>
Hi Nishad,
On Wed, Nov 27, 2019 at 5:46 PM Nishad Kamdar <nishadkamdar@gmail.com> wrote:
> This patch corrects the SPDX License Identifier style in
> header files related to Reneses Soc pinctrl driver.
> It assigns explicit block comment for the SPDX License Identifier.
Is it incorrect to not have an explicit block comment?
Other recommendations have been to integrate the SPDX comment line
into an existing comment header, if it exists....
> Changes made by using a script provided by Joe Perches here:
> https://lkml.org/lkml/2019/2/7/46.
>
> Suggested-by: Joe Perches <joe@perches.com>
> Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
> ---
> drivers/pinctrl/sh-pfc/core.h | 4 ++--
> drivers/pinctrl/sh-pfc/sh_pfc.h | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/sh-pfc/core.h b/drivers/pinctrl/sh-pfc/core.h
> index b5b1d163e98a..5ad0ab8f9e14 100644
> --- a/drivers/pinctrl/sh-pfc/core.h
> +++ b/drivers/pinctrl/sh-pfc/core.h
> @@ -1,5 +1,5 @@
> -/* SPDX-License-Identifier: GPL-2.0
> - *
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> * SuperH Pin Function Controller support.
> *
> * Copyright (C) 2012 Renesas Solutions Corp.
> diff --git a/drivers/pinctrl/sh-pfc/sh_pfc.h b/drivers/pinctrl/sh-pfc/sh_pfc.h
> index 640d2a4cb838..fff9cbb7a0f8 100644
> --- a/drivers/pinctrl/sh-pfc/sh_pfc.h
> +++ b/drivers/pinctrl/sh-pfc/sh_pfc.h
> @@ -1,5 +1,5 @@
> -/* SPDX-License-Identifier: GPL-2.0
> - *
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> * SuperH Pin Function Controller Support
> *
> * Copyright (c) 2008 Magnus Damm
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Nishad Kamdar <nishadkamdar@gmail.com>
Cc: "Alexandre Torgue" <alexandre.torgue@st.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Kevin Hilman" <khilman@baylibre.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Sean Wang" <sean.wang@kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-stm32@st-md-mailman.stormreply.com,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"Joe Perches" <joe@perches.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
linux-mediatek@lists.infradead.org,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
"Andreas Färber" <afaerber@suse.de>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 4/5] pinctrl: sh-pfc: Use the correct style for SPDX License Identifier
Date: Wed, 27 Nov 2019 21:37:47 +0100 [thread overview]
Message-ID: <CAMuHMdUqfRioTBV27AKx9zv9YuSqEod6x+A4aguf=h20TDXr6w@mail.gmail.com> (raw)
In-Reply-To: <5a7ed2e4b58ba7ff2f0638a2435a3a1e1c62c9f6.1574871463.git.nishadkamdar@gmail.com>
Hi Nishad,
On Wed, Nov 27, 2019 at 5:46 PM Nishad Kamdar <nishadkamdar@gmail.com> wrote:
> This patch corrects the SPDX License Identifier style in
> header files related to Reneses Soc pinctrl driver.
> It assigns explicit block comment for the SPDX License Identifier.
Is it incorrect to not have an explicit block comment?
Other recommendations have been to integrate the SPDX comment line
into an existing comment header, if it exists....
> Changes made by using a script provided by Joe Perches here:
> https://lkml.org/lkml/2019/2/7/46.
>
> Suggested-by: Joe Perches <joe@perches.com>
> Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
> ---
> drivers/pinctrl/sh-pfc/core.h | 4 ++--
> drivers/pinctrl/sh-pfc/sh_pfc.h | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/sh-pfc/core.h b/drivers/pinctrl/sh-pfc/core.h
> index b5b1d163e98a..5ad0ab8f9e14 100644
> --- a/drivers/pinctrl/sh-pfc/core.h
> +++ b/drivers/pinctrl/sh-pfc/core.h
> @@ -1,5 +1,5 @@
> -/* SPDX-License-Identifier: GPL-2.0
> - *
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> * SuperH Pin Function Controller support.
> *
> * Copyright (C) 2012 Renesas Solutions Corp.
> diff --git a/drivers/pinctrl/sh-pfc/sh_pfc.h b/drivers/pinctrl/sh-pfc/sh_pfc.h
> index 640d2a4cb838..fff9cbb7a0f8 100644
> --- a/drivers/pinctrl/sh-pfc/sh_pfc.h
> +++ b/drivers/pinctrl/sh-pfc/sh_pfc.h
> @@ -1,5 +1,5 @@
> -/* SPDX-License-Identifier: GPL-2.0
> - *
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> * SuperH Pin Function Controller Support
> *
> * Copyright (c) 2008 Magnus Damm
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Nishad Kamdar <nishadkamdar@gmail.com>
Cc: "Alexandre Torgue" <alexandre.torgue@st.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Kevin Hilman" <khilman@baylibre.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Sean Wang" <sean.wang@kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-stm32@st-md-mailman.stormreply.com,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"Joe Perches" <joe@perches.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
linux-mediatek@lists.infradead.org,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
"Andreas Färber" <afaerber@suse.de>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 4/5] pinctrl: sh-pfc: Use the correct style for SPDX License Identifier
Date: Wed, 27 Nov 2019 21:37:47 +0100 [thread overview]
Message-ID: <CAMuHMdUqfRioTBV27AKx9zv9YuSqEod6x+A4aguf=h20TDXr6w@mail.gmail.com> (raw)
In-Reply-To: <5a7ed2e4b58ba7ff2f0638a2435a3a1e1c62c9f6.1574871463.git.nishadkamdar@gmail.com>
Hi Nishad,
On Wed, Nov 27, 2019 at 5:46 PM Nishad Kamdar <nishadkamdar@gmail.com> wrote:
> This patch corrects the SPDX License Identifier style in
> header files related to Reneses Soc pinctrl driver.
> It assigns explicit block comment for the SPDX License Identifier.
Is it incorrect to not have an explicit block comment?
Other recommendations have been to integrate the SPDX comment line
into an existing comment header, if it exists....
> Changes made by using a script provided by Joe Perches here:
> https://lkml.org/lkml/2019/2/7/46.
>
> Suggested-by: Joe Perches <joe@perches.com>
> Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
> ---
> drivers/pinctrl/sh-pfc/core.h | 4 ++--
> drivers/pinctrl/sh-pfc/sh_pfc.h | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/sh-pfc/core.h b/drivers/pinctrl/sh-pfc/core.h
> index b5b1d163e98a..5ad0ab8f9e14 100644
> --- a/drivers/pinctrl/sh-pfc/core.h
> +++ b/drivers/pinctrl/sh-pfc/core.h
> @@ -1,5 +1,5 @@
> -/* SPDX-License-Identifier: GPL-2.0
> - *
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> * SuperH Pin Function Controller support.
> *
> * Copyright (C) 2012 Renesas Solutions Corp.
> diff --git a/drivers/pinctrl/sh-pfc/sh_pfc.h b/drivers/pinctrl/sh-pfc/sh_pfc.h
> index 640d2a4cb838..fff9cbb7a0f8 100644
> --- a/drivers/pinctrl/sh-pfc/sh_pfc.h
> +++ b/drivers/pinctrl/sh-pfc/sh_pfc.h
> @@ -1,5 +1,5 @@
> -/* SPDX-License-Identifier: GPL-2.0
> - *
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> * SuperH Pin Function Controller Support
> *
> * Copyright (c) 2008 Magnus Damm
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-11-27 21:44 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 16:38 [PATCH 0/5] pinctrl: Use the correct style for SPDX License Identifier Nishad Kamdar
2019-11-27 16:38 ` Nishad Kamdar
2019-11-27 16:38 ` Nishad Kamdar
2019-11-27 16:38 ` Nishad Kamdar
2019-11-27 16:40 ` [PATCH 1/5] pinctrl: actions: " Nishad Kamdar
2019-11-27 16:40 ` Nishad Kamdar
2019-11-27 16:40 ` Nishad Kamdar
2019-11-27 16:40 ` Nishad Kamdar
2019-11-27 21:02 ` Andreas Färber
2019-11-27 21:02 ` Andreas Färber
2019-11-27 21:02 ` Andreas Färber
2019-11-27 21:02 ` Andreas Färber
2019-12-05 14:48 ` Nishad Kamdar
2019-12-05 14:48 ` Nishad Kamdar
2019-12-05 14:48 ` Nishad Kamdar
2019-12-05 14:48 ` Nishad Kamdar
2019-11-27 16:42 ` [PATCH 2/5] pinctrl: mediatek: " Nishad Kamdar
2019-11-27 16:42 ` Nishad Kamdar
2019-11-27 16:42 ` Nishad Kamdar
2019-11-27 16:42 ` Nishad Kamdar
2019-12-12 10:31 ` Linus Walleij
2019-12-12 10:31 ` Linus Walleij
2019-12-12 10:31 ` Linus Walleij
2019-12-12 10:31 ` Linus Walleij
2019-11-27 16:44 ` [PATCH 3/5] pinctrl: meson-axg: " Nishad Kamdar
2019-11-27 16:44 ` Nishad Kamdar
2019-11-27 16:44 ` Nishad Kamdar
2019-11-27 16:44 ` Nishad Kamdar
2019-12-12 10:33 ` Linus Walleij
2019-12-12 10:33 ` Linus Walleij
2019-12-12 10:33 ` Linus Walleij
2019-12-12 10:33 ` Linus Walleij
2019-11-27 16:45 ` [PATCH 4/5] pinctrl: sh-pfc: " Nishad Kamdar
2019-11-27 16:45 ` Nishad Kamdar
2019-11-27 16:45 ` Nishad Kamdar
2019-11-27 16:45 ` Nishad Kamdar
2019-11-27 20:37 ` Geert Uytterhoeven [this message]
2019-11-27 20:37 ` Geert Uytterhoeven
2019-11-27 20:37 ` Geert Uytterhoeven
2019-11-27 20:37 ` Geert Uytterhoeven
2019-11-27 20:55 ` Andreas Färber
2019-11-27 20:55 ` Andreas Färber
2019-11-27 20:55 ` Andreas Färber
2019-11-27 20:55 ` Andreas Färber
2019-11-27 20:59 ` Joe Perches
2019-11-27 20:59 ` Joe Perches
2019-11-27 20:59 ` Joe Perches
2019-11-27 20:59 ` Joe Perches
2019-11-27 21:12 ` Geert Uytterhoeven
2019-11-27 21:12 ` Geert Uytterhoeven
2019-11-27 21:12 ` Geert Uytterhoeven
2019-11-27 21:12 ` Geert Uytterhoeven
2019-11-27 21:32 ` Joe Perches
2019-11-27 21:32 ` Joe Perches
2019-11-27 21:32 ` Joe Perches
2019-11-27 21:32 ` Joe Perches
2019-12-12 10:32 ` Linus Walleij
2019-12-12 10:32 ` Linus Walleij
2019-12-12 10:32 ` Linus Walleij
2019-12-12 10:32 ` Linus Walleij
2019-11-27 16:47 ` [PATCH 5/5] pinctrl: stm32: " Nishad Kamdar
2019-11-27 16:47 ` Nishad Kamdar
2019-11-27 16:47 ` Nishad Kamdar
2019-11-27 16:47 ` Nishad Kamdar
2019-12-12 10:34 ` Linus Walleij
2019-12-12 10:34 ` Linus Walleij
2019-12-12 10:34 ` Linus Walleij
2019-12-12 10:34 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdUqfRioTBV27AKx9zv9YuSqEod6x+A4aguf=h20TDXr6w@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=afaerber@suse.de \
--cc=alexandre.torgue@st.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=khilman@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=nishadkamdar@gmail.com \
--cc=sean.wang@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.