From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> To: dri-devel@lists.freedesktop.org Cc: linux-renesas-soc@vger.kernel.org, Neil Armstrong <narmstrong@baylibre.com>, Andrzej Hajda <a.hajda@samsung.com>, Fabrizio Castro <fabrizio.castro@bp.renesas.com>, Geert Uytterhoeven <geert+renesas@glider.be>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Subject: [PATCH v4.1 06/13] drm/bridge: lvds-codec: Add "lvds-decoder" support Date: Wed, 18 Dec 2019 01:07:53 +0200 [thread overview] Message-ID: <20191217230753.2999-1-laurent.pinchart+renesas@ideasonboard.com> (raw) In-Reply-To: <1573660292-10629-7-git-send-email-fabrizio.castro@bp.renesas.com> From: Fabrizio Castro <fabrizio.castro@bp.renesas.com> Add support for transparent LVDS decoders by adding a new compatible string ("lvds-decoder") to the driver. This patch also adds member connector_type to struct lvds_codec, and that's because LVDS decoders have a different connector type from LVDS encoders. We fill this new member up with the data matching the compatible string. Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> [Fix pointer to int cast warning] Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- Changes since v4: - Fix compiler warning to to a cast from 64-bit pointer to 32-bit integer v3->v4: * New patch --- drivers/gpu/drm/bridge/lvds-codec.c | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/lvds-codec.c b/drivers/gpu/drm/bridge/lvds-codec.c index b5801a287a0a..d072a76b20d9 100644 --- a/drivers/gpu/drm/bridge/lvds-codec.c +++ b/drivers/gpu/drm/bridge/lvds-codec.c @@ -7,6 +7,7 @@ #include <linux/gpio/consumer.h> #include <linux/module.h> #include <linux/of.h> +#include <linux/of_device.h> #include <linux/of_graph.h> #include <linux/platform_device.h> @@ -17,6 +18,7 @@ struct lvds_codec { struct drm_bridge bridge; struct drm_bridge *panel_bridge; struct gpio_desc *powerdown_gpio; + u32 connector_type; }; static int lvds_codec_attach(struct drm_bridge *bridge) @@ -65,6 +67,7 @@ static int lvds_codec_probe(struct platform_device *pdev) if (!lvds_codec) return -ENOMEM; + lvds_codec->connector_type = (uintptr_t)of_device_get_match_data(dev); lvds_codec->powerdown_gpio = devm_gpiod_get_optional(dev, "powerdown", GPIOD_OUT_HIGH); if (IS_ERR(lvds_codec->powerdown_gpio)) { @@ -105,7 +108,7 @@ static int lvds_codec_probe(struct platform_device *pdev) lvds_codec->panel_bridge = devm_drm_panel_bridge_add_typed(dev, panel, - DRM_MODE_CONNECTOR_LVDS); + lvds_codec->connector_type); if (IS_ERR(lvds_codec->panel_bridge)) return PTR_ERR(lvds_codec->panel_bridge); @@ -133,8 +136,18 @@ static int lvds_codec_remove(struct platform_device *pdev) } static const struct of_device_id lvds_codec_match[] = { - { .compatible = "lvds-encoder" }, - { .compatible = "thine,thc63lvdm83d" }, + { + .compatible = "lvds-decoder", + .data = (void *)DRM_MODE_CONNECTOR_DPI, + }, + { + .compatible = "lvds-encoder", + .data = (void *)DRM_MODE_CONNECTOR_LVDS, + }, + { + .compatible = "thine,thc63lvdm83d", + .data = (void *)DRM_MODE_CONNECTOR_LVDS, + }, {}, }; MODULE_DEVICE_TABLE(of, lvds_codec_match); -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> To: dri-devel@lists.freedesktop.org Cc: Fabrizio Castro <fabrizio.castro@bp.renesas.com>, Geert Uytterhoeven <geert+renesas@glider.be>, Neil Armstrong <narmstrong@baylibre.com>, linux-renesas-soc@vger.kernel.org, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Subject: [PATCH v4.1 06/13] drm/bridge: lvds-codec: Add "lvds-decoder" support Date: Wed, 18 Dec 2019 01:07:53 +0200 [thread overview] Message-ID: <20191217230753.2999-1-laurent.pinchart+renesas@ideasonboard.com> (raw) In-Reply-To: <1573660292-10629-7-git-send-email-fabrizio.castro@bp.renesas.com> From: Fabrizio Castro <fabrizio.castro@bp.renesas.com> Add support for transparent LVDS decoders by adding a new compatible string ("lvds-decoder") to the driver. This patch also adds member connector_type to struct lvds_codec, and that's because LVDS decoders have a different connector type from LVDS encoders. We fill this new member up with the data matching the compatible string. Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> [Fix pointer to int cast warning] Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- Changes since v4: - Fix compiler warning to to a cast from 64-bit pointer to 32-bit integer v3->v4: * New patch --- drivers/gpu/drm/bridge/lvds-codec.c | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/lvds-codec.c b/drivers/gpu/drm/bridge/lvds-codec.c index b5801a287a0a..d072a76b20d9 100644 --- a/drivers/gpu/drm/bridge/lvds-codec.c +++ b/drivers/gpu/drm/bridge/lvds-codec.c @@ -7,6 +7,7 @@ #include <linux/gpio/consumer.h> #include <linux/module.h> #include <linux/of.h> +#include <linux/of_device.h> #include <linux/of_graph.h> #include <linux/platform_device.h> @@ -17,6 +18,7 @@ struct lvds_codec { struct drm_bridge bridge; struct drm_bridge *panel_bridge; struct gpio_desc *powerdown_gpio; + u32 connector_type; }; static int lvds_codec_attach(struct drm_bridge *bridge) @@ -65,6 +67,7 @@ static int lvds_codec_probe(struct platform_device *pdev) if (!lvds_codec) return -ENOMEM; + lvds_codec->connector_type = (uintptr_t)of_device_get_match_data(dev); lvds_codec->powerdown_gpio = devm_gpiod_get_optional(dev, "powerdown", GPIOD_OUT_HIGH); if (IS_ERR(lvds_codec->powerdown_gpio)) { @@ -105,7 +108,7 @@ static int lvds_codec_probe(struct platform_device *pdev) lvds_codec->panel_bridge = devm_drm_panel_bridge_add_typed(dev, panel, - DRM_MODE_CONNECTOR_LVDS); + lvds_codec->connector_type); if (IS_ERR(lvds_codec->panel_bridge)) return PTR_ERR(lvds_codec->panel_bridge); @@ -133,8 +136,18 @@ static int lvds_codec_remove(struct platform_device *pdev) } static const struct of_device_id lvds_codec_match[] = { - { .compatible = "lvds-encoder" }, - { .compatible = "thine,thc63lvdm83d" }, + { + .compatible = "lvds-decoder", + .data = (void *)DRM_MODE_CONNECTOR_DPI, + }, + { + .compatible = "lvds-encoder", + .data = (void *)DRM_MODE_CONNECTOR_LVDS, + }, + { + .compatible = "thine,thc63lvdm83d", + .data = (void *)DRM_MODE_CONNECTOR_LVDS, + }, {}, }; MODULE_DEVICE_TABLE(of, lvds_codec_match); -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-12-17 23:08 UTC|newest] Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-13 15:51 [PATCH v4 00/13] Add LCD panel support to iwg20d Fabrizio Castro 2019-11-13 15:51 ` Fabrizio Castro 2019-11-13 15:51 ` [PATCH v4 01/13] dt-bindings: display: bridge: Convert lvds-transmitter binding to json-schema Fabrizio Castro 2019-11-13 15:51 ` Fabrizio Castro 2019-11-18 21:35 ` Rob Herring 2019-11-18 21:35 ` Rob Herring 2019-11-18 21:35 ` Rob Herring 2019-11-18 23:51 ` Laurent Pinchart 2019-11-18 23:51 ` Laurent Pinchart 2019-11-13 15:51 ` [PATCH v4 02/13] dt-bindings: display: bridge: lvds-transmitter: Document powerdown-gpios Fabrizio Castro 2019-11-13 15:51 ` Fabrizio Castro 2019-11-18 21:36 ` Rob Herring 2019-11-18 21:36 ` Rob Herring 2019-11-18 21:36 ` Rob Herring 2019-11-18 23:55 ` Laurent Pinchart 2019-11-18 23:55 ` Laurent Pinchart 2019-11-13 15:51 ` [PATCH v4 03/13] dt-bindings: display: bridge: lvds-transmitter: Absorb ti,ds90c185.txt Fabrizio Castro 2019-11-13 15:51 ` [PATCH v4 03/13] dt-bindings: display: bridge: lvds-transmitter: Absorb ti, ds90c185.txt Fabrizio Castro 2019-11-18 21:38 ` [PATCH v4 03/13] dt-bindings: display: bridge: lvds-transmitter: Absorb ti,ds90c185.txt Rob Herring 2019-11-18 21:38 ` Rob Herring 2019-11-18 21:38 ` Rob Herring 2019-11-18 23:56 ` Laurent Pinchart 2019-11-18 23:56 ` Laurent Pinchart 2019-11-13 15:51 ` [PATCH v4 04/13] dt-bindings: display: bridge: lvds-transmitter: Document "ti,sn75lvds83" Fabrizio Castro 2019-11-13 15:51 ` [PATCH v4 04/13] dt-bindings: display: bridge: lvds-transmitter: Document "ti, sn75lvds83" Fabrizio Castro 2019-11-18 21:38 ` [PATCH v4 04/13] dt-bindings: display: bridge: lvds-transmitter: Document "ti,sn75lvds83" Rob Herring 2019-11-18 21:38 ` Rob Herring 2019-11-18 21:38 ` Rob Herring 2019-11-18 23:57 ` Laurent Pinchart 2019-11-18 23:57 ` Laurent Pinchart 2019-11-13 15:51 ` [PATCH v4 05/13] drm/bridge: Repurpose lvds-encoder.c Fabrizio Castro 2019-11-13 15:51 ` Fabrizio Castro 2019-11-19 0:00 ` Laurent Pinchart 2019-11-19 0:00 ` Laurent Pinchart 2019-11-13 15:51 ` [PATCH v4 06/13] drm/bridge: lvds-codec: Add "lvds-decoder" support Fabrizio Castro 2019-11-13 15:51 ` Fabrizio Castro 2019-11-19 0:02 ` Laurent Pinchart 2019-11-19 0:02 ` Laurent Pinchart 2019-12-13 17:10 ` Laurent Pinchart 2019-12-13 17:10 ` Laurent Pinchart 2019-12-16 21:22 ` Laurent Pinchart 2019-12-16 21:22 ` Laurent Pinchart 2019-12-17 11:02 ` Fabrizio Castro 2019-12-17 11:02 ` Fabrizio Castro 2019-12-17 12:21 ` Geert Uytterhoeven 2019-12-17 12:21 ` Geert Uytterhoeven 2019-12-17 12:31 ` Fabrizio Castro 2019-12-17 12:31 ` Fabrizio Castro 2019-12-17 12:38 ` Geert Uytterhoeven 2019-12-17 12:38 ` Geert Uytterhoeven 2019-12-17 13:54 ` Laurent Pinchart 2019-12-17 13:54 ` Laurent Pinchart 2019-12-17 22:06 ` Fabrizio Castro 2019-12-17 22:06 ` Fabrizio Castro 2019-12-17 23:08 ` Laurent Pinchart 2019-12-17 23:08 ` Laurent Pinchart 2019-12-18 12:00 ` Fabrizio Castro 2019-12-18 12:00 ` Fabrizio Castro 2019-12-17 23:07 ` Laurent Pinchart [this message] 2019-12-17 23:07 ` [PATCH v4.1 " Laurent Pinchart 2019-11-13 15:51 ` [PATCH v4 07/13] drm/bridge: lvds-codec: Simplify panel DT node localisation Fabrizio Castro 2019-11-13 15:51 ` Fabrizio Castro 2019-11-19 0:03 ` Laurent Pinchart 2019-11-19 0:03 ` Laurent Pinchart 2019-11-13 15:51 ` [PATCH v4 08/13] dt-bindings: display: bridge: Repurpose lvds-encoder Fabrizio Castro 2019-11-13 15:51 ` Fabrizio Castro 2019-11-18 21:40 ` Rob Herring 2019-11-18 21:40 ` Rob Herring 2019-11-18 21:40 ` Rob Herring 2019-11-19 0:07 ` Laurent Pinchart 2019-11-19 0:07 ` Laurent Pinchart 2019-11-19 10:35 ` Fabrizio Castro 2019-11-19 10:35 ` Fabrizio Castro 2019-11-13 15:51 ` [PATCH v4 09/13] dt-bindings: display: bridge: lvds-codec: Document ti,ds90cf384a Fabrizio Castro 2019-11-13 15:51 ` [PATCH v4 09/13] dt-bindings: display: bridge: lvds-codec: Document ti, ds90cf384a Fabrizio Castro 2019-11-18 21:41 ` [PATCH v4 09/13] dt-bindings: display: bridge: lvds-codec: Document ti,ds90cf384a Rob Herring 2019-11-18 21:41 ` Rob Herring 2019-11-18 21:41 ` Rob Herring 2019-11-19 0:09 ` Laurent Pinchart 2019-11-19 0:09 ` Laurent Pinchart 2019-11-13 15:51 ` [PATCH v4 10/13] ARM: dts: iwg20d-q7-common: Add LCD support Fabrizio Castro 2019-11-13 15:51 ` Fabrizio Castro 2019-11-19 0:10 ` Laurent Pinchart 2019-11-19 0:10 ` Laurent Pinchart 2019-11-25 10:30 ` Geert Uytterhoeven 2019-11-25 10:30 ` Geert Uytterhoeven 2019-11-13 15:51 ` [PATCH v4 11/13] ARM: shmobile_defconfig: Enable support for panels from EDT Fabrizio Castro 2019-11-13 15:51 ` Fabrizio Castro 2019-11-19 0:12 ` Laurent Pinchart 2019-11-19 0:12 ` Laurent Pinchart 2019-11-25 10:30 ` Geert Uytterhoeven 2019-11-25 10:30 ` Geert Uytterhoeven 2019-11-13 15:51 ` [PATCH v4 12/13] [HACK] drm/bridge: lvds-codec: Enforce device specific compatible strings Fabrizio Castro 2019-11-13 15:51 ` Fabrizio Castro 2019-11-19 0:16 ` Laurent Pinchart 2019-11-19 0:16 ` Laurent Pinchart 2019-11-19 11:17 ` Fabrizio Castro 2019-11-19 11:17 ` Fabrizio Castro 2019-11-19 21:51 ` Laurent Pinchart 2019-11-19 21:51 ` Laurent Pinchart 2019-11-21 16:00 ` Fabrizio Castro 2019-11-21 16:00 ` Fabrizio Castro 2019-11-22 8:16 ` Geert Uytterhoeven 2019-11-22 8:16 ` Geert Uytterhoeven 2019-11-25 11:17 ` Fabrizio Castro 2019-11-25 11:17 ` Fabrizio Castro 2019-12-02 9:42 ` Laurent Pinchart 2019-12-02 9:42 ` Laurent Pinchart 2019-11-13 15:51 ` [PATCH v4 13/13] [HACK] dt-bindings: display: bridge: lvds-codec: Absorb thine,thc63lvdm83d.txt Fabrizio Castro 2019-11-13 15:51 ` [PATCH v4 13/13] [HACK] dt-bindings: display: bridge: lvds-codec: Absorb thine, thc63lvdm83d.txt Fabrizio Castro 2019-11-18 21:51 ` [PATCH v4 13/13] [HACK] dt-bindings: display: bridge: lvds-codec: Absorb thine,thc63lvdm83d.txt Rob Herring 2019-11-18 21:51 ` Rob Herring 2019-11-19 0:19 ` Laurent Pinchart 2019-11-19 0:19 ` Laurent Pinchart 2019-12-18 11:52 ` [PATCH v4 00/13] Add LCD panel support to iwg20d Neil Armstrong 2019-12-18 11:52 ` Neil Armstrong 2019-12-18 14:05 ` Fabrizio Castro 2019-12-18 14:05 ` Fabrizio Castro
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191217230753.2999-1-laurent.pinchart+renesas@ideasonboard.com \ --to=laurent.pinchart+renesas@ideasonboard.com \ --cc=a.hajda@samsung.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=fabrizio.castro@bp.renesas.com \ --cc=geert+renesas@glider.be \ --cc=kieran.bingham+renesas@ideasonboard.com \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=narmstrong@baylibre.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.