From: Krzysztof Kozlowski <krzk@kernel.org> To: Chanwoo Choi <cw00.choi@samsung.com> Cc: robh+dt@kernel.org, mark.rutland@arm.com, heiko@sntech.de, leonard.crestez@nxp.com, lukasz.luba@arm.com, a.swigon@samsung.com, m.szyprowski@samsung.com, kgene@kernel.org, myungjoo.ham@samsung.com, kyungmin.park@samsung.com, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 7/9] memory: samsung: exynos5422-dmc: Replace deprecated 'devfreq-events' property Date: Thu, 19 Dec 2019 21:19:17 +0100 [thread overview] Message-ID: <20191219201917.GA21576@kozik-lap> (raw) In-Reply-To: <20191217055738.28445-8-cw00.choi@samsung.com> On Tue, Dec 17, 2019 at 02:57:36PM +0900, Chanwoo Choi wrote: > In order to remove the deprecated 'devfreq-events' property, replace with > new 'exynos,ppmu-device' property in order to get the devfreq-event device > in devicetree file instead of 'devfreq-events' property. But, to guarantee > the backward-compatibility, keep the support 'devfreq-events' property. > > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > --- > .../memory-controllers/exynos5422-dmc.txt | 6 ++-- > drivers/memory/samsung/exynos5422-dmc.c | 29 +++++++++++++++---- > 2 files changed, 26 insertions(+), 9 deletions(-) In general looks good for me but I need an ack from Rob. Patch should be also split and sent as one of first in the series (before code). > > diff --git a/Documentation/devicetree/bindings/memory-controllers/exynos5422-dmc.txt b/Documentation/devicetree/bindings/memory-controllers/exynos5422-dmc.txt > index 02e4a1f862f1..1e1b3702f045 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/exynos5422-dmc.txt > +++ b/Documentation/devicetree/bindings/memory-controllers/exynos5422-dmc.txt > @@ -17,14 +17,14 @@ Required properties for DMC device for Exynos5422: > - clock-names : should include "fout_spll", "mout_sclk_spll", "ff_dout_spll2", > "fout_bpll", "mout_bpll", "sclk_bpll", "mout_mx_mspll_ccore", > "mout_mclk_cdrex" entries > -- devfreq-events : phandles for PPMU devices connected to this DMC. > +- exynos,ppmu-device : phandles for PPMU devices connected to this DMC. > - vdd-supply : phandle for voltage regulator which is connected. > - reg : registers of two CDREX controllers. > - operating-points-v2 : phandle for OPPs described in v2 definition. > - device-handle : phandle of the connected DRAM memory device. For more > information please refer to documentation file: > Documentation/devicetree/bindings/ddr/lpddr3.txt > -- devfreq-events : phandles of the PPMU events used by the controller. > +- exynos,ppmu-device : phandles of the PPMU events used by the controller. > - samsung,syscon-clk : phandle of the clock register set used by the controller, > these registers are used for enabling a 'pause' feature and are not > exposed by clock framework but they must be used in a safe way. > @@ -73,7 +73,7 @@ Example: > "mout_mx_mspll_ccore", > "mout_mclk_cdrex"; > operating-points-v2 = <&dmc_opp_table>; > - devfreq-events = <&ppmu_event3_dmc0_0>, <&ppmu_event3_dmc0_1>, > + exynos,ppmu-device = <&ppmu_event3_dmc0_0>, <&ppmu_event3_dmc0_1>, > <&ppmu_event3_dmc1_0>, <&ppmu_event3_dmc1_1>; Indentation is broken here. Best regards, Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org> To: Chanwoo Choi <cw00.choi@samsung.com> Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, heiko@sntech.de, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, a.swigon@samsung.com, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, myungjoo.ham@samsung.com, robh+dt@kernel.org, kgene@kernel.org, kyungmin.park@samsung.com, leonard.crestez@nxp.com, lukasz.luba@arm.com, m.szyprowski@samsung.com Subject: Re: [PATCH 7/9] memory: samsung: exynos5422-dmc: Replace deprecated 'devfreq-events' property Date: Thu, 19 Dec 2019 21:19:17 +0100 [thread overview] Message-ID: <20191219201917.GA21576@kozik-lap> (raw) In-Reply-To: <20191217055738.28445-8-cw00.choi@samsung.com> On Tue, Dec 17, 2019 at 02:57:36PM +0900, Chanwoo Choi wrote: > In order to remove the deprecated 'devfreq-events' property, replace with > new 'exynos,ppmu-device' property in order to get the devfreq-event device > in devicetree file instead of 'devfreq-events' property. But, to guarantee > the backward-compatibility, keep the support 'devfreq-events' property. > > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > --- > .../memory-controllers/exynos5422-dmc.txt | 6 ++-- > drivers/memory/samsung/exynos5422-dmc.c | 29 +++++++++++++++---- > 2 files changed, 26 insertions(+), 9 deletions(-) In general looks good for me but I need an ack from Rob. Patch should be also split and sent as one of first in the series (before code). > > diff --git a/Documentation/devicetree/bindings/memory-controllers/exynos5422-dmc.txt b/Documentation/devicetree/bindings/memory-controllers/exynos5422-dmc.txt > index 02e4a1f862f1..1e1b3702f045 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/exynos5422-dmc.txt > +++ b/Documentation/devicetree/bindings/memory-controllers/exynos5422-dmc.txt > @@ -17,14 +17,14 @@ Required properties for DMC device for Exynos5422: > - clock-names : should include "fout_spll", "mout_sclk_spll", "ff_dout_spll2", > "fout_bpll", "mout_bpll", "sclk_bpll", "mout_mx_mspll_ccore", > "mout_mclk_cdrex" entries > -- devfreq-events : phandles for PPMU devices connected to this DMC. > +- exynos,ppmu-device : phandles for PPMU devices connected to this DMC. > - vdd-supply : phandle for voltage regulator which is connected. > - reg : registers of two CDREX controllers. > - operating-points-v2 : phandle for OPPs described in v2 definition. > - device-handle : phandle of the connected DRAM memory device. For more > information please refer to documentation file: > Documentation/devicetree/bindings/ddr/lpddr3.txt > -- devfreq-events : phandles of the PPMU events used by the controller. > +- exynos,ppmu-device : phandles of the PPMU events used by the controller. > - samsung,syscon-clk : phandle of the clock register set used by the controller, > these registers are used for enabling a 'pause' feature and are not > exposed by clock framework but they must be used in a safe way. > @@ -73,7 +73,7 @@ Example: > "mout_mx_mspll_ccore", > "mout_mclk_cdrex"; > operating-points-v2 = <&dmc_opp_table>; > - devfreq-events = <&ppmu_event3_dmc0_0>, <&ppmu_event3_dmc0_1>, > + exynos,ppmu-device = <&ppmu_event3_dmc0_0>, <&ppmu_event3_dmc0_1>, > <&ppmu_event3_dmc1_0>, <&ppmu_event3_dmc1_1>; Indentation is broken here. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-19 20:19 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20191217055105epcas1p365e306f27fd53852b793155c929ee634@epcas1p3.samsung.com> 2019-12-17 5:57 ` [PATCH 0/9] PM / devfreq: Remove deprecated 'devfreq' and 'devfreq-events' properties Chanwoo Choi 2019-12-17 5:57 ` Chanwoo Choi 2019-12-17 5:57 ` Chanwoo Choi [not found] ` <CGME20191217055105epcas1p3bacbf54550c52979fe819ab33bb21d30@epcas1p3.samsung.com> 2019-12-17 5:57 ` [PATCH 1/9] PM / devfreq: Add devfreq_get_devfreq_by_node function Chanwoo Choi 2019-12-17 5:57 ` Chanwoo Choi [not found] ` <CGME20191217055105epcas1p2d2930402a559e381a7854f515a683d15@epcas1p2.samsung.com> 2019-12-17 5:57 ` [PATCH 2/9] PM / devfreq: Remove devfreq_get_devfreq_by_phandle function Chanwoo Choi 2019-12-17 5:57 ` Chanwoo Choi 2019-12-17 14:33 ` Leonard Crestez 2019-12-17 14:33 ` Leonard Crestez 2019-12-17 14:33 ` Leonard Crestez 2019-12-18 2:59 ` Chanwoo Choi 2019-12-18 2:59 ` Chanwoo Choi 2019-12-18 2:59 ` Chanwoo Choi 2019-12-18 3:20 ` Chanwoo Choi 2019-12-18 3:20 ` Chanwoo Choi 2019-12-18 3:20 ` Chanwoo Choi [not found] ` <CGME20191217055106epcas1p3e77268d200006921dfa736b2c7550a04@epcas1p3.samsung.com> 2019-12-17 5:57 ` [PATCH 3/9] PM / devfreq: event: Add devfreq_event_get_edev_by_node function Chanwoo Choi 2019-12-17 5:57 ` Chanwoo Choi [not found] ` <CGME20191217055106epcas1p11f2bc81d6bb2db3fc4bc257d78c337b9@epcas1p1.samsung.com> 2019-12-17 5:57 ` [PATCH 4/9] PM / devfreq: exynos-bus: Replace deprecated 'devfreq' property Chanwoo Choi 2019-12-17 5:57 ` Chanwoo Choi 2019-12-26 21:01 ` Rob Herring 2019-12-26 21:01 ` Rob Herring 2019-12-27 0:09 ` Chanwoo Choi 2019-12-27 0:09 ` Chanwoo Choi 2020-01-06 1:38 ` Chanwoo Choi 2020-01-06 1:38 ` Chanwoo Choi 2020-01-14 18:57 ` Chanwoo Choi 2020-01-14 18:57 ` Chanwoo Choi 2020-01-14 18:57 ` Chanwoo Choi [not found] ` <CGME20191217055106epcas1p4b50ca647af9b54465e5c0a0bebb165b8@epcas1p4.samsung.com> 2019-12-17 5:57 ` [PATCH 5/9] PM / devfreq: exynos-bus: Replace deprecated 'devfreq-events' property Chanwoo Choi 2019-12-17 5:57 ` Chanwoo Choi [not found] ` <CGME20191217055106epcas1p156b1323f4ec9f7c35fed825d56e577ff@epcas1p1.samsung.com> 2019-12-17 5:57 ` [PATCH 6/9] PM / devfreq: rk3399_dmc: " Chanwoo Choi 2019-12-17 5:57 ` Chanwoo Choi [not found] ` <CGME20191217055106epcas1p2c43a45e34983c1b3e60cc6fd842dd33e@epcas1p2.samsung.com> 2019-12-17 5:57 ` [PATCH 7/9] memory: samsung: exynos5422-dmc: " Chanwoo Choi 2019-12-17 5:57 ` Chanwoo Choi 2019-12-17 11:03 ` Lukasz Luba 2019-12-17 11:03 ` Lukasz Luba 2019-12-17 11:03 ` Lukasz Luba 2019-12-19 20:19 ` Krzysztof Kozlowski [this message] 2019-12-19 20:19 ` Krzysztof Kozlowski [not found] ` <CGME20191217055106epcas1p4c0f65bec74e53b38d95e984e146bf8b6@epcas1p4.samsung.com> 2019-12-17 5:57 ` [PATCH 8/9] ARM: dts: exynos: Replace deprecated property for Exynos bus and DMC Chanwoo Choi 2019-12-17 5:57 ` Chanwoo Choi 2019-12-19 20:21 ` Krzysztof Kozlowski 2019-12-19 20:21 ` Krzysztof Kozlowski [not found] ` <CGME20191217055107epcas1p44d46bdea7b326b86689f326742f5444a@epcas1p4.samsung.com> 2019-12-17 5:57 ` [PATCH 9/9] arm64: dts: exynos: Replace deprecated property for Exynos bus Chanwoo Choi 2019-12-17 5:57 ` Chanwoo Choi 2019-12-19 20:22 ` Krzysztof Kozlowski 2019-12-19 20:22 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191219201917.GA21576@kozik-lap \ --to=krzk@kernel.org \ --cc=a.swigon@samsung.com \ --cc=cw00.choi@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=heiko@sntech.de \ --cc=kgene@kernel.org \ --cc=kyungmin.park@samsung.com \ --cc=leonard.crestez@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=lukasz.luba@arm.com \ --cc=m.szyprowski@samsung.com \ --cc=mark.rutland@arm.com \ --cc=myungjoo.ham@samsung.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.