All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: krzk@kernel.org, mark.rutland@arm.com, heiko@sntech.de,
	leonard.crestez@nxp.com, lukasz.luba@arm.com,
	a.swigon@samsung.com, m.szyprowski@samsung.com, kgene@kernel.org,
	myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
	linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 4/9] PM / devfreq: exynos-bus: Replace deprecated 'devfreq' property
Date: Thu, 26 Dec 2019 14:01:19 -0700	[thread overview]
Message-ID: <20191226210119.GA8706@bogus> (raw)
In-Reply-To: <20191217055738.28445-5-cw00.choi@samsung.com>

On Tue, Dec 17, 2019 at 02:57:33PM +0900, Chanwoo Choi wrote:
> In order to remove the deprecated 'devfreq' property, replace with
> new 'exynos,parent-bus' property in order to get the parent devfreq device
> in devicetree file instead of 'devfreq' property. But, to guarantee the
> backward-compatibility, keep the support 'devfreq' property.
> 
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
>  .../bindings/devfreq/exynos-bus.txt           | 16 +++++++--------
>  drivers/devfreq/exynos-bus.c                  | 20 ++++++++++++-------
>  2 files changed, 21 insertions(+), 15 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/devfreq/exynos-bus.txt b/Documentation/devicetree/bindings/devfreq/exynos-bus.txt
> index e71f752cc18f..c948cee01124 100644
> --- a/Documentation/devicetree/bindings/devfreq/exynos-bus.txt
> +++ b/Documentation/devicetree/bindings/devfreq/exynos-bus.txt
> @@ -45,7 +45,7 @@ Required properties only for parent bus device:
>    of buses.
>  
>  Required properties only for passive bus device:
> -- devfreq: the parent bus device.
> +- exynos,parent-bus: the parent bus device.

If you are going to do something new, why not use the interconnect 
binding here?

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org, heiko@sntech.de,
	linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
	a.swigon@samsung.com, krzk@kernel.org,
	linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
	kyungmin.park@samsung.com, kgene@kernel.org,
	myungjoo.ham@samsung.com, leonard.crestez@nxp.com,
	lukasz.luba@arm.com, m.szyprowski@samsung.com
Subject: Re: [PATCH 4/9] PM / devfreq: exynos-bus: Replace deprecated 'devfreq' property
Date: Thu, 26 Dec 2019 14:01:19 -0700	[thread overview]
Message-ID: <20191226210119.GA8706@bogus> (raw)
In-Reply-To: <20191217055738.28445-5-cw00.choi@samsung.com>

On Tue, Dec 17, 2019 at 02:57:33PM +0900, Chanwoo Choi wrote:
> In order to remove the deprecated 'devfreq' property, replace with
> new 'exynos,parent-bus' property in order to get the parent devfreq device
> in devicetree file instead of 'devfreq' property. But, to guarantee the
> backward-compatibility, keep the support 'devfreq' property.
> 
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
>  .../bindings/devfreq/exynos-bus.txt           | 16 +++++++--------
>  drivers/devfreq/exynos-bus.c                  | 20 ++++++++++++-------
>  2 files changed, 21 insertions(+), 15 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/devfreq/exynos-bus.txt b/Documentation/devicetree/bindings/devfreq/exynos-bus.txt
> index e71f752cc18f..c948cee01124 100644
> --- a/Documentation/devicetree/bindings/devfreq/exynos-bus.txt
> +++ b/Documentation/devicetree/bindings/devfreq/exynos-bus.txt
> @@ -45,7 +45,7 @@ Required properties only for parent bus device:
>    of buses.
>  
>  Required properties only for passive bus device:
> -- devfreq: the parent bus device.
> +- exynos,parent-bus: the parent bus device.

If you are going to do something new, why not use the interconnect 
binding here?

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-12-26 21:01 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20191217055105epcas1p365e306f27fd53852b793155c929ee634@epcas1p3.samsung.com>
2019-12-17  5:57 ` [PATCH 0/9] PM / devfreq: Remove deprecated 'devfreq' and 'devfreq-events' properties Chanwoo Choi
2019-12-17  5:57   ` Chanwoo Choi
2019-12-17  5:57   ` Chanwoo Choi
     [not found]   ` <CGME20191217055105epcas1p3bacbf54550c52979fe819ab33bb21d30@epcas1p3.samsung.com>
2019-12-17  5:57     ` [PATCH 1/9] PM / devfreq: Add devfreq_get_devfreq_by_node function Chanwoo Choi
2019-12-17  5:57       ` Chanwoo Choi
     [not found]   ` <CGME20191217055105epcas1p2d2930402a559e381a7854f515a683d15@epcas1p2.samsung.com>
2019-12-17  5:57     ` [PATCH 2/9] PM / devfreq: Remove devfreq_get_devfreq_by_phandle function Chanwoo Choi
2019-12-17  5:57       ` Chanwoo Choi
2019-12-17 14:33       ` Leonard Crestez
2019-12-17 14:33         ` Leonard Crestez
2019-12-17 14:33         ` Leonard Crestez
2019-12-18  2:59         ` Chanwoo Choi
2019-12-18  2:59           ` Chanwoo Choi
2019-12-18  2:59           ` Chanwoo Choi
2019-12-18  3:20           ` Chanwoo Choi
2019-12-18  3:20             ` Chanwoo Choi
2019-12-18  3:20             ` Chanwoo Choi
     [not found]   ` <CGME20191217055106epcas1p3e77268d200006921dfa736b2c7550a04@epcas1p3.samsung.com>
2019-12-17  5:57     ` [PATCH 3/9] PM / devfreq: event: Add devfreq_event_get_edev_by_node function Chanwoo Choi
2019-12-17  5:57       ` Chanwoo Choi
     [not found]   ` <CGME20191217055106epcas1p11f2bc81d6bb2db3fc4bc257d78c337b9@epcas1p1.samsung.com>
2019-12-17  5:57     ` [PATCH 4/9] PM / devfreq: exynos-bus: Replace deprecated 'devfreq' property Chanwoo Choi
2019-12-17  5:57       ` Chanwoo Choi
2019-12-26 21:01       ` Rob Herring [this message]
2019-12-26 21:01         ` Rob Herring
2019-12-27  0:09         ` Chanwoo Choi
2019-12-27  0:09           ` Chanwoo Choi
2020-01-06  1:38           ` Chanwoo Choi
2020-01-06  1:38             ` Chanwoo Choi
2020-01-14 18:57             ` Chanwoo Choi
2020-01-14 18:57               ` Chanwoo Choi
2020-01-14 18:57               ` Chanwoo Choi
     [not found]   ` <CGME20191217055106epcas1p4b50ca647af9b54465e5c0a0bebb165b8@epcas1p4.samsung.com>
2019-12-17  5:57     ` [PATCH 5/9] PM / devfreq: exynos-bus: Replace deprecated 'devfreq-events' property Chanwoo Choi
2019-12-17  5:57       ` Chanwoo Choi
     [not found]   ` <CGME20191217055106epcas1p156b1323f4ec9f7c35fed825d56e577ff@epcas1p1.samsung.com>
2019-12-17  5:57     ` [PATCH 6/9] PM / devfreq: rk3399_dmc: " Chanwoo Choi
2019-12-17  5:57       ` Chanwoo Choi
     [not found]   ` <CGME20191217055106epcas1p2c43a45e34983c1b3e60cc6fd842dd33e@epcas1p2.samsung.com>
2019-12-17  5:57     ` [PATCH 7/9] memory: samsung: exynos5422-dmc: " Chanwoo Choi
2019-12-17  5:57       ` Chanwoo Choi
2019-12-17 11:03       ` Lukasz Luba
2019-12-17 11:03         ` Lukasz Luba
2019-12-17 11:03         ` Lukasz Luba
2019-12-19 20:19       ` Krzysztof Kozlowski
2019-12-19 20:19         ` Krzysztof Kozlowski
     [not found]   ` <CGME20191217055106epcas1p4c0f65bec74e53b38d95e984e146bf8b6@epcas1p4.samsung.com>
2019-12-17  5:57     ` [PATCH 8/9] ARM: dts: exynos: Replace deprecated property for Exynos bus and DMC Chanwoo Choi
2019-12-17  5:57       ` Chanwoo Choi
2019-12-19 20:21       ` Krzysztof Kozlowski
2019-12-19 20:21         ` Krzysztof Kozlowski
     [not found]   ` <CGME20191217055107epcas1p44d46bdea7b326b86689f326742f5444a@epcas1p4.samsung.com>
2019-12-17  5:57     ` [PATCH 9/9] arm64: dts: exynos: Replace deprecated property for Exynos bus Chanwoo Choi
2019-12-17  5:57       ` Chanwoo Choi
2019-12-19 20:22       ` Krzysztof Kozlowski
2019-12-19 20:22         ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191226210119.GA8706@bogus \
    --to=robh@kernel.org \
    --cc=a.swigon@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=leonard.crestez@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=m.szyprowski@samsung.com \
    --cc=mark.rutland@arm.com \
    --cc=myungjoo.ham@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.