From: "Ville Syrjälä" <ville.syrjala@linux.intel.com> To: "José Roberto de Souza" <jose.souza@intel.com> Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH 3/4] drm/i915/display: Remove useless call intel_dp_mst_encoder_cleanup() Date: Thu, 30 Jan 2020 19:16:00 +0200 [thread overview] Message-ID: <20200130171600.GG13686@intel.com> (raw) In-Reply-To: <20200117015837.402239-3-jose.souza@intel.com> On Thu, Jan 16, 2020 at 05:58:36PM -0800, José Roberto de Souza wrote: > This is a eDP function and it will always returns true for non-eDP > ports. > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com> > --- > drivers/gpu/drm/i915/display/intel_dp.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 4074d83b1a5f..a50b5b6dd009 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -7537,7 +7537,6 @@ intel_dp_init_connector(struct intel_digital_port *intel_dig_port, > > if (!intel_edp_init_connector(intel_dp, intel_connector)) { > intel_dp_aux_fini(intel_dp); > - intel_dp_mst_encoder_cleanup(intel_dig_port); This makes the unwind look incomplete to the causual reader. The cleanup function does both anyway so cross checking is harder if they're not consistent. So not sure I like it. Hmm. The ordering of these two also looks off here. Maybe nicer to just move the whole onion to the end of function (we alredy have one layer there)? > goto fail; > } > > -- > 2.25.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com> To: "José Roberto de Souza" <jose.souza@intel.com> Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH 3/4] drm/i915/display: Remove useless call intel_dp_mst_encoder_cleanup() Date: Thu, 30 Jan 2020 19:16:00 +0200 [thread overview] Message-ID: <20200130171600.GG13686@intel.com> (raw) In-Reply-To: <20200117015837.402239-3-jose.souza@intel.com> On Thu, Jan 16, 2020 at 05:58:36PM -0800, José Roberto de Souza wrote: > This is a eDP function and it will always returns true for non-eDP > ports. > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com> > --- > drivers/gpu/drm/i915/display/intel_dp.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 4074d83b1a5f..a50b5b6dd009 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -7537,7 +7537,6 @@ intel_dp_init_connector(struct intel_digital_port *intel_dig_port, > > if (!intel_edp_init_connector(intel_dp, intel_connector)) { > intel_dp_aux_fini(intel_dp); > - intel_dp_mst_encoder_cleanup(intel_dig_port); This makes the unwind look incomplete to the causual reader. The cleanup function does both anyway so cross checking is harder if they're not consistent. So not sure I like it. Hmm. The ordering of these two also looks off here. Maybe nicer to just move the whole onion to the end of function (we alredy have one layer there)? > goto fail; > } > > -- > 2.25.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-01-30 17:24 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-17 1:58 [PATCH 1/4] drm/mst: Don't do atomic checks over disabled managers José Roberto de Souza 2020-01-17 1:58 ` [Intel-gfx] " José Roberto de Souza 2020-01-17 1:58 ` [PATCH 2/4] drm/mst: Some style improvements in drm_dp_mst_topology_mgr_set_mst() José Roberto de Souza 2020-01-17 1:58 ` [Intel-gfx] " José Roberto de Souza 2020-01-17 20:22 ` Lyude Paul 2020-01-17 20:22 ` [Intel-gfx] " Lyude Paul 2020-01-17 21:20 ` Lyude Paul 2020-01-17 21:20 ` [Intel-gfx] " Lyude Paul 2020-01-17 1:58 ` [PATCH 3/4] drm/i915/display: Remove useless call intel_dp_mst_encoder_cleanup() José Roberto de Souza 2020-01-17 1:58 ` [Intel-gfx] " José Roberto de Souza 2020-01-30 17:16 ` Ville Syrjälä [this message] 2020-01-30 17:16 ` Ville Syrjälä 2020-01-31 0:14 ` Souza, Jose 2020-01-31 0:14 ` Souza, Jose 2020-02-11 10:53 ` Lisovskiy, Stanislav 2020-02-11 10:53 ` [Intel-gfx] " Lisovskiy, Stanislav 2020-01-17 1:58 ` [PATCH 4/4] drm/i915/display: Set TRANS_DDI_MODE_SELECT to default value when disabling TRANS_DDI José Roberto de Souza 2020-01-17 1:58 ` [Intel-gfx] " José Roberto de Souza 2020-01-30 17:25 ` Ville Syrjälä 2020-01-30 17:25 ` [Intel-gfx] " Ville Syrjälä 2020-01-30 20:07 ` Souza, Jose 2020-01-30 20:07 ` [Intel-gfx] " Souza, Jose 2020-01-31 11:20 ` Ville Syrjälä 2020-01-31 11:20 ` [Intel-gfx] " Ville Syrjälä 2020-05-13 8:28 ` Sharma, Swati2 2020-05-13 8:28 ` Sharma, Swati2 2020-05-13 12:09 ` Ville Syrjälä 2020-05-13 12:09 ` Ville Syrjälä 2020-05-13 12:14 ` Ville Syrjälä 2020-05-13 12:14 ` Ville Syrjälä 2020-02-11 11:23 ` Lisovskiy, Stanislav 2020-02-11 11:23 ` [Intel-gfx] " Lisovskiy, Stanislav 2020-01-17 3:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/mst: Don't do atomic checks over disabled managers Patchwork 2020-01-17 3:08 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork 2020-01-17 13:51 ` [PATCH 1/4] " Mikita Lipski 2020-01-17 13:51 ` [Intel-gfx] " Mikita Lipski 2020-01-17 20:21 ` Lyude Paul 2020-01-17 20:21 ` [Intel-gfx] " Lyude Paul 2020-01-17 21:24 ` Alex Deucher 2020-01-17 21:24 ` [Intel-gfx] " Alex Deucher 2020-01-20 10:42 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200130171600.GG13686@intel.com \ --to=ville.syrjala@linux.intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jose.souza@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.