From: "Lisovskiy, Stanislav" <stanislav.lisovskiy@intel.com>
To: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"Souza, Jose" <jose.souza@intel.com>
Subject: Re: [PATCH 3/4] drm/i915/display: Remove useless call intel_dp_mst_encoder_cleanup()
Date: Tue, 11 Feb 2020 10:53:09 +0000 [thread overview]
Message-ID: <a09f01c2c73f05ccd41a27a3a76137e8c1f5c830.camel@intel.com> (raw)
In-Reply-To: <20200117015837.402239-3-jose.souza@intel.com>
On Thu, 2020-01-16 at 17:58 -0800, José Roberto de Souza wrote:
> This is a eDP function and it will always returns true for non-eDP
> ports.
>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> b/drivers/gpu/drm/i915/display/intel_dp.c
> index 4074d83b1a5f..a50b5b6dd009 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -7537,7 +7537,6 @@ intel_dp_init_connector(struct
> intel_digital_port *intel_dig_port,
>
> if (!intel_edp_init_connector(intel_dp, intel_connector)) {
> intel_dp_aux_fini(intel_dp);
> - intel_dp_mst_encoder_cleanup(intel_dig_port);
> goto fail;
> }
>
Change looks fine for me(anyway better than now).
But:
This whole thing looks kind of confusing to me. Why we are even calling
intel_edp_init_connector for
non-eDP ports, just to immediately get true returned? So returning
success means either success or that this is non-eDP..
This confuses the caller, that we have actually successfully
initialized eDP, while actually this also means here that it is not
eDP.
Why we can't just do it like:
if (intel_dp_is_edp(intel_dp)) {
if (!intel_edp_init_connector(intel_dp, intel_connector)) {
intel_dp_aux_fini(intel_dp);
goto fail;
}
}
it looks much more understandable and less confusing, i.e eDP functions
are only called for eDP and no return value hacks are needed.
Reviewed-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Stan
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Lisovskiy, Stanislav" <stanislav.lisovskiy@intel.com>
To: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"Souza, Jose" <jose.souza@intel.com>
Subject: Re: [Intel-gfx] [PATCH 3/4] drm/i915/display: Remove useless call intel_dp_mst_encoder_cleanup()
Date: Tue, 11 Feb 2020 10:53:09 +0000 [thread overview]
Message-ID: <a09f01c2c73f05ccd41a27a3a76137e8c1f5c830.camel@intel.com> (raw)
In-Reply-To: <20200117015837.402239-3-jose.souza@intel.com>
On Thu, 2020-01-16 at 17:58 -0800, José Roberto de Souza wrote:
> This is a eDP function and it will always returns true for non-eDP
> ports.
>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> b/drivers/gpu/drm/i915/display/intel_dp.c
> index 4074d83b1a5f..a50b5b6dd009 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -7537,7 +7537,6 @@ intel_dp_init_connector(struct
> intel_digital_port *intel_dig_port,
>
> if (!intel_edp_init_connector(intel_dp, intel_connector)) {
> intel_dp_aux_fini(intel_dp);
> - intel_dp_mst_encoder_cleanup(intel_dig_port);
> goto fail;
> }
>
Change looks fine for me(anyway better than now).
But:
This whole thing looks kind of confusing to me. Why we are even calling
intel_edp_init_connector for
non-eDP ports, just to immediately get true returned? So returning
success means either success or that this is non-eDP..
This confuses the caller, that we have actually successfully
initialized eDP, while actually this also means here that it is not
eDP.
Why we can't just do it like:
if (intel_dp_is_edp(intel_dp)) {
if (!intel_edp_init_connector(intel_dp, intel_connector)) {
intel_dp_aux_fini(intel_dp);
goto fail;
}
}
it looks much more understandable and less confusing, i.e eDP functions
are only called for eDP and no return value hacks are needed.
Reviewed-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Stan
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-11 10:53 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 1:58 [PATCH 1/4] drm/mst: Don't do atomic checks over disabled managers José Roberto de Souza
2020-01-17 1:58 ` [Intel-gfx] " José Roberto de Souza
2020-01-17 1:58 ` [PATCH 2/4] drm/mst: Some style improvements in drm_dp_mst_topology_mgr_set_mst() José Roberto de Souza
2020-01-17 1:58 ` [Intel-gfx] " José Roberto de Souza
2020-01-17 20:22 ` Lyude Paul
2020-01-17 20:22 ` [Intel-gfx] " Lyude Paul
2020-01-17 21:20 ` Lyude Paul
2020-01-17 21:20 ` [Intel-gfx] " Lyude Paul
2020-01-17 1:58 ` [PATCH 3/4] drm/i915/display: Remove useless call intel_dp_mst_encoder_cleanup() José Roberto de Souza
2020-01-17 1:58 ` [Intel-gfx] " José Roberto de Souza
2020-01-30 17:16 ` Ville Syrjälä
2020-01-30 17:16 ` Ville Syrjälä
2020-01-31 0:14 ` Souza, Jose
2020-01-31 0:14 ` Souza, Jose
2020-02-11 10:53 ` Lisovskiy, Stanislav [this message]
2020-02-11 10:53 ` Lisovskiy, Stanislav
2020-01-17 1:58 ` [PATCH 4/4] drm/i915/display: Set TRANS_DDI_MODE_SELECT to default value when disabling TRANS_DDI José Roberto de Souza
2020-01-17 1:58 ` [Intel-gfx] " José Roberto de Souza
2020-01-30 17:25 ` Ville Syrjälä
2020-01-30 17:25 ` [Intel-gfx] " Ville Syrjälä
2020-01-30 20:07 ` Souza, Jose
2020-01-30 20:07 ` [Intel-gfx] " Souza, Jose
2020-01-31 11:20 ` Ville Syrjälä
2020-01-31 11:20 ` [Intel-gfx] " Ville Syrjälä
2020-05-13 8:28 ` Sharma, Swati2
2020-05-13 8:28 ` Sharma, Swati2
2020-05-13 12:09 ` Ville Syrjälä
2020-05-13 12:09 ` Ville Syrjälä
2020-05-13 12:14 ` Ville Syrjälä
2020-05-13 12:14 ` Ville Syrjälä
2020-02-11 11:23 ` Lisovskiy, Stanislav
2020-02-11 11:23 ` [Intel-gfx] " Lisovskiy, Stanislav
2020-01-17 3:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/mst: Don't do atomic checks over disabled managers Patchwork
2020-01-17 3:08 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
2020-01-17 13:51 ` [PATCH 1/4] " Mikita Lipski
2020-01-17 13:51 ` [Intel-gfx] " Mikita Lipski
2020-01-17 20:21 ` Lyude Paul
2020-01-17 20:21 ` [Intel-gfx] " Lyude Paul
2020-01-17 21:24 ` Alex Deucher
2020-01-17 21:24 ` [Intel-gfx] " Alex Deucher
2020-01-20 10:42 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a09f01c2c73f05ccd41a27a3a76137e8c1f5c830.camel@intel.com \
--to=stanislav.lisovskiy@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.