From: Sam Ravnborg <sam@ravnborg.org> To: Thomas Zimmermann <tzimmermann@suse.de> Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, virtualization@lists.linux-foundation.org, noralf@tronnes.org, daniel@ffwll.ch, alexander.deucher@amd.com, spice-devel@lists.freedesktop.org, emil.velikov@collabora.com Subject: Re: [PATCH v2 2/4] drm/ast: Use simple encoder Date: Thu, 20 Feb 2020 20:09:43 +0100 [thread overview] Message-ID: <20200220190943.GB20011@ravnborg.org> (raw) In-Reply-To: <20200218084815.2137-3-tzimmermann@suse.de> Hi Thomas. On Tue, Feb 18, 2020 at 09:48:13AM +0100, Thomas Zimmermann wrote: > The ast driver uses an empty implementation for its encoder. Replace > the code with the generic simple encoder. > > v2: > * rebase onto new simple-encoder interface > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> From browsign the code - looks good: Acked-by: Sam Ravnborg <sam@ravnborg.org> Sam > --- > drivers/gpu/drm/ast/ast_drv.h | 6 +----- > drivers/gpu/drm/ast/ast_mode.c | 25 ++++++++----------------- > 2 files changed, 9 insertions(+), 22 deletions(-) > > diff --git a/drivers/gpu/drm/ast/ast_drv.h b/drivers/gpu/drm/ast/ast_drv.h > index f5d8780776ae..656d591b154b 100644 > --- a/drivers/gpu/drm/ast/ast_drv.h > +++ b/drivers/gpu/drm/ast/ast_drv.h > @@ -121,6 +121,7 @@ struct ast_private { > unsigned int next_index; > } cursor; > > + struct drm_encoder encoder; > struct drm_plane primary_plane; > struct drm_plane cursor_plane; > > @@ -238,13 +239,8 @@ struct ast_crtc { > u8 offset_x, offset_y; > }; > > -struct ast_encoder { > - struct drm_encoder base; > -}; > - > #define to_ast_crtc(x) container_of(x, struct ast_crtc, base) > #define to_ast_connector(x) container_of(x, struct ast_connector, base) > -#define to_ast_encoder(x) container_of(x, struct ast_encoder, base) > > struct ast_vbios_stdtable { > u8 misc; > diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c > index 562ea6d9df13..7a9f20a2fd30 100644 > --- a/drivers/gpu/drm/ast/ast_mode.c > +++ b/drivers/gpu/drm/ast/ast_mode.c > @@ -40,6 +40,7 @@ > #include <drm/drm_gem_vram_helper.h> > #include <drm/drm_plane_helper.h> > #include <drm/drm_probe_helper.h> > +#include <drm/drm_simple_kms_helper.h> > > #include "ast_drv.h" > #include "ast_tables.h" > @@ -968,28 +969,18 @@ static int ast_crtc_init(struct drm_device *dev) > * Encoder > */ > > -static void ast_encoder_destroy(struct drm_encoder *encoder) > -{ > - drm_encoder_cleanup(encoder); > - kfree(encoder); > -} > - > -static const struct drm_encoder_funcs ast_enc_funcs = { > - .destroy = ast_encoder_destroy, > -}; > - > static int ast_encoder_init(struct drm_device *dev) > { > - struct ast_encoder *ast_encoder; > + struct ast_private *ast = dev->dev_private; > + struct drm_encoder *encoder = &ast->encoder; > + int ret; > > - ast_encoder = kzalloc(sizeof(struct ast_encoder), GFP_KERNEL); > - if (!ast_encoder) > - return -ENOMEM; > + ret = drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_DAC); > + if (ret) > + return ret; > > - drm_encoder_init(dev, &ast_encoder->base, &ast_enc_funcs, > - DRM_MODE_ENCODER_DAC, NULL); > + encoder->possible_crtcs = 1; > > - ast_encoder->base.possible_crtcs = 1; > return 0; > } > > -- > 2.25.0
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org> To: Thomas Zimmermann <tzimmermann@suse.de> Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, kraxel@redhat.com, alexander.deucher@amd.com, spice-devel@lists.freedesktop.org, emil.velikov@collabora.com Subject: Re: [PATCH v2 2/4] drm/ast: Use simple encoder Date: Thu, 20 Feb 2020 20:09:43 +0100 [thread overview] Message-ID: <20200220190943.GB20011@ravnborg.org> (raw) In-Reply-To: <20200218084815.2137-3-tzimmermann@suse.de> Hi Thomas. On Tue, Feb 18, 2020 at 09:48:13AM +0100, Thomas Zimmermann wrote: > The ast driver uses an empty implementation for its encoder. Replace > the code with the generic simple encoder. > > v2: > * rebase onto new simple-encoder interface > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> From browsign the code - looks good: Acked-by: Sam Ravnborg <sam@ravnborg.org> Sam > --- > drivers/gpu/drm/ast/ast_drv.h | 6 +----- > drivers/gpu/drm/ast/ast_mode.c | 25 ++++++++----------------- > 2 files changed, 9 insertions(+), 22 deletions(-) > > diff --git a/drivers/gpu/drm/ast/ast_drv.h b/drivers/gpu/drm/ast/ast_drv.h > index f5d8780776ae..656d591b154b 100644 > --- a/drivers/gpu/drm/ast/ast_drv.h > +++ b/drivers/gpu/drm/ast/ast_drv.h > @@ -121,6 +121,7 @@ struct ast_private { > unsigned int next_index; > } cursor; > > + struct drm_encoder encoder; > struct drm_plane primary_plane; > struct drm_plane cursor_plane; > > @@ -238,13 +239,8 @@ struct ast_crtc { > u8 offset_x, offset_y; > }; > > -struct ast_encoder { > - struct drm_encoder base; > -}; > - > #define to_ast_crtc(x) container_of(x, struct ast_crtc, base) > #define to_ast_connector(x) container_of(x, struct ast_connector, base) > -#define to_ast_encoder(x) container_of(x, struct ast_encoder, base) > > struct ast_vbios_stdtable { > u8 misc; > diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c > index 562ea6d9df13..7a9f20a2fd30 100644 > --- a/drivers/gpu/drm/ast/ast_mode.c > +++ b/drivers/gpu/drm/ast/ast_mode.c > @@ -40,6 +40,7 @@ > #include <drm/drm_gem_vram_helper.h> > #include <drm/drm_plane_helper.h> > #include <drm/drm_probe_helper.h> > +#include <drm/drm_simple_kms_helper.h> > > #include "ast_drv.h" > #include "ast_tables.h" > @@ -968,28 +969,18 @@ static int ast_crtc_init(struct drm_device *dev) > * Encoder > */ > > -static void ast_encoder_destroy(struct drm_encoder *encoder) > -{ > - drm_encoder_cleanup(encoder); > - kfree(encoder); > -} > - > -static const struct drm_encoder_funcs ast_enc_funcs = { > - .destroy = ast_encoder_destroy, > -}; > - > static int ast_encoder_init(struct drm_device *dev) > { > - struct ast_encoder *ast_encoder; > + struct ast_private *ast = dev->dev_private; > + struct drm_encoder *encoder = &ast->encoder; > + int ret; > > - ast_encoder = kzalloc(sizeof(struct ast_encoder), GFP_KERNEL); > - if (!ast_encoder) > - return -ENOMEM; > + ret = drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_DAC); > + if (ret) > + return ret; > > - drm_encoder_init(dev, &ast_encoder->base, &ast_enc_funcs, > - DRM_MODE_ENCODER_DAC, NULL); > + encoder->possible_crtcs = 1; > > - ast_encoder->base.possible_crtcs = 1; > return 0; > } > > -- > 2.25.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-20 19:09 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-18 8:48 [PATCH v2 0/4] drm: Provide a simple encoder Thomas Zimmermann 2020-02-18 8:48 ` Thomas Zimmermann 2020-02-18 8:48 ` [PATCH v2 1/4] drm/simple-kms: Add drm_simple_encoder_{init, create}() Thomas Zimmermann 2020-02-18 8:48 ` Thomas Zimmermann 2020-02-20 18:42 ` Sam Ravnborg 2020-02-20 18:42 ` Sam Ravnborg 2020-02-20 18:50 ` Sam Ravnborg 2020-02-20 18:50 ` Sam Ravnborg 2020-02-18 8:48 ` [PATCH v2 2/4] drm/ast: Use simple encoder Thomas Zimmermann 2020-02-18 8:48 ` Thomas Zimmermann 2020-02-20 19:09 ` Sam Ravnborg [this message] 2020-02-20 19:09 ` Sam Ravnborg 2020-02-18 8:48 ` [PATCH v2 3/4] drm/mgag200: " Thomas Zimmermann 2020-02-18 8:48 ` Thomas Zimmermann 2020-02-20 18:56 ` Sam Ravnborg 2020-02-20 18:56 ` Sam Ravnborg 2020-02-21 7:48 ` Thomas Zimmermann 2020-02-21 7:48 ` Thomas Zimmermann 2020-02-21 19:00 ` Sam Ravnborg 2020-02-21 19:00 ` Sam Ravnborg 2020-02-21 19:03 ` Daniel Vetter 2020-02-21 19:03 ` Daniel Vetter 2020-02-18 8:48 ` [PATCH v2 4/4] drm/qxl: " Thomas Zimmermann 2020-02-18 8:48 ` Thomas Zimmermann 2020-02-20 19:10 ` Sam Ravnborg 2020-02-20 19:10 ` Sam Ravnborg 2020-02-24 8:09 ` Gerd Hoffmann 2020-02-24 8:09 ` Gerd Hoffmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200220190943.GB20011@ravnborg.org \ --to=sam@ravnborg.org \ --cc=airlied@linux.ie \ --cc=alexander.deucher@amd.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=emil.velikov@collabora.com \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mripard@kernel.org \ --cc=noralf@tronnes.org \ --cc=spice-devel@lists.freedesktop.org \ --cc=tzimmermann@suse.de \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.