From: Sam Ravnborg <sam@ravnborg.org> To: Thomas Zimmermann <tzimmermann@suse.de> Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, virtualization@lists.linux-foundation.org, noralf@tronnes.org, daniel@ffwll.ch, alexander.deucher@amd.com, spice-devel@lists.freedesktop.org, emil.velikov@collabora.com Subject: Re: [PATCH v2 4/4] drm/qxl: Use simple encoder Date: Thu, 20 Feb 2020 20:10:47 +0100 [thread overview] Message-ID: <20200220191047.GC20011@ravnborg.org> (raw) In-Reply-To: <20200218084815.2137-5-tzimmermann@suse.de> Hi Thomas. On Tue, Feb 18, 2020 at 09:48:15AM +0100, Thomas Zimmermann wrote: > The qxl driver uses an empty implementation for its encoder. Replace > the code with the generic simple encoder. > > v2: > * rebase onto new simple-encoder interface > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> I looked at best_encoder - but could not see we could do anything. So from browsing the code: Acked-by: Sam Ravnborg <sam@ravnborg.org> Sam > --- > drivers/gpu/drm/qxl/qxl_display.c | 18 +++--------------- > 1 file changed, 3 insertions(+), 15 deletions(-) > > diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c > index ab4f8dd00400..9c0e1add59fb 100644 > --- a/drivers/gpu/drm/qxl/qxl_display.c > +++ b/drivers/gpu/drm/qxl/qxl_display.c > @@ -31,6 +31,7 @@ > #include <drm/drm_gem_framebuffer_helper.h> > #include <drm/drm_plane_helper.h> > #include <drm/drm_probe_helper.h> > +#include <drm/drm_simple_kms_helper.h> > > #include "qxl_drv.h" > #include "qxl_object.h" > @@ -1007,9 +1008,6 @@ static struct drm_encoder *qxl_best_encoder(struct drm_connector *connector) > return &qxl_output->enc; > } > > -static const struct drm_encoder_helper_funcs qxl_enc_helper_funcs = { > -}; > - > static const struct drm_connector_helper_funcs qxl_connector_helper_funcs = { > .get_modes = qxl_conn_get_modes, > .mode_valid = qxl_conn_mode_valid, > @@ -1059,15 +1057,6 @@ static const struct drm_connector_funcs qxl_connector_funcs = { > .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, > }; > > -static void qxl_enc_destroy(struct drm_encoder *encoder) > -{ > - drm_encoder_cleanup(encoder); > -} > - > -static const struct drm_encoder_funcs qxl_enc_funcs = { > - .destroy = qxl_enc_destroy, > -}; > - > static int qxl_mode_create_hotplug_mode_update_property(struct qxl_device *qdev) > { > if (qdev->hotplug_mode_update_property) > @@ -1098,15 +1087,14 @@ static int qdev_output_init(struct drm_device *dev, int num_output) > drm_connector_init(dev, &qxl_output->base, > &qxl_connector_funcs, DRM_MODE_CONNECTOR_VIRTUAL); > > - drm_encoder_init(dev, &qxl_output->enc, &qxl_enc_funcs, > - DRM_MODE_ENCODER_VIRTUAL, NULL); > + drm_simple_encoder_init(dev, &qxl_output->enc, > + DRM_MODE_ENCODER_VIRTUAL); > > /* we get HPD via client monitors config */ > connector->polled = DRM_CONNECTOR_POLL_HPD; > encoder->possible_crtcs = 1 << num_output; > drm_connector_attach_encoder(&qxl_output->base, > &qxl_output->enc); > - drm_encoder_helper_add(encoder, &qxl_enc_helper_funcs); > drm_connector_helper_add(connector, &qxl_connector_helper_funcs); > > drm_object_attach_property(&connector->base, > -- > 2.25.0
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org> To: Thomas Zimmermann <tzimmermann@suse.de> Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, kraxel@redhat.com, alexander.deucher@amd.com, spice-devel@lists.freedesktop.org, emil.velikov@collabora.com Subject: Re: [PATCH v2 4/4] drm/qxl: Use simple encoder Date: Thu, 20 Feb 2020 20:10:47 +0100 [thread overview] Message-ID: <20200220191047.GC20011@ravnborg.org> (raw) In-Reply-To: <20200218084815.2137-5-tzimmermann@suse.de> Hi Thomas. On Tue, Feb 18, 2020 at 09:48:15AM +0100, Thomas Zimmermann wrote: > The qxl driver uses an empty implementation for its encoder. Replace > the code with the generic simple encoder. > > v2: > * rebase onto new simple-encoder interface > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> I looked at best_encoder - but could not see we could do anything. So from browsing the code: Acked-by: Sam Ravnborg <sam@ravnborg.org> Sam > --- > drivers/gpu/drm/qxl/qxl_display.c | 18 +++--------------- > 1 file changed, 3 insertions(+), 15 deletions(-) > > diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c > index ab4f8dd00400..9c0e1add59fb 100644 > --- a/drivers/gpu/drm/qxl/qxl_display.c > +++ b/drivers/gpu/drm/qxl/qxl_display.c > @@ -31,6 +31,7 @@ > #include <drm/drm_gem_framebuffer_helper.h> > #include <drm/drm_plane_helper.h> > #include <drm/drm_probe_helper.h> > +#include <drm/drm_simple_kms_helper.h> > > #include "qxl_drv.h" > #include "qxl_object.h" > @@ -1007,9 +1008,6 @@ static struct drm_encoder *qxl_best_encoder(struct drm_connector *connector) > return &qxl_output->enc; > } > > -static const struct drm_encoder_helper_funcs qxl_enc_helper_funcs = { > -}; > - > static const struct drm_connector_helper_funcs qxl_connector_helper_funcs = { > .get_modes = qxl_conn_get_modes, > .mode_valid = qxl_conn_mode_valid, > @@ -1059,15 +1057,6 @@ static const struct drm_connector_funcs qxl_connector_funcs = { > .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, > }; > > -static void qxl_enc_destroy(struct drm_encoder *encoder) > -{ > - drm_encoder_cleanup(encoder); > -} > - > -static const struct drm_encoder_funcs qxl_enc_funcs = { > - .destroy = qxl_enc_destroy, > -}; > - > static int qxl_mode_create_hotplug_mode_update_property(struct qxl_device *qdev) > { > if (qdev->hotplug_mode_update_property) > @@ -1098,15 +1087,14 @@ static int qdev_output_init(struct drm_device *dev, int num_output) > drm_connector_init(dev, &qxl_output->base, > &qxl_connector_funcs, DRM_MODE_CONNECTOR_VIRTUAL); > > - drm_encoder_init(dev, &qxl_output->enc, &qxl_enc_funcs, > - DRM_MODE_ENCODER_VIRTUAL, NULL); > + drm_simple_encoder_init(dev, &qxl_output->enc, > + DRM_MODE_ENCODER_VIRTUAL); > > /* we get HPD via client monitors config */ > connector->polled = DRM_CONNECTOR_POLL_HPD; > encoder->possible_crtcs = 1 << num_output; > drm_connector_attach_encoder(&qxl_output->base, > &qxl_output->enc); > - drm_encoder_helper_add(encoder, &qxl_enc_helper_funcs); > drm_connector_helper_add(connector, &qxl_connector_helper_funcs); > > drm_object_attach_property(&connector->base, > -- > 2.25.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-20 19:10 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-18 8:48 [PATCH v2 0/4] drm: Provide a simple encoder Thomas Zimmermann 2020-02-18 8:48 ` Thomas Zimmermann 2020-02-18 8:48 ` [PATCH v2 1/4] drm/simple-kms: Add drm_simple_encoder_{init, create}() Thomas Zimmermann 2020-02-18 8:48 ` Thomas Zimmermann 2020-02-20 18:42 ` Sam Ravnborg 2020-02-20 18:42 ` Sam Ravnborg 2020-02-20 18:50 ` Sam Ravnborg 2020-02-20 18:50 ` Sam Ravnborg 2020-02-18 8:48 ` [PATCH v2 2/4] drm/ast: Use simple encoder Thomas Zimmermann 2020-02-18 8:48 ` Thomas Zimmermann 2020-02-20 19:09 ` Sam Ravnborg 2020-02-20 19:09 ` Sam Ravnborg 2020-02-18 8:48 ` [PATCH v2 3/4] drm/mgag200: " Thomas Zimmermann 2020-02-18 8:48 ` Thomas Zimmermann 2020-02-20 18:56 ` Sam Ravnborg 2020-02-20 18:56 ` Sam Ravnborg 2020-02-21 7:48 ` Thomas Zimmermann 2020-02-21 7:48 ` Thomas Zimmermann 2020-02-21 19:00 ` Sam Ravnborg 2020-02-21 19:00 ` Sam Ravnborg 2020-02-21 19:03 ` Daniel Vetter 2020-02-21 19:03 ` Daniel Vetter 2020-02-18 8:48 ` [PATCH v2 4/4] drm/qxl: " Thomas Zimmermann 2020-02-18 8:48 ` Thomas Zimmermann 2020-02-20 19:10 ` Sam Ravnborg [this message] 2020-02-20 19:10 ` Sam Ravnborg 2020-02-24 8:09 ` Gerd Hoffmann 2020-02-24 8:09 ` Gerd Hoffmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200220191047.GC20011@ravnborg.org \ --to=sam@ravnborg.org \ --cc=airlied@linux.ie \ --cc=alexander.deucher@amd.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=emil.velikov@collabora.com \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mripard@kernel.org \ --cc=noralf@tronnes.org \ --cc=spice-devel@lists.freedesktop.org \ --cc=tzimmermann@suse.de \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.