From: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com> To: jani.nikula@linux.intel.com, daniel@ffwll.ch, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@linux.ie> Cc: pankaj.laxminarayan.bharadiya@intel.com Subject: [PATCH 8/9] drm/fb-helper: Remove drm_fb_helper add, add_all and remove connector functions Date: Mon, 2 Mar 2020 18:26:48 +0530 [thread overview] Message-ID: <20200302125649.61443-9-pankaj.laxminarayan.bharadiya@intel.com> (raw) In-Reply-To: <20200302125649.61443-1-pankaj.laxminarayan.bharadiya@intel.com> drm_fb_helper_single_add_all_connectors(), drm_fb_helper_add_one_connector() and drm_fb_helper_remove_one_connector() doesn't keep an array of connectors anymore and are just dummy. Now we have no callers to these functions hence remove them. Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com> --- include/drm/drm_fb_helper.h | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index 62e8dda6d1d1..208dbf87afa3 100644 --- a/include/drm/drm_fb_helper.h +++ b/include/drm/drm_fb_helper.h @@ -451,27 +451,6 @@ drm_fbdev_generic_setup(struct drm_device *dev, unsigned int preferred_bpp) #endif -/* TODO: There's a todo entry to remove these three */ -static inline int -drm_fb_helper_single_add_all_connectors(struct drm_fb_helper *fb_helper) -{ - return 0; -} - -static inline int -drm_fb_helper_add_one_connector(struct drm_fb_helper *fb_helper, - struct drm_connector *connector) -{ - return 0; -} - -static inline int -drm_fb_helper_remove_one_connector(struct drm_fb_helper *fb_helper, - struct drm_connector *connector) -{ - return 0; -} - /** * drm_fb_helper_remove_conflicting_framebuffers - remove firmware-configured framebuffers * @a: memory range, users of which are to be removed -- 2.20.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com> To: jani.nikula@linux.intel.com, daniel@ffwll.ch, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@linux.ie> Subject: [Intel-gfx] [PATCH 8/9] drm/fb-helper: Remove drm_fb_helper add, add_all and remove connector functions Date: Mon, 2 Mar 2020 18:26:48 +0530 [thread overview] Message-ID: <20200302125649.61443-9-pankaj.laxminarayan.bharadiya@intel.com> (raw) In-Reply-To: <20200302125649.61443-1-pankaj.laxminarayan.bharadiya@intel.com> drm_fb_helper_single_add_all_connectors(), drm_fb_helper_add_one_connector() and drm_fb_helper_remove_one_connector() doesn't keep an array of connectors anymore and are just dummy. Now we have no callers to these functions hence remove them. Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com> --- include/drm/drm_fb_helper.h | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index 62e8dda6d1d1..208dbf87afa3 100644 --- a/include/drm/drm_fb_helper.h +++ b/include/drm/drm_fb_helper.h @@ -451,27 +451,6 @@ drm_fbdev_generic_setup(struct drm_device *dev, unsigned int preferred_bpp) #endif -/* TODO: There's a todo entry to remove these three */ -static inline int -drm_fb_helper_single_add_all_connectors(struct drm_fb_helper *fb_helper) -{ - return 0; -} - -static inline int -drm_fb_helper_add_one_connector(struct drm_fb_helper *fb_helper, - struct drm_connector *connector) -{ - return 0; -} - -static inline int -drm_fb_helper_remove_one_connector(struct drm_fb_helper *fb_helper, - struct drm_connector *connector) -{ - return 0; -} - /** * drm_fb_helper_remove_conflicting_framebuffers - remove firmware-configured framebuffers * @a: memory range, users of which are to be removed -- 2.20.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-03-02 13:09 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-02 12:56 [PATCH 0/9] drm: drm_fb_helper cleanup Pankaj Bharadiya 2020-03-02 12:56 ` [Intel-gfx] " Pankaj Bharadiya 2020-03-02 12:56 ` [PATCH 1/9] drm: Remove unused arg from drm_fb_helper_init Pankaj Bharadiya 2020-03-02 12:56 ` [Intel-gfx] " Pankaj Bharadiya 2020-03-02 13:44 ` Thomas Zimmermann 2020-03-02 13:44 ` [Intel-gfx] " Thomas Zimmermann 2020-03-02 21:38 ` Alex Deucher 2020-03-02 21:38 ` [Intel-gfx] " Alex Deucher 2020-03-02 12:56 ` [PATCH 2/9] drm/radeon: remove radeon_fb_{add, remove}_connector functions Pankaj Bharadiya 2020-03-02 12:56 ` [Intel-gfx] " Pankaj Bharadiya 2020-03-02 21:41 ` Alex Deucher 2020-03-02 21:41 ` [Intel-gfx] " Alex Deucher 2020-03-02 12:56 ` [PATCH 3/9] drm/amdgpu: Remove drm_fb_helper_{add, remove}_one_connector calls Pankaj Bharadiya 2020-03-02 12:56 ` [Intel-gfx] " Pankaj Bharadiya 2020-03-02 21:41 ` Alex Deucher 2020-03-02 21:41 ` [Intel-gfx] " Alex Deucher 2020-03-02 12:56 ` [PATCH 4/9] drm/i915/display: " Pankaj Bharadiya 2020-03-02 12:56 ` [Intel-gfx] " Pankaj Bharadiya 2020-03-02 21:42 ` Alex Deucher 2020-03-02 21:42 ` [Intel-gfx] " Alex Deucher 2020-03-02 12:56 ` [PATCH 5/9] drm: Remove drm_fb_helper add, add all and remove connector calls Pankaj Bharadiya 2020-03-02 12:56 ` [Intel-gfx] " Pankaj Bharadiya 2020-03-02 21:42 ` Alex Deucher 2020-03-02 21:42 ` [Intel-gfx] " Alex Deucher 2020-03-02 12:56 ` [PATCH 6/9] drm/nouveau: Fix unused variable warning Pankaj Bharadiya 2020-03-02 12:56 ` [Intel-gfx] " Pankaj Bharadiya 2020-03-02 13:30 ` Laurent Pinchart 2020-03-02 13:30 ` [Intel-gfx] " Laurent Pinchart 2020-03-03 18:58 ` Lyude Paul 2020-03-03 18:58 ` [Intel-gfx] " Lyude Paul 2020-03-02 12:56 ` [PATCH 7/9] drm/bridge: remove unused variable warning in tc358764_detach Pankaj Bharadiya 2020-03-02 12:56 ` [Intel-gfx] " Pankaj Bharadiya 2020-03-02 13:27 ` Laurent Pinchart 2020-03-02 13:27 ` [Intel-gfx] " Laurent Pinchart 2020-03-02 12:56 ` Pankaj Bharadiya [this message] 2020-03-02 12:56 ` [Intel-gfx] [PATCH 8/9] drm/fb-helper: Remove drm_fb_helper add, add_all and remove connector functions Pankaj Bharadiya 2020-03-02 13:27 ` Laurent Pinchart 2020-03-02 13:27 ` [Intel-gfx] " Laurent Pinchart 2020-03-02 21:43 ` Alex Deucher 2020-03-02 21:43 ` [Intel-gfx] " Alex Deucher 2020-03-02 12:56 ` [PATCH 9/9] drm/todo: Update drm_fb_helper tasks Pankaj Bharadiya 2020-03-02 12:56 ` [Intel-gfx] " Pankaj Bharadiya 2020-03-02 13:29 ` Laurent Pinchart 2020-03-02 13:29 ` [Intel-gfx] " Laurent Pinchart 2020-03-02 21:35 ` Daniel Vetter 2020-03-02 21:35 ` [Intel-gfx] " Daniel Vetter 2020-03-02 14:29 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: drm_fb_helper cleanup Patchwork 2020-03-02 14:47 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork 2020-03-02 15:04 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2020-03-02 15:58 ` [Intel-gfx] [PATCH 0/9] " Emil Velikov 2020-03-02 15:58 ` Emil Velikov 2020-03-02 16:17 ` Emil Velikov 2020-03-02 16:17 ` Emil Velikov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200302125649.61443-9-pankaj.laxminarayan.bharadiya@intel.com \ --to=pankaj.laxminarayan.bharadiya@intel.com \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jani.nikula@linux.intel.com \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mripard@kernel.org \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.