From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
Neil Armstrong <narmstrong@baylibre.com>,
David Airlie <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, Jonas Karlman <jonas@kwiboo.se>,
dri-devel@lists.freedesktop.org,
Andrzej Hajda <a.hajda@samsung.com>
Subject: Re: [PATCH 7/9] drm/bridge: remove unused variable warning in tc358764_detach
Date: Mon, 2 Mar 2020 15:27:09 +0200 [thread overview]
Message-ID: <20200302132709.GN11960@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200302125649.61443-8-pankaj.laxminarayan.bharadiya@intel.com>
Hi Pankaj,
Thank you for the patch.
You can squash this with the patch that introduced the issue in the same
series. Otherwise we will be left with a compilation breakage in the
history, which could be annoying when bisecting issues.
On Mon, Mar 02, 2020 at 06:26:47PM +0530, Pankaj Bharadiya wrote:
> drm_device pointer is not getting used in tc358764_detach() anymore,
> hence remove it.
>
> This fixes below warning.
>
> drivers/gpu/drm/bridge/tc358764.c: In function ‘tc358764_detach’:
> drivers/gpu/drm/bridge/tc358764.c:386:21: warning: unused variable ‘drm’ [-Wunused-variable]
> struct drm_device *drm = bridge->dev;
> ^~~
>
> Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
> ---
> drivers/gpu/drm/bridge/tc358764.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/tc358764.c b/drivers/gpu/drm/bridge/tc358764.c
> index 530342dd4a34..5ac1430fab04 100644
> --- a/drivers/gpu/drm/bridge/tc358764.c
> +++ b/drivers/gpu/drm/bridge/tc358764.c
> @@ -383,7 +383,6 @@ static int tc358764_attach(struct drm_bridge *bridge,
> static void tc358764_detach(struct drm_bridge *bridge)
> {
> struct tc358764 *ctx = bridge_to_tc358764(bridge);
> - struct drm_device *drm = bridge->dev;
>
> drm_connector_unregister(&ctx->connector);
> drm_panel_detach(ctx->panel);
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
Neil Armstrong <narmstrong@baylibre.com>,
David Airlie <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, Jonas Karlman <jonas@kwiboo.se>,
dri-devel@lists.freedesktop.org,
Andrzej Hajda <a.hajda@samsung.com>
Subject: Re: [Intel-gfx] [PATCH 7/9] drm/bridge: remove unused variable warning in tc358764_detach
Date: Mon, 2 Mar 2020 15:27:09 +0200 [thread overview]
Message-ID: <20200302132709.GN11960@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200302125649.61443-8-pankaj.laxminarayan.bharadiya@intel.com>
Hi Pankaj,
Thank you for the patch.
You can squash this with the patch that introduced the issue in the same
series. Otherwise we will be left with a compilation breakage in the
history, which could be annoying when bisecting issues.
On Mon, Mar 02, 2020 at 06:26:47PM +0530, Pankaj Bharadiya wrote:
> drm_device pointer is not getting used in tc358764_detach() anymore,
> hence remove it.
>
> This fixes below warning.
>
> drivers/gpu/drm/bridge/tc358764.c: In function ‘tc358764_detach’:
> drivers/gpu/drm/bridge/tc358764.c:386:21: warning: unused variable ‘drm’ [-Wunused-variable]
> struct drm_device *drm = bridge->dev;
> ^~~
>
> Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
> ---
> drivers/gpu/drm/bridge/tc358764.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/tc358764.c b/drivers/gpu/drm/bridge/tc358764.c
> index 530342dd4a34..5ac1430fab04 100644
> --- a/drivers/gpu/drm/bridge/tc358764.c
> +++ b/drivers/gpu/drm/bridge/tc358764.c
> @@ -383,7 +383,6 @@ static int tc358764_attach(struct drm_bridge *bridge,
> static void tc358764_detach(struct drm_bridge *bridge)
> {
> struct tc358764 *ctx = bridge_to_tc358764(bridge);
> - struct drm_device *drm = bridge->dev;
>
> drm_connector_unregister(&ctx->connector);
> drm_panel_detach(ctx->panel);
--
Regards,
Laurent Pinchart
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-03-02 13:27 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 12:56 [PATCH 0/9] drm: drm_fb_helper cleanup Pankaj Bharadiya
2020-03-02 12:56 ` [Intel-gfx] " Pankaj Bharadiya
2020-03-02 12:56 ` [PATCH 1/9] drm: Remove unused arg from drm_fb_helper_init Pankaj Bharadiya
2020-03-02 12:56 ` [Intel-gfx] " Pankaj Bharadiya
2020-03-02 13:44 ` Thomas Zimmermann
2020-03-02 13:44 ` [Intel-gfx] " Thomas Zimmermann
2020-03-02 21:38 ` Alex Deucher
2020-03-02 21:38 ` [Intel-gfx] " Alex Deucher
2020-03-02 12:56 ` [PATCH 2/9] drm/radeon: remove radeon_fb_{add, remove}_connector functions Pankaj Bharadiya
2020-03-02 12:56 ` [Intel-gfx] " Pankaj Bharadiya
2020-03-02 21:41 ` Alex Deucher
2020-03-02 21:41 ` [Intel-gfx] " Alex Deucher
2020-03-02 12:56 ` [PATCH 3/9] drm/amdgpu: Remove drm_fb_helper_{add, remove}_one_connector calls Pankaj Bharadiya
2020-03-02 12:56 ` [Intel-gfx] " Pankaj Bharadiya
2020-03-02 21:41 ` Alex Deucher
2020-03-02 21:41 ` [Intel-gfx] " Alex Deucher
2020-03-02 12:56 ` [PATCH 4/9] drm/i915/display: " Pankaj Bharadiya
2020-03-02 12:56 ` [Intel-gfx] " Pankaj Bharadiya
2020-03-02 21:42 ` Alex Deucher
2020-03-02 21:42 ` [Intel-gfx] " Alex Deucher
2020-03-02 12:56 ` [PATCH 5/9] drm: Remove drm_fb_helper add, add all and remove connector calls Pankaj Bharadiya
2020-03-02 12:56 ` [Intel-gfx] " Pankaj Bharadiya
2020-03-02 21:42 ` Alex Deucher
2020-03-02 21:42 ` [Intel-gfx] " Alex Deucher
2020-03-02 12:56 ` [PATCH 6/9] drm/nouveau: Fix unused variable warning Pankaj Bharadiya
2020-03-02 12:56 ` [Intel-gfx] " Pankaj Bharadiya
2020-03-02 13:30 ` Laurent Pinchart
2020-03-02 13:30 ` [Intel-gfx] " Laurent Pinchart
2020-03-03 18:58 ` Lyude Paul
2020-03-03 18:58 ` [Intel-gfx] " Lyude Paul
2020-03-02 12:56 ` [PATCH 7/9] drm/bridge: remove unused variable warning in tc358764_detach Pankaj Bharadiya
2020-03-02 12:56 ` [Intel-gfx] " Pankaj Bharadiya
2020-03-02 13:27 ` Laurent Pinchart [this message]
2020-03-02 13:27 ` Laurent Pinchart
2020-03-02 12:56 ` [PATCH 8/9] drm/fb-helper: Remove drm_fb_helper add, add_all and remove connector functions Pankaj Bharadiya
2020-03-02 12:56 ` [Intel-gfx] " Pankaj Bharadiya
2020-03-02 13:27 ` Laurent Pinchart
2020-03-02 13:27 ` [Intel-gfx] " Laurent Pinchart
2020-03-02 21:43 ` Alex Deucher
2020-03-02 21:43 ` [Intel-gfx] " Alex Deucher
2020-03-02 12:56 ` [PATCH 9/9] drm/todo: Update drm_fb_helper tasks Pankaj Bharadiya
2020-03-02 12:56 ` [Intel-gfx] " Pankaj Bharadiya
2020-03-02 13:29 ` Laurent Pinchart
2020-03-02 13:29 ` [Intel-gfx] " Laurent Pinchart
2020-03-02 21:35 ` Daniel Vetter
2020-03-02 21:35 ` [Intel-gfx] " Daniel Vetter
2020-03-02 14:29 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: drm_fb_helper cleanup Patchwork
2020-03-02 14:47 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2020-03-02 15:04 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-03-02 15:58 ` [Intel-gfx] [PATCH 0/9] " Emil Velikov
2020-03-02 15:58 ` Emil Velikov
2020-03-02 16:17 ` Emil Velikov
2020-03-02 16:17 ` Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200302132709.GN11960@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=narmstrong@baylibre.com \
--cc=pankaj.laxminarayan.bharadiya@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.