From: Wolfram Sang <wsa@the-dreams.de> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: "Wolfram Sang" <wsa+renesas@sang-engineering.com>, "Linux I2C" <linux-i2c@vger.kernel.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, linux-i3c@lists.infradead.org, "Kieran Bingham" <kieran@ksquared.org.uk>, "Niklas Söderlund" <niklas.soderlund@ragnatech.se>, "Luca Ceresoli" <luca@lucaceresoli.net>, "Jacopo Mondi" <jacopo@jmondi.org>, "Laurent Pinchart" <laurent.pinchart@ideasonboard.com>, "Vladimir Zapolskiy" <vz@mleia.com>, "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org> Subject: Re: [RFC PATCH 6/7] i2c: of: mark a whole array of regs as reserved Date: Wed, 18 Mar 2020 15:33:21 +0100 [thread overview] Message-ID: <20200318143321.GB8300@ninjato> (raw) In-Reply-To: <CAMuHMdUvADDozCX6Bd0dDVejpTY-k42naEnB7Q5Z6w7Yg94_Vw@mail.gmail.com> [-- Attachment #1: Type: text/plain, Size: 1614 bytes --] > > +int of_i2c_get_board_info(struct device_node *node, struct i2c_board_info *info) > > +{ > > + u32 addr; > > + int ret; > > + > > + ret = of_property_read_u32(node, "reg", &addr); > > Perhaps the time is ripe to start considering #address-cells, instead > of assuming 1, here ... I think here it is okay because we really want the first entry of the first tuple. > > + of_property_for_each_u32(node, "reg", prop, cur, reg) { > > ... and especially here, if this code can ever be reused for i3c, which uses 3. But here I agree. I reimplemented the code to handle it, and it worked with '#address-cells = <2>;' as expected. Here is the diff to this patch: @@ -16,6 +16,7 @@ #include <linux/i2c.h> #include <linux/module.h> #include <linux/of.h> +#include <linux/of_address.h> #include <linux/of_device.h> #include <linux/sysfs.h> @@ -75,13 +76,14 @@ static struct i2c_client *of_i2c_register_device(struct i2c_adapter *adap, struct i2c_client *client, *first_client = ERR_PTR(-ENOENT); struct i2c_board_info info; bool first_reg = true; - struct property *prop; - const __be32 *cur; - u32 reg; + unsigned int i = 0; + const __be32 *prop; + u16 reg; pr_debug("register %pOF\n", node); - of_property_for_each_u32(node, "reg", prop, cur, reg) { + while ((prop = of_get_address(node, i++, NULL, NULL))) { + reg = of_read_number(prop, 1); of_i2c_decode_board_info(node, reg, first_reg, &info); client = i2c_new_client_device(adap, &info); Thanks, Geert! I will send out the new version in a few minutes. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, "Kieran Bingham" <kieran@ksquared.org.uk>, "Luca Ceresoli" <luca@lucaceresoli.net>, "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>, "Jacopo Mondi" <jacopo@jmondi.org>, "Vladimir Zapolskiy" <vz@mleia.com>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, "Wolfram Sang" <wsa+renesas@sang-engineering.com>, "Linux I2C" <linux-i2c@vger.kernel.org>, "Niklas Söderlund" <niklas.soderlund@ragnatech.se>, linux-i3c@lists.infradead.org, "Laurent Pinchart" <laurent.pinchart@ideasonboard.com> Subject: Re: [RFC PATCH 6/7] i2c: of: mark a whole array of regs as reserved Date: Wed, 18 Mar 2020 15:33:21 +0100 [thread overview] Message-ID: <20200318143321.GB8300@ninjato> (raw) In-Reply-To: <CAMuHMdUvADDozCX6Bd0dDVejpTY-k42naEnB7Q5Z6w7Yg94_Vw@mail.gmail.com> [-- Attachment #1.1: Type: text/plain, Size: 1614 bytes --] > > +int of_i2c_get_board_info(struct device_node *node, struct i2c_board_info *info) > > +{ > > + u32 addr; > > + int ret; > > + > > + ret = of_property_read_u32(node, "reg", &addr); > > Perhaps the time is ripe to start considering #address-cells, instead > of assuming 1, here ... I think here it is okay because we really want the first entry of the first tuple. > > + of_property_for_each_u32(node, "reg", prop, cur, reg) { > > ... and especially here, if this code can ever be reused for i3c, which uses 3. But here I agree. I reimplemented the code to handle it, and it worked with '#address-cells = <2>;' as expected. Here is the diff to this patch: @@ -16,6 +16,7 @@ #include <linux/i2c.h> #include <linux/module.h> #include <linux/of.h> +#include <linux/of_address.h> #include <linux/of_device.h> #include <linux/sysfs.h> @@ -75,13 +76,14 @@ static struct i2c_client *of_i2c_register_device(struct i2c_adapter *adap, struct i2c_client *client, *first_client = ERR_PTR(-ENOENT); struct i2c_board_info info; bool first_reg = true; - struct property *prop; - const __be32 *cur; - u32 reg; + unsigned int i = 0; + const __be32 *prop; + u16 reg; pr_debug("register %pOF\n", node); - of_property_for_each_u32(node, "reg", prop, cur, reg) { + while ((prop = of_get_address(node, i++, NULL, NULL))) { + reg = of_read_number(prop, 1); of_i2c_decode_board_info(node, reg, first_reg, &info); client = i2c_new_client_device(adap, &info); Thanks, Geert! I will send out the new version in a few minutes. [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 155 bytes --] _______________________________________________ linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2020-03-18 14:33 UTC|newest] Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-20 17:23 [RFC PATCH 0/7] i2c: of: reserve unknown and ancillary addresses Wolfram Sang 2020-02-20 17:23 ` Wolfram Sang 2020-02-20 17:23 ` [RFC PATCH 1/7] i2c: add sanity check for parameter of i2c_verify_client() Wolfram Sang 2020-02-20 17:23 ` Wolfram Sang 2020-02-21 9:36 ` Geert Uytterhoeven 2020-02-21 9:36 ` Geert Uytterhoeven 2020-02-20 17:23 ` [RFC PATCH 2/7] i2c: use DEFINE for the dummy driver name Wolfram Sang 2020-02-20 17:23 ` Wolfram Sang 2020-02-21 9:38 ` Geert Uytterhoeven 2020-02-21 9:38 ` Geert Uytterhoeven 2020-02-20 17:23 ` [RFC PATCH 3/7] i2c: allow DT nodes without 'compatible' Wolfram Sang 2020-02-20 17:23 ` Wolfram Sang 2020-02-20 17:23 ` Wolfram Sang 2020-02-21 9:45 ` Geert Uytterhoeven 2020-02-21 9:45 ` Geert Uytterhoeven 2020-02-21 9:45 ` Geert Uytterhoeven 2020-02-21 9:48 ` Geert Uytterhoeven 2020-02-21 9:48 ` Geert Uytterhoeven 2020-02-21 9:48 ` Geert Uytterhoeven 2020-02-23 23:11 ` Luca Ceresoli 2020-02-23 23:11 ` Luca Ceresoli 2020-03-12 11:19 ` Wolfram Sang 2020-03-12 11:19 ` Wolfram Sang 2020-03-12 11:44 ` Alexandre Belloni 2020-03-12 11:44 ` Alexandre Belloni 2020-03-12 11:44 ` Alexandre Belloni 2020-04-10 13:47 ` Luca Ceresoli 2020-04-10 13:47 ` Luca Ceresoli 2020-02-26 16:30 ` Rob Herring 2020-02-26 16:30 ` Rob Herring 2020-02-26 16:30 ` Rob Herring 2020-02-20 17:24 ` [RFC PATCH 4/7] i2c: of: remove superfluous parameter from exported function Wolfram Sang 2020-02-20 17:24 ` Wolfram Sang 2020-02-21 9:50 ` Geert Uytterhoeven 2020-02-21 9:50 ` Geert Uytterhoeven 2020-02-21 9:50 ` Geert Uytterhoeven 2020-02-24 8:12 ` Luca Ceresoli 2020-02-24 8:12 ` Luca Ceresoli 2020-02-20 17:24 ` [RFC PATCH 5/7] i2c: of: error message unification Wolfram Sang 2020-02-20 17:24 ` Wolfram Sang 2020-02-21 9:54 ` Geert Uytterhoeven 2020-02-21 9:54 ` Geert Uytterhoeven 2020-02-20 17:24 ` [RFC PATCH 6/7] i2c: of: mark a whole array of regs as reserved Wolfram Sang 2020-02-20 17:24 ` Wolfram Sang 2020-02-21 10:09 ` Geert Uytterhoeven 2020-02-21 10:09 ` Geert Uytterhoeven 2020-03-12 11:21 ` Wolfram Sang 2020-03-12 11:21 ` Wolfram Sang 2020-03-18 14:33 ` Wolfram Sang [this message] 2020-03-18 14:33 ` Wolfram Sang 2020-02-28 12:11 ` Luca Ceresoli 2020-02-28 12:11 ` Luca Ceresoli 2020-02-20 17:24 ` [RFC PATCH 7/7] i2c: core: hand over reserved devices when requesting ancillary addresses Wolfram Sang 2020-02-20 17:24 ` Wolfram Sang 2020-02-21 10:13 ` Geert Uytterhoeven 2020-02-21 10:13 ` Geert Uytterhoeven 2020-02-21 10:13 ` Geert Uytterhoeven 2020-02-28 12:11 ` Luca Ceresoli 2020-02-28 12:11 ` Luca Ceresoli 2020-03-12 11:30 ` Wolfram Sang 2020-03-12 11:30 ` Wolfram Sang 2020-03-12 11:21 ` Wolfram Sang 2020-03-12 11:21 ` Wolfram Sang 2020-03-13 12:42 ` Wolfram Sang 2020-03-13 12:42 ` Wolfram Sang 2020-02-21 10:15 ` [RFC PATCH 0/7] i2c: of: reserve unknown and " Geert Uytterhoeven 2020-02-21 10:15 ` Geert Uytterhoeven
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200318143321.GB8300@ninjato \ --to=wsa@the-dreams.de \ --cc=devicetree@vger.kernel.org \ --cc=geert@linux-m68k.org \ --cc=jacopo@jmondi.org \ --cc=kieran@ksquared.org.uk \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-i3c@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=luca@lucaceresoli.net \ --cc=niklas.soderlund@ragnatech.se \ --cc=vz@mleia.com \ --cc=wsa+renesas@sang-engineering.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.