From: Geert Uytterhoeven <geert@linux-m68k.org> To: Wolfram Sang <wsa+renesas@sang-engineering.com> Cc: "Linux I2C" <linux-i2c@vger.kernel.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, linux-i3c@lists.infradead.org, "Kieran Bingham" <kieran@ksquared.org.uk>, "Niklas Söderlund" <niklas.soderlund@ragnatech.se>, "Luca Ceresoli" <luca@lucaceresoli.net>, "Jacopo Mondi" <jacopo@jmondi.org>, "Laurent Pinchart" <laurent.pinchart@ideasonboard.com>, "Vladimir Zapolskiy" <vz@mleia.com>, "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org> Subject: Re: [RFC PATCH 1/7] i2c: add sanity check for parameter of i2c_verify_client() Date: Fri, 21 Feb 2020 10:36:30 +0100 [thread overview] Message-ID: <CAMuHMdU3WgdV0cqf0Gu=szyNch=QOEK8UbiQyxLjsf+WnS=-ZA@mail.gmail.com> (raw) In-Reply-To: <20200220172403.26062-2-wsa+renesas@sang-engineering.com> Hi Wolfram, On Thu, Feb 20, 2020 at 6:26 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > We export this function, so we should check the paramter to make it parameter > NULL-compatible. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> And then the check in i2c_acpi_find_client_by_adev() can be removed. BTW, can the i2c_verify_client() check in that function actually fail? If yes, it should call put_device(dev) on failure, like of_find_i2c_device_by_node() does. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org> To: Wolfram Sang <wsa+renesas@sang-engineering.com> Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, "Kieran Bingham" <kieran@ksquared.org.uk>, "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>, "Jacopo Mondi" <jacopo@jmondi.org>, "Vladimir Zapolskiy" <vz@mleia.com>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, "Luca Ceresoli" <luca@lucaceresoli.net>, "Linux I2C" <linux-i2c@vger.kernel.org>, "Niklas Söderlund" <niklas.soderlund@ragnatech.se>, linux-i3c@lists.infradead.org, "Laurent Pinchart" <laurent.pinchart@ideasonboard.com> Subject: Re: [RFC PATCH 1/7] i2c: add sanity check for parameter of i2c_verify_client() Date: Fri, 21 Feb 2020 10:36:30 +0100 [thread overview] Message-ID: <CAMuHMdU3WgdV0cqf0Gu=szyNch=QOEK8UbiQyxLjsf+WnS=-ZA@mail.gmail.com> (raw) In-Reply-To: <20200220172403.26062-2-wsa+renesas@sang-engineering.com> Hi Wolfram, On Thu, Feb 20, 2020 at 6:26 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > We export this function, so we should check the paramter to make it parameter > NULL-compatible. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> And then the check in i2c_acpi_find_client_by_adev() can be removed. BTW, can the i2c_verify_client() check in that function actually fail? If yes, it should call put_device(dev) on failure, like of_find_i2c_device_by_node() does. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2020-02-21 9:36 UTC|newest] Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-20 17:23 [RFC PATCH 0/7] i2c: of: reserve unknown and ancillary addresses Wolfram Sang 2020-02-20 17:23 ` Wolfram Sang 2020-02-20 17:23 ` [RFC PATCH 1/7] i2c: add sanity check for parameter of i2c_verify_client() Wolfram Sang 2020-02-20 17:23 ` Wolfram Sang 2020-02-21 9:36 ` Geert Uytterhoeven [this message] 2020-02-21 9:36 ` Geert Uytterhoeven 2020-02-20 17:23 ` [RFC PATCH 2/7] i2c: use DEFINE for the dummy driver name Wolfram Sang 2020-02-20 17:23 ` Wolfram Sang 2020-02-21 9:38 ` Geert Uytterhoeven 2020-02-21 9:38 ` Geert Uytterhoeven 2020-02-20 17:23 ` [RFC PATCH 3/7] i2c: allow DT nodes without 'compatible' Wolfram Sang 2020-02-20 17:23 ` Wolfram Sang 2020-02-20 17:23 ` Wolfram Sang 2020-02-21 9:45 ` Geert Uytterhoeven 2020-02-21 9:45 ` Geert Uytterhoeven 2020-02-21 9:45 ` Geert Uytterhoeven 2020-02-21 9:48 ` Geert Uytterhoeven 2020-02-21 9:48 ` Geert Uytterhoeven 2020-02-21 9:48 ` Geert Uytterhoeven 2020-02-23 23:11 ` Luca Ceresoli 2020-02-23 23:11 ` Luca Ceresoli 2020-03-12 11:19 ` Wolfram Sang 2020-03-12 11:19 ` Wolfram Sang 2020-03-12 11:44 ` Alexandre Belloni 2020-03-12 11:44 ` Alexandre Belloni 2020-03-12 11:44 ` Alexandre Belloni 2020-04-10 13:47 ` Luca Ceresoli 2020-04-10 13:47 ` Luca Ceresoli 2020-02-26 16:30 ` Rob Herring 2020-02-26 16:30 ` Rob Herring 2020-02-26 16:30 ` Rob Herring 2020-02-20 17:24 ` [RFC PATCH 4/7] i2c: of: remove superfluous parameter from exported function Wolfram Sang 2020-02-20 17:24 ` Wolfram Sang 2020-02-21 9:50 ` Geert Uytterhoeven 2020-02-21 9:50 ` Geert Uytterhoeven 2020-02-21 9:50 ` Geert Uytterhoeven 2020-02-24 8:12 ` Luca Ceresoli 2020-02-24 8:12 ` Luca Ceresoli 2020-02-20 17:24 ` [RFC PATCH 5/7] i2c: of: error message unification Wolfram Sang 2020-02-20 17:24 ` Wolfram Sang 2020-02-21 9:54 ` Geert Uytterhoeven 2020-02-21 9:54 ` Geert Uytterhoeven 2020-02-20 17:24 ` [RFC PATCH 6/7] i2c: of: mark a whole array of regs as reserved Wolfram Sang 2020-02-20 17:24 ` Wolfram Sang 2020-02-21 10:09 ` Geert Uytterhoeven 2020-02-21 10:09 ` Geert Uytterhoeven 2020-03-12 11:21 ` Wolfram Sang 2020-03-12 11:21 ` Wolfram Sang 2020-03-18 14:33 ` Wolfram Sang 2020-03-18 14:33 ` Wolfram Sang 2020-02-28 12:11 ` Luca Ceresoli 2020-02-28 12:11 ` Luca Ceresoli 2020-02-20 17:24 ` [RFC PATCH 7/7] i2c: core: hand over reserved devices when requesting ancillary addresses Wolfram Sang 2020-02-20 17:24 ` Wolfram Sang 2020-02-21 10:13 ` Geert Uytterhoeven 2020-02-21 10:13 ` Geert Uytterhoeven 2020-02-21 10:13 ` Geert Uytterhoeven 2020-02-28 12:11 ` Luca Ceresoli 2020-02-28 12:11 ` Luca Ceresoli 2020-03-12 11:30 ` Wolfram Sang 2020-03-12 11:30 ` Wolfram Sang 2020-03-12 11:21 ` Wolfram Sang 2020-03-12 11:21 ` Wolfram Sang 2020-03-13 12:42 ` Wolfram Sang 2020-03-13 12:42 ` Wolfram Sang 2020-02-21 10:15 ` [RFC PATCH 0/7] i2c: of: reserve unknown and " Geert Uytterhoeven 2020-02-21 10:15 ` Geert Uytterhoeven
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAMuHMdU3WgdV0cqf0Gu=szyNch=QOEK8UbiQyxLjsf+WnS=-ZA@mail.gmail.com' \ --to=geert@linux-m68k.org \ --cc=devicetree@vger.kernel.org \ --cc=jacopo@jmondi.org \ --cc=kieran@ksquared.org.uk \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-i3c@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=luca@lucaceresoli.net \ --cc=niklas.soderlund@ragnatech.se \ --cc=vz@mleia.com \ --cc=wsa+renesas@sang-engineering.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.