From: Alex Riesen <alexander.riesen@cetitec.com> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Kieran Bingham <kieran.bingham@ideasonboard.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, "Laurent Pinchart" <laurent.pinchart@ideasonboard.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>, driverdevel <devel@driverdev.osuosl.org>, Linux Media Mailing List <linux-media@vger.kernel.org>, "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, linux-clk <linux-clk@vger.kernel.org> Subject: Re: [PATCH v2 05/10] media: adv748x: add support for HDMI audio Date: Fri, 20 Mar 2020 11:58:46 +0100 [thread overview] Message-ID: <20200320105846.GG4344@pflmari> (raw) In-Reply-To: <CAMuHMdXOAQtuxCAfb=sZKodyJWwSrf-GO-pdV3HYkOytQW4ENg@mail.gmail.com> Hi Geert, Geert Uytterhoeven, Fri, Mar 20, 2020 09:43:29 +0100: > CC linux-clk for the clock provider. > > On Thu, Mar 19, 2020 at 6:42 PM Alex Riesen <alexander.riesen@cetitec.com> wrote: > > This adds an implemention of SoC DAI driver which provides access to the > > I2S port of the device. I just noticed I don't do clk_prepare_enable anywhere. Shouldn't the clock master enable its clocks somewhere? > > diff --git a/drivers/media/i2c/adv748x/adv748x-dai.c b/drivers/media/i2c/adv748x/adv748x-dai.c > > new file mode 100644 > > index 000000000000..4775a0c7ed7f > > --- /dev/null > > +++ b/drivers/media/i2c/adv748x/adv748x-dai.c ... > > +static int adv748x_dai_startup(struct snd_pcm_substream *sub, struct snd_soc_dai *dai) > > +{ > > + struct adv748x_state *state = state_of(dai); > > + > > + if (sub->stream != SNDRV_PCM_STREAM_CAPTURE) > > + return -EINVAL; > > + return set_audio_pads_state(state, 1); > > +} For example, here, after activation of the lines succeeded? > > +static void adv748x_dai_shutdown(struct snd_pcm_substream *sub, struct snd_soc_dai *dai) > > +{ > > + struct adv748x_state *state = state_of(dai); > > + > > + set_audio_pads_state(state, 0); > > +} And clk_disable_unprepare here, before shutting down the pads? Regards, Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alex Riesen <alexander.riesen@cetitec.com> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Mark Rutland <mark.rutland@arm.com>, driverdevel <devel@driverdev.osuosl.org>, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Kieran Bingham <kieran.bingham@ideasonboard.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Mauro Carvalho Chehab <mchehab@kernel.org>, linux-clk <linux-clk@vger.kernel.org>, Linux Media Mailing List <linux-media@vger.kernel.org> Subject: Re: [PATCH v2 05/10] media: adv748x: add support for HDMI audio Date: Fri, 20 Mar 2020 11:58:46 +0100 [thread overview] Message-ID: <20200320105846.GG4344@pflmari> (raw) In-Reply-To: <CAMuHMdXOAQtuxCAfb=sZKodyJWwSrf-GO-pdV3HYkOytQW4ENg@mail.gmail.com> Hi Geert, Geert Uytterhoeven, Fri, Mar 20, 2020 09:43:29 +0100: > CC linux-clk for the clock provider. > > On Thu, Mar 19, 2020 at 6:42 PM Alex Riesen <alexander.riesen@cetitec.com> wrote: > > This adds an implemention of SoC DAI driver which provides access to the > > I2S port of the device. I just noticed I don't do clk_prepare_enable anywhere. Shouldn't the clock master enable its clocks somewhere? > > diff --git a/drivers/media/i2c/adv748x/adv748x-dai.c b/drivers/media/i2c/adv748x/adv748x-dai.c > > new file mode 100644 > > index 000000000000..4775a0c7ed7f > > --- /dev/null > > +++ b/drivers/media/i2c/adv748x/adv748x-dai.c ... > > +static int adv748x_dai_startup(struct snd_pcm_substream *sub, struct snd_soc_dai *dai) > > +{ > > + struct adv748x_state *state = state_of(dai); > > + > > + if (sub->stream != SNDRV_PCM_STREAM_CAPTURE) > > + return -EINVAL; > > + return set_audio_pads_state(state, 1); > > +} For example, here, after activation of the lines succeeded? > > +static void adv748x_dai_shutdown(struct snd_pcm_substream *sub, struct snd_soc_dai *dai) > > +{ > > + struct adv748x_state *state = state_of(dai); > > + > > + set_audio_pads_state(state, 0); > > +} And clk_disable_unprepare here, before shutting down the pads? Regards, Alex _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-03-20 10:59 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-19 17:41 [PATCH v2 00/10] media: adv748x: add support for HDMI audio Alex Riesen 2020-03-19 17:41 ` Alex Riesen 2020-03-19 17:41 ` [PATCH v2 01/10] media: adv748x: fix end-of-line terminators in diagnostic statements Alex Riesen 2020-03-19 17:41 ` Alex Riesen 2020-03-19 18:03 ` Laurent Pinchart 2020-03-19 18:03 ` Laurent Pinchart 2020-03-19 17:41 ` [PATCH v2 02/10] media: adv748x: include everything adv748x.h needs into the file Alex Riesen 2020-03-19 17:41 ` Alex Riesen 2020-03-19 17:48 ` Laurent Pinchart 2020-03-19 17:48 ` Laurent Pinchart 2020-03-20 8:23 ` Alex Riesen 2020-03-20 8:23 ` Alex Riesen 2020-03-19 17:41 ` [PATCH v2 03/10] media: adv748x: reduce amount of code for bitwise modifications of device registers Alex Riesen 2020-03-19 17:41 ` Alex Riesen 2020-03-19 18:06 ` Laurent Pinchart 2020-03-19 18:06 ` Laurent Pinchart 2020-03-20 9:08 ` Alex Riesen 2020-03-20 9:08 ` Alex Riesen 2020-03-19 17:41 ` [PATCH v2 04/10] media: adv748x: add definitions for audio output related registers Alex Riesen 2020-03-19 17:41 ` Alex Riesen 2020-03-19 17:42 ` [PATCH v2 05/10] media: adv748x: add support for HDMI audio Alex Riesen 2020-03-19 17:42 ` Alex Riesen 2020-03-20 8:43 ` Geert Uytterhoeven 2020-03-20 8:43 ` Geert Uytterhoeven 2020-03-20 8:57 ` Alex Riesen 2020-03-20 8:57 ` Alex Riesen 2020-03-20 9:10 ` Geert Uytterhoeven 2020-03-20 9:10 ` Geert Uytterhoeven 2020-03-20 10:58 ` Alex Riesen [this message] 2020-03-20 10:58 ` Alex Riesen 2020-03-20 11:05 ` Geert Uytterhoeven 2020-03-20 11:05 ` Geert Uytterhoeven 2020-03-20 11:11 ` Alex Riesen 2020-03-20 11:11 ` Alex Riesen 2020-03-19 17:42 ` [PATCH v2 06/10] media: adv748x: only activate DAI if it is described in device tree Alex Riesen 2020-03-19 17:42 ` Alex Riesen 2020-03-19 17:42 ` [PATCH v2 07/10] dt-bindings: adv748x: add information about serial audio interface (I2S/TDM) Alex Riesen 2020-03-19 17:42 ` Alex Riesen 2020-03-19 18:01 ` Laurent Pinchart 2020-03-19 18:01 ` Laurent Pinchart 2020-03-20 8:44 ` Alex Riesen 2020-03-20 8:44 ` Alex Riesen 2020-03-20 8:48 ` Geert Uytterhoeven 2020-03-20 8:48 ` Geert Uytterhoeven 2020-03-20 9:03 ` Alex Riesen 2020-03-20 9:03 ` Alex Riesen 2020-03-20 9:15 ` Geert Uytterhoeven 2020-03-20 9:15 ` Geert Uytterhoeven 2020-03-20 9:18 ` Alex Riesen 2020-03-20 9:18 ` Alex Riesen 2020-03-20 9:59 ` Laurent Pinchart 2020-03-20 9:59 ` Laurent Pinchart 2020-03-20 16:15 ` Alex Riesen 2020-03-20 16:15 ` Alex Riesen 2020-03-19 17:42 ` [PATCH v2 08/10] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC Alex Riesen 2020-03-19 17:42 ` Alex Riesen 2020-03-23 0:12 ` Kuninori Morimoto 2020-03-23 0:12 ` Kuninori Morimoto 2020-03-23 7:35 ` Alex Riesen 2020-03-23 7:35 ` Alex Riesen 2020-03-19 17:42 ` [PATCH v2 09/10] media: adv748x: add support for log_status ioctl Alex Riesen 2020-03-19 17:42 ` Alex Riesen 2020-03-19 17:43 ` [PATCH v2 10/10] media: adv748x: allow the HDMI sub-device to accept EDID Alex Riesen 2020-03-19 17:43 ` Alex Riesen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200320105846.GG4344@pflmari \ --to=alexander.riesen@cetitec.com \ --cc=devel@driverdev.osuosl.org \ --cc=devicetree@vger.kernel.org \ --cc=geert@linux-m68k.org \ --cc=hverkuil-cisco@xs4all.nl \ --cc=kieran.bingham@ideasonboard.com \ --cc=kuninori.morimoto.gx@renesas.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mchehab@kernel.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.