From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Cc: Sakari Ailus <sakari.ailus@linux.intel.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, Geert Uytterhoeven <geert+renesas@glider.be>, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lad Prabhakar <prabhakar.csengg@gmail.com> Subject: Re: [PATCH v5 1/5] media: dt-bindings: media: i2c: Deprecate usage of the clock-frequency property Date: Mon, 6 Apr 2020 20:30:02 +0300 [thread overview] Message-ID: <20200406173002.GC16885@pendragon.ideasonboard.com> (raw) In-Reply-To: <1586191361-16598-2-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> Hi Prabhakar, Thank you for the patch. On Mon, Apr 06, 2020 at 05:42:37PM +0100, Lad Prabhakar wrote: > OV5645 sensor supports input clock frequency ranging from 6MHz to 27MHz > but the driver strictly expects this to be 24MHz (with tolerance of 1%) > with this restrictions let the driver enforce the clock frequency Maybe s/with/With/ ? > internally to 24MHz rather then being passed as dt-property. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > Documentation/devicetree/bindings/media/i2c/ov5645.txt | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov5645.txt b/Documentation/devicetree/bindings/media/i2c/ov5645.txt > index 72ad992f77be..a55bb728ea48 100644 > --- a/Documentation/devicetree/bindings/media/i2c/ov5645.txt > +++ b/Documentation/devicetree/bindings/media/i2c/ov5645.txt > @@ -8,7 +8,6 @@ Required Properties: > - compatible: Value should be "ovti,ov5645". > - clocks: Reference to the xclk clock. > - clock-names: Should be "xclk". > -- clock-frequency: Frequency of the xclk clock. > - enable-gpios: Chip enable GPIO. Polarity is GPIO_ACTIVE_HIGH. This corresponds > to the hardware pin PWDNB which is physically active low. > - reset-gpios: Chip reset GPIO. Polarity is GPIO_ACTIVE_LOW. This corresponds to > @@ -37,7 +36,6 @@ Example: > > clocks = <&clks 200>; > clock-names = "xclk"; > - clock-frequency = <24000000>; > > vdddo-supply = <&camera_dovdd_1v8>; > vdda-supply = <&camera_avdd_2v8>; -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, Pengutronix Kernel Team <kernel@pengutronix.de>, Geert Uytterhoeven <geert+renesas@glider.be>, Fabio Estevam <festevam@gmail.com>, Sascha Hauer <s.hauer@pengutronix.de>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, linux-kernel@vger.kernel.org, Lad Prabhakar <prabhakar.csengg@gmail.com>, Rob Herring <robh+dt@kernel.org>, NXP Linux Team <linux-imx@nxp.com>, Sakari Ailus <sakari.ailus@linux.intel.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Shawn Guo <shawnguo@kernel.org>, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Subject: Re: [PATCH v5 1/5] media: dt-bindings: media: i2c: Deprecate usage of the clock-frequency property Date: Mon, 6 Apr 2020 20:30:02 +0300 [thread overview] Message-ID: <20200406173002.GC16885@pendragon.ideasonboard.com> (raw) In-Reply-To: <1586191361-16598-2-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> Hi Prabhakar, Thank you for the patch. On Mon, Apr 06, 2020 at 05:42:37PM +0100, Lad Prabhakar wrote: > OV5645 sensor supports input clock frequency ranging from 6MHz to 27MHz > but the driver strictly expects this to be 24MHz (with tolerance of 1%) > with this restrictions let the driver enforce the clock frequency Maybe s/with/With/ ? > internally to 24MHz rather then being passed as dt-property. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > Documentation/devicetree/bindings/media/i2c/ov5645.txt | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov5645.txt b/Documentation/devicetree/bindings/media/i2c/ov5645.txt > index 72ad992f77be..a55bb728ea48 100644 > --- a/Documentation/devicetree/bindings/media/i2c/ov5645.txt > +++ b/Documentation/devicetree/bindings/media/i2c/ov5645.txt > @@ -8,7 +8,6 @@ Required Properties: > - compatible: Value should be "ovti,ov5645". > - clocks: Reference to the xclk clock. > - clock-names: Should be "xclk". > -- clock-frequency: Frequency of the xclk clock. > - enable-gpios: Chip enable GPIO. Polarity is GPIO_ACTIVE_HIGH. This corresponds > to the hardware pin PWDNB which is physically active low. > - reset-gpios: Chip reset GPIO. Polarity is GPIO_ACTIVE_LOW. This corresponds to > @@ -37,7 +36,6 @@ Example: > > clocks = <&clks 200>; > clock-names = "xclk"; > - clock-frequency = <24000000>; > > vdddo-supply = <&camera_dovdd_1v8>; > vdda-supply = <&camera_avdd_2v8>; -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-06 17:30 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-06 16:42 [PATCH v5 0/5] ov5645: Deprecate usage of the clock-frequency Lad Prabhakar 2020-04-06 16:42 ` Lad Prabhakar 2020-04-06 16:42 ` [PATCH v5 1/5] media: dt-bindings: media: i2c: Deprecate usage of the clock-frequency property Lad Prabhakar 2020-04-06 16:42 ` Lad Prabhakar 2020-04-06 17:30 ` Laurent Pinchart [this message] 2020-04-06 17:30 ` Laurent Pinchart 2020-04-07 7:35 ` Lad, Prabhakar 2020-04-07 7:35 ` Lad, Prabhakar 2020-04-07 7:14 ` Geert Uytterhoeven 2020-04-07 7:14 ` Geert Uytterhoeven 2020-04-14 13:55 ` Rob Herring 2020-04-14 13:55 ` Rob Herring 2020-04-06 16:42 ` [PATCH v5 2/5] media: i2c: ov5645: Drop reading clock-frequency dt-property Lad Prabhakar 2020-04-06 16:42 ` Lad Prabhakar 2020-04-06 16:51 ` Sakari Ailus 2020-04-06 16:51 ` Sakari Ailus 2020-04-06 17:11 ` Lad, Prabhakar 2020-04-06 17:11 ` Lad, Prabhakar 2020-04-06 17:32 ` Laurent Pinchart 2020-04-06 17:32 ` Laurent Pinchart 2020-04-07 6:22 ` Sakari Ailus 2020-04-07 6:22 ` Sakari Ailus 2020-04-07 12:21 ` Laurent Pinchart 2020-04-07 12:21 ` Laurent Pinchart 2020-04-07 15:14 ` Sakari Ailus 2020-04-07 15:14 ` Sakari Ailus 2020-04-14 20:55 ` Laurent Pinchart 2020-04-14 20:55 ` Laurent Pinchart 2020-04-14 20:56 ` Laurent Pinchart 2020-04-14 20:56 ` Laurent Pinchart 2020-04-15 8:19 ` Maxime Ripard 2020-04-15 8:19 ` Maxime Ripard 2020-04-15 16:27 ` Sakari Ailus 2020-04-15 16:27 ` Sakari Ailus 2020-04-17 2:09 ` Laurent Pinchart 2020-04-17 2:09 ` Laurent Pinchart 2020-04-06 17:34 ` Laurent Pinchart 2020-04-06 17:34 ` Laurent Pinchart 2020-04-07 7:36 ` Lad, Prabhakar 2020-04-07 7:36 ` Lad, Prabhakar 2020-04-07 7:16 ` Geert Uytterhoeven 2020-04-07 7:16 ` Geert Uytterhoeven 2020-04-07 7:40 ` Lad, Prabhakar 2020-04-07 7:40 ` Lad, Prabhakar 2020-04-07 12:18 ` Laurent Pinchart 2020-04-07 12:18 ` Laurent Pinchart 2020-04-06 16:42 ` [PATCH v5 3/5] media: i2c: ov5645: Turn probe error into warning for xvclk frequency mismatch Lad Prabhakar 2020-04-06 16:42 ` Lad Prabhakar 2020-04-06 17:35 ` Laurent Pinchart 2020-04-06 17:35 ` Laurent Pinchart 2020-04-07 7:19 ` Geert Uytterhoeven 2020-04-07 7:19 ` Geert Uytterhoeven 2020-04-07 7:43 ` Lad, Prabhakar 2020-04-07 7:43 ` Lad, Prabhakar 2020-04-06 16:42 ` [PATCH v5 4/5] ARM: dts: imx6qdl-wandboard: Drop clock-frequency property from ov5645 node Lad Prabhakar 2020-04-06 16:42 ` Lad Prabhakar 2020-04-06 17:36 ` Laurent Pinchart 2020-04-06 17:36 ` Laurent Pinchart 2020-04-06 16:42 ` [PATCH v5 5/5] media: dt-bindings: media: i2c: convert ov5645 bindings to json-schema Lad Prabhakar 2020-04-06 16:42 ` Lad Prabhakar 2020-04-06 17:43 ` Laurent Pinchart 2020-04-06 17:43 ` Laurent Pinchart 2020-04-07 7:46 ` Lad, Prabhakar 2020-04-07 7:46 ` Lad, Prabhakar 2020-04-15 14:43 ` Rob Herring 2020-04-15 14:43 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200406173002.GC16885@pendragon.ideasonboard.com \ --to=laurent.pinchart@ideasonboard.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=geert+renesas@glider.be \ --cc=kernel@pengutronix.de \ --cc=kieran.bingham+renesas@ideasonboard.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mchehab@kernel.org \ --cc=prabhakar.csengg@gmail.com \ --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=sakari.ailus@linux.intel.com \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.