From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com> Cc: Geert Uytterhoeven <geert@linux-m68k.org>, Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>, Sakari Ailus <sakari.ailus@linux.intel.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, Geert Uytterhoeven <geert+renesas@glider.be>, Linux Media Mailing List <linux-media@vger.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v5 2/5] media: i2c: ov5645: Drop reading clock-frequency dt-property Date: Tue, 7 Apr 2020 15:18:18 +0300 [thread overview] Message-ID: <20200407121818.GC4751@pendragon.ideasonboard.com> (raw) In-Reply-To: <CA+V-a8tHb1OomhfdsWV5duyuypTKC_EWT4o=mMjWVsxu+aOnBQ@mail.gmail.com> Hi Prabhakar, On Tue, Apr 07, 2020 at 08:40:06AM +0100, Lad, Prabhakar wrote: > On Tue, Apr 7, 2020 at 8:17 AM Geert Uytterhoeven wrote: > > On Mon, Apr 6, 2020 at 6:43 PM Lad Prabhakar wrote: > > > Modes in the driver are based on xvclk frequency fixed to 24MHz, but where > > > as the OV5645 sensor can support the xvclk frequency ranging from 6MHz to > > > 24MHz. So instead making clock-frequency as dt-property just let the > > > driver enforce the required clock frequency. > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > However, still wondering about the "xvclk" name above and in the definition > > below. Is this the naming from the datasheet? > > The DT bindings nor the driver use the "xvclk" naming. > > > xvclk naming is from the datasheet, although the 0v5645 datasheet on > publicly available I have referred [1]/[2]. > If I am not wrong all the ov sensors have the same naming convention as xvclk. > > [1] https://cdn.sparkfun.com/datasheets/Sensors/LightImaging/OV5640_datasheet.pdf > [2] https://www.ovt.com/download/sensorpdf/126/OmniVision_OV5645.pdf The clock in DT should really have been named xvclk, but it's too late to change that. We can follow one of two approaches, either naming everything xclk, and naming everything but the DT property xvclk. Both have pros and cons, feel free to pick your preferred option, but in any case a comment to explain the issue would be useful. > > > --- a/drivers/media/i2c/ov5645.c > > > +++ b/drivers/media/i2c/ov5645.c > > > @@ -61,6 +61,8 @@ > > > #define OV5645_SDE_SAT_U 0x5583 > > > #define OV5645_SDE_SAT_V 0x5584 > > > > > > +#define OV5645_XVCLK_FREQ 24000000 > > > + -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com> Cc: Mark Rutland <mark.rutland@arm.com>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Pengutronix Kernel Team <kernel@pengutronix.de>, Geert Uytterhoeven <geert+renesas@glider.be>, Fabio Estevam <festevam@gmail.com>, Sascha Hauer <s.hauer@pengutronix.de>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, Geert Uytterhoeven <geert@linux-m68k.org>, NXP Linux Team <linux-imx@nxp.com>, Sakari Ailus <sakari.ailus@linux.intel.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org>, Linux Media Mailing List <linux-media@vger.kernel.org> Subject: Re: [PATCH v5 2/5] media: i2c: ov5645: Drop reading clock-frequency dt-property Date: Tue, 7 Apr 2020 15:18:18 +0300 [thread overview] Message-ID: <20200407121818.GC4751@pendragon.ideasonboard.com> (raw) In-Reply-To: <CA+V-a8tHb1OomhfdsWV5duyuypTKC_EWT4o=mMjWVsxu+aOnBQ@mail.gmail.com> Hi Prabhakar, On Tue, Apr 07, 2020 at 08:40:06AM +0100, Lad, Prabhakar wrote: > On Tue, Apr 7, 2020 at 8:17 AM Geert Uytterhoeven wrote: > > On Mon, Apr 6, 2020 at 6:43 PM Lad Prabhakar wrote: > > > Modes in the driver are based on xvclk frequency fixed to 24MHz, but where > > > as the OV5645 sensor can support the xvclk frequency ranging from 6MHz to > > > 24MHz. So instead making clock-frequency as dt-property just let the > > > driver enforce the required clock frequency. > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > However, still wondering about the "xvclk" name above and in the definition > > below. Is this the naming from the datasheet? > > The DT bindings nor the driver use the "xvclk" naming. > > > xvclk naming is from the datasheet, although the 0v5645 datasheet on > publicly available I have referred [1]/[2]. > If I am not wrong all the ov sensors have the same naming convention as xvclk. > > [1] https://cdn.sparkfun.com/datasheets/Sensors/LightImaging/OV5640_datasheet.pdf > [2] https://www.ovt.com/download/sensorpdf/126/OmniVision_OV5645.pdf The clock in DT should really have been named xvclk, but it's too late to change that. We can follow one of two approaches, either naming everything xclk, and naming everything but the DT property xvclk. Both have pros and cons, feel free to pick your preferred option, but in any case a comment to explain the issue would be useful. > > > --- a/drivers/media/i2c/ov5645.c > > > +++ b/drivers/media/i2c/ov5645.c > > > @@ -61,6 +61,8 @@ > > > #define OV5645_SDE_SAT_U 0x5583 > > > #define OV5645_SDE_SAT_V 0x5584 > > > > > > +#define OV5645_XVCLK_FREQ 24000000 > > > + -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-07 12:18 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-06 16:42 [PATCH v5 0/5] ov5645: Deprecate usage of the clock-frequency Lad Prabhakar 2020-04-06 16:42 ` Lad Prabhakar 2020-04-06 16:42 ` [PATCH v5 1/5] media: dt-bindings: media: i2c: Deprecate usage of the clock-frequency property Lad Prabhakar 2020-04-06 16:42 ` Lad Prabhakar 2020-04-06 17:30 ` Laurent Pinchart 2020-04-06 17:30 ` Laurent Pinchart 2020-04-07 7:35 ` Lad, Prabhakar 2020-04-07 7:35 ` Lad, Prabhakar 2020-04-07 7:14 ` Geert Uytterhoeven 2020-04-07 7:14 ` Geert Uytterhoeven 2020-04-14 13:55 ` Rob Herring 2020-04-14 13:55 ` Rob Herring 2020-04-06 16:42 ` [PATCH v5 2/5] media: i2c: ov5645: Drop reading clock-frequency dt-property Lad Prabhakar 2020-04-06 16:42 ` Lad Prabhakar 2020-04-06 16:51 ` Sakari Ailus 2020-04-06 16:51 ` Sakari Ailus 2020-04-06 17:11 ` Lad, Prabhakar 2020-04-06 17:11 ` Lad, Prabhakar 2020-04-06 17:32 ` Laurent Pinchart 2020-04-06 17:32 ` Laurent Pinchart 2020-04-07 6:22 ` Sakari Ailus 2020-04-07 6:22 ` Sakari Ailus 2020-04-07 12:21 ` Laurent Pinchart 2020-04-07 12:21 ` Laurent Pinchart 2020-04-07 15:14 ` Sakari Ailus 2020-04-07 15:14 ` Sakari Ailus 2020-04-14 20:55 ` Laurent Pinchart 2020-04-14 20:55 ` Laurent Pinchart 2020-04-14 20:56 ` Laurent Pinchart 2020-04-14 20:56 ` Laurent Pinchart 2020-04-15 8:19 ` Maxime Ripard 2020-04-15 8:19 ` Maxime Ripard 2020-04-15 16:27 ` Sakari Ailus 2020-04-15 16:27 ` Sakari Ailus 2020-04-17 2:09 ` Laurent Pinchart 2020-04-17 2:09 ` Laurent Pinchart 2020-04-06 17:34 ` Laurent Pinchart 2020-04-06 17:34 ` Laurent Pinchart 2020-04-07 7:36 ` Lad, Prabhakar 2020-04-07 7:36 ` Lad, Prabhakar 2020-04-07 7:16 ` Geert Uytterhoeven 2020-04-07 7:16 ` Geert Uytterhoeven 2020-04-07 7:40 ` Lad, Prabhakar 2020-04-07 7:40 ` Lad, Prabhakar 2020-04-07 12:18 ` Laurent Pinchart [this message] 2020-04-07 12:18 ` Laurent Pinchart 2020-04-06 16:42 ` [PATCH v5 3/5] media: i2c: ov5645: Turn probe error into warning for xvclk frequency mismatch Lad Prabhakar 2020-04-06 16:42 ` Lad Prabhakar 2020-04-06 17:35 ` Laurent Pinchart 2020-04-06 17:35 ` Laurent Pinchart 2020-04-07 7:19 ` Geert Uytterhoeven 2020-04-07 7:19 ` Geert Uytterhoeven 2020-04-07 7:43 ` Lad, Prabhakar 2020-04-07 7:43 ` Lad, Prabhakar 2020-04-06 16:42 ` [PATCH v5 4/5] ARM: dts: imx6qdl-wandboard: Drop clock-frequency property from ov5645 node Lad Prabhakar 2020-04-06 16:42 ` Lad Prabhakar 2020-04-06 17:36 ` Laurent Pinchart 2020-04-06 17:36 ` Laurent Pinchart 2020-04-06 16:42 ` [PATCH v5 5/5] media: dt-bindings: media: i2c: convert ov5645 bindings to json-schema Lad Prabhakar 2020-04-06 16:42 ` Lad Prabhakar 2020-04-06 17:43 ` Laurent Pinchart 2020-04-06 17:43 ` Laurent Pinchart 2020-04-07 7:46 ` Lad, Prabhakar 2020-04-07 7:46 ` Lad, Prabhakar 2020-04-15 14:43 ` Rob Herring 2020-04-15 14:43 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200407121818.GC4751@pendragon.ideasonboard.com \ --to=laurent.pinchart@ideasonboard.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=geert+renesas@glider.be \ --cc=geert@linux-m68k.org \ --cc=kernel@pengutronix.de \ --cc=kieran.bingham+renesas@ideasonboard.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mchehab@kernel.org \ --cc=prabhakar.csengg@gmail.com \ --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=sakari.ailus@linux.intel.com \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.