All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Jordan <daniel.m.jordan@oracle.com>
To: Michel Lespinasse <walken@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-mm <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Laurent Dufour <ldufour@linux.ibm.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Matthew Wilcox <willy@infradead.org>,
	Liam Howlett <Liam.Howlett@oracle.com>,
	Jerome Glisse <jglisse@redhat.com>,
	Davidlohr Bueso <dave@stgolabs.net>,
	David Rientjes <rientjes@google.com>,
	Hugh Dickins <hughd@google.com>, Ying Han <yinghan@google.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Markus Elfring <Markus.Elfring@web.de>
Subject: Re: [PATCH v3 05/10] mmap locking API: convert mmap_sem call sites missed by coccinelle
Date: Mon, 13 Apr 2020 13:06:18 -0400	[thread overview]
Message-ID: <20200413170618.3luttzyzwjsd5y26@ca-dmjordan1.us.oracle.com> (raw)
In-Reply-To: <20200327225102.25061-6-walken@google.com>

On Fri, Mar 27, 2020 at 03:50:57PM -0700, Michel Lespinasse wrote:
> Convert the last few remaining mmap_sem rwsem calls to use the new
> mmap locking API. These were missed by coccinelle for some reason
> (I think coccinelle does not support some of the preprocessor
> constructs in these files ?)

Adding the wrappers for instrumentation makes sense to me.  For patches 1-5,
you can add
Reviewed-by: Daniel Jordan <daniel.m.jordan@oracle.com>

I'll wait for the next version to review the rest.

  parent reply	other threads:[~2020-04-13 17:06 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-27 22:50 [PATCH v3 00/10] Add a new mmap locking API wrapping mmap_sem calls Michel Lespinasse
2020-03-27 22:50 ` Michel Lespinasse
2020-03-27 22:50 ` [PATCH v3 01/10] mmap locking API: initial implementation as rwsem wrappers Michel Lespinasse
2020-03-27 22:50   ` Michel Lespinasse
2020-03-28  8:57   ` [PATCH v3 01/10] mmap locking API: initial implementation as rwsem wrappers (Michel Lespinasse) SeongJae Park
2020-03-27 22:50 ` [PATCH v3 02/10] MMU notifier: use the new mmap locking API Michel Lespinasse
2020-03-27 22:50   ` Michel Lespinasse
2020-03-27 22:50 ` [PATCH v3 03/10] DMA reservations: " Michel Lespinasse
2020-03-27 22:50   ` Michel Lespinasse
2020-03-27 22:50 ` [PATCH v3 04/10] mmap locking API: use coccinelle to convert mmap_sem rwsem call sites Michel Lespinasse
2020-03-27 22:50   ` Michel Lespinasse
2020-03-27 22:50 ` [PATCH v3 05/10] mmap locking API: convert mmap_sem call sites missed by coccinelle Michel Lespinasse
2020-03-27 22:50   ` Michel Lespinasse
2020-03-28  7:36   ` Markus Elfring
2020-03-28  7:36     ` [Cocci] " Markus Elfring
2020-03-28  7:47     ` Michel Lespinasse
2020-03-28  7:47       ` [Cocci] " Michel Lespinasse
2020-03-28  7:47       ` Michel Lespinasse
2020-03-28  8:39       ` [v3 " Markus Elfring
2020-03-28  8:39         ` [Cocci] " Markus Elfring
2020-03-28  8:53         ` Michel Lespinasse
2020-03-28  8:53           ` [Cocci] " Michel Lespinasse
2020-03-28  8:53           ` Michel Lespinasse
2020-03-28  9:01           ` Markus Elfring
2020-03-28  9:01             ` [Cocci] " Markus Elfring
2020-03-28 13:20           ` [v3 05/10] mmap locking API: Checking the Coccinelle software Markus Elfring
2020-03-28 13:20             ` [Cocci] " Markus Elfring
2020-03-28 13:42             ` Julia Lawall
2020-03-28 13:42               ` Julia Lawall
2020-03-28 13:42               ` Julia Lawall
2020-03-28 13:52               ` Markus Elfring
2020-03-28 13:52                 ` Markus Elfring
2020-03-28 13:53             ` Julia Lawall
2020-03-28 13:53               ` Julia Lawall
2020-03-28 13:53               ` Julia Lawall
2020-03-28 14:00             ` Julia Lawall
2020-03-28 14:00               ` Julia Lawall
2020-03-28 14:00               ` Julia Lawall
2020-03-28 14:16               ` Markus Elfring
2020-03-28 14:16                 ` Markus Elfring
2020-03-30  6:10           ` [v3 05/10] mmap locking API: Improving " Markus Elfring
2020-03-30  6:10             ` [Cocci] " Markus Elfring
2020-03-30  8:47             ` Julia Lawall
2020-03-30  8:47               ` Julia Lawall
2020-03-30  8:47               ` Julia Lawall
2020-03-30 10:15               ` Markus Elfring
2020-03-30 10:15                 ` Markus Elfring
2020-03-30 10:20                 ` Julia Lawall
2020-03-30 10:20                   ` Julia Lawall
2020-03-30 10:20                   ` Julia Lawall
2020-03-30 10:42                   ` Markus Elfring
2020-03-30 10:42                     ` Markus Elfring
2020-04-13 17:06   ` Daniel Jordan [this message]
2020-03-27 22:50 ` [PATCH v3 06/10] mmap locking API: convert nested write lock sites Michel Lespinasse
2020-03-27 22:50   ` Michel Lespinasse
2020-04-01 13:42   ` Peter Zijlstra
2020-04-06 15:35     ` Michel Lespinasse
2020-04-06 15:35       ` Michel Lespinasse
2020-04-06 15:58       ` Peter Zijlstra
2020-03-27 22:50 ` [PATCH v3 07/10] mmap locking API: add mmap_read_release() and mmap_read_unlock_non_owner() Michel Lespinasse
2020-03-27 22:50   ` Michel Lespinasse
2020-04-01 13:46   ` Peter Zijlstra
2020-04-06 15:39     ` Michel Lespinasse
2020-04-06 15:39       ` Michel Lespinasse
2020-03-27 22:51 ` [PATCH v3 08/10] mmap locking API: add MMAP_LOCK_INITIALIZER Michel Lespinasse
2020-03-27 22:51   ` Michel Lespinasse
2020-03-27 22:51 ` [PATCH v3 09/10] mmap locking API: use lockdep_assert_held Michel Lespinasse
2020-03-27 22:51   ` Michel Lespinasse
2020-03-27 22:51 ` [PATCH v3 10/10] mmap locking API: rename mmap_sem to mmap_lock Michel Lespinasse
2020-03-27 22:51   ` Michel Lespinasse
2020-04-01 13:48   ` Peter Zijlstra
2020-04-06 15:49     ` Michel Lespinasse
2020-04-06 15:49       ` Michel Lespinasse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200413170618.3luttzyzwjsd5y26@ca-dmjordan1.us.oracle.com \
    --to=daniel.m.jordan@oracle.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=Markus.Elfring@web.de \
    --cc=akpm@linux-foundation.org \
    --cc=dave@stgolabs.net \
    --cc=hughd@google.com \
    --cc=jgg@ziepe.ca \
    --cc=jglisse@redhat.com \
    --cc=ldufour@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=peterz@infradead.org \
    --cc=rientjes@google.com \
    --cc=vbabka@suse.cz \
    --cc=walken@google.com \
    --cc=willy@infradead.org \
    --cc=yinghan@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.