From: Michel Lespinasse <walken@google.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Laurent Dufour <ldufour@linux.ibm.com>,
Vlastimil Babka <vbabka@suse.cz>,
Matthew Wilcox <willy@infradead.org>,
Liam Howlett <Liam.Howlett@oracle.com>,
Jerome Glisse <jglisse@redhat.com>,
Davidlohr Bueso <dave@stgolabs.net>,
David Rientjes <rientjes@google.com>,
Hugh Dickins <hughd@google.com>, Ying Han <yinghan@google.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Markus Elfring <Markus.Elfring@web.de>
Subject: Re: [PATCH v3 07/10] mmap locking API: add mmap_read_release() and mmap_read_unlock_non_owner()
Date: Mon, 6 Apr 2020 08:39:53 -0700 [thread overview]
Message-ID: <CANN689FRvuZFGUKT+4Xd32JvHoH+OkMiB=OJzoGh+b3YtCwq3g@mail.gmail.com> (raw)
In-Reply-To: <20200401134633.GS20696@hirez.programming.kicks-ass.net>
On Wed, Apr 1, 2020 at 6:46 AM Peter Zijlstra <peterz@infradead.org> wrote:
> On Fri, Mar 27, 2020 at 03:50:59PM -0700, Michel Lespinasse wrote:
> > Add a couple APIs to allow splitting mmap_read_unlock() into two calls:
> > - mmap_read_release(), called by the task that had taken the mmap lock;
> > - mmap_read_unlock_non_owner(), called from a work queue.
> >
> > These apis are used by kernel/bpf/stackmap.c only.
>
> That code is an absolute abomination and should never have gotten
> merged.
I have to say, it's causing me some grief too :/
> That said; I would prefer a mmap_read_trylock_nonowner() over
> mmap_read_release() existing.
It only addresses part of the issue, but I suppose I could do that. Is
this something I could append to the end of this series, or do I need
to prepare a v4 for such changes ?
next prev parent reply other threads:[~2020-04-06 15:40 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 22:50 [PATCH v3 00/10] Add a new mmap locking API wrapping mmap_sem calls Michel Lespinasse
2020-03-27 22:50 ` Michel Lespinasse
2020-03-27 22:50 ` [PATCH v3 01/10] mmap locking API: initial implementation as rwsem wrappers Michel Lespinasse
2020-03-27 22:50 ` Michel Lespinasse
2020-03-28 8:57 ` [PATCH v3 01/10] mmap locking API: initial implementation as rwsem wrappers (Michel Lespinasse) SeongJae Park
2020-03-27 22:50 ` [PATCH v3 02/10] MMU notifier: use the new mmap locking API Michel Lespinasse
2020-03-27 22:50 ` Michel Lespinasse
2020-03-27 22:50 ` [PATCH v3 03/10] DMA reservations: " Michel Lespinasse
2020-03-27 22:50 ` Michel Lespinasse
2020-03-27 22:50 ` [PATCH v3 04/10] mmap locking API: use coccinelle to convert mmap_sem rwsem call sites Michel Lespinasse
2020-03-27 22:50 ` Michel Lespinasse
2020-03-27 22:50 ` [PATCH v3 05/10] mmap locking API: convert mmap_sem call sites missed by coccinelle Michel Lespinasse
2020-03-27 22:50 ` Michel Lespinasse
2020-03-28 7:36 ` Markus Elfring
2020-03-28 7:36 ` [Cocci] " Markus Elfring
2020-03-28 7:47 ` Michel Lespinasse
2020-03-28 7:47 ` [Cocci] " Michel Lespinasse
2020-03-28 7:47 ` Michel Lespinasse
2020-03-28 8:39 ` [v3 " Markus Elfring
2020-03-28 8:39 ` [Cocci] " Markus Elfring
2020-03-28 8:53 ` Michel Lespinasse
2020-03-28 8:53 ` [Cocci] " Michel Lespinasse
2020-03-28 8:53 ` Michel Lespinasse
2020-03-28 9:01 ` Markus Elfring
2020-03-28 9:01 ` [Cocci] " Markus Elfring
2020-03-28 13:20 ` [v3 05/10] mmap locking API: Checking the Coccinelle software Markus Elfring
2020-03-28 13:20 ` [Cocci] " Markus Elfring
2020-03-28 13:42 ` Julia Lawall
2020-03-28 13:42 ` Julia Lawall
2020-03-28 13:42 ` Julia Lawall
2020-03-28 13:52 ` Markus Elfring
2020-03-28 13:52 ` Markus Elfring
2020-03-28 13:53 ` Julia Lawall
2020-03-28 13:53 ` Julia Lawall
2020-03-28 13:53 ` Julia Lawall
2020-03-28 14:00 ` Julia Lawall
2020-03-28 14:00 ` Julia Lawall
2020-03-28 14:00 ` Julia Lawall
2020-03-28 14:16 ` Markus Elfring
2020-03-28 14:16 ` Markus Elfring
2020-03-30 6:10 ` [v3 05/10] mmap locking API: Improving " Markus Elfring
2020-03-30 6:10 ` [Cocci] " Markus Elfring
2020-03-30 8:47 ` Julia Lawall
2020-03-30 8:47 ` Julia Lawall
2020-03-30 8:47 ` Julia Lawall
2020-03-30 10:15 ` Markus Elfring
2020-03-30 10:15 ` Markus Elfring
2020-03-30 10:20 ` Julia Lawall
2020-03-30 10:20 ` Julia Lawall
2020-03-30 10:20 ` Julia Lawall
2020-03-30 10:42 ` Markus Elfring
2020-03-30 10:42 ` Markus Elfring
2020-04-13 17:06 ` [PATCH v3 05/10] mmap locking API: convert mmap_sem call sites missed by coccinelle Daniel Jordan
2020-03-27 22:50 ` [PATCH v3 06/10] mmap locking API: convert nested write lock sites Michel Lespinasse
2020-03-27 22:50 ` Michel Lespinasse
2020-04-01 13:42 ` Peter Zijlstra
2020-04-06 15:35 ` Michel Lespinasse
2020-04-06 15:35 ` Michel Lespinasse
2020-04-06 15:58 ` Peter Zijlstra
2020-03-27 22:50 ` [PATCH v3 07/10] mmap locking API: add mmap_read_release() and mmap_read_unlock_non_owner() Michel Lespinasse
2020-03-27 22:50 ` Michel Lespinasse
2020-04-01 13:46 ` Peter Zijlstra
2020-04-06 15:39 ` Michel Lespinasse [this message]
2020-04-06 15:39 ` Michel Lespinasse
2020-03-27 22:51 ` [PATCH v3 08/10] mmap locking API: add MMAP_LOCK_INITIALIZER Michel Lespinasse
2020-03-27 22:51 ` Michel Lespinasse
2020-03-27 22:51 ` [PATCH v3 09/10] mmap locking API: use lockdep_assert_held Michel Lespinasse
2020-03-27 22:51 ` Michel Lespinasse
2020-03-27 22:51 ` [PATCH v3 10/10] mmap locking API: rename mmap_sem to mmap_lock Michel Lespinasse
2020-03-27 22:51 ` Michel Lespinasse
2020-04-01 13:48 ` Peter Zijlstra
2020-04-06 15:49 ` Michel Lespinasse
2020-04-06 15:49 ` Michel Lespinasse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANN689FRvuZFGUKT+4Xd32JvHoH+OkMiB=OJzoGh+b3YtCwq3g@mail.gmail.com' \
--to=walken@google.com \
--cc=Liam.Howlett@oracle.com \
--cc=Markus.Elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=hughd@google.com \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=ldufour@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.