From: Markus Elfring <Markus.Elfring@web.de>
To: Michel Lespinasse <walken@google.com>,
Coccinelle <cocci@systeme.lip6.fr>,
linux-mm@kvack.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Laurent Dufour <ldufour@linux.ibm.com>,
Vlastimil Babka <vbabka@suse.cz>,
Matthew Wilcox <willy@infradead.org>,
Liam Howlett <Liam.Howlett@oracle.com>,
Jerome Glisse <jglisse@redhat.com>,
Davidlohr Bueso <dave@stgolabs.net>,
David Rientjes <rientjes@google.com>,
Hugh Dickins <hughd@google.com>, Ying Han <yinghan@google.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [v3 05/10] mmap locking API: Improving the Coccinelle software
Date: Mon, 30 Mar 2020 08:10:58 +0200 [thread overview]
Message-ID: <2c74e465-249d-eeb8-86fe-462b93bfe743@web.de> (raw)
In-Reply-To: <CANN689HyS0dYWZw3AeWGBvN6_2G4hRDzjMJQ_adHMh0ZkiACYg@mail.gmail.com>
>> How will corresponding software development resources evolve?
>
> I don't think I understand the question, or, actually, are you asking
> me or the coccinelle developers ?
I hope that more development challenges will be picked up.
The code from a mentioned source file can be reduced to the following
test file.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/x86/kvm/mmu/paging_tmpl.h?id=7111951b8d4973bda27ff663f2cf18b663d15b48#n122
// deleted part
static inline int FNAME(is_present_gpte)(unsigned long pte)
{
#if PTTYPE != PTTYPE_EPT
return pte & PT_PRESENT_MASK;
#else
return pte & 7;
#endif
}
// deleted part
Application of the software “Coccinelle 1.0.8-00029-ga549b9f0” (OCaml 4.10.0)
elfring@Sonne:~/Projekte/Coccinelle/Probe> spatch --parse-c paging_tmpl-excerpt1.h
…
(ONCE) CPP-MACRO: found known macro = FNAME
…
parse error
= File "paging_tmpl-excerpt1.h", line 2, column 41, charpos = 57
around = 'unsigned',
…
BAD:!!!!! static inline int FNAME(is_present_gpte)(unsigned long pte)
…
NB total files = 1; perfect = 0; pbs = 1; timeout = 0; =========> 0%
nb good = 1, nb passed = 1 =========> 10.00% passed
nb good = 1, nb bad = 8 =========> 20.00% good or passed
How would you like to improve the affected software areas?
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Michel Lespinasse <walken@google.com>,
Coccinelle <cocci@systeme.lip6.fr>,
linux-mm@kvack.org
Cc: Davidlohr Bueso <dave@stgolabs.net>,
Peter Zijlstra <peterz@infradead.org>,
Hugh Dickins <hughd@google.com>,
LKML <linux-kernel@vger.kernel.org>,
Liam Howlett <Liam.Howlett@oracle.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Matthew Wilcox <willy@infradead.org>,
Ying Han <yinghan@google.com>,
David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Laurent Dufour <ldufour@linux.ibm.com>,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [Cocci] [v3 05/10] mmap locking API: Improving the Coccinelle software
Date: Mon, 30 Mar 2020 08:10:58 +0200 [thread overview]
Message-ID: <2c74e465-249d-eeb8-86fe-462b93bfe743@web.de> (raw)
In-Reply-To: <CANN689HyS0dYWZw3AeWGBvN6_2G4hRDzjMJQ_adHMh0ZkiACYg@mail.gmail.com>
>> How will corresponding software development resources evolve?
>
> I don't think I understand the question, or, actually, are you asking
> me or the coccinelle developers ?
I hope that more development challenges will be picked up.
The code from a mentioned source file can be reduced to the following
test file.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/x86/kvm/mmu/paging_tmpl.h?id=7111951b8d4973bda27ff663f2cf18b663d15b48#n122
// deleted part
static inline int FNAME(is_present_gpte)(unsigned long pte)
{
#if PTTYPE != PTTYPE_EPT
return pte & PT_PRESENT_MASK;
#else
return pte & 7;
#endif
}
// deleted part
Application of the software “Coccinelle 1.0.8-00029-ga549b9f0” (OCaml 4.10.0)
elfring@Sonne:~/Projekte/Coccinelle/Probe> spatch --parse-c paging_tmpl-excerpt1.h
…
(ONCE) CPP-MACRO: found known macro = FNAME
…
parse error
= File "paging_tmpl-excerpt1.h", line 2, column 41, charpos = 57
around = 'unsigned',
…
BAD:!!!!! static inline int FNAME(is_present_gpte)(unsigned long pte)
…
NB total files = 1; perfect = 0; pbs = 1; timeout = 0; =========> 0%
nb good = 1, nb passed = 1 =========> 10.00% passed
nb good = 1, nb bad = 8 =========> 20.00% good or passed
How would you like to improve the affected software areas?
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2020-03-30 6:11 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 22:50 [PATCH v3 00/10] Add a new mmap locking API wrapping mmap_sem calls Michel Lespinasse
2020-03-27 22:50 ` Michel Lespinasse
2020-03-27 22:50 ` [PATCH v3 01/10] mmap locking API: initial implementation as rwsem wrappers Michel Lespinasse
2020-03-27 22:50 ` Michel Lespinasse
2020-03-28 8:57 ` [PATCH v3 01/10] mmap locking API: initial implementation as rwsem wrappers (Michel Lespinasse) SeongJae Park
2020-03-27 22:50 ` [PATCH v3 02/10] MMU notifier: use the new mmap locking API Michel Lespinasse
2020-03-27 22:50 ` Michel Lespinasse
2020-03-27 22:50 ` [PATCH v3 03/10] DMA reservations: " Michel Lespinasse
2020-03-27 22:50 ` Michel Lespinasse
2020-03-27 22:50 ` [PATCH v3 04/10] mmap locking API: use coccinelle to convert mmap_sem rwsem call sites Michel Lespinasse
2020-03-27 22:50 ` Michel Lespinasse
2020-03-27 22:50 ` [PATCH v3 05/10] mmap locking API: convert mmap_sem call sites missed by coccinelle Michel Lespinasse
2020-03-27 22:50 ` Michel Lespinasse
2020-03-28 7:36 ` Markus Elfring
2020-03-28 7:36 ` [Cocci] " Markus Elfring
2020-03-28 7:47 ` Michel Lespinasse
2020-03-28 7:47 ` [Cocci] " Michel Lespinasse
2020-03-28 7:47 ` Michel Lespinasse
2020-03-28 8:39 ` [v3 " Markus Elfring
2020-03-28 8:39 ` [Cocci] " Markus Elfring
2020-03-28 8:53 ` Michel Lespinasse
2020-03-28 8:53 ` [Cocci] " Michel Lespinasse
2020-03-28 8:53 ` Michel Lespinasse
2020-03-28 9:01 ` Markus Elfring
2020-03-28 9:01 ` [Cocci] " Markus Elfring
2020-03-28 13:20 ` [v3 05/10] mmap locking API: Checking the Coccinelle software Markus Elfring
2020-03-28 13:20 ` [Cocci] " Markus Elfring
2020-03-28 13:42 ` Julia Lawall
2020-03-28 13:42 ` Julia Lawall
2020-03-28 13:42 ` Julia Lawall
2020-03-28 13:52 ` Markus Elfring
2020-03-28 13:52 ` Markus Elfring
2020-03-28 13:53 ` Julia Lawall
2020-03-28 13:53 ` Julia Lawall
2020-03-28 13:53 ` Julia Lawall
2020-03-28 14:00 ` Julia Lawall
2020-03-28 14:00 ` Julia Lawall
2020-03-28 14:00 ` Julia Lawall
2020-03-28 14:16 ` Markus Elfring
2020-03-28 14:16 ` Markus Elfring
2020-03-30 6:10 ` Markus Elfring [this message]
2020-03-30 6:10 ` [Cocci] [v3 05/10] mmap locking API: Improving " Markus Elfring
2020-03-30 8:47 ` Julia Lawall
2020-03-30 8:47 ` Julia Lawall
2020-03-30 8:47 ` Julia Lawall
2020-03-30 10:15 ` Markus Elfring
2020-03-30 10:15 ` Markus Elfring
2020-03-30 10:20 ` Julia Lawall
2020-03-30 10:20 ` Julia Lawall
2020-03-30 10:20 ` Julia Lawall
2020-03-30 10:42 ` Markus Elfring
2020-03-30 10:42 ` Markus Elfring
2020-04-13 17:06 ` [PATCH v3 05/10] mmap locking API: convert mmap_sem call sites missed by coccinelle Daniel Jordan
2020-03-27 22:50 ` [PATCH v3 06/10] mmap locking API: convert nested write lock sites Michel Lespinasse
2020-03-27 22:50 ` Michel Lespinasse
2020-04-01 13:42 ` Peter Zijlstra
2020-04-06 15:35 ` Michel Lespinasse
2020-04-06 15:35 ` Michel Lespinasse
2020-04-06 15:58 ` Peter Zijlstra
2020-03-27 22:50 ` [PATCH v3 07/10] mmap locking API: add mmap_read_release() and mmap_read_unlock_non_owner() Michel Lespinasse
2020-03-27 22:50 ` Michel Lespinasse
2020-04-01 13:46 ` Peter Zijlstra
2020-04-06 15:39 ` Michel Lespinasse
2020-04-06 15:39 ` Michel Lespinasse
2020-03-27 22:51 ` [PATCH v3 08/10] mmap locking API: add MMAP_LOCK_INITIALIZER Michel Lespinasse
2020-03-27 22:51 ` Michel Lespinasse
2020-03-27 22:51 ` [PATCH v3 09/10] mmap locking API: use lockdep_assert_held Michel Lespinasse
2020-03-27 22:51 ` Michel Lespinasse
2020-03-27 22:51 ` [PATCH v3 10/10] mmap locking API: rename mmap_sem to mmap_lock Michel Lespinasse
2020-03-27 22:51 ` Michel Lespinasse
2020-04-01 13:48 ` Peter Zijlstra
2020-04-06 15:49 ` Michel Lespinasse
2020-04-06 15:49 ` Michel Lespinasse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c74e465-249d-eeb8-86fe-462b93bfe743@web.de \
--to=markus.elfring@web.de \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=cocci@systeme.lip6.fr \
--cc=dave@stgolabs.net \
--cc=hughd@google.com \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=ldufour@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=walken@google.com \
--cc=willy@infradead.org \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.