Re: [PATCH 10/17] mfd: vexpress-sysreg: Drop unused syscon child devices

From: Liviu Dudau <liviu.dudau@arm.com>
To: Rob Herring <robh@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Lee Jones <lee.jones@linaro.org>,
	Sebastian Reichel <sre@kernel.org>,
	Stephen Boyd <sboyd@kernel.org>, Will Deacon <will@kernel.org>,
	Kevin Brodsky <Kevin.Brodsky@arm.com>,
	linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH 10/17] mfd: vexpress-sysreg: Drop unused syscon child devices
Date: Wed, 22 Apr 2020 12:18:04 +0100	[thread overview]
Message-ID: <20200422111804.GV364558@e110455-lin.cambridge.arm.com> (raw)
In-Reply-To: <20200419170810.5738-11-robh@kernel.org>

Hi Rob,

Missing commit message?

On Sun, Apr 19, 2020 at 12:08:03PM -0500, Rob Herring wrote:
> Cc: Liviu Dudau <liviu.dudau@arm.com>
> Cc: Sudeep Holla <sudeep.holla@arm.com>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  drivers/mfd/vexpress-sysreg.c | 36 -----------------------------------
>  1 file changed, 36 deletions(-)
> 
> diff --git a/drivers/mfd/vexpress-sysreg.c b/drivers/mfd/vexpress-sysreg.c
> index 0b9cc67706c7..90a4eda2ba2b 100644
> --- a/drivers/mfd/vexpress-sysreg.c
> +++ b/drivers/mfd/vexpress-sysreg.c
> @@ -43,10 +43,6 @@
>  
>  /* The sysreg block is just a random collection of various functions... */
>  
> -static struct syscon_platform_data vexpress_sysreg_sys_id_pdata = {
> -	.label = "sys_id",
> -};
> -
>  static struct bgpio_pdata vexpress_sysreg_sys_led_pdata = {
>  	.label = "sys_led",
>  	.base = -1,
> @@ -65,24 +61,8 @@ static struct bgpio_pdata vexpress_sysreg_sys_flash_pdata = {
>  	.ngpio = 1,
>  };
>  
> -static struct syscon_platform_data vexpress_sysreg_sys_misc_pdata = {
> -	.label = "sys_misc",
> -};
> -
> -static struct syscon_platform_data vexpress_sysreg_sys_procid_pdata = {
> -	.label = "sys_procid",
> -};
> -
>  static struct mfd_cell vexpress_sysreg_cells[] = {
>  	{
> -		.name = "syscon",
> -		.num_resources = 1,
> -		.resources = (struct resource []) {
> -			DEFINE_RES_MEM(SYS_ID, 0x4),
> -		},
> -		.platform_data = &vexpress_sysreg_sys_id_pdata,
> -		.pdata_size = sizeof(vexpress_sysreg_sys_id_pdata),
> -	}, {
>  		.name = "basic-mmio-gpio",
>  		.of_compatible = "arm,vexpress-sysreg,sys_led",
>  		.num_resources = 1,
> @@ -109,22 +89,6 @@ static struct mfd_cell vexpress_sysreg_cells[] = {
>  		},
>  		.platform_data = &vexpress_sysreg_sys_flash_pdata,
>  		.pdata_size = sizeof(vexpress_sysreg_sys_flash_pdata),
> -	}, {
> -		.name = "syscon",
> -		.num_resources = 1,
> -		.resources = (struct resource []) {
> -			DEFINE_RES_MEM(SYS_MISC, 0x4),
> -		},
> -		.platform_data = &vexpress_sysreg_sys_misc_pdata,
> -		.pdata_size = sizeof(vexpress_sysreg_sys_misc_pdata),
> -	}, {
> -		.name = "syscon",
> -		.num_resources = 1,
> -		.resources = (struct resource []) {
> -			DEFINE_RES_MEM(SYS_PROCID0, 0x8),
> -		},
> -		.platform_data = &vexpress_sysreg_sys_procid_pdata,
> -		.pdata_size = sizeof(vexpress_sysreg_sys_procid_pdata),

These were used for communication with the daughterboards. AFAIK there is no upstream
support for that in the kernel and even inside Arm I am almost sure there are no
users left.

With the commit message added:

Acked-by: Liviu Dudau <liviu.dudau@arm.com>

Best regards,
Liviu

>  	}, {
>  		.name = "vexpress-syscfg",
>  		.num_resources = 1,
> -- 
> 2.20.1
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯