From: Rob Herring <robh@kernel.org> To: Sudeep Holla <sudeep.holla@arm.com> Cc: Linus Walleij <linus.walleij@linaro.org>, Liviu Dudau <liviu.dudau@arm.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Arnd Bergmann <arnd@arndb.de>, Catalin Marinas <catalin.marinas@arm.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Lee Jones <lee.jones@linaro.org>, Sebastian Reichel <sre@kernel.org>, Stephen Boyd <sboyd@kernel.org>, Will Deacon <will@kernel.org>, Kevin Brodsky <Kevin.Brodsky@arm.com>, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>, linux-clk <linux-clk@vger.kernel.org>, "open list:THERMAL" <linux-pm@vger.kernel.org>, Michael Turquette <mturquette@baylibre.com> Subject: Re: [PATCH 08/17] clk: vexpress-osc: Support building as a module Date: Thu, 23 Apr 2020 10:53:40 -0500 [thread overview] Message-ID: <CAL_JsqLnKd5_ifeARuc8RfsUCnc37jNBOkGSeWEp6EPA4J9tqA@mail.gmail.com> (raw) In-Reply-To: <20200423133342.GA10628@bogus> On Thu, Apr 23, 2020 at 8:45 AM Sudeep Holla <sudeep.holla@arm.com> wrote: > > On Wed, Apr 22, 2020 at 10:08:02PM +0100, Sudeep Holla wrote: > > On Sun, Apr 19, 2020 at 12:08:01PM -0500, Rob Herring wrote: > > > Enable building the vexpress-osc clock driver as a module. > > > > > > Cc: Linus Walleij <linus.walleij@linaro.org> > > > Cc: Liviu Dudau <liviu.dudau@arm.com> > > > Cc: Sudeep Holla <sudeep.holla@arm.com> > > > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > > > Cc: Michael Turquette <mturquette@baylibre.com> > > > Cc: Stephen Boyd <sboyd@kernel.org> > > > Cc: linux-clk@vger.kernel.org > > > Signed-off-by: Rob Herring <robh@kernel.org> > > > --- > > > drivers/clk/versatile/Kconfig | 4 ++-- > > > drivers/clk/versatile/clk-vexpress-osc.c | 10 ++++------ > > > 2 files changed, 6 insertions(+), 8 deletions(-) > > > > > > diff --git a/drivers/clk/versatile/Kconfig b/drivers/clk/versatile/Kconfig > > > index 5bdd5c98990b..9de2396dcf9b 100644 > > > --- a/drivers/clk/versatile/Kconfig > > > +++ b/drivers/clk/versatile/Kconfig > > > @@ -15,8 +15,8 @@ config CLK_SP810 > > > of the ARM SP810 System Controller cell. > > > > > > config CLK_VEXPRESS_OSC > > > - bool "Clock driver for Versatile Express OSC clock generators" > > > - depends on VEXPRESS_CONFIG || COMPILE_TEST > > > + tristate "Clock driver for Versatile Express OSC clock generators" > > > + depends on VEXPRESS_CONFIG > > > default y if ARCH_VEXPRESS > > > ---help--- > > > Simple regmap-based driver driving clock generators on Versatile > > > diff --git a/drivers/clk/versatile/clk-vexpress-osc.c b/drivers/clk/versatile/clk-vexpress-osc.c > > > index 5bb1d5a714d0..b2b32fa2d7c3 100644 > > > --- a/drivers/clk/versatile/clk-vexpress-osc.c > > > +++ b/drivers/clk/versatile/clk-vexpress-osc.c > > > @@ -7,6 +7,7 @@ > > > #include <linux/clkdev.h> > > > #include <linux/clk-provider.h> > > > #include <linux/err.h> > > > +#include <linux/module.h> > > > #include <linux/of.h> > > > #include <linux/platform_device.h> > > > #include <linux/slab.h> > > > @@ -108,6 +109,7 @@ static const struct of_device_id vexpress_osc_of_match[] = { > > > { .compatible = "arm,vexpress-osc", }, > > > {} > > > }; > > > +MODULE_DEVICE_TABLE(of, vexpress_osc_of_match); > > > > > > static struct platform_driver vexpress_osc_driver = { > > > .driver = { > > > @@ -116,9 +118,5 @@ static struct platform_driver vexpress_osc_driver = { > > > }, > > > .probe = vexpress_osc_probe, > > > }; > > > - > > > -static int __init vexpress_osc_init(void) > > > -{ > > > - return platform_driver_register(&vexpress_osc_driver); > > > -} > > > -core_initcall(vexpress_osc_init); > > > +module_platform_driver(vexpress_osc_driver); > > > > I am not 100% sure of this. This might break the boot on CA9 and TC2 > > at-least. There are loads of MB peripherals that need this. This will > > break the boot. We need to check if all the dependent modules are also > > at module_initcall level and if they deal with deferred probe correctly. > > Lot of them are legacy and may happen to be working by carefully initcall > > level adjustments. > > > > OK I managed to try this on my TC2 and it fails to boot. However when I > enable earlyprintk as I see no log without it, it boots just fine. Well, the uart clocks for TC2 are all dependent on vexpress-osc. The console setup is going to fail to get the clocks and just fail as there's no deferred probe for consoles. We need some way to retrigger the console matching. > I also checked adding initcall_debug and I may be wrong on the dependency > part. The modules dependent on vexpress-osc are probed later correctly. > > This make it more difficult to debug as I don't have any debugger attached > at the moment to look at the logbuf when it hangs without earlyprintk. > > -- > Regards, > Sudeep
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Sudeep Holla <sudeep.holla@arm.com> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Arnd Bergmann <arnd@arndb.de>, "open list:THERMAL" <linux-pm@vger.kernel.org>, Stephen Boyd <sboyd@kernel.org>, Catalin Marinas <catalin.marinas@arm.com>, Linus Walleij <linus.walleij@linaro.org>, Kevin Brodsky <Kevin.Brodsky@arm.com>, Liviu Dudau <liviu.dudau@arm.com>, Sebastian Reichel <sre@kernel.org>, Michael Turquette <mturquette@baylibre.com>, Will Deacon <will@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Lee Jones <lee.jones@linaro.org>, linux-clk <linux-clk@vger.kernel.org>, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 08/17] clk: vexpress-osc: Support building as a module Date: Thu, 23 Apr 2020 10:53:40 -0500 [thread overview] Message-ID: <CAL_JsqLnKd5_ifeARuc8RfsUCnc37jNBOkGSeWEp6EPA4J9tqA@mail.gmail.com> (raw) In-Reply-To: <20200423133342.GA10628@bogus> On Thu, Apr 23, 2020 at 8:45 AM Sudeep Holla <sudeep.holla@arm.com> wrote: > > On Wed, Apr 22, 2020 at 10:08:02PM +0100, Sudeep Holla wrote: > > On Sun, Apr 19, 2020 at 12:08:01PM -0500, Rob Herring wrote: > > > Enable building the vexpress-osc clock driver as a module. > > > > > > Cc: Linus Walleij <linus.walleij@linaro.org> > > > Cc: Liviu Dudau <liviu.dudau@arm.com> > > > Cc: Sudeep Holla <sudeep.holla@arm.com> > > > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > > > Cc: Michael Turquette <mturquette@baylibre.com> > > > Cc: Stephen Boyd <sboyd@kernel.org> > > > Cc: linux-clk@vger.kernel.org > > > Signed-off-by: Rob Herring <robh@kernel.org> > > > --- > > > drivers/clk/versatile/Kconfig | 4 ++-- > > > drivers/clk/versatile/clk-vexpress-osc.c | 10 ++++------ > > > 2 files changed, 6 insertions(+), 8 deletions(-) > > > > > > diff --git a/drivers/clk/versatile/Kconfig b/drivers/clk/versatile/Kconfig > > > index 5bdd5c98990b..9de2396dcf9b 100644 > > > --- a/drivers/clk/versatile/Kconfig > > > +++ b/drivers/clk/versatile/Kconfig > > > @@ -15,8 +15,8 @@ config CLK_SP810 > > > of the ARM SP810 System Controller cell. > > > > > > config CLK_VEXPRESS_OSC > > > - bool "Clock driver for Versatile Express OSC clock generators" > > > - depends on VEXPRESS_CONFIG || COMPILE_TEST > > > + tristate "Clock driver for Versatile Express OSC clock generators" > > > + depends on VEXPRESS_CONFIG > > > default y if ARCH_VEXPRESS > > > ---help--- > > > Simple regmap-based driver driving clock generators on Versatile > > > diff --git a/drivers/clk/versatile/clk-vexpress-osc.c b/drivers/clk/versatile/clk-vexpress-osc.c > > > index 5bb1d5a714d0..b2b32fa2d7c3 100644 > > > --- a/drivers/clk/versatile/clk-vexpress-osc.c > > > +++ b/drivers/clk/versatile/clk-vexpress-osc.c > > > @@ -7,6 +7,7 @@ > > > #include <linux/clkdev.h> > > > #include <linux/clk-provider.h> > > > #include <linux/err.h> > > > +#include <linux/module.h> > > > #include <linux/of.h> > > > #include <linux/platform_device.h> > > > #include <linux/slab.h> > > > @@ -108,6 +109,7 @@ static const struct of_device_id vexpress_osc_of_match[] = { > > > { .compatible = "arm,vexpress-osc", }, > > > {} > > > }; > > > +MODULE_DEVICE_TABLE(of, vexpress_osc_of_match); > > > > > > static struct platform_driver vexpress_osc_driver = { > > > .driver = { > > > @@ -116,9 +118,5 @@ static struct platform_driver vexpress_osc_driver = { > > > }, > > > .probe = vexpress_osc_probe, > > > }; > > > - > > > -static int __init vexpress_osc_init(void) > > > -{ > > > - return platform_driver_register(&vexpress_osc_driver); > > > -} > > > -core_initcall(vexpress_osc_init); > > > +module_platform_driver(vexpress_osc_driver); > > > > I am not 100% sure of this. This might break the boot on CA9 and TC2 > > at-least. There are loads of MB peripherals that need this. This will > > break the boot. We need to check if all the dependent modules are also > > at module_initcall level and if they deal with deferred probe correctly. > > Lot of them are legacy and may happen to be working by carefully initcall > > level adjustments. > > > > OK I managed to try this on my TC2 and it fails to boot. However when I > enable earlyprintk as I see no log without it, it boots just fine. Well, the uart clocks for TC2 are all dependent on vexpress-osc. The console setup is going to fail to get the clocks and just fail as there's no deferred probe for consoles. We need some way to retrigger the console matching. > I also checked adding initcall_debug and I may be wrong on the dependency > part. The modules dependent on vexpress-osc are probed later correctly. > > This make it more difficult to debug as I don't have any debugger attached > at the moment to look at the logbuf when it hangs without earlyprintk. > > -- > Regards, > Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-23 15:53 UTC|newest] Thread overview: 136+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-19 17:07 [PATCH 00/17] Modularizing Versatile Express Rob Herring 2020-04-19 17:07 ` Rob Herring 2020-04-19 17:07 ` [PATCH 01/17] ARM: vexpress: Move vexpress_flags_set() into arch code Rob Herring 2020-04-19 17:07 ` Rob Herring 2020-04-20 15:17 ` Arnd Bergmann 2020-04-20 15:17 ` Arnd Bergmann 2020-04-22 10:15 ` Liviu Dudau 2020-04-22 10:15 ` Liviu Dudau 2020-04-22 19:04 ` Sudeep Holla 2020-04-22 19:04 ` Sudeep Holla 2020-04-19 17:07 ` [PATCH 02/17] arm64: vexpress: Don't select CONFIG_POWER_RESET_VEXPRESS Rob Herring 2020-04-19 17:07 ` Rob Herring 2020-04-20 15:18 ` Arnd Bergmann 2020-04-20 15:18 ` Arnd Bergmann 2020-04-22 10:16 ` Liviu Dudau 2020-04-22 10:16 ` Liviu Dudau 2020-04-22 19:08 ` Sudeep Holla 2020-04-22 19:08 ` Sudeep Holla 2020-04-19 17:07 ` [PATCH 03/17] arm64: vexpress: Don't select CONFIG_VEXPRESS_CONFIG Rob Herring 2020-04-19 17:07 ` Rob Herring 2020-04-20 15:18 ` Arnd Bergmann 2020-04-20 15:18 ` Arnd Bergmann 2020-04-22 19:09 ` Sudeep Holla 2020-04-22 19:09 ` Sudeep Holla 2020-04-19 17:07 ` [PATCH 04/17] power/reset: vexpress: Support building as a module Rob Herring 2020-04-19 17:07 ` Rob Herring 2020-04-20 15:23 ` Arnd Bergmann 2020-04-20 15:23 ` Arnd Bergmann 2020-04-20 17:23 ` Rob Herring 2020-04-20 17:23 ` Rob Herring 2020-04-28 19:31 ` Sebastian Reichel 2020-04-28 19:31 ` Sebastian Reichel 2020-04-22 19:11 ` Sudeep Holla 2020-04-22 19:11 ` Sudeep Holla 2020-04-19 17:07 ` [PATCH 05/17] clk: versatile: Kill CONFIG_COMMON_CLK_VERSATILE Rob Herring 2020-04-19 17:07 ` Rob Herring 2020-04-20 6:44 ` Linus Walleij 2020-04-20 6:44 ` Linus Walleij 2020-04-22 9:47 ` Stephen Boyd 2020-04-22 9:47 ` Stephen Boyd 2020-04-22 22:34 ` Rob Herring 2020-04-22 22:34 ` Rob Herring 2020-04-22 19:17 ` Sudeep Holla 2020-04-22 19:17 ` Sudeep Holla 2020-04-19 17:07 ` [PATCH 06/17] clk: versatile: Only enable SP810 on 32-bit by default Rob Herring 2020-04-19 17:07 ` Rob Herring 2020-04-20 15:26 ` Arnd Bergmann 2020-04-20 15:26 ` Arnd Bergmann 2020-04-20 17:48 ` Rob Herring 2020-04-20 17:48 ` Rob Herring 2020-04-20 20:07 ` Arnd Bergmann 2020-04-20 20:07 ` Arnd Bergmann 2020-04-22 9:48 ` Stephen Boyd 2020-04-22 9:48 ` Stephen Boyd 2020-04-22 10:20 ` Liviu Dudau 2020-04-22 10:20 ` Liviu Dudau 2020-04-22 20:52 ` Sudeep Holla 2020-04-22 20:52 ` Sudeep Holla 2020-04-23 15:38 ` Rob Herring 2020-04-23 15:38 ` Rob Herring 2020-04-19 17:08 ` [PATCH 07/17] clk: vexpress-osc: Use the devres clock API variants Rob Herring 2020-04-19 17:08 ` Rob Herring 2020-04-20 15:26 ` Arnd Bergmann 2020-04-20 15:26 ` Arnd Bergmann 2020-04-22 9:51 ` Stephen Boyd 2020-04-22 9:51 ` Stephen Boyd 2020-04-22 10:21 ` Liviu Dudau 2020-04-22 10:21 ` Liviu Dudau 2020-04-22 20:56 ` Sudeep Holla 2020-04-22 20:56 ` Sudeep Holla 2020-04-19 17:08 ` [PATCH 08/17] clk: vexpress-osc: Support building as a module Rob Herring 2020-04-19 17:08 ` Rob Herring 2020-04-20 15:27 ` Arnd Bergmann 2020-04-20 15:27 ` Arnd Bergmann 2020-04-20 17:18 ` Rob Herring 2020-04-20 17:18 ` Rob Herring 2020-04-22 11:01 ` Liviu Dudau 2020-04-22 11:01 ` Liviu Dudau 2020-04-22 21:08 ` Sudeep Holla 2020-04-22 21:08 ` Sudeep Holla 2020-04-23 13:45 ` Sudeep Holla 2020-04-23 13:45 ` Sudeep Holla 2020-04-23 15:53 ` Rob Herring [this message] 2020-04-23 15:53 ` Rob Herring 2020-04-23 16:58 ` Sudeep Holla 2020-04-23 16:58 ` Sudeep Holla 2020-04-19 17:08 ` [PATCH 09/17] mfd: vexpress-sysreg: Drop selecting CONFIG_CLKSRC_MMIO Rob Herring 2020-04-19 17:08 ` Rob Herring 2020-04-20 15:29 ` Arnd Bergmann 2020-04-20 15:29 ` Arnd Bergmann 2020-04-22 11:02 ` Liviu Dudau 2020-04-22 11:02 ` Liviu Dudau 2020-04-19 17:08 ` [PATCH 10/17] mfd: vexpress-sysreg: Drop unused syscon child devices Rob Herring 2020-04-19 17:08 ` Rob Herring 2020-04-20 15:30 ` Arnd Bergmann 2020-04-20 15:30 ` Arnd Bergmann 2020-04-22 11:18 ` Liviu Dudau 2020-04-22 11:18 ` Liviu Dudau 2020-04-19 17:08 ` [PATCH 11/17] mfd: vexpress-sysreg: Use devres API variants Rob Herring 2020-04-19 17:08 ` Rob Herring 2020-04-20 15:31 ` Arnd Bergmann 2020-04-20 15:31 ` Arnd Bergmann 2020-04-22 11:18 ` Liviu Dudau 2020-04-22 11:18 ` Liviu Dudau 2020-04-19 17:08 ` [PATCH 12/17] mfd: vexpress-sysreg: Support building as a module Rob Herring 2020-04-19 17:08 ` Rob Herring 2020-04-20 15:32 ` Arnd Bergmann 2020-04-20 15:32 ` Arnd Bergmann 2020-04-20 17:05 ` Rob Herring 2020-04-20 17:05 ` Rob Herring 2020-04-19 17:08 ` [PATCH 13/17] bus: vexpress-config: Merge vexpress-syscfg into vexpress-config Rob Herring 2020-04-19 17:08 ` Rob Herring 2020-04-20 11:45 ` Greg Kroah-Hartman 2020-04-20 11:45 ` Greg Kroah-Hartman 2020-04-22 11:22 ` Liviu Dudau 2020-04-22 11:22 ` Liviu Dudau 2020-04-19 17:08 ` [PATCH 14/17] bus: vexpress-config: simplify config bus probing Rob Herring 2020-04-19 17:08 ` Rob Herring 2020-04-22 11:58 ` Liviu Dudau 2020-04-22 11:58 ` Liviu Dudau 2020-04-19 17:08 ` [PATCH 15/17] vexpress: Move site master init to vexpress-config bus Rob Herring 2020-04-19 17:08 ` Rob Herring 2020-04-22 9:51 ` Stephen Boyd 2020-04-22 9:51 ` Stephen Boyd 2020-04-22 12:03 ` Liviu Dudau 2020-04-22 12:03 ` Liviu Dudau 2020-04-23 0:54 ` Rob Herring 2020-04-23 0:54 ` Rob Herring 2020-04-19 17:08 ` [PATCH 16/17] bus: vexpress-config: Support building as module Rob Herring 2020-04-19 17:08 ` Rob Herring 2020-04-22 12:04 ` Liviu Dudau 2020-04-22 12:04 ` Liviu Dudau 2020-04-19 17:08 ` [PATCH 17/17] ARM: vexpress: Don't select VEXPRESS_CONFIG Rob Herring 2020-04-19 17:08 ` Rob Herring 2020-04-22 12:05 ` Liviu Dudau 2020-04-22 12:05 ` Liviu Dudau
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAL_JsqLnKd5_ifeARuc8RfsUCnc37jNBOkGSeWEp6EPA4J9tqA@mail.gmail.com \ --to=robh@kernel.org \ --cc=Kevin.Brodsky@arm.com \ --cc=arnd@arndb.de \ --cc=catalin.marinas@arm.com \ --cc=gregkh@linuxfoundation.org \ --cc=lee.jones@linaro.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=liviu.dudau@arm.com \ --cc=lorenzo.pieralisi@arm.com \ --cc=mturquette@baylibre.com \ --cc=sboyd@kernel.org \ --cc=sre@kernel.org \ --cc=sudeep.holla@arm.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.