All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>,
	Liviu Dudau <liviu.dudau@arm.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>
Cc: Kevin Brodsky <Kevin.Brodsky@arm.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Lee Jones <lee.jones@linaro.org>,
	Sebastian Reichel <sre@kernel.org>,
	Stephen Boyd <sboyd@kernel.org>, Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 11/16] mfd: vexpress-sysreg: Support building as a module
Date: Wed, 29 Apr 2020 15:58:20 -0500	[thread overview]
Message-ID: <20200429205825.10604-12-robh@kernel.org> (raw)
In-Reply-To: <20200429205825.10604-1-robh@kernel.org>

Enable building the vexpress-sysreg driver as a module.

As deferred probe between the vexpress components works now, we don't
need to create struct devices early with of_platform_device_create().

Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Rob Herring <robh@kernel.org>
---
 drivers/mfd/Kconfig           |  2 +-
 drivers/mfd/vexpress-sysreg.c | 15 ++++-----------
 2 files changed, 5 insertions(+), 12 deletions(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index b1311dea2da1..792766558328 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -2028,7 +2028,7 @@ config MCP_UCB1200_TS
 endmenu
 
 config MFD_VEXPRESS_SYSREG
-	bool "Versatile Express System Registers"
+	tristate "Versatile Express System Registers"
 	depends on VEXPRESS_CONFIG && GPIOLIB
 	default y
 	select GPIO_GENERIC_PLATFORM
diff --git a/drivers/mfd/vexpress-sysreg.c b/drivers/mfd/vexpress-sysreg.c
index 9fb37fa689e0..eeeeb1d26d5d 100644
--- a/drivers/mfd/vexpress-sysreg.c
+++ b/drivers/mfd/vexpress-sysreg.c
@@ -8,6 +8,7 @@
 #include <linux/err.h>
 #include <linux/io.h>
 #include <linux/mfd/core.h>
+#include <linux/module.h>
 #include <linux/of_platform.h>
 #include <linux/platform_data/syscon.h>
 #include <linux/platform_device.h>
@@ -151,6 +152,7 @@ static const struct of_device_id vexpress_sysreg_match[] = {
 	{ .compatible = "arm,vexpress-sysreg", },
 	{},
 };
+MODULE_DEVICE_TABLE(of, vexpress_sysreg_match);
 
 static struct platform_driver vexpress_sysreg_driver = {
 	.driver = {
@@ -160,14 +162,5 @@ static struct platform_driver vexpress_sysreg_driver = {
 	.probe = vexpress_sysreg_probe,
 };
 
-static int __init vexpress_sysreg_init(void)
-{
-	struct device_node *node;
-
-	/* Need the sysreg early, before any other device... */
-	for_each_matching_node(node, vexpress_sysreg_match)
-		of_platform_device_create(node, NULL, NULL);
-
-	return platform_driver_register(&vexpress_sysreg_driver);
-}
-core_initcall(vexpress_sysreg_init);
+module_platform_driver(vexpress_sysreg_driver);
+MODULE_LICENSE("GPL v2");
-- 
2.20.1


WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>,
	Liviu Dudau <liviu.dudau@arm.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	linux-pm@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Kevin Brodsky <Kevin.Brodsky@arm.com>,
	Sebastian Reichel <sre@kernel.org>, Will Deacon <will@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Lee Jones <lee.jones@linaro.org>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 11/16] mfd: vexpress-sysreg: Support building as a module
Date: Wed, 29 Apr 2020 15:58:20 -0500	[thread overview]
Message-ID: <20200429205825.10604-12-robh@kernel.org> (raw)
In-Reply-To: <20200429205825.10604-1-robh@kernel.org>

Enable building the vexpress-sysreg driver as a module.

As deferred probe between the vexpress components works now, we don't
need to create struct devices early with of_platform_device_create().

Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Rob Herring <robh@kernel.org>
---
 drivers/mfd/Kconfig           |  2 +-
 drivers/mfd/vexpress-sysreg.c | 15 ++++-----------
 2 files changed, 5 insertions(+), 12 deletions(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index b1311dea2da1..792766558328 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -2028,7 +2028,7 @@ config MCP_UCB1200_TS
 endmenu
 
 config MFD_VEXPRESS_SYSREG
-	bool "Versatile Express System Registers"
+	tristate "Versatile Express System Registers"
 	depends on VEXPRESS_CONFIG && GPIOLIB
 	default y
 	select GPIO_GENERIC_PLATFORM
diff --git a/drivers/mfd/vexpress-sysreg.c b/drivers/mfd/vexpress-sysreg.c
index 9fb37fa689e0..eeeeb1d26d5d 100644
--- a/drivers/mfd/vexpress-sysreg.c
+++ b/drivers/mfd/vexpress-sysreg.c
@@ -8,6 +8,7 @@
 #include <linux/err.h>
 #include <linux/io.h>
 #include <linux/mfd/core.h>
+#include <linux/module.h>
 #include <linux/of_platform.h>
 #include <linux/platform_data/syscon.h>
 #include <linux/platform_device.h>
@@ -151,6 +152,7 @@ static const struct of_device_id vexpress_sysreg_match[] = {
 	{ .compatible = "arm,vexpress-sysreg", },
 	{},
 };
+MODULE_DEVICE_TABLE(of, vexpress_sysreg_match);
 
 static struct platform_driver vexpress_sysreg_driver = {
 	.driver = {
@@ -160,14 +162,5 @@ static struct platform_driver vexpress_sysreg_driver = {
 	.probe = vexpress_sysreg_probe,
 };
 
-static int __init vexpress_sysreg_init(void)
-{
-	struct device_node *node;
-
-	/* Need the sysreg early, before any other device... */
-	for_each_matching_node(node, vexpress_sysreg_match)
-		of_platform_device_create(node, NULL, NULL);
-
-	return platform_driver_register(&vexpress_sysreg_driver);
-}
-core_initcall(vexpress_sysreg_init);
+module_platform_driver(vexpress_sysreg_driver);
+MODULE_LICENSE("GPL v2");
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-04-29 20:58 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29 20:58 [PATCH v2 00/17] Modularizing Versatile Express Rob Herring
2020-04-29 20:58 ` Rob Herring
2020-04-29 20:58 ` [PATCH v2 01/16] ARM: vexpress: Move vexpress_flags_set() into arch code Rob Herring
2020-04-29 20:58   ` Rob Herring
2020-05-04  8:56   ` Lee Jones
2020-05-04  8:56     ` Lee Jones
2020-04-29 20:58 ` [PATCH v2 02/16] arm64: vexpress: Don't select CONFIG_POWER_RESET_VEXPRESS Rob Herring
2020-04-29 20:58   ` Rob Herring
2020-04-29 20:58 ` [PATCH v2 03/16] amba: Retry adding deferred devices at late_initcall Rob Herring
2020-04-29 20:58   ` Rob Herring
2020-04-29 20:58 ` [PATCH v2 04/16] clk: versatile: Rework kconfig structure Rob Herring
2020-04-29 20:58   ` Rob Herring
2020-05-01 16:26   ` Sudeep Holla
2020-05-01 16:26     ` Sudeep Holla
2020-05-05  6:20   ` Stephen Boyd
2020-05-05  6:20     ` Stephen Boyd
2020-04-29 20:58 ` [PATCH v2 05/16] clk: versatile: Only enable SP810 on 32-bit by default Rob Herring
2020-04-29 20:58   ` Rob Herring
2020-05-01 16:32   ` Sudeep Holla
2020-05-01 16:32     ` Sudeep Holla
2020-05-05  6:20   ` Stephen Boyd
2020-05-05  6:20     ` Stephen Boyd
2020-04-29 20:58 ` [PATCH v2 06/16] clk: vexpress-osc: Use the devres clock API variants Rob Herring
2020-04-29 20:58   ` Rob Herring
2020-04-29 20:58 ` [PATCH v2 07/16] clk: vexpress-osc: Support building as a module Rob Herring
2020-04-29 20:58   ` Rob Herring
2020-05-01 16:36   ` Sudeep Holla
2020-05-01 16:36     ` Sudeep Holla
2020-05-05  6:21   ` Stephen Boyd
2020-05-05  6:21     ` Stephen Boyd
2020-04-29 20:58 ` [PATCH v2 08/16] mfd: vexpress-sysreg: Drop selecting CONFIG_CLKSRC_MMIO Rob Herring
2020-04-29 20:58   ` Rob Herring
2020-05-01 16:37   ` Sudeep Holla
2020-05-01 16:37     ` Sudeep Holla
2020-05-04  8:55   ` Lee Jones
2020-05-04  8:55     ` Lee Jones
2020-04-29 20:58 ` [PATCH v2 09/16] mfd: vexpress-sysreg: Drop unused syscon child devices Rob Herring
2020-04-29 20:58   ` Rob Herring
2020-05-01 16:50   ` Sudeep Holla
2020-05-01 16:50     ` Sudeep Holla
2020-05-04  8:41   ` Lee Jones
2020-05-04  8:41     ` Lee Jones
2020-04-29 20:58 ` [PATCH v2 10/16] mfd: vexpress-sysreg: Use devres API variants Rob Herring
2020-04-29 20:58   ` Rob Herring
2020-05-01 16:56   ` Sudeep Holla
2020-05-01 16:56     ` Sudeep Holla
2020-05-04  8:41   ` Lee Jones
2020-05-04  8:41     ` Lee Jones
2020-04-29 20:58 ` Rob Herring [this message]
2020-04-29 20:58   ` [PATCH v2 11/16] mfd: vexpress-sysreg: Support building as a module Rob Herring
2020-05-01 16:58   ` Sudeep Holla
2020-05-01 16:58     ` Sudeep Holla
2020-05-04  8:40   ` Lee Jones
2020-05-04  8:40     ` Lee Jones
2020-04-29 20:58 ` [PATCH v2 12/16] bus: vexpress-config: Merge vexpress-syscfg into vexpress-config Rob Herring
2020-04-29 20:58   ` Rob Herring
2020-05-01 17:02   ` Sudeep Holla
2020-05-01 17:02     ` Sudeep Holla
2020-04-29 20:58 ` [PATCH v2 13/16] bus: vexpress-config: simplify config bus probing Rob Herring
2020-04-29 20:58   ` Rob Herring
2020-05-01 17:10   ` Sudeep Holla
2020-05-01 17:10     ` Sudeep Holla
2020-04-29 20:58 ` [PATCH v2 14/16] vexpress: Move setting master site to vexpress-config bus Rob Herring
2020-04-29 20:58   ` Rob Herring
2020-05-01 17:18   ` Sudeep Holla
2020-05-01 17:18     ` Sudeep Holla
2020-05-04  8:26   ` Lee Jones
2020-05-04  8:26     ` Lee Jones
2020-04-29 20:58 ` [PATCH v2 15/16] bus: vexpress-config: Support building as module Rob Herring
2020-04-29 20:58   ` Rob Herring
2020-05-01 16:58   ` Sudeep Holla
2020-05-01 16:58     ` Sudeep Holla
2020-04-29 20:58 ` [PATCH v2 16/16] ARM: vexpress: Don't select VEXPRESS_CONFIG Rob Herring
2020-04-29 20:58   ` Rob Herring
2020-05-01 16:55   ` Sudeep Holla
2020-05-01 16:55     ` Sudeep Holla
2020-04-29 22:11 ` [PATCH v2 00/17] Modularizing Versatile Express Sebastian Reichel
2020-04-29 22:11   ` Sebastian Reichel
2020-05-01 17:20 ` Sudeep Holla
2020-05-01 17:20   ` Sudeep Holla
2020-06-17 15:08 ` Daniel Thompson
2020-06-17 15:08   ` Daniel Thompson
2020-07-08 16:39   ` Rob Herring
2020-07-08 16:39     ` Rob Herring
2020-07-09 11:33     ` Daniel Thompson
2020-07-09 11:33       ` Daniel Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200429205825.10604-12-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Kevin.Brodsky@arm.com \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=liviu.dudau@arm.com \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=sboyd@kernel.org \
    --cc=sre@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.