From: Sudeep Holla <sudeep.holla@arm.com>
To: Rob Herring <robh@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Liviu Dudau <liviu.dudau@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Kevin Brodsky <Kevin.Brodsky@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
Catalin Marinas <catalin.marinas@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Lee Jones <lee.jones@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
Stephen Boyd <sboyd@kernel.org>, Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 05/16] clk: versatile: Only enable SP810 on 32-bit by default
Date: Fri, 1 May 2020 17:32:39 +0100 [thread overview]
Message-ID: <20200501163239.GB14018@bogus> (raw)
In-Reply-To: <20200429205825.10604-6-robh@kernel.org>
On Wed, Apr 29, 2020 at 03:58:14PM -0500, Rob Herring wrote:
> While 64-bit Arm reference platforms have SP810 for clocks for SP804
> timers, they are not needed since the arch timers are used instead.
>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Sudeep Holla <sudeep.holla@arm.com>
With a note below for sake of information,
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: linux-clk@vger.kernel.org
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Liviu Dudau <liviu.dudau@arm.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> drivers/clk/versatile/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/versatile/Kconfig b/drivers/clk/versatile/Kconfig
> index df0d50bb846c..a47dd6c86d2e 100644
> --- a/drivers/clk/versatile/Kconfig
> +++ b/drivers/clk/versatile/Kconfig
> @@ -17,7 +17,7 @@ config ICST
>
> config CLK_SP810
> bool "Clock driver for ARM SP810 System Controller"
> - default y if ARCH_VEXPRESS
> + default y if (ARCH_VEXPRESS && ARM)
Just note that SP804 is selected by ARCH_HISILICON and ARCH_BRCM or
something for Raspberry Pi. So, this will result in the warnings on
Juno like:
sp804: timer clock not found: -517
sp804: arm,sp804 clock not found: -2
sp804: timer clock not found: -517
sp804: arm,sp804 clock not found: -2
This can be ignored as we rely on arch-timers and they are just there
in DT for completion. We can disable them in DT if that's fine ?
--
Regards,
Sudeep
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com>
To: Rob Herring <robh@kernel.org>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-pm@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
Kevin Brodsky <Kevin.Brodsky@arm.com>,
Liviu Dudau <liviu.dudau@arm.com>,
Sebastian Reichel <sre@kernel.org>, Will Deacon <will@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Lee Jones <lee.jones@linaro.org>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 05/16] clk: versatile: Only enable SP810 on 32-bit by default
Date: Fri, 1 May 2020 17:32:39 +0100 [thread overview]
Message-ID: <20200501163239.GB14018@bogus> (raw)
In-Reply-To: <20200429205825.10604-6-robh@kernel.org>
On Wed, Apr 29, 2020 at 03:58:14PM -0500, Rob Herring wrote:
> While 64-bit Arm reference platforms have SP810 for clocks for SP804
> timers, they are not needed since the arch timers are used instead.
>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Sudeep Holla <sudeep.holla@arm.com>
With a note below for sake of information,
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: linux-clk@vger.kernel.org
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Liviu Dudau <liviu.dudau@arm.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> drivers/clk/versatile/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/versatile/Kconfig b/drivers/clk/versatile/Kconfig
> index df0d50bb846c..a47dd6c86d2e 100644
> --- a/drivers/clk/versatile/Kconfig
> +++ b/drivers/clk/versatile/Kconfig
> @@ -17,7 +17,7 @@ config ICST
>
> config CLK_SP810
> bool "Clock driver for ARM SP810 System Controller"
> - default y if ARCH_VEXPRESS
> + default y if (ARCH_VEXPRESS && ARM)
Just note that SP804 is selected by ARCH_HISILICON and ARCH_BRCM or
something for Raspberry Pi. So, this will result in the warnings on
Juno like:
sp804: timer clock not found: -517
sp804: arm,sp804 clock not found: -2
sp804: timer clock not found: -517
sp804: arm,sp804 clock not found: -2
This can be ignored as we rely on arch-timers and they are just there
in DT for completion. We can disable them in DT if that's fine ?
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-01 16:32 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 20:58 [PATCH v2 00/17] Modularizing Versatile Express Rob Herring
2020-04-29 20:58 ` Rob Herring
2020-04-29 20:58 ` [PATCH v2 01/16] ARM: vexpress: Move vexpress_flags_set() into arch code Rob Herring
2020-04-29 20:58 ` Rob Herring
2020-05-04 8:56 ` Lee Jones
2020-05-04 8:56 ` Lee Jones
2020-04-29 20:58 ` [PATCH v2 02/16] arm64: vexpress: Don't select CONFIG_POWER_RESET_VEXPRESS Rob Herring
2020-04-29 20:58 ` Rob Herring
2020-04-29 20:58 ` [PATCH v2 03/16] amba: Retry adding deferred devices at late_initcall Rob Herring
2020-04-29 20:58 ` Rob Herring
2020-04-29 20:58 ` [PATCH v2 04/16] clk: versatile: Rework kconfig structure Rob Herring
2020-04-29 20:58 ` Rob Herring
2020-05-01 16:26 ` Sudeep Holla
2020-05-01 16:26 ` Sudeep Holla
2020-05-05 6:20 ` Stephen Boyd
2020-05-05 6:20 ` Stephen Boyd
2020-04-29 20:58 ` [PATCH v2 05/16] clk: versatile: Only enable SP810 on 32-bit by default Rob Herring
2020-04-29 20:58 ` Rob Herring
2020-05-01 16:32 ` Sudeep Holla [this message]
2020-05-01 16:32 ` Sudeep Holla
2020-05-05 6:20 ` Stephen Boyd
2020-05-05 6:20 ` Stephen Boyd
2020-04-29 20:58 ` [PATCH v2 06/16] clk: vexpress-osc: Use the devres clock API variants Rob Herring
2020-04-29 20:58 ` Rob Herring
2020-04-29 20:58 ` [PATCH v2 07/16] clk: vexpress-osc: Support building as a module Rob Herring
2020-04-29 20:58 ` Rob Herring
2020-05-01 16:36 ` Sudeep Holla
2020-05-01 16:36 ` Sudeep Holla
2020-05-05 6:21 ` Stephen Boyd
2020-05-05 6:21 ` Stephen Boyd
2020-04-29 20:58 ` [PATCH v2 08/16] mfd: vexpress-sysreg: Drop selecting CONFIG_CLKSRC_MMIO Rob Herring
2020-04-29 20:58 ` Rob Herring
2020-05-01 16:37 ` Sudeep Holla
2020-05-01 16:37 ` Sudeep Holla
2020-05-04 8:55 ` Lee Jones
2020-05-04 8:55 ` Lee Jones
2020-04-29 20:58 ` [PATCH v2 09/16] mfd: vexpress-sysreg: Drop unused syscon child devices Rob Herring
2020-04-29 20:58 ` Rob Herring
2020-05-01 16:50 ` Sudeep Holla
2020-05-01 16:50 ` Sudeep Holla
2020-05-04 8:41 ` Lee Jones
2020-05-04 8:41 ` Lee Jones
2020-04-29 20:58 ` [PATCH v2 10/16] mfd: vexpress-sysreg: Use devres API variants Rob Herring
2020-04-29 20:58 ` Rob Herring
2020-05-01 16:56 ` Sudeep Holla
2020-05-01 16:56 ` Sudeep Holla
2020-05-04 8:41 ` Lee Jones
2020-05-04 8:41 ` Lee Jones
2020-04-29 20:58 ` [PATCH v2 11/16] mfd: vexpress-sysreg: Support building as a module Rob Herring
2020-04-29 20:58 ` Rob Herring
2020-05-01 16:58 ` Sudeep Holla
2020-05-01 16:58 ` Sudeep Holla
2020-05-04 8:40 ` Lee Jones
2020-05-04 8:40 ` Lee Jones
2020-04-29 20:58 ` [PATCH v2 12/16] bus: vexpress-config: Merge vexpress-syscfg into vexpress-config Rob Herring
2020-04-29 20:58 ` Rob Herring
2020-05-01 17:02 ` Sudeep Holla
2020-05-01 17:02 ` Sudeep Holla
2020-04-29 20:58 ` [PATCH v2 13/16] bus: vexpress-config: simplify config bus probing Rob Herring
2020-04-29 20:58 ` Rob Herring
2020-05-01 17:10 ` Sudeep Holla
2020-05-01 17:10 ` Sudeep Holla
2020-04-29 20:58 ` [PATCH v2 14/16] vexpress: Move setting master site to vexpress-config bus Rob Herring
2020-04-29 20:58 ` Rob Herring
2020-05-01 17:18 ` Sudeep Holla
2020-05-01 17:18 ` Sudeep Holla
2020-05-04 8:26 ` Lee Jones
2020-05-04 8:26 ` Lee Jones
2020-04-29 20:58 ` [PATCH v2 15/16] bus: vexpress-config: Support building as module Rob Herring
2020-04-29 20:58 ` Rob Herring
2020-05-01 16:58 ` Sudeep Holla
2020-05-01 16:58 ` Sudeep Holla
2020-04-29 20:58 ` [PATCH v2 16/16] ARM: vexpress: Don't select VEXPRESS_CONFIG Rob Herring
2020-04-29 20:58 ` Rob Herring
2020-05-01 16:55 ` Sudeep Holla
2020-05-01 16:55 ` Sudeep Holla
2020-04-29 22:11 ` [PATCH v2 00/17] Modularizing Versatile Express Sebastian Reichel
2020-04-29 22:11 ` Sebastian Reichel
2020-05-01 17:20 ` Sudeep Holla
2020-05-01 17:20 ` Sudeep Holla
2020-06-17 15:08 ` Daniel Thompson
2020-06-17 15:08 ` Daniel Thompson
2020-07-08 16:39 ` Rob Herring
2020-07-08 16:39 ` Rob Herring
2020-07-09 11:33 ` Daniel Thompson
2020-07-09 11:33 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501163239.GB14018@bogus \
--to=sudeep.holla@arm.com \
--cc=Kevin.Brodsky@arm.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=sre@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.