From: Kai-Heng Feng <kai.heng.feng@canonical.com>
To: tiwai@suse.com
Cc: David_chen7@dell.com,
"Kai-Heng Feng" <kai.heng.feng@canonical.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Kailang Yang" <kailang@realtek.com>,
"Hui Wang" <hui.wang@canonical.com>,
"Jian-Hong Pan" <jian-hong@endlessm.com>,
"Tomas Espeleta" <tomas.espeleta@gmail.com>,
"Thomas Hebb" <tommyhebb@gmail.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
alsa-devel@alsa-project.org (moderated list:SOUND),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 1/2] Revert "ALSA: hda/realtek: Fix pop noise on ALC225"
Date: Sun, 3 May 2020 23:24:46 +0800 [thread overview]
Message-ID: <20200503152449.22761-1-kai.heng.feng@canonical.com> (raw)
This reverts commit 3b36b13d5e69d6f51ff1c55d1b404a74646c9757.
Enable power save node breaks some systems with ACL225. Revert the patch
and use a platform specific quirk for the original issue isntead.
Fixes: 3b36b13d5e69 ("ALSA: hda/realtek: Fix pop noise on ALC225")
BugLink: https://bugs.launchpad.net/bugs/1875916
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
sound/pci/hda/patch_realtek.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index b26f0acfd86e..dedf0c17f198 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8246,8 +8246,6 @@ static int patch_alc269(struct hda_codec *codec)
spec->gen.mixer_nid = 0;
break;
case 0x10ec0225:
- codec->power_save_node = 1;
- /* fall through */
case 0x10ec0295:
case 0x10ec0299:
spec->codec_variant = ALC269_TYPE_ALC225;
--
2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Kai-Heng Feng <kai.heng.feng@canonical.com>
To: tiwai@suse.com
Cc: "moderated list:SOUND" <alsa-devel@alsa-project.org>,
"Kailang Yang" <kailang@realtek.com>,
"Tomas Espeleta" <tomas.espeleta@gmail.com>,
"Thomas Hebb" <tommyhebb@gmail.com>,
David_chen7@dell.com, "open list" <linux-kernel@vger.kernel.org>,
"Hui Wang" <hui.wang@canonical.com>,
"Kai-Heng Feng" <kai.heng.feng@canonical.com>,
"Jian-Hong Pan" <jian-hong@endlessm.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Subject: [PATCH 1/2] Revert "ALSA: hda/realtek: Fix pop noise on ALC225"
Date: Sun, 3 May 2020 23:24:46 +0800 [thread overview]
Message-ID: <20200503152449.22761-1-kai.heng.feng@canonical.com> (raw)
This reverts commit 3b36b13d5e69d6f51ff1c55d1b404a74646c9757.
Enable power save node breaks some systems with ACL225. Revert the patch
and use a platform specific quirk for the original issue isntead.
Fixes: 3b36b13d5e69 ("ALSA: hda/realtek: Fix pop noise on ALC225")
BugLink: https://bugs.launchpad.net/bugs/1875916
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
sound/pci/hda/patch_realtek.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index b26f0acfd86e..dedf0c17f198 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8246,8 +8246,6 @@ static int patch_alc269(struct hda_codec *codec)
spec->gen.mixer_nid = 0;
break;
case 0x10ec0225:
- codec->power_save_node = 1;
- /* fall through */
case 0x10ec0295:
case 0x10ec0299:
spec->codec_variant = ALC269_TYPE_ALC225;
--
2.17.1
next reply other threads:[~2020-05-03 15:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-03 15:24 Kai-Heng Feng [this message]
2020-05-03 15:24 ` [PATCH 1/2] Revert "ALSA: hda/realtek: Fix pop noise on ALC225" Kai-Heng Feng
2020-05-03 15:24 ` [PATCH 2/2] ALSA: hda/realtek - Fix S3 pop noise on Dell Wyse Kai-Heng Feng
2020-05-03 15:24 ` Kai-Heng Feng
2020-05-03 19:02 ` Takashi Iwai
2020-05-03 19:02 ` Takashi Iwai
2020-05-03 19:02 ` [PATCH 1/2] Revert "ALSA: hda/realtek: Fix pop noise on ALC225" Takashi Iwai
2020-05-03 19:02 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200503152449.22761-1-kai.heng.feng@canonical.com \
--to=kai.heng.feng@canonical.com \
--cc=David_chen7@dell.com \
--cc=alsa-devel@alsa-project.org \
--cc=hui.wang@canonical.com \
--cc=jian-hong@endlessm.com \
--cc=kailang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=tomas.espeleta@gmail.com \
--cc=tommyhebb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.