From: Takashi Iwai <tiwai@suse.de>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: tiwai@suse.com, David_chen7@dell.com,
"Jaroslav Kysela" <perex@perex.cz>,
"Kailang Yang" <kailang@realtek.com>,
"Hui Wang" <hui.wang@canonical.com>,
"Jian-Hong Pan" <jian-hong@endlessm.com>,
"Tomas Espeleta" <tomas.espeleta@gmail.com>,
"Thomas Hebb" <tommyhebb@gmail.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"moderated list:SOUND" <alsa-devel@alsa-project.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] ALSA: hda/realtek - Fix S3 pop noise on Dell Wyse
Date: Sun, 03 May 2020 21:02:25 +0200 [thread overview]
Message-ID: <s5ha72ohmf2.wl-tiwai@suse.de> (raw)
In-Reply-To: <20200503152449.22761-2-kai.heng.feng@canonical.com>
On Sun, 03 May 2020 17:24:47 +0200,
Kai-Heng Feng wrote:
>
> Commit 317d9313925c ("ALSA: hda/realtek - Set default power save node to
> 0") makes the ALC225 have pop noise on S3 resume and cold boot.
>
> The previous fix enable power save node universally for ALC225, however
> it makes some ALC225 systems unable to produce any sound.
>
> So let's only enable power save node for the affected Dell Wyse
> platform.
>
> Fixes: 317d9313925c ("ALSA: hda/realtek - Set default power save node to 0")
> BugLink: https://bugs.launchpad.net/bugs/1866357
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Applied, thanks.
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: "moderated list:SOUND" <alsa-devel@alsa-project.org>,
"Kailang Yang" <kailang@realtek.com>,
"Tomas Espeleta" <tomas.espeleta@gmail.com>,
"open list" <linux-kernel@vger.kernel.org>,
David_chen7@dell.com, tiwai@suse.com,
"Hui Wang" <hui.wang@canonical.com>,
"Thomas Hebb" <tommyhebb@gmail.com>,
"Jian-Hong Pan" <jian-hong@endlessm.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Subject: Re: [PATCH 2/2] ALSA: hda/realtek - Fix S3 pop noise on Dell Wyse
Date: Sun, 03 May 2020 21:02:25 +0200 [thread overview]
Message-ID: <s5ha72ohmf2.wl-tiwai@suse.de> (raw)
In-Reply-To: <20200503152449.22761-2-kai.heng.feng@canonical.com>
On Sun, 03 May 2020 17:24:47 +0200,
Kai-Heng Feng wrote:
>
> Commit 317d9313925c ("ALSA: hda/realtek - Set default power save node to
> 0") makes the ALC225 have pop noise on S3 resume and cold boot.
>
> The previous fix enable power save node universally for ALC225, however
> it makes some ALC225 systems unable to produce any sound.
>
> So let's only enable power save node for the affected Dell Wyse
> platform.
>
> Fixes: 317d9313925c ("ALSA: hda/realtek - Set default power save node to 0")
> BugLink: https://bugs.launchpad.net/bugs/1866357
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Applied, thanks.
Takashi
next prev parent reply other threads:[~2020-05-03 19:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-03 15:24 [PATCH 1/2] Revert "ALSA: hda/realtek: Fix pop noise on ALC225" Kai-Heng Feng
2020-05-03 15:24 ` Kai-Heng Feng
2020-05-03 15:24 ` [PATCH 2/2] ALSA: hda/realtek - Fix S3 pop noise on Dell Wyse Kai-Heng Feng
2020-05-03 15:24 ` Kai-Heng Feng
2020-05-03 19:02 ` Takashi Iwai [this message]
2020-05-03 19:02 ` Takashi Iwai
2020-05-03 19:02 ` [PATCH 1/2] Revert "ALSA: hda/realtek: Fix pop noise on ALC225" Takashi Iwai
2020-05-03 19:02 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5ha72ohmf2.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=David_chen7@dell.com \
--cc=alsa-devel@alsa-project.org \
--cc=hui.wang@canonical.com \
--cc=jian-hong@endlessm.com \
--cc=kai.heng.feng@canonical.com \
--cc=kailang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=tomas.espeleta@gmail.com \
--cc=tommyhebb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.