From: kernel test robot <lkp@intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>
Cc: Roland Scheidegger <sroland@vmware.com>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
VMware Graphics <linux-graphics-maintainer@vmware.com>,
kbuild-all@lists.01.org, Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 6/8] drm/vmwgfx: Use __drm_atomic_helper_crtc_reset
Date: Sat, 13 Jun 2020 07:21:43 +0800 [thread overview]
Message-ID: <202006130752.WFKm8kxc%lkp@intel.com> (raw)
In-Reply-To: <20200612160056.2082681-6-daniel.vetter@ffwll.ch>
[-- Attachment #1: Type: text/plain, Size: 3453 bytes --]
Hi Daniel,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.7 next-20200612]
[cannot apply to drm/drm-next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/drm-atomic-helper-reset-vblank-on-crtc-reset/20200613-000414
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-rhel-7.6 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c: In function 'vmw_du_primary_plane_atomic_check':
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:460:31: warning: variable 'vcs' set but not used [-Wunused-but-set-variable]
460 | struct vmw_connector_state *vcs;
| ^~~
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c: In function 'vmw_du_crtc_reset':
<< In file included from drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:37:
>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:632:40: error: 'state' undeclared (first use in this function); did you mean 'statx'?
632 | __drm_atomic_helper_crtc_reset(crtc, &state->base);
| ^~~~~
| statx
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:632:40: note: each undeclared identifier is reported only once for each function it appears in
In file included from drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:37:
At top level:
drivers/gpu/drm/vmwgfx/vmwgfx_kms.h:256:23: warning: 'vmw_cursor_plane_formats' defined but not used [-Wunused-const-variable=]
256 | static const uint32_t vmw_cursor_plane_formats[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/vmwgfx/vmwgfx_kms.h:248:23: warning: 'vmw_primary_plane_formats' defined but not used [-Wunused-const-variable=]
248 | static const uint32_t vmw_primary_plane_formats[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
vim +632 drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
604
605
606 /**
607 * vmw_du_crtc_reset - creates a blank vmw crtc state
608 * @crtc: DRM crtc
609 *
610 * Resets the atomic state for @crtc by freeing the state pointer (which
611 * might be NULL, e.g. at driver load time) and allocating a new empty state
612 * object.
613 */
614 void vmw_du_crtc_reset(struct drm_crtc *crtc)
615 {
616 struct vmw_crtc_state *vcs;
617
618
619 if (crtc->state) {
620 __drm_atomic_helper_crtc_destroy_state(crtc->state);
621
622 kfree(vmw_crtc_state_to_vcs(crtc->state));
623 }
624
625 vcs = kzalloc(sizeof(*vcs), GFP_KERNEL);
626
627 if (!vcs) {
628 DRM_ERROR("Cannot allocate vmw_crtc_state\n");
629 return;
630 }
631
> 632 __drm_atomic_helper_crtc_reset(crtc, &state->base);
633 }
634
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 48661 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>
Cc: Roland Scheidegger <sroland@vmware.com>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
VMware Graphics <linux-graphics-maintainer@vmware.com>,
kbuild-all@lists.01.org, Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [Intel-gfx] [PATCH 6/8] drm/vmwgfx: Use __drm_atomic_helper_crtc_reset
Date: Sat, 13 Jun 2020 07:21:43 +0800 [thread overview]
Message-ID: <202006130752.WFKm8kxc%lkp@intel.com> (raw)
In-Reply-To: <20200612160056.2082681-6-daniel.vetter@ffwll.ch>
[-- Attachment #1: Type: text/plain, Size: 3453 bytes --]
Hi Daniel,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.7 next-20200612]
[cannot apply to drm/drm-next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/drm-atomic-helper-reset-vblank-on-crtc-reset/20200613-000414
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-rhel-7.6 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c: In function 'vmw_du_primary_plane_atomic_check':
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:460:31: warning: variable 'vcs' set but not used [-Wunused-but-set-variable]
460 | struct vmw_connector_state *vcs;
| ^~~
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c: In function 'vmw_du_crtc_reset':
<< In file included from drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:37:
>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:632:40: error: 'state' undeclared (first use in this function); did you mean 'statx'?
632 | __drm_atomic_helper_crtc_reset(crtc, &state->base);
| ^~~~~
| statx
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:632:40: note: each undeclared identifier is reported only once for each function it appears in
In file included from drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:37:
At top level:
drivers/gpu/drm/vmwgfx/vmwgfx_kms.h:256:23: warning: 'vmw_cursor_plane_formats' defined but not used [-Wunused-const-variable=]
256 | static const uint32_t vmw_cursor_plane_formats[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/vmwgfx/vmwgfx_kms.h:248:23: warning: 'vmw_primary_plane_formats' defined but not used [-Wunused-const-variable=]
248 | static const uint32_t vmw_primary_plane_formats[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
vim +632 drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
604
605
606 /**
607 * vmw_du_crtc_reset - creates a blank vmw crtc state
608 * @crtc: DRM crtc
609 *
610 * Resets the atomic state for @crtc by freeing the state pointer (which
611 * might be NULL, e.g. at driver load time) and allocating a new empty state
612 * object.
613 */
614 void vmw_du_crtc_reset(struct drm_crtc *crtc)
615 {
616 struct vmw_crtc_state *vcs;
617
618
619 if (crtc->state) {
620 __drm_atomic_helper_crtc_destroy_state(crtc->state);
621
622 kfree(vmw_crtc_state_to_vcs(crtc->state));
623 }
624
625 vcs = kzalloc(sizeof(*vcs), GFP_KERNEL);
626
627 if (!vcs) {
628 DRM_ERROR("Cannot allocate vmw_crtc_state\n");
629 return;
630 }
631
> 632 __drm_atomic_helper_crtc_reset(crtc, &state->base);
633 }
634
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 48661 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 6/8] drm/vmwgfx: Use __drm_atomic_helper_crtc_reset
Date: Sat, 13 Jun 2020 07:21:43 +0800 [thread overview]
Message-ID: <202006130752.WFKm8kxc%lkp@intel.com> (raw)
In-Reply-To: <20200612160056.2082681-6-daniel.vetter@ffwll.ch>
[-- Attachment #1: Type: text/plain, Size: 3536 bytes --]
Hi Daniel,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.7 next-20200612]
[cannot apply to drm/drm-next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/drm-atomic-helper-reset-vblank-on-crtc-reset/20200613-000414
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-rhel-7.6 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c: In function 'vmw_du_primary_plane_atomic_check':
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:460:31: warning: variable 'vcs' set but not used [-Wunused-but-set-variable]
460 | struct vmw_connector_state *vcs;
| ^~~
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c: In function 'vmw_du_crtc_reset':
<< In file included from drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:37:
>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:632:40: error: 'state' undeclared (first use in this function); did you mean 'statx'?
632 | __drm_atomic_helper_crtc_reset(crtc, &state->base);
| ^~~~~
| statx
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:632:40: note: each undeclared identifier is reported only once for each function it appears in
In file included from drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:37:
At top level:
drivers/gpu/drm/vmwgfx/vmwgfx_kms.h:256:23: warning: 'vmw_cursor_plane_formats' defined but not used [-Wunused-const-variable=]
256 | static const uint32_t vmw_cursor_plane_formats[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/vmwgfx/vmwgfx_kms.h:248:23: warning: 'vmw_primary_plane_formats' defined but not used [-Wunused-const-variable=]
248 | static const uint32_t vmw_primary_plane_formats[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
vim +632 drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
604
605
606 /**
607 * vmw_du_crtc_reset - creates a blank vmw crtc state
608 * @crtc: DRM crtc
609 *
610 * Resets the atomic state for @crtc by freeing the state pointer (which
611 * might be NULL, e.g. at driver load time) and allocating a new empty state
612 * object.
613 */
614 void vmw_du_crtc_reset(struct drm_crtc *crtc)
615 {
616 struct vmw_crtc_state *vcs;
617
618
619 if (crtc->state) {
620 __drm_atomic_helper_crtc_destroy_state(crtc->state);
621
622 kfree(vmw_crtc_state_to_vcs(crtc->state));
623 }
624
625 vcs = kzalloc(sizeof(*vcs), GFP_KERNEL);
626
627 if (!vcs) {
628 DRM_ERROR("Cannot allocate vmw_crtc_state\n");
629 return;
630 }
631
> 632 __drm_atomic_helper_crtc_reset(crtc, &state->base);
633 }
634
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 48661 bytes --]
next prev parent reply other threads:[~2020-06-12 23:22 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 16:00 [PATCH 1/8] drm/atomic-helper: reset vblank on crtc reset Daniel Vetter
2020-06-12 16:00 ` [Intel-gfx] " Daniel Vetter
2020-06-12 16:00 ` Daniel Vetter
2020-06-12 16:00 ` Daniel Vetter
2020-06-12 16:00 ` Daniel Vetter
2020-06-12 16:00 ` [PATCH 2/8] drm/amdgpu: Use __drm_atomic_helper_crtc_reset Daniel Vetter
2020-06-12 16:00 ` [Intel-gfx] " Daniel Vetter
2020-06-12 17:24 ` Harry Wentland
2020-06-12 17:24 ` [Intel-gfx] " Harry Wentland
2020-06-12 17:41 ` Alex Deucher
2020-06-12 17:41 ` [Intel-gfx] " Alex Deucher
2020-07-02 18:21 ` Daniel Vetter
2020-07-02 18:21 ` [Intel-gfx] " Daniel Vetter
2020-06-12 16:00 ` [PATCH 3/8] drm/imx: " Daniel Vetter
2020-06-12 16:00 ` [Intel-gfx] " Daniel Vetter
2020-06-12 16:00 ` Daniel Vetter
2020-06-24 7:25 ` Daniel Vetter
2020-06-24 7:25 ` [Intel-gfx] " Daniel Vetter
2020-06-24 7:25 ` Daniel Vetter
2020-07-02 9:41 ` Daniel Vetter
2020-07-02 9:41 ` [Intel-gfx] " Daniel Vetter
2020-07-02 9:41 ` Daniel Vetter
2020-07-02 10:12 ` Philipp Zabel
2020-07-02 10:12 ` [Intel-gfx] " Philipp Zabel
2020-07-02 10:12 ` Philipp Zabel
2020-06-12 16:00 ` [PATCH 4/8] drm/mtk: " Daniel Vetter
2020-06-12 16:00 ` [Intel-gfx] " Daniel Vetter
2020-06-12 16:00 ` Daniel Vetter
2020-06-12 16:00 ` Daniel Vetter
2020-06-23 16:01 ` Chun-Kuang Hu
2020-06-23 16:01 ` [Intel-gfx] " Chun-Kuang Hu
2020-06-23 16:01 ` Chun-Kuang Hu
2020-06-23 16:01 ` Chun-Kuang Hu
2020-06-12 16:00 ` [PATCH 5/8] drm/vc4: " Daniel Vetter
2020-06-12 16:00 ` [Intel-gfx] " Daniel Vetter
2020-06-24 8:49 ` Maxime Ripard
2020-06-24 8:49 ` [Intel-gfx] " Maxime Ripard
2020-06-12 16:00 ` [PATCH 6/8] drm/vmwgfx: " Daniel Vetter
2020-06-12 16:00 ` [Intel-gfx] " Daniel Vetter
2020-06-12 20:32 ` kernel test robot
2020-06-12 20:32 ` kernel test robot
2020-06-12 20:32 ` [Intel-gfx] " kernel test robot
2020-06-12 20:49 ` [PATCH] " Daniel Vetter
2020-06-12 20:49 ` [Intel-gfx] " Daniel Vetter
2020-06-22 14:31 ` Roland Scheidegger
2020-06-12 23:21 ` kernel test robot [this message]
2020-06-12 23:21 ` [PATCH 6/8] " kernel test robot
2020-06-12 23:21 ` [Intel-gfx] " kernel test robot
2020-06-12 16:00 ` [PATCH 7/8] drm/mipi-dbi: Remove ->enabled Daniel Vetter
2020-06-12 16:00 ` [Intel-gfx] " Daniel Vetter
2020-06-13 13:42 ` Noralf Trønnes
2020-06-13 13:42 ` [Intel-gfx] " Noralf Trønnes
2020-06-13 18:47 ` David Lechner
2020-06-13 18:47 ` [Intel-gfx] " David Lechner
2020-06-15 21:31 ` Emil Velikov
2020-06-15 21:31 ` Emil Velikov
2020-06-16 6:50 ` Daniel Vetter
2020-06-16 6:50 ` Daniel Vetter
2020-06-16 13:54 ` Emil Velikov
2020-06-16 13:54 ` Emil Velikov
2020-06-16 17:16 ` Daniel Vetter
2020-06-16 17:16 ` Daniel Vetter
2020-06-24 7:18 ` Daniel Vetter
2020-06-24 7:18 ` Daniel Vetter
2020-06-12 16:00 ` [PATCH 8/8] drm/tiny/repaper: Drop edp->enabled Daniel Vetter
2020-06-12 16:00 ` [Intel-gfx] " Daniel Vetter
2020-06-13 13:43 ` Noralf Trønnes
2020-06-13 13:43 ` [Intel-gfx] " Noralf Trønnes
2020-06-24 7:15 ` Daniel Vetter
2020-06-24 7:15 ` [Intel-gfx] " Daniel Vetter
2020-06-12 16:27 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/8] drm/atomic-helper: reset vblank on crtc reset Patchwork
2020-06-12 16:27 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-06-12 16:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-06-12 18:04 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-06-12 22:02 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/8] drm/atomic-helper: reset vblank on crtc reset (rev2) Patchwork
2020-06-12 22:02 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-06-12 22:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-06-13 0:24 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
[not found] ` <20200612160056.2082681-1-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2020-06-24 9:42 ` [PATCH 1/8] drm/atomic-helper: reset vblank on crtc reset Maxime Ripard
2020-06-24 9:42 ` [Intel-gfx] " Maxime Ripard
2020-06-24 9:42 ` Maxime Ripard
2020-06-24 9:42 ` Maxime Ripard
2020-06-24 9:42 ` Maxime Ripard
2020-07-02 11:27 ` Laurent Pinchart
2020-07-02 11:27 ` [Intel-gfx] " Laurent Pinchart
2020-07-02 11:27 ` Laurent Pinchart
2020-07-02 11:27 ` Laurent Pinchart
2020-07-02 11:27 ` Laurent Pinchart
[not found] ` <20200702112722.GA18036-N3hz7ZxfLydczECFQUw77jytWr6r+dGw0E9HWUfgJXw@public.gmane.org>
2020-07-02 11:40 ` Daniel Vetter
2020-07-02 11:40 ` [Intel-gfx] " Daniel Vetter
2020-07-02 11:40 ` Daniel Vetter
2020-07-02 11:40 ` Daniel Vetter
2020-07-02 11:40 ` Daniel Vetter
2020-08-06 6:43 ` Tetsuo Handa
2020-08-06 6:43 ` [Intel-gfx] " Tetsuo Handa
2020-08-06 6:43 ` Tetsuo Handa
2020-08-06 6:43 ` Tetsuo Handa
2020-08-06 6:57 ` daniel
2020-08-06 6:57 ` [Intel-gfx] " daniel
2020-08-06 6:57 ` daniel
2020-08-06 6:57 ` daniel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202006130752.WFKm8kxc%lkp@intel.com \
--to=lkp@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-graphics-maintainer@vmware.com \
--cc=sroland@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.