From: Daniel Vetter <daniel.vetter@ffwll.ch> To: Emil Velikov <emil.l.velikov@gmail.com> Cc: David Lechner <david@lechnology.com>, David Airlie <airlied@linux.ie>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, DRI Development <dri-devel@lists.freedesktop.org>, Thomas Zimmermann <tzimmermann@suse.de>, Daniel Vetter <daniel.vetter@intel.com> Subject: Re: [Intel-gfx] [PATCH 7/8] drm/mipi-dbi: Remove ->enabled Date: Tue, 16 Jun 2020 08:50:06 +0200 [thread overview] Message-ID: <CAKMK7uEEkH+8BuFcFUVTv6p8swZZTwcho-HNx5GdZTO1vHDoeg@mail.gmail.com> (raw) In-Reply-To: <CACvgo51AVVOxhGK2Uin=ZLgPpihJiEsnc6pvAyKqFKPvLdOzLA@mail.gmail.com> On Mon, Jun 15, 2020 at 11:35 PM Emil Velikov <emil.l.velikov@gmail.com> wrote: > > Hi Daniel, > > On Fri, 12 Jun 2020 at 17:01, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > > > > The atomic helpers try really hard to not lose track of things, > > duplicating enabled tracking in the driver is at best confusing. > > Double-enabling or disabling is a bug in atomic helpers. > > > > In the fb_dirty function we can just assume that the fb always exists, > > simple display pipe helpers guarantee that the crtc is only enabled > > together with the output, so we always have a primary plane around. > > > > Now in the update function we need to be a notch more careful, since > > that can also get called when the crtc is off. And we don't want to > > upload frames when that's the case, so filter that out too. > > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > Cc: Maxime Ripard <mripard@kernel.org> > > Cc: Thomas Zimmermann <tzimmermann@suse.de> > > Cc: David Airlie <airlied@linux.ie> > > Cc: Daniel Vetter <daniel@ffwll.ch> > > Cc: David Lechner <david@lechnology.com> > > --- > > drivers/gpu/drm/drm_mipi_dbi.c | 16 ++++++---------- > > drivers/gpu/drm/tiny/ili9225.c | 12 +++--------- > > drivers/gpu/drm/tiny/st7586.c | 11 +++-------- > > include/drm/drm_mipi_dbi.h | 5 ----- > > 4 files changed, 12 insertions(+), 32 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_mipi_dbi.c b/drivers/gpu/drm/drm_mipi_dbi.c > > index fd8d672972a9..79532b9a324a 100644 > > --- a/drivers/gpu/drm/drm_mipi_dbi.c > > +++ b/drivers/gpu/drm/drm_mipi_dbi.c > > @@ -268,7 +268,7 @@ static void mipi_dbi_fb_dirty(struct drm_framebuffer *fb, struct drm_rect *rect) > > bool full; > > void *tr; > > > > - if (!dbidev->enabled) > > + if (WARN_ON(!fb)) > > return; > > > AFAICT no other driver has such WARN_ON. Let's drop that - it is > pretty confusing and misleading as-is. Yeah, this is a helper library which might be used wrongly by drivers. That's why I put it in - if you don't put all the various calls together correctly, this should at least catch one case. So really would like to keep this, can I convince you? -Daniel > With that, patches 7/8 and 8/8 are: > Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com> > > -Emil -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel.vetter@ffwll.ch> To: Emil Velikov <emil.l.velikov@gmail.com> Cc: David Lechner <david@lechnology.com>, David Airlie <airlied@linux.ie>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Maxime Ripard <mripard@kernel.org>, DRI Development <dri-devel@lists.freedesktop.org>, Thomas Zimmermann <tzimmermann@suse.de>, Daniel Vetter <daniel.vetter@intel.com> Subject: Re: [Intel-gfx] [PATCH 7/8] drm/mipi-dbi: Remove ->enabled Date: Tue, 16 Jun 2020 08:50:06 +0200 [thread overview] Message-ID: <CAKMK7uEEkH+8BuFcFUVTv6p8swZZTwcho-HNx5GdZTO1vHDoeg@mail.gmail.com> (raw) In-Reply-To: <CACvgo51AVVOxhGK2Uin=ZLgPpihJiEsnc6pvAyKqFKPvLdOzLA@mail.gmail.com> On Mon, Jun 15, 2020 at 11:35 PM Emil Velikov <emil.l.velikov@gmail.com> wrote: > > Hi Daniel, > > On Fri, 12 Jun 2020 at 17:01, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > > > > The atomic helpers try really hard to not lose track of things, > > duplicating enabled tracking in the driver is at best confusing. > > Double-enabling or disabling is a bug in atomic helpers. > > > > In the fb_dirty function we can just assume that the fb always exists, > > simple display pipe helpers guarantee that the crtc is only enabled > > together with the output, so we always have a primary plane around. > > > > Now in the update function we need to be a notch more careful, since > > that can also get called when the crtc is off. And we don't want to > > upload frames when that's the case, so filter that out too. > > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > Cc: Maxime Ripard <mripard@kernel.org> > > Cc: Thomas Zimmermann <tzimmermann@suse.de> > > Cc: David Airlie <airlied@linux.ie> > > Cc: Daniel Vetter <daniel@ffwll.ch> > > Cc: David Lechner <david@lechnology.com> > > --- > > drivers/gpu/drm/drm_mipi_dbi.c | 16 ++++++---------- > > drivers/gpu/drm/tiny/ili9225.c | 12 +++--------- > > drivers/gpu/drm/tiny/st7586.c | 11 +++-------- > > include/drm/drm_mipi_dbi.h | 5 ----- > > 4 files changed, 12 insertions(+), 32 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_mipi_dbi.c b/drivers/gpu/drm/drm_mipi_dbi.c > > index fd8d672972a9..79532b9a324a 100644 > > --- a/drivers/gpu/drm/drm_mipi_dbi.c > > +++ b/drivers/gpu/drm/drm_mipi_dbi.c > > @@ -268,7 +268,7 @@ static void mipi_dbi_fb_dirty(struct drm_framebuffer *fb, struct drm_rect *rect) > > bool full; > > void *tr; > > > > - if (!dbidev->enabled) > > + if (WARN_ON(!fb)) > > return; > > > AFAICT no other driver has such WARN_ON. Let's drop that - it is > pretty confusing and misleading as-is. Yeah, this is a helper library which might be used wrongly by drivers. That's why I put it in - if you don't put all the various calls together correctly, this should at least catch one case. So really would like to keep this, can I convince you? -Daniel > With that, patches 7/8 and 8/8 are: > Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com> > > -Emil -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-06-16 6:50 UTC|newest] Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-12 16:00 [PATCH 1/8] drm/atomic-helper: reset vblank on crtc reset Daniel Vetter 2020-06-12 16:00 ` [Intel-gfx] " Daniel Vetter 2020-06-12 16:00 ` Daniel Vetter 2020-06-12 16:00 ` Daniel Vetter 2020-06-12 16:00 ` Daniel Vetter 2020-06-12 16:00 ` [PATCH 2/8] drm/amdgpu: Use __drm_atomic_helper_crtc_reset Daniel Vetter 2020-06-12 16:00 ` [Intel-gfx] " Daniel Vetter 2020-06-12 17:24 ` Harry Wentland 2020-06-12 17:24 ` [Intel-gfx] " Harry Wentland 2020-06-12 17:41 ` Alex Deucher 2020-06-12 17:41 ` [Intel-gfx] " Alex Deucher 2020-07-02 18:21 ` Daniel Vetter 2020-07-02 18:21 ` [Intel-gfx] " Daniel Vetter 2020-06-12 16:00 ` [PATCH 3/8] drm/imx: " Daniel Vetter 2020-06-12 16:00 ` [Intel-gfx] " Daniel Vetter 2020-06-12 16:00 ` Daniel Vetter 2020-06-24 7:25 ` Daniel Vetter 2020-06-24 7:25 ` [Intel-gfx] " Daniel Vetter 2020-06-24 7:25 ` Daniel Vetter 2020-07-02 9:41 ` Daniel Vetter 2020-07-02 9:41 ` [Intel-gfx] " Daniel Vetter 2020-07-02 9:41 ` Daniel Vetter 2020-07-02 10:12 ` Philipp Zabel 2020-07-02 10:12 ` [Intel-gfx] " Philipp Zabel 2020-07-02 10:12 ` Philipp Zabel 2020-06-12 16:00 ` [PATCH 4/8] drm/mtk: " Daniel Vetter 2020-06-12 16:00 ` [Intel-gfx] " Daniel Vetter 2020-06-12 16:00 ` Daniel Vetter 2020-06-12 16:00 ` Daniel Vetter 2020-06-23 16:01 ` Chun-Kuang Hu 2020-06-23 16:01 ` [Intel-gfx] " Chun-Kuang Hu 2020-06-23 16:01 ` Chun-Kuang Hu 2020-06-23 16:01 ` Chun-Kuang Hu 2020-06-12 16:00 ` [PATCH 5/8] drm/vc4: " Daniel Vetter 2020-06-12 16:00 ` [Intel-gfx] " Daniel Vetter 2020-06-24 8:49 ` Maxime Ripard 2020-06-24 8:49 ` [Intel-gfx] " Maxime Ripard 2020-06-12 16:00 ` [PATCH 6/8] drm/vmwgfx: " Daniel Vetter 2020-06-12 16:00 ` [Intel-gfx] " Daniel Vetter 2020-06-12 20:32 ` kernel test robot 2020-06-12 20:32 ` kernel test robot 2020-06-12 20:32 ` [Intel-gfx] " kernel test robot 2020-06-12 20:49 ` [PATCH] " Daniel Vetter 2020-06-12 20:49 ` [Intel-gfx] " Daniel Vetter 2020-06-22 14:31 ` Roland Scheidegger 2020-06-12 23:21 ` [PATCH 6/8] " kernel test robot 2020-06-12 23:21 ` kernel test robot 2020-06-12 23:21 ` [Intel-gfx] " kernel test robot 2020-06-12 16:00 ` [PATCH 7/8] drm/mipi-dbi: Remove ->enabled Daniel Vetter 2020-06-12 16:00 ` [Intel-gfx] " Daniel Vetter 2020-06-13 13:42 ` Noralf Trønnes 2020-06-13 13:42 ` [Intel-gfx] " Noralf Trønnes 2020-06-13 18:47 ` David Lechner 2020-06-13 18:47 ` [Intel-gfx] " David Lechner 2020-06-15 21:31 ` Emil Velikov 2020-06-15 21:31 ` Emil Velikov 2020-06-16 6:50 ` Daniel Vetter [this message] 2020-06-16 6:50 ` Daniel Vetter 2020-06-16 13:54 ` Emil Velikov 2020-06-16 13:54 ` Emil Velikov 2020-06-16 17:16 ` Daniel Vetter 2020-06-16 17:16 ` Daniel Vetter 2020-06-24 7:18 ` Daniel Vetter 2020-06-24 7:18 ` Daniel Vetter 2020-06-12 16:00 ` [PATCH 8/8] drm/tiny/repaper: Drop edp->enabled Daniel Vetter 2020-06-12 16:00 ` [Intel-gfx] " Daniel Vetter 2020-06-13 13:43 ` Noralf Trønnes 2020-06-13 13:43 ` [Intel-gfx] " Noralf Trønnes 2020-06-24 7:15 ` Daniel Vetter 2020-06-24 7:15 ` [Intel-gfx] " Daniel Vetter 2020-06-12 16:27 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/8] drm/atomic-helper: reset vblank on crtc reset Patchwork 2020-06-12 16:27 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2020-06-12 16:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2020-06-12 18:04 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2020-06-12 22:02 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/8] drm/atomic-helper: reset vblank on crtc reset (rev2) Patchwork 2020-06-12 22:02 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2020-06-12 22:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2020-06-13 0:24 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork [not found] ` <20200612160056.2082681-1-daniel.vetter-/w4YWyX8dFk@public.gmane.org> 2020-06-24 9:42 ` [PATCH 1/8] drm/atomic-helper: reset vblank on crtc reset Maxime Ripard 2020-06-24 9:42 ` [Intel-gfx] " Maxime Ripard 2020-06-24 9:42 ` Maxime Ripard 2020-06-24 9:42 ` Maxime Ripard 2020-06-24 9:42 ` Maxime Ripard 2020-07-02 11:27 ` Laurent Pinchart 2020-07-02 11:27 ` [Intel-gfx] " Laurent Pinchart 2020-07-02 11:27 ` Laurent Pinchart 2020-07-02 11:27 ` Laurent Pinchart 2020-07-02 11:27 ` Laurent Pinchart [not found] ` <20200702112722.GA18036-N3hz7ZxfLydczECFQUw77jytWr6r+dGw0E9HWUfgJXw@public.gmane.org> 2020-07-02 11:40 ` Daniel Vetter 2020-07-02 11:40 ` [Intel-gfx] " Daniel Vetter 2020-07-02 11:40 ` Daniel Vetter 2020-07-02 11:40 ` Daniel Vetter 2020-07-02 11:40 ` Daniel Vetter 2020-08-06 6:43 ` Tetsuo Handa 2020-08-06 6:43 ` [Intel-gfx] " Tetsuo Handa 2020-08-06 6:43 ` Tetsuo Handa 2020-08-06 6:43 ` Tetsuo Handa 2020-08-06 6:57 ` daniel 2020-08-06 6:57 ` [Intel-gfx] " daniel 2020-08-06 6:57 ` daniel 2020-08-06 6:57 ` daniel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAKMK7uEEkH+8BuFcFUVTv6p8swZZTwcho-HNx5GdZTO1vHDoeg@mail.gmail.com \ --to=daniel.vetter@ffwll.ch \ --cc=airlied@linux.ie \ --cc=daniel.vetter@intel.com \ --cc=david@lechnology.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=emil.l.velikov@gmail.com \ --cc=intel-gfx@lists.freedesktop.org \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.