All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Mike Rapoport <rppt@linux.ibm.com>,
	Dmitry Safonov <0x7f454c46@gmail.com>,
	Guenter Roeck <linux@roeck-us.net>,
	linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH v2 3/9] Revert "sh: remove needless printk()"
Date: Wed, 17 Jun 2020 14:36:33 +0000	[thread overview]
Message-ID: <20200617143639.18315-4-geert+renesas@glider.be> (raw)
In-Reply-To: <20200617143639.18315-1-geert+renesas@glider.be>

This reverts commit 8b92f34877225c8eb85e3ab7f1177fc248ba26d0.

"data" became the log level in commit 539e786cc37ee5cb ("sh: add loglvl
to show_trace()"), so we do need to keep the printk() before the
continuation in print_trace_address().

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - New.
---
 arch/sh/kernel/dumpstack.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/sh/kernel/dumpstack.c b/arch/sh/kernel/dumpstack.c
index ad548fc976350c50..cc8063a01284bf64 100644
--- a/arch/sh/kernel/dumpstack.c
+++ b/arch/sh/kernel/dumpstack.c
@@ -118,6 +118,7 @@ static int print_trace_stack(void *data, char *name)
  */
 static void print_trace_address(void *data, unsigned long addr, int reliable)
 {
+	printk("%s", (char *)data);
 	printk_address(addr, reliable);
 }
 
-- 
2.17.1

WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Mike Rapoport <rppt@linux.ibm.com>,
	Dmitry Safonov <0x7f454c46@gmail.com>,
	Guenter Roeck <linux@roeck-us.net>,
	linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH v2 3/9] Revert "sh: remove needless printk()"
Date: Wed, 17 Jun 2020 16:36:33 +0200	[thread overview]
Message-ID: <20200617143639.18315-4-geert+renesas@glider.be> (raw)
In-Reply-To: <20200617143639.18315-1-geert+renesas@glider.be>

This reverts commit 8b92f34877225c8eb85e3ab7f1177fc248ba26d0.

"data" became the log level in commit 539e786cc37ee5cb ("sh: add loglvl
to show_trace()"), so we do need to keep the printk() before the
continuation in print_trace_address().

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - New.
---
 arch/sh/kernel/dumpstack.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/sh/kernel/dumpstack.c b/arch/sh/kernel/dumpstack.c
index ad548fc976350c50..cc8063a01284bf64 100644
--- a/arch/sh/kernel/dumpstack.c
+++ b/arch/sh/kernel/dumpstack.c
@@ -118,6 +118,7 @@ static int print_trace_stack(void *data, char *name)
  */
 static void print_trace_address(void *data, unsigned long addr, int reliable)
 {
+	printk("%s", (char *)data);
 	printk_address(addr, reliable);
 }
 
-- 
2.17.1


  parent reply	other threads:[~2020-06-17 14:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-17 14:36 [PATCH v2 0/9] sh: Modernize printing of kernel messages Geert Uytterhoeven
2020-06-17 14:36 ` Geert Uytterhoeven
2020-06-17 14:36 ` [PATCH v2 1/9] sh: fault: Fix duplicate printing of "PC:" Geert Uytterhoeven
2020-06-17 14:36   ` Geert Uytterhoeven
2020-06-17 14:36 ` [PATCH v2 2/9] Revert "sh: add loglvl to printk_address()" Geert Uytterhoeven
2020-06-17 14:36   ` Geert Uytterhoeven
2020-06-17 14:36 ` Geert Uytterhoeven [this message]
2020-06-17 14:36   ` [PATCH v2 3/9] Revert "sh: remove needless printk()" Geert Uytterhoeven
2020-06-17 14:36 ` [PATCH v2 4/9] sh: kernel: disassemble: Fix broken lines in disassembly dumps Geert Uytterhoeven
2020-06-17 14:36   ` Geert Uytterhoeven
2020-06-17 14:36 ` [PATCH v2 5/9] sh: dump_stack: Fix broken lines and ptrval in calltrace dumps Geert Uytterhoeven
2020-06-17 14:36   ` Geert Uytterhoeven
2020-06-17 14:36 ` [PATCH v2 6/9] sh: process: Fix broken lines in register dumps Geert Uytterhoeven
2020-06-17 14:36   ` Geert Uytterhoeven
2020-06-17 14:36 ` [PATCH v2 7/9] sh: sh2007: Modernize printing of kernel messages Geert Uytterhoeven
2020-06-17 14:36   ` Geert Uytterhoeven
2020-06-17 14:36 ` [PATCH v2 8/9] sh: pci: " Geert Uytterhoeven
2020-06-17 14:36   ` Geert Uytterhoeven
2020-06-17 14:36 ` [PATCH v2 9/9] sh: machvec: " Geert Uytterhoeven
2020-06-17 14:36   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200617143639.18315-4-geert+renesas@glider.be \
    --to=geert+renesas@glider.be \
    --cc=0x7f454c46@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=dalias@libc.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=rppt@linux.ibm.com \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.