From: Alex Riesen <alexander.riesen@cetitec.com> To: Kieran Bingham <kieran.bingham@ideasonboard.com> Cc: Geert Uytterhoeven <geert@linux-m68k.org>, Mauro Carvalho Chehab <mchehab@kernel.org>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>, devel@driverdev.osuosl.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v5 7/9] media: adv748x: only activate DAI if it is described in device tree Date: Fri, 19 Jun 2020 11:10:52 +0200 [thread overview] Message-ID: <20200619091052.GB7780@pflmari> (raw) In-Reply-To: <c752ea76-c8da-c77a-104f-9163230cc08a@ideasonboard.com> Kieran Bingham, Thu, Jun 18, 2020 18:17:04 +0200: > On 02/04/2020 19:34, Alex Riesen wrote: > > To avoid setting it up even if the hardware is not actually connected > > to anything physically. > > > > Besides, the bindings explicitly notes that port definitions are > > "optional if they are not connected to anything at the hardware level". > > > > Signed-off-by: Alexander Riesen <alexander.riesen@cetitec.com> > > --- > > drivers/media/i2c/adv748x/adv748x-dai.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/media/i2c/adv748x/adv748x-dai.c b/drivers/media/i2c/adv748x/adv748x-dai.c > > index 185f78023e91..f9cc47fa9ad1 100644 > > --- a/drivers/media/i2c/adv748x/adv748x-dai.c > > +++ b/drivers/media/i2c/adv748x/adv748x-dai.c > > @@ -216,6 +216,11 @@ int adv748x_dai_init(struct adv748x_dai *dai) > > int ret; > > struct adv748x_state *state = adv748x_dai_to_state(dai); > > > > + if (!state->endpoints[ADV748X_PORT_I2S]) { > > + adv_info(state, "no I2S port, DAI disabled\n"); > > + ret = 0; > > + goto fail; > > How about just 'return 0'? Indeed. In the retrospect, the whole event of loading the DAI driver does not feel that important anymore to warrant logging on info prio. > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > This could also be folded into 5/9 too I guess?, though it is easier to > review the sequential additions, rather than the one-big-feature > addition ;-) I would prefer to have it separately, if you don't mind: maybe not a big one, but loading a driver without hardware for it *is* an event. Thanks, Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alex Riesen <alexander.riesen@cetitec.com> To: Kieran Bingham <kieran.bingham@ideasonboard.com> Cc: Mark Rutland <mark.rutland@arm.com>, devel@driverdev.osuosl.org, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Geert Uytterhoeven <geert@linux-m68k.org>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Mauro Carvalho Chehab <mchehab@kernel.org>, linux-media@vger.kernel.org Subject: Re: [PATCH v5 7/9] media: adv748x: only activate DAI if it is described in device tree Date: Fri, 19 Jun 2020 11:10:52 +0200 [thread overview] Message-ID: <20200619091052.GB7780@pflmari> (raw) In-Reply-To: <c752ea76-c8da-c77a-104f-9163230cc08a@ideasonboard.com> Kieran Bingham, Thu, Jun 18, 2020 18:17:04 +0200: > On 02/04/2020 19:34, Alex Riesen wrote: > > To avoid setting it up even if the hardware is not actually connected > > to anything physically. > > > > Besides, the bindings explicitly notes that port definitions are > > "optional if they are not connected to anything at the hardware level". > > > > Signed-off-by: Alexander Riesen <alexander.riesen@cetitec.com> > > --- > > drivers/media/i2c/adv748x/adv748x-dai.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/media/i2c/adv748x/adv748x-dai.c b/drivers/media/i2c/adv748x/adv748x-dai.c > > index 185f78023e91..f9cc47fa9ad1 100644 > > --- a/drivers/media/i2c/adv748x/adv748x-dai.c > > +++ b/drivers/media/i2c/adv748x/adv748x-dai.c > > @@ -216,6 +216,11 @@ int adv748x_dai_init(struct adv748x_dai *dai) > > int ret; > > struct adv748x_state *state = adv748x_dai_to_state(dai); > > > > + if (!state->endpoints[ADV748X_PORT_I2S]) { > > + adv_info(state, "no I2S port, DAI disabled\n"); > > + ret = 0; > > + goto fail; > > How about just 'return 0'? Indeed. In the retrospect, the whole event of loading the DAI driver does not feel that important anymore to warrant logging on info prio. > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > This could also be folded into 5/9 too I guess?, though it is easier to > review the sequential additions, rather than the one-big-feature > addition ;-) I would prefer to have it separately, if you don't mind: maybe not a big one, but loading a driver without hardware for it *is* an event. Thanks, Alex _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-06-19 9:11 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-02 18:33 [PATCH v5 0/9] media: adv748x: add support for HDMI audio Alex Riesen 2020-04-02 18:33 ` Alex Riesen 2020-04-02 18:34 ` [PATCH v5 1/9] media: adv748x: fix end-of-line terminators in diagnostic statements Alex Riesen 2020-04-02 18:34 ` Alex Riesen 2020-04-03 10:43 ` Kieran Bingham 2020-04-03 10:43 ` Kieran Bingham 2020-04-03 11:01 ` Alex Riesen 2020-04-03 11:01 ` Alex Riesen 2020-04-02 18:34 ` [PATCH v5 2/9] media: adv748x: include everything adv748x.h needs into the file Alex Riesen 2020-04-02 18:34 ` Alex Riesen 2020-04-03 10:48 ` Kieran Bingham 2020-04-03 10:48 ` Kieran Bingham 2020-04-03 11:02 ` Alex Riesen 2020-04-03 11:02 ` Alex Riesen 2020-04-02 18:34 ` [PATCH v5 3/9] media: adv748x: reduce amount of code for bitwise modifications of device registers Alex Riesen 2020-04-02 18:34 ` Alex Riesen 2020-04-03 19:09 ` Kieran Bingham 2020-04-03 19:09 ` Kieran Bingham 2020-04-02 18:34 ` [PATCH v5 4/9] media: adv748x: add definitions for audio output related registers Alex Riesen 2020-04-02 18:34 ` Alex Riesen 2020-04-07 16:21 ` Kieran Bingham 2020-04-07 16:21 ` Kieran Bingham 2020-04-07 17:13 ` Alex Riesen 2020-04-07 17:13 ` Alex Riesen 2020-04-07 18:44 ` Kieran Bingham 2020-04-07 18:44 ` Kieran Bingham 2020-04-07 18:55 ` Alex Riesen 2020-04-07 18:55 ` Alex Riesen 2020-04-02 18:34 ` [PATCH v5 5/9] media: adv748x: add support for HDMI audio Alex Riesen 2020-04-02 18:34 ` Alex Riesen 2020-04-02 18:34 ` [PATCH v5 6/9] media: adv748x: prepare/enable mclk when the audio is used Alex Riesen 2020-04-02 18:34 ` Alex Riesen 2020-06-18 16:23 ` Kieran Bingham 2020-06-18 16:23 ` Kieran Bingham 2020-06-19 8:51 ` Alex Riesen 2020-06-19 8:51 ` Alex Riesen 2020-04-02 18:34 ` [PATCH v5 7/9] media: adv748x: only activate DAI if it is described in device tree Alex Riesen 2020-04-02 18:34 ` Alex Riesen 2020-06-18 16:17 ` Kieran Bingham 2020-06-18 16:17 ` Kieran Bingham 2020-06-19 9:10 ` Alex Riesen [this message] 2020-06-19 9:10 ` Alex Riesen 2020-04-02 18:35 ` [PATCH v5 8/9] dt-bindings: adv748x: add information about serial audio interface (I2S/TDM) Alex Riesen 2020-04-02 18:35 ` Alex Riesen 2020-06-18 16:27 ` Kieran Bingham 2020-06-18 16:27 ` Kieran Bingham 2020-04-02 18:35 ` [PATCH v5 9/9] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC Alex Riesen 2020-04-02 18:35 ` Alex Riesen 2020-06-18 16:32 ` Kieran Bingham 2020-06-18 16:32 ` Kieran Bingham 2020-06-19 9:34 ` Alex Riesen 2020-06-19 9:34 ` Alex Riesen 2020-08-25 14:57 ` Kieran Bingham 2020-08-25 14:57 ` Kieran Bingham 2020-09-14 8:17 ` Alex Riesen 2020-09-14 8:17 ` Alex Riesen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200619091052.GB7780@pflmari \ --to=alexander.riesen@cetitec.com \ --cc=devel@driverdev.osuosl.org \ --cc=devicetree@vger.kernel.org \ --cc=geert@linux-m68k.org \ --cc=hverkuil-cisco@xs4all.nl \ --cc=kieran.bingham@ideasonboard.com \ --cc=kuninori.morimoto.gx@renesas.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mchehab@kernel.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.