From: Alex Riesen <alexander.riesen@cetitec.com> To: Kieran Bingham <kieran.bingham@ideasonboard.com> Cc: Geert Uytterhoeven <geert@linux-m68k.org>, Mauro Carvalho Chehab <mchehab@kernel.org>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>, devel@driverdev.osuosl.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v5 9/9] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC Date: Mon, 14 Sep 2020 10:17:21 +0200 [thread overview] Message-ID: <20200914081721.GA4705@pflmari> (raw) In-Reply-To: <c7d93d6c-4893-8bd0-5859-87f30389b5d5@ideasonboard.com> Hi Kieran, Kieran Bingham, Tue, Aug 25, 2020 16:57:04 +0200: > On 18/06/2020 17:32, Kieran Bingham wrote: > > On 02/04/2020 19:35, Alex Riesen wrote: > >> As all known variants of the Salvator board have the HDMI decoder > >> chip (the ADV7482) connected to the SSI4 on R-Car SoC, the ADV7482 > >> endpoint and the connection definitions are placed in the common board > >> file. > >> > >> For the same reason, the CLK_C clock line and I2C configuration (similar > >> to the ak4613, on the same interface) are added into the common file. > >> ... > >> --- > >> .../boot/dts/renesas/r8a77950-salvator-x.dts | 3 +- > >> arch/arm64/boot/dts/renesas/r8a77961.dtsi | 1 + > >> .../boot/dts/renesas/salvator-common.dtsi | 47 +++++++++++++++++-- > > Once again I'm back trying to test this series, and one issue I've had > is that the board I have (r8a77951-salvator-xs.dts) isn't included in > this DT update. > > For v6, Should we include the relevant changes to all the following? Ok. I shall add them as a separate patch though, as I have no way to verify those boards (and some verification seem to be in order...) > arch/arm64/boot/dts/renesas/r8a77950-salvator-x.dts > arch/arm64/boot/dts/renesas/r8a77951-salvator-x.dts > arch/arm64/boot/dts/renesas/r8a77960-salvator-x.dts > arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts > arch/arm64/boot/dts/renesas/salvator-x.dtsi > > And perhaps handle the salvator-xs in a second (yet very similar) patch? > > arch/arm64/boot/dts/renesas/r8a77951-salvator-xs.dts > arch/arm64/boot/dts/renesas/r8a77960-salvator-xs.dts > arch/arm64/boot/dts/renesas/r8a77961-salvator-xs.dts > arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts > arch/arm64/boot/dts/renesas/salvator-xs.dtsi > > I think I've added the relevant entries to my dtb, but I haven't > successfully captured audio yet. > > I can see the device being listed through arecord: > > kbingham@salvator-xs:~$ arecord -l > **** List of CAPTURE Hardware Devices **** > card 0: rcarsound [rcar-sound], device 0: rsnd-dai.0-ak4613-hifi ak4613-hifi-0 [] > Subdevices: 0/1 > Subdevice #0: subdevice #0 > card 0: rcarsound [rcar-sound], device 3: rsnd-dai.3-adv748x-i2s adv748x.4-0070-3 [] > Subdevices: 1/1 > Subdevice #0: subdevice #0 > > But as yet, everything I try to record fails or is empty silence. > > Debugging ... Does it fail somewhere in the ASoC infrastructure? If so, how'd you find out where exactly and what fails? Asking, because when I was writing this code I ended up adding quite a bit of tracing into the SoC core to figure that out, and I just hope there is a better way to get at the diagnostics. > >> diff --git a/arch/arm64/boot/dts/renesas/r8a77950-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a77950-salvator-x.dts > >> index 2438825c9b22..e16c146808b6 100644 > >> --- a/arch/arm64/boot/dts/renesas/r8a77950-salvator-x.dts > >> +++ b/arch/arm64/boot/dts/renesas/r8a77950-salvator-x.dts > >> @@ -146,7 +146,8 @@ &sata { > >> &sound_card { > >> dais = <&rsnd_port0 /* ak4613 */ > >> &rsnd_port1 /* HDMI0 */ > >> - &rsnd_port2>; /* HDMI1 */ > >> + &rsnd_port2 /* HDMI1 */ > >> + &rsnd_port3>; /* adv7482 hdmi-in */ > > > > Ah - that was confusing at first... but HDMI0 and HDMI1 are *outputs*, > > where of course the adv7482 is an input ;-) I shall add an "output" to HDMI0 and HDMI1. > > Otherwise, I can't spot anything else yet so: > > > > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Thanks! > > But I fear there may have been some churn around here, so it would be > > good to see a rebase too. Of course, I shall rebase on top of linux-media/master. Should I wait with submission until you get data out of your boards? Regards, Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alex Riesen <alexander.riesen@cetitec.com> To: Kieran Bingham <kieran.bingham@ideasonboard.com> Cc: Mark Rutland <mark.rutland@arm.com>, devel@driverdev.osuosl.org, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Geert Uytterhoeven <geert@linux-m68k.org>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Mauro Carvalho Chehab <mchehab@kernel.org>, linux-media@vger.kernel.org Subject: Re: [PATCH v5 9/9] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC Date: Mon, 14 Sep 2020 10:17:21 +0200 [thread overview] Message-ID: <20200914081721.GA4705@pflmari> (raw) In-Reply-To: <c7d93d6c-4893-8bd0-5859-87f30389b5d5@ideasonboard.com> Hi Kieran, Kieran Bingham, Tue, Aug 25, 2020 16:57:04 +0200: > On 18/06/2020 17:32, Kieran Bingham wrote: > > On 02/04/2020 19:35, Alex Riesen wrote: > >> As all known variants of the Salvator board have the HDMI decoder > >> chip (the ADV7482) connected to the SSI4 on R-Car SoC, the ADV7482 > >> endpoint and the connection definitions are placed in the common board > >> file. > >> > >> For the same reason, the CLK_C clock line and I2C configuration (similar > >> to the ak4613, on the same interface) are added into the common file. > >> ... > >> --- > >> .../boot/dts/renesas/r8a77950-salvator-x.dts | 3 +- > >> arch/arm64/boot/dts/renesas/r8a77961.dtsi | 1 + > >> .../boot/dts/renesas/salvator-common.dtsi | 47 +++++++++++++++++-- > > Once again I'm back trying to test this series, and one issue I've had > is that the board I have (r8a77951-salvator-xs.dts) isn't included in > this DT update. > > For v6, Should we include the relevant changes to all the following? Ok. I shall add them as a separate patch though, as I have no way to verify those boards (and some verification seem to be in order...) > arch/arm64/boot/dts/renesas/r8a77950-salvator-x.dts > arch/arm64/boot/dts/renesas/r8a77951-salvator-x.dts > arch/arm64/boot/dts/renesas/r8a77960-salvator-x.dts > arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts > arch/arm64/boot/dts/renesas/salvator-x.dtsi > > And perhaps handle the salvator-xs in a second (yet very similar) patch? > > arch/arm64/boot/dts/renesas/r8a77951-salvator-xs.dts > arch/arm64/boot/dts/renesas/r8a77960-salvator-xs.dts > arch/arm64/boot/dts/renesas/r8a77961-salvator-xs.dts > arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts > arch/arm64/boot/dts/renesas/salvator-xs.dtsi > > I think I've added the relevant entries to my dtb, but I haven't > successfully captured audio yet. > > I can see the device being listed through arecord: > > kbingham@salvator-xs:~$ arecord -l > **** List of CAPTURE Hardware Devices **** > card 0: rcarsound [rcar-sound], device 0: rsnd-dai.0-ak4613-hifi ak4613-hifi-0 [] > Subdevices: 0/1 > Subdevice #0: subdevice #0 > card 0: rcarsound [rcar-sound], device 3: rsnd-dai.3-adv748x-i2s adv748x.4-0070-3 [] > Subdevices: 1/1 > Subdevice #0: subdevice #0 > > But as yet, everything I try to record fails or is empty silence. > > Debugging ... Does it fail somewhere in the ASoC infrastructure? If so, how'd you find out where exactly and what fails? Asking, because when I was writing this code I ended up adding quite a bit of tracing into the SoC core to figure that out, and I just hope there is a better way to get at the diagnostics. > >> diff --git a/arch/arm64/boot/dts/renesas/r8a77950-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a77950-salvator-x.dts > >> index 2438825c9b22..e16c146808b6 100644 > >> --- a/arch/arm64/boot/dts/renesas/r8a77950-salvator-x.dts > >> +++ b/arch/arm64/boot/dts/renesas/r8a77950-salvator-x.dts > >> @@ -146,7 +146,8 @@ &sata { > >> &sound_card { > >> dais = <&rsnd_port0 /* ak4613 */ > >> &rsnd_port1 /* HDMI0 */ > >> - &rsnd_port2>; /* HDMI1 */ > >> + &rsnd_port2 /* HDMI1 */ > >> + &rsnd_port3>; /* adv7482 hdmi-in */ > > > > Ah - that was confusing at first... but HDMI0 and HDMI1 are *outputs*, > > where of course the adv7482 is an input ;-) I shall add an "output" to HDMI0 and HDMI1. > > Otherwise, I can't spot anything else yet so: > > > > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Thanks! > > But I fear there may have been some churn around here, so it would be > > good to see a rebase too. Of course, I shall rebase on top of linux-media/master. Should I wait with submission until you get data out of your boards? Regards, Alex _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-09-14 8:18 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-02 18:33 [PATCH v5 0/9] media: adv748x: add support for HDMI audio Alex Riesen 2020-04-02 18:33 ` Alex Riesen 2020-04-02 18:34 ` [PATCH v5 1/9] media: adv748x: fix end-of-line terminators in diagnostic statements Alex Riesen 2020-04-02 18:34 ` Alex Riesen 2020-04-03 10:43 ` Kieran Bingham 2020-04-03 10:43 ` Kieran Bingham 2020-04-03 11:01 ` Alex Riesen 2020-04-03 11:01 ` Alex Riesen 2020-04-02 18:34 ` [PATCH v5 2/9] media: adv748x: include everything adv748x.h needs into the file Alex Riesen 2020-04-02 18:34 ` Alex Riesen 2020-04-03 10:48 ` Kieran Bingham 2020-04-03 10:48 ` Kieran Bingham 2020-04-03 11:02 ` Alex Riesen 2020-04-03 11:02 ` Alex Riesen 2020-04-02 18:34 ` [PATCH v5 3/9] media: adv748x: reduce amount of code for bitwise modifications of device registers Alex Riesen 2020-04-02 18:34 ` Alex Riesen 2020-04-03 19:09 ` Kieran Bingham 2020-04-03 19:09 ` Kieran Bingham 2020-04-02 18:34 ` [PATCH v5 4/9] media: adv748x: add definitions for audio output related registers Alex Riesen 2020-04-02 18:34 ` Alex Riesen 2020-04-07 16:21 ` Kieran Bingham 2020-04-07 16:21 ` Kieran Bingham 2020-04-07 17:13 ` Alex Riesen 2020-04-07 17:13 ` Alex Riesen 2020-04-07 18:44 ` Kieran Bingham 2020-04-07 18:44 ` Kieran Bingham 2020-04-07 18:55 ` Alex Riesen 2020-04-07 18:55 ` Alex Riesen 2020-04-02 18:34 ` [PATCH v5 5/9] media: adv748x: add support for HDMI audio Alex Riesen 2020-04-02 18:34 ` Alex Riesen 2020-04-02 18:34 ` [PATCH v5 6/9] media: adv748x: prepare/enable mclk when the audio is used Alex Riesen 2020-04-02 18:34 ` Alex Riesen 2020-06-18 16:23 ` Kieran Bingham 2020-06-18 16:23 ` Kieran Bingham 2020-06-19 8:51 ` Alex Riesen 2020-06-19 8:51 ` Alex Riesen 2020-04-02 18:34 ` [PATCH v5 7/9] media: adv748x: only activate DAI if it is described in device tree Alex Riesen 2020-04-02 18:34 ` Alex Riesen 2020-06-18 16:17 ` Kieran Bingham 2020-06-18 16:17 ` Kieran Bingham 2020-06-19 9:10 ` Alex Riesen 2020-06-19 9:10 ` Alex Riesen 2020-04-02 18:35 ` [PATCH v5 8/9] dt-bindings: adv748x: add information about serial audio interface (I2S/TDM) Alex Riesen 2020-04-02 18:35 ` Alex Riesen 2020-06-18 16:27 ` Kieran Bingham 2020-06-18 16:27 ` Kieran Bingham 2020-04-02 18:35 ` [PATCH v5 9/9] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC Alex Riesen 2020-04-02 18:35 ` Alex Riesen 2020-06-18 16:32 ` Kieran Bingham 2020-06-18 16:32 ` Kieran Bingham 2020-06-19 9:34 ` Alex Riesen 2020-06-19 9:34 ` Alex Riesen 2020-08-25 14:57 ` Kieran Bingham 2020-08-25 14:57 ` Kieran Bingham 2020-09-14 8:17 ` Alex Riesen [this message] 2020-09-14 8:17 ` Alex Riesen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200914081721.GA4705@pflmari \ --to=alexander.riesen@cetitec.com \ --cc=devel@driverdev.osuosl.org \ --cc=devicetree@vger.kernel.org \ --cc=geert@linux-m68k.org \ --cc=hverkuil-cisco@xs4all.nl \ --cc=kieran.bingham@ideasonboard.com \ --cc=kuninori.morimoto.gx@renesas.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mchehab@kernel.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.