From: Arvind Sankar <nivedita@alum.mit.edu>
To: Kees Cook <keescook@chromium.org>
Cc: Will Deacon <will@kernel.org>, Fangrui Song <maskray@google.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ard Biesheuvel <ardb@kernel.org>,
Peter Collingbourne <pcc@google.com>,
James Morse <james.morse@arm.com>, Borislav Petkov <bp@suse.de>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Russell King <linux@armlinux.org.uk>,
Masahiro Yamada <masahiroy@kernel.org>,
Arvind Sankar <nivedita@alum.mit.edu>,
Nick Desaulniers <ndesaulniers@google.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
x86@kernel.org, clang-built-linux@googlegroups.com,
linux-arch@vger.kernel.org, linux-efi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/9] vmlinux.lds.h: Add .symtab, .strtab, and .shstrtab to STABS_DEBUG
Date: Wed, 24 Jun 2020 11:39:30 -0400 [thread overview]
Message-ID: <20200624153930.GA1337895@rani.riverdale.lan> (raw)
In-Reply-To: <20200624014940.1204448-3-keescook@chromium.org>
On Tue, Jun 23, 2020 at 06:49:33PM -0700, Kees Cook wrote:
> When linking vmlinux with LLD, the synthetic sections .symtab, .strtab,
> and .shstrtab are listed as orphaned. Add them to the STABS_DEBUG section
> so there will be no warnings when --orphan-handling=warn is used more
> widely. (They are added above comment as it is the more common
Nit 1: is "after .comment" better than "above comment"? It's above in the
sense of higher file offset, but it's below in readelf output.
Nit 2: These aren't actually debugging sections, no? Is it better to add
a new macro for it, and is there any plan to stop LLD from warning about
them?
> order[1].)
>
> ld.lld: warning: <internal>:(.symtab) is being placed in '.symtab'
> ld.lld: warning: <internal>:(.shstrtab) is being placed in '.shstrtab'
> ld.lld: warning: <internal>:(.strtab) is being placed in '.strtab'
>
> [1] https://lore.kernel.org/lkml/20200622224928.o2a7jkq33guxfci4@google.com/
>
> Reported-by: Fangrui Song <maskray@google.com>
> Reviewed-by: Fangrui Song <maskray@google.com>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> include/asm-generic/vmlinux.lds.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
> index 1248a206be8d..8e71757f485b 100644
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -792,7 +792,10 @@
> .stab.exclstr 0 : { *(.stab.exclstr) } \
> .stab.index 0 : { *(.stab.index) } \
> .stab.indexstr 0 : { *(.stab.indexstr) } \
> - .comment 0 : { *(.comment) }
> + .comment 0 : { *(.comment) } \
> + .symtab 0 : { *(.symtab) } \
> + .strtab 0 : { *(.strtab) } \
> + .shstrtab 0 : { *(.shstrtab) }
>
> #ifdef CONFIG_GENERIC_BUG
> #define BUG_TABLE \
> --
> 2.25.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Arvind Sankar <nivedita@alum.mit.edu>
To: Kees Cook <keescook@chromium.org>
Cc: Will Deacon <will@kernel.org>, Fangrui Song <maskray@google.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ard Biesheuvel <ardb@kernel.org>,
Peter Collingbourne <pcc@google.com>,
James Morse <james.morse@arm.com>, Borislav Petkov <bp@suse.de>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Russell King <linux@armlinux.org.uk>,
Masahiro Yamada <masahiroy@kernel.org>,
Arvind Sankar <nivedita@alum.mit.edu>,
Nick Desaulniers <ndesaulniers@google.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
x86@kernel.org, clang-built-linux@googlegroups.com,
linux-arch@vger.kernel.org, linux-efi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel
Subject: Re: [PATCH v3 2/9] vmlinux.lds.h: Add .symtab, .strtab, and .shstrtab to STABS_DEBUG
Date: Wed, 24 Jun 2020 11:39:30 -0400 [thread overview]
Message-ID: <20200624153930.GA1337895@rani.riverdale.lan> (raw)
In-Reply-To: <20200624014940.1204448-3-keescook@chromium.org>
On Tue, Jun 23, 2020 at 06:49:33PM -0700, Kees Cook wrote:
> When linking vmlinux with LLD, the synthetic sections .symtab, .strtab,
> and .shstrtab are listed as orphaned. Add them to the STABS_DEBUG section
> so there will be no warnings when --orphan-handling=warn is used more
> widely. (They are added above comment as it is the more common
Nit 1: is "after .comment" better than "above comment"? It's above in the
sense of higher file offset, but it's below in readelf output.
Nit 2: These aren't actually debugging sections, no? Is it better to add
a new macro for it, and is there any plan to stop LLD from warning about
them?
> order[1].)
>
> ld.lld: warning: <internal>:(.symtab) is being placed in '.symtab'
> ld.lld: warning: <internal>:(.shstrtab) is being placed in '.shstrtab'
> ld.lld: warning: <internal>:(.strtab) is being placed in '.strtab'
>
> [1] https://lore.kernel.org/lkml/20200622224928.o2a7jkq33guxfci4@google.com/
>
> Reported-by: Fangrui Song <maskray@google.com>
> Reviewed-by: Fangrui Song <maskray@google.com>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> include/asm-generic/vmlinux.lds.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
> index 1248a206be8d..8e71757f485b 100644
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -792,7 +792,10 @@
> .stab.exclstr 0 : { *(.stab.exclstr) } \
> .stab.index 0 : { *(.stab.index) } \
> .stab.indexstr 0 : { *(.stab.indexstr) } \
> - .comment 0 : { *(.comment) }
> + .comment 0 : { *(.comment) } \
> + .symtab 0 : { *(.symtab) } \
> + .strtab 0 : { *(.strtab) } \
> + .shstrtab 0 : { *(.shstrtab) }
>
> #ifdef CONFIG_GENERIC_BUG
> #define BUG_TABLE \
> --
> 2.25.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Arvind Sankar <nivedita@alum.mit.edu>
To: Kees Cook <keescook@chromium.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
linux-efi@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
Arvind Sankar <nivedita@alum.mit.edu>,
Will Deacon <will@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arch@vger.kernel.org, Fangrui Song <maskray@google.com>,
Masahiro Yamada <masahiroy@kernel.org>,
x86@kernel.org, Russell King <linux@armlinux.org.uk>,
Ard Biesheuvel <ardb@kernel.org>,
clang-built-linux@googlegroups.com,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@suse.de>,
Arnd Bergmann <arnd@arndb.de>,
Nathan Chancellor <natechancellor@gmail.com>,
Peter Collingbourne <pcc@google.com>,
linux-arm-kernel@lists.infradead.org,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org, James Morse <james.morse@arm.com>
Subject: Re: [PATCH v3 2/9] vmlinux.lds.h: Add .symtab, .strtab, and .shstrtab to STABS_DEBUG
Date: Wed, 24 Jun 2020 11:39:30 -0400 [thread overview]
Message-ID: <20200624153930.GA1337895@rani.riverdale.lan> (raw)
In-Reply-To: <20200624014940.1204448-3-keescook@chromium.org>
On Tue, Jun 23, 2020 at 06:49:33PM -0700, Kees Cook wrote:
> When linking vmlinux with LLD, the synthetic sections .symtab, .strtab,
> and .shstrtab are listed as orphaned. Add them to the STABS_DEBUG section
> so there will be no warnings when --orphan-handling=warn is used more
> widely. (They are added above comment as it is the more common
Nit 1: is "after .comment" better than "above comment"? It's above in the
sense of higher file offset, but it's below in readelf output.
Nit 2: These aren't actually debugging sections, no? Is it better to add
a new macro for it, and is there any plan to stop LLD from warning about
them?
> order[1].)
>
> ld.lld: warning: <internal>:(.symtab) is being placed in '.symtab'
> ld.lld: warning: <internal>:(.shstrtab) is being placed in '.shstrtab'
> ld.lld: warning: <internal>:(.strtab) is being placed in '.strtab'
>
> [1] https://lore.kernel.org/lkml/20200622224928.o2a7jkq33guxfci4@google.com/
>
> Reported-by: Fangrui Song <maskray@google.com>
> Reviewed-by: Fangrui Song <maskray@google.com>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> include/asm-generic/vmlinux.lds.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
> index 1248a206be8d..8e71757f485b 100644
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -792,7 +792,10 @@
> .stab.exclstr 0 : { *(.stab.exclstr) } \
> .stab.index 0 : { *(.stab.index) } \
> .stab.indexstr 0 : { *(.stab.indexstr) } \
> - .comment 0 : { *(.comment) }
> + .comment 0 : { *(.comment) } \
> + .symtab 0 : { *(.symtab) } \
> + .strtab 0 : { *(.strtab) } \
> + .shstrtab 0 : { *(.shstrtab) }
>
> #ifdef CONFIG_GENERIC_BUG
> #define BUG_TABLE \
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-24 15:39 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 1:49 [PATCH v3 0/9] Warn on orphan section placement Kees Cook
2020-06-24 1:49 ` Kees Cook
2020-06-24 1:49 ` [PATCH v3 1/9] vmlinux.lds.h: Add .gnu.version* to DISCARDS Kees Cook
2020-06-24 1:49 ` Kees Cook
2020-06-24 1:49 ` Kees Cook
2020-06-24 1:49 ` [PATCH v3 2/9] vmlinux.lds.h: Add .symtab, .strtab, and .shstrtab to STABS_DEBUG Kees Cook
2020-06-24 1:49 ` Kees Cook
2020-06-24 1:49 ` Kees Cook
2020-06-24 15:39 ` Arvind Sankar [this message]
2020-06-24 15:39 ` Arvind Sankar
2020-06-24 15:39 ` Arvind Sankar
2020-06-24 16:16 ` Fangrui Song
2020-06-24 16:16 ` Fangrui Song
2020-06-24 17:11 ` Arvind Sankar
2020-06-24 17:11 ` Arvind Sankar
2020-06-24 17:11 ` Arvind Sankar
2020-06-24 17:26 ` Fangrui Song
2020-06-24 17:26 ` Fangrui Song
2020-06-24 17:35 ` Arvind Sankar
2020-06-24 17:35 ` Arvind Sankar
2020-06-24 17:35 ` Arvind Sankar
2020-06-24 1:49 ` [PATCH v3 3/9] efi/libstub: Remove .note.gnu.property Kees Cook
2020-06-24 1:49 ` Kees Cook
2020-06-24 3:31 ` Fangrui Song
2020-06-24 3:31 ` Fangrui Song
2020-06-24 4:44 ` Kees Cook
2020-06-24 4:44 ` Kees Cook
2020-06-24 10:43 ` Will Deacon
2020-06-24 10:43 ` Will Deacon
2020-06-24 10:46 ` Ard Biesheuvel
2020-06-24 10:46 ` Ard Biesheuvel
2020-06-24 10:46 ` Ard Biesheuvel
2020-06-24 11:26 ` Will Deacon
2020-06-24 11:26 ` Will Deacon
2020-06-24 11:26 ` Will Deacon
2020-06-24 13:48 ` Dave Martin
2020-06-24 13:48 ` Dave Martin
2020-06-24 13:48 ` Dave Martin
2020-06-24 15:26 ` Will Deacon
2020-06-24 15:26 ` Will Deacon
2020-06-24 15:26 ` Will Deacon
2020-06-24 16:26 ` Dave Martin
2020-06-24 16:26 ` Dave Martin
2020-06-24 16:26 ` Dave Martin
2020-06-24 15:21 ` Kees Cook
2020-06-24 15:21 ` Kees Cook
2020-06-24 15:21 ` Kees Cook
2020-06-24 15:31 ` Ard Biesheuvel
2020-06-24 15:31 ` Ard Biesheuvel
2020-06-24 15:31 ` Ard Biesheuvel
2020-06-24 15:45 ` Kees Cook
2020-06-24 15:45 ` Kees Cook
2020-06-24 15:45 ` Kees Cook
2020-06-24 15:48 ` Ard Biesheuvel
2020-06-24 15:48 ` Ard Biesheuvel
2020-06-24 15:48 ` Ard Biesheuvel
2020-06-24 16:29 ` Dave Martin
2020-06-24 16:29 ` Dave Martin
2020-06-24 16:29 ` Dave Martin
2020-06-24 16:40 ` Ard Biesheuvel
2020-06-24 16:40 ` Ard Biesheuvel
2020-06-24 16:40 ` Ard Biesheuvel
2020-06-24 17:16 ` Dave Martin
2020-06-24 17:16 ` Dave Martin
2020-06-24 17:16 ` Dave Martin
2020-06-24 18:23 ` Ard Biesheuvel
2020-06-24 18:23 ` Ard Biesheuvel
2020-06-24 18:23 ` Ard Biesheuvel
2020-06-24 18:57 ` Ard Biesheuvel
2020-06-24 18:57 ` Ard Biesheuvel
2020-06-24 18:57 ` Ard Biesheuvel
2020-06-24 1:49 ` [PATCH v3 4/9] x86/build: Warn on orphan section placement Kees Cook
2020-06-24 1:49 ` Kees Cook
2020-06-24 18:36 ` kernel test robot
2020-06-27 15:44 ` Kees Cook
2020-06-27 15:44 ` Kees Cook
2020-06-29 14:54 ` Marco Elver
2020-06-29 14:54 ` Marco Elver
2020-06-29 15:26 ` Kees Cook
2020-06-29 15:26 ` Kees Cook
2020-06-24 1:49 ` [PATCH v3 5/9] x86/boot: " Kees Cook
2020-06-24 1:49 ` Kees Cook
2020-06-24 1:49 ` [PATCH v3 6/9] arm/build: " Kees Cook
2020-06-24 1:49 ` Kees Cook
2020-06-24 1:49 ` [PATCH v3 7/9] arm/boot: " Kees Cook
2020-06-24 1:49 ` Kees Cook
2020-06-24 1:49 ` [PATCH v3 8/9] arm64/build: Use common DISCARDS in linker script Kees Cook
2020-06-24 1:49 ` Kees Cook
2020-06-24 1:49 ` [PATCH v3 9/9] arm64/build: Warn on orphan section placement Kees Cook
2020-06-24 1:49 ` Kees Cook
2020-06-24 7:57 ` Will Deacon
2020-06-24 7:57 ` Will Deacon
2020-06-24 15:36 ` Kees Cook
2020-06-24 15:36 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200624153930.GA1337895@rani.riverdale.lan \
--to=nivedita@alum.mit.edu \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=bp@suse.de \
--cc=catalin.marinas@arm.com \
--cc=clang-built-linux@googlegroups.com \
--cc=james.morse@arm.com \
--cc=keescook@chromium.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=masahiroy@kernel.org \
--cc=maskray@google.com \
--cc=mingo@redhat.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=pcc@google.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.