All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime@cerno.tech>
To: Ondrej Jirman <megous@megous.com>
Cc: linux-sunxi@googlegroups.com,
	Vasily Khoruzhick <anarsoul@gmail.com>,
	Yangtao Li <tiny.windzz@gmail.com>,
	Zhang Rui <rui.zhang@intel.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Amit Kucheria <amit.kucheria@verdurent.com>,
	Chen-Yu Tsai <wens@csie.org>,
	"open list:ALLWINNER THERMAL DRIVER" <linux-pm@vger.kernel.org>,
	"moderated list:ARM/Allwinner sunXi SoC support" 
	<linux-arm-kernel@lists.infradead.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] thermal: sun8i: Be loud when probe fails
Date: Wed, 8 Jul 2020 15:29:47 +0200	[thread overview]
Message-ID: <20200708132947.6rsgsqychmtzvuhr@gilmour.lan> (raw)
In-Reply-To: <20200708105527.868987-1-megous@megous.com>

On Wed, Jul 08, 2020 at 12:55:27PM +0200, Ondrej Jirman wrote:
> @@ -523,10 +547,17 @@ static int sun8i_ths_probe(struct platform_device *pdev)
>  	ret = devm_request_threaded_irq(dev, irq, NULL,
>  					sun8i_irq_thread,
>  					IRQF_ONESHOT, "ths", tmdev);
> -	if (ret)
> -		return ret;
> +	if (ret) {
> +		dev_err(dev, "Failed to request irq (%d)\n", ret);
> +		goto err_out;
> +	}
>  
> +	dev_info(dev, "Thermal sensor ready!\n");
>  	return 0;

I missed that in my first mail, but I'm not sure we want to print
anything on success. This doesn't bring any value and that will only
make it harder to find errors in other drivers.

Maxime

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech>
To: Ondrej Jirman <megous@megous.com>
Cc: Amit Kucheria <amit.kucheria@verdurent.com>,
	"open list:ALLWINNER THERMAL DRIVER" <linux-pm@vger.kernel.org>,
	Yangtao Li <tiny.windzz@gmail.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	open list <linux-kernel@vger.kernel.org>,
	Vasily Khoruzhick <anarsoul@gmail.com>,
	linux-sunxi@googlegroups.com, Zhang Rui <rui.zhang@intel.com>,
	"moderated list:ARM/Allwinner sunXi SoC support"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] thermal: sun8i: Be loud when probe fails
Date: Wed, 8 Jul 2020 15:29:47 +0200	[thread overview]
Message-ID: <20200708132947.6rsgsqychmtzvuhr@gilmour.lan> (raw)
In-Reply-To: <20200708105527.868987-1-megous@megous.com>

On Wed, Jul 08, 2020 at 12:55:27PM +0200, Ondrej Jirman wrote:
> @@ -523,10 +547,17 @@ static int sun8i_ths_probe(struct platform_device *pdev)
>  	ret = devm_request_threaded_irq(dev, irq, NULL,
>  					sun8i_irq_thread,
>  					IRQF_ONESHOT, "ths", tmdev);
> -	if (ret)
> -		return ret;
> +	if (ret) {
> +		dev_err(dev, "Failed to request irq (%d)\n", ret);
> +		goto err_out;
> +	}
>  
> +	dev_info(dev, "Thermal sensor ready!\n");
>  	return 0;

I missed that in my first mail, but I'm not sure we want to print
anything on success. This doesn't bring any value and that will only
make it harder to find errors in other drivers.

Maxime

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-07-08 13:29 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-08 10:55 [PATCH] thermal: sun8i: Be loud when probe fails Ondrej Jirman
2020-07-08 10:55 ` Ondrej Jirman
2020-07-08 11:03 ` Russell King - ARM Linux admin
2020-07-08 11:03   ` Russell King - ARM Linux admin
2020-07-08 11:10   ` Ondřej Jirman
2020-07-08 11:10     ` Ondřej Jirman
2020-07-20  7:55   ` Icenowy Zheng
2020-07-20  7:55     ` Icenowy Zheng
2020-07-20  8:28     ` Russell King - ARM Linux admin
2020-07-20  8:28       ` Russell King - ARM Linux admin
2020-07-08 11:55 ` Frank Lee
2020-07-08 11:55   ` Frank Lee
2020-07-08 13:21   ` Ondřej Jirman
2020-07-08 13:21     ` Ondřej Jirman
2020-07-08 13:42     ` Robin Murphy
2020-07-08 13:42       ` Robin Murphy
2020-07-08 13:33   ` Ondřej Jirman
2020-07-08 13:33     ` Ondřej Jirman
2020-07-08 12:25 ` Maxime Ripard
2020-07-08 12:25   ` Maxime Ripard
2020-07-08 13:29   ` Ondřej Jirman
2020-07-08 13:29     ` Ondřej Jirman
2020-07-08 13:36     ` Maxime Ripard
2020-07-08 13:36       ` Maxime Ripard
2020-07-08 13:44       ` Ondřej Jirman
2020-07-08 13:44         ` Ondřej Jirman
2020-07-08 13:57         ` Maxime Ripard
2020-07-08 13:57           ` Maxime Ripard
2020-07-12 23:29           ` Ondřej Jirman
2020-07-12 23:29             ` Ondřej Jirman
2020-07-23 15:20             ` Maxime Ripard
2020-07-23 15:20               ` Maxime Ripard
2020-07-08 13:29 ` Maxime Ripard [this message]
2020-07-08 13:29   ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200708132947.6rsgsqychmtzvuhr@gilmour.lan \
    --to=maxime@cerno.tech \
    --cc=amit.kucheria@verdurent.com \
    --cc=anarsoul@gmail.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=megous@megous.com \
    --cc=rui.zhang@intel.com \
    --cc=tiny.windzz@gmail.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.