From: "Ondřej Jirman" <megous@megous.com> To: Maxime Ripard <maxime@cerno.tech> Cc: linux-sunxi@googlegroups.com, Vasily Khoruzhick <anarsoul@gmail.com>, Yangtao Li <tiny.windzz@gmail.com>, Zhang Rui <rui.zhang@intel.com>, Daniel Lezcano <daniel.lezcano@linaro.org>, Amit Kucheria <amit.kucheria@verdurent.com>, Chen-Yu Tsai <wens@csie.org>, "open list:ALLWINNER THERMAL DRIVER" <linux-pm@vger.kernel.org>, "moderated list:ARM/Allwinner sunXi SoC support" <linux-arm-kernel@lists.infradead.org>, open list <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] thermal: sun8i: Be loud when probe fails Date: Mon, 13 Jul 2020 01:29:42 +0200 [thread overview] Message-ID: <20200712232942.eecoekr25i3wu2iq@core.my.home> (raw) In-Reply-To: <20200708135748.l4zncodhhggurp6s@gilmour.lan> Hi Maxime, On Wed, Jul 08, 2020 at 03:57:48PM +0200, Maxime Ripard wrote: > On Wed, Jul 08, 2020 at 03:44:41PM +0200, Ondřej Jirman wrote: > > > [...] > > > Yeah, but on the other hand, we regularly have people that come up and > > > ask if a "legitimate" EPROBE_DEFER error message (as in: the driver > > > wasn't there on the first attempt but was there on the second) is a > > > cause of concern or not. > > > > That's why I also added a success message, to distinguish this case. > > That doesn't really help though. We have plenty of drivers that have > some sort of success message and people will still ask about that error > message earlier. > > > > > And people run several distros for 3-4 months without anyone noticing any > > > > issues and that thermal regulation doesn't work. So it seems that lack of a > > > > success message is not enough. > > > > > > I understand what the issue is, but do you really expect phone users to > > > monitor the kernel logs every time they boot their phone to see if the > > > thermal throttling is enabled? > > > > Not phone users, but people making their own kernels/distributions. Those people > > monitor dmesg, and out of 4 distros or more nobody noticed there was an issue > > (despite the complaints of overheating by their users). > > > > So I thought some warning may be in order, so that distro people more easily > > notice they have misconfigured the kernel or sometging. > > I mean, then there's nothing we can do to properly address that then. > > The configuration system is a gun, we can point at the target, but > anyone is definitely free to shot themself in the foot. > > You would have exactly the same result if you left the thermal driver > disabled, or if you didn't have cpufreq support. Right. Though I hope there's some middle ground. I mean all of those dev_err in error paths of many drivers are there mostly to help debugging stuff. And even though I was part of this driver's development, it took me quite some time to figure out it was the missing sunxi-sid driver causing the issue, with complete silence from the driver. Maybe this can/will be solved at another level entirely, like having a device core report devices probes that failed with EPROBE_DEFER some time after the boot finished and modules had a chance to load, instead of immediately for each probe retry. regards, o. > Maxime
WARNING: multiple messages have this Message-ID (diff)
From: "Ondřej Jirman" <megous@megous.com> To: Maxime Ripard <maxime@cerno.tech> Cc: Amit Kucheria <amit.kucheria@verdurent.com>, "open list:ALLWINNER THERMAL DRIVER" <linux-pm@vger.kernel.org>, Yangtao Li <tiny.windzz@gmail.com>, Daniel Lezcano <daniel.lezcano@linaro.org>, Chen-Yu Tsai <wens@csie.org>, open list <linux-kernel@vger.kernel.org>, Vasily Khoruzhick <anarsoul@gmail.com>, linux-sunxi@googlegroups.com, Zhang Rui <rui.zhang@intel.com>, "moderated list:ARM/Allwinner sunXi SoC support" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH] thermal: sun8i: Be loud when probe fails Date: Mon, 13 Jul 2020 01:29:42 +0200 [thread overview] Message-ID: <20200712232942.eecoekr25i3wu2iq@core.my.home> (raw) In-Reply-To: <20200708135748.l4zncodhhggurp6s@gilmour.lan> Hi Maxime, On Wed, Jul 08, 2020 at 03:57:48PM +0200, Maxime Ripard wrote: > On Wed, Jul 08, 2020 at 03:44:41PM +0200, Ondřej Jirman wrote: > > > [...] > > > Yeah, but on the other hand, we regularly have people that come up and > > > ask if a "legitimate" EPROBE_DEFER error message (as in: the driver > > > wasn't there on the first attempt but was there on the second) is a > > > cause of concern or not. > > > > That's why I also added a success message, to distinguish this case. > > That doesn't really help though. We have plenty of drivers that have > some sort of success message and people will still ask about that error > message earlier. > > > > > And people run several distros for 3-4 months without anyone noticing any > > > > issues and that thermal regulation doesn't work. So it seems that lack of a > > > > success message is not enough. > > > > > > I understand what the issue is, but do you really expect phone users to > > > monitor the kernel logs every time they boot their phone to see if the > > > thermal throttling is enabled? > > > > Not phone users, but people making their own kernels/distributions. Those people > > monitor dmesg, and out of 4 distros or more nobody noticed there was an issue > > (despite the complaints of overheating by their users). > > > > So I thought some warning may be in order, so that distro people more easily > > notice they have misconfigured the kernel or sometging. > > I mean, then there's nothing we can do to properly address that then. > > The configuration system is a gun, we can point at the target, but > anyone is definitely free to shot themself in the foot. > > You would have exactly the same result if you left the thermal driver > disabled, or if you didn't have cpufreq support. Right. Though I hope there's some middle ground. I mean all of those dev_err in error paths of many drivers are there mostly to help debugging stuff. And even though I was part of this driver's development, it took me quite some time to figure out it was the missing sunxi-sid driver causing the issue, with complete silence from the driver. Maybe this can/will be solved at another level entirely, like having a device core report devices probes that failed with EPROBE_DEFER some time after the boot finished and modules had a chance to load, instead of immediately for each probe retry. regards, o. > Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-12 23:29 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-08 10:55 [PATCH] thermal: sun8i: Be loud when probe fails Ondrej Jirman 2020-07-08 10:55 ` Ondrej Jirman 2020-07-08 11:03 ` Russell King - ARM Linux admin 2020-07-08 11:03 ` Russell King - ARM Linux admin 2020-07-08 11:10 ` Ondřej Jirman 2020-07-08 11:10 ` Ondřej Jirman 2020-07-20 7:55 ` Icenowy Zheng 2020-07-20 7:55 ` Icenowy Zheng 2020-07-20 8:28 ` Russell King - ARM Linux admin 2020-07-20 8:28 ` Russell King - ARM Linux admin 2020-07-08 11:55 ` Frank Lee 2020-07-08 11:55 ` Frank Lee 2020-07-08 13:21 ` Ondřej Jirman 2020-07-08 13:21 ` Ondřej Jirman 2020-07-08 13:42 ` Robin Murphy 2020-07-08 13:42 ` Robin Murphy 2020-07-08 13:33 ` Ondřej Jirman 2020-07-08 13:33 ` Ondřej Jirman 2020-07-08 12:25 ` Maxime Ripard 2020-07-08 12:25 ` Maxime Ripard 2020-07-08 13:29 ` Ondřej Jirman 2020-07-08 13:29 ` Ondřej Jirman 2020-07-08 13:36 ` Maxime Ripard 2020-07-08 13:36 ` Maxime Ripard 2020-07-08 13:44 ` Ondřej Jirman 2020-07-08 13:44 ` Ondřej Jirman 2020-07-08 13:57 ` Maxime Ripard 2020-07-08 13:57 ` Maxime Ripard 2020-07-12 23:29 ` Ondřej Jirman [this message] 2020-07-12 23:29 ` Ondřej Jirman 2020-07-23 15:20 ` Maxime Ripard 2020-07-23 15:20 ` Maxime Ripard 2020-07-08 13:29 ` Maxime Ripard 2020-07-08 13:29 ` Maxime Ripard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200712232942.eecoekr25i3wu2iq@core.my.home \ --to=megous@megous.com \ --cc=amit.kucheria@verdurent.com \ --cc=anarsoul@gmail.com \ --cc=daniel.lezcano@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-sunxi@googlegroups.com \ --cc=maxime@cerno.tech \ --cc=rui.zhang@intel.com \ --cc=tiny.windzz@gmail.com \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.