From: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
To: amd-gfx@lists.freedesktop.org
Cc: maraeo@gmail.com, dri-devel@lists.freedesktop.org
Subject: [PATCH 2/8] drm/amd: Init modifier field of helper fb.
Date: Tue, 4 Aug 2020 23:31:13 +0200 [thread overview]
Message-ID: <20200804213119.25091-3-bas@basnieuwenhuizen.nl> (raw)
In-Reply-To: <20200804213119.25091-1-bas@basnieuwenhuizen.nl>
Otherwise the field ends up being used uninitialized when
enabling modifiers, failing validation with high likelihood.
Signed-off-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
index 25ddb482466a..c2d6952d0a7d 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
@@ -201,7 +201,7 @@ static int amdgpufb_create(struct drm_fb_helper *helper,
struct amdgpu_device *adev = rfbdev->adev;
struct fb_info *info;
struct drm_framebuffer *fb = NULL;
- struct drm_mode_fb_cmd2 mode_cmd;
+ struct drm_mode_fb_cmd2 mode_cmd = {0};
struct drm_gem_object *gobj = NULL;
struct amdgpu_bo *abo = NULL;
int ret;
--
2.28.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
To: amd-gfx@lists.freedesktop.org
Cc: maraeo@gmail.com, daniel@fooishbar.org,
dri-devel@lists.freedesktop.org, daniel@ffwll.ch,
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>,
harry.wentland@amd.com
Subject: [PATCH 2/8] drm/amd: Init modifier field of helper fb.
Date: Tue, 4 Aug 2020 23:31:13 +0200 [thread overview]
Message-ID: <20200804213119.25091-3-bas@basnieuwenhuizen.nl> (raw)
In-Reply-To: <20200804213119.25091-1-bas@basnieuwenhuizen.nl>
Otherwise the field ends up being used uninitialized when
enabling modifiers, failing validation with high likelihood.
Signed-off-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
index 25ddb482466a..c2d6952d0a7d 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
@@ -201,7 +201,7 @@ static int amdgpufb_create(struct drm_fb_helper *helper,
struct amdgpu_device *adev = rfbdev->adev;
struct fb_info *info;
struct drm_framebuffer *fb = NULL;
- struct drm_mode_fb_cmd2 mode_cmd;
+ struct drm_mode_fb_cmd2 mode_cmd = {0};
struct drm_gem_object *gobj = NULL;
struct amdgpu_bo *abo = NULL;
int ret;
--
2.28.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-08-04 21:32 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 21:31 [PATCH 0/8] amd/display: Add GFX9+ modifier support Bas Nieuwenhuizen
2020-08-04 21:31 ` Bas Nieuwenhuizen
2020-08-04 21:31 ` [PATCH 1/8] drm/amd/display: Do not silently accept DCC for multiplane formats Bas Nieuwenhuizen
2020-08-04 21:31 ` Bas Nieuwenhuizen
2020-08-04 21:31 ` Bas Nieuwenhuizen [this message]
2020-08-04 21:31 ` [PATCH 2/8] drm/amd: Init modifier field of helper fb Bas Nieuwenhuizen
2020-08-04 21:31 ` [PATCH 3/8] drm/amd/display: Honor the offset for plane 0 Bas Nieuwenhuizen
2020-08-04 21:31 ` Bas Nieuwenhuizen
2020-08-05 7:21 ` daniel
2020-08-05 7:21 ` daniel
2020-08-04 21:31 ` [PATCH 4/8] drm/fourcc: Add AMD DRM modifiers Bas Nieuwenhuizen
2020-08-04 21:31 ` Bas Nieuwenhuizen
2020-08-04 21:31 ` [PATCH 5/8] drm/amd/display: Refactor surface tiling setup Bas Nieuwenhuizen
2020-08-04 21:31 ` Bas Nieuwenhuizen
2020-08-04 21:31 ` [PATCH 6/8] drm/amd/display: Set DC options from modifiers Bas Nieuwenhuizen
2020-08-04 21:31 ` Bas Nieuwenhuizen
2020-08-05 7:32 ` daniel
2020-08-05 7:32 ` daniel
2020-08-10 12:28 ` Daniel Vetter
2020-08-10 12:28 ` Daniel Vetter
2020-08-10 12:49 ` Michel Dänzer
2020-08-10 12:49 ` Michel Dänzer
2020-08-10 13:09 ` Daniel Vetter
2020-08-10 13:09 ` Daniel Vetter
2020-08-10 14:13 ` Bas Nieuwenhuizen
2020-08-10 14:13 ` Bas Nieuwenhuizen
2020-08-10 14:20 ` Daniel Vetter
2020-08-10 14:20 ` Daniel Vetter
2020-08-04 21:31 ` [PATCH 7/8] drm/amd/display: Add formats for DCC with 2/3 planes Bas Nieuwenhuizen
2020-08-04 21:31 ` Bas Nieuwenhuizen
2020-08-04 21:31 ` [PATCH 8/8] drm/amd/display: Expose modifiers Bas Nieuwenhuizen
2020-08-04 21:31 ` Bas Nieuwenhuizen
2020-08-07 19:42 ` Marek Olšák
2020-08-07 19:42 ` Marek Olšák
2020-09-02 10:31 ` Bas Nieuwenhuizen
2020-09-02 10:31 ` Bas Nieuwenhuizen
2020-09-03 2:42 ` Marek Olšák
2020-09-03 2:42 ` Marek Olšák
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200804213119.25091-3-bas@basnieuwenhuizen.nl \
--to=bas@basnieuwenhuizen.nl \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=maraeo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.