From: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: "amd-gfx mailing list" <amd-gfx@lists.freedesktop.org>,
"Marek Olšák" <maraeo@gmail.com>,
"Michel Dänzer" <michel@daenzer.net>,
"ML dri-devel" <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 6/8] drm/amd/display: Set DC options from modifiers.
Date: Mon, 10 Aug 2020 16:13:11 +0200 [thread overview]
Message-ID: <CAP+8YyH0ufOc34Bis3PqfUR6XdE+6kRMasfgz1E4XUWJbbmB+A@mail.gmail.com> (raw)
In-Reply-To: <20200810130935.GT2352366@phenom.ffwll.local>
On Mon, Aug 10, 2020 at 3:09 PM Daniel Vetter <daniel@ffwll.ch> wrote:
>
> On Mon, Aug 10, 2020 at 02:49:00PM +0200, Michel Dänzer wrote:
> > On 2020-08-10 2:28 p.m., Daniel Vetter wrote:
> > >
> > > Ok just learned that amdgpu hat set/get_tiling, so I'm upgrading my idea
> > > here to a very strong recommendation, i.e. please do this except if
> > > there's and amd ddx which somehow wants to change tiling mode while a fb
> > > exists, and expects this to propagate.
> > >
> > > In i915 we even disallow the set_tiling ioctl with an error if an fb
> > > exists, just to make sure userspace behaves. Even if userspace uses
> > > set_tiling, this way we can at least enforce the same semantics of "client
> > > can't pull compositor over the table with a set_tiling at the wrong time"
> > > of modifiers.
> >
> > FWIW, xf86-video-amdgpu doesn't have any code to set the tiling
> > metadata, only Mesa and presumably AMD's Vulkan/OpenGL UMDs do.
>
> Ah right you do everything with glamour, so this should never show up as a
> problem.
I think it is a good idea to do so, but cannot do it completely in
this series as we don't define modifiers for GFX6-GFX8 GPU generations
yet. (wanted to leave these out for a bit to reduce the scope for the
initial version)
That said, there is a series that captures the tiling flags on FB
creation: https://patchwork.freedesktop.org/series/80109/
> -Daniel
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: "amd-gfx mailing list" <amd-gfx@lists.freedesktop.org>,
"Marek Olšák" <maraeo@gmail.com>,
"Michel Dänzer" <michel@daenzer.net>,
"ML dri-devel" <dri-devel@lists.freedesktop.org>,
"Daniel Stone" <daniel@fooishbar.org>,
harry.wentland@amd.com
Subject: Re: [PATCH 6/8] drm/amd/display: Set DC options from modifiers.
Date: Mon, 10 Aug 2020 16:13:11 +0200 [thread overview]
Message-ID: <CAP+8YyH0ufOc34Bis3PqfUR6XdE+6kRMasfgz1E4XUWJbbmB+A@mail.gmail.com> (raw)
In-Reply-To: <20200810130935.GT2352366@phenom.ffwll.local>
On Mon, Aug 10, 2020 at 3:09 PM Daniel Vetter <daniel@ffwll.ch> wrote:
>
> On Mon, Aug 10, 2020 at 02:49:00PM +0200, Michel Dänzer wrote:
> > On 2020-08-10 2:28 p.m., Daniel Vetter wrote:
> > >
> > > Ok just learned that amdgpu hat set/get_tiling, so I'm upgrading my idea
> > > here to a very strong recommendation, i.e. please do this except if
> > > there's and amd ddx which somehow wants to change tiling mode while a fb
> > > exists, and expects this to propagate.
> > >
> > > In i915 we even disallow the set_tiling ioctl with an error if an fb
> > > exists, just to make sure userspace behaves. Even if userspace uses
> > > set_tiling, this way we can at least enforce the same semantics of "client
> > > can't pull compositor over the table with a set_tiling at the wrong time"
> > > of modifiers.
> >
> > FWIW, xf86-video-amdgpu doesn't have any code to set the tiling
> > metadata, only Mesa and presumably AMD's Vulkan/OpenGL UMDs do.
>
> Ah right you do everything with glamour, so this should never show up as a
> problem.
I think it is a good idea to do so, but cannot do it completely in
this series as we don't define modifiers for GFX6-GFX8 GPU generations
yet. (wanted to leave these out for a bit to reduce the scope for the
initial version)
That said, there is a series that captures the tiling flags on FB
creation: https://patchwork.freedesktop.org/series/80109/
> -Daniel
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-08-10 14:13 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 21:31 [PATCH 0/8] amd/display: Add GFX9+ modifier support Bas Nieuwenhuizen
2020-08-04 21:31 ` Bas Nieuwenhuizen
2020-08-04 21:31 ` [PATCH 1/8] drm/amd/display: Do not silently accept DCC for multiplane formats Bas Nieuwenhuizen
2020-08-04 21:31 ` Bas Nieuwenhuizen
2020-08-04 21:31 ` [PATCH 2/8] drm/amd: Init modifier field of helper fb Bas Nieuwenhuizen
2020-08-04 21:31 ` Bas Nieuwenhuizen
2020-08-04 21:31 ` [PATCH 3/8] drm/amd/display: Honor the offset for plane 0 Bas Nieuwenhuizen
2020-08-04 21:31 ` Bas Nieuwenhuizen
2020-08-05 7:21 ` daniel
2020-08-05 7:21 ` daniel
2020-08-04 21:31 ` [PATCH 4/8] drm/fourcc: Add AMD DRM modifiers Bas Nieuwenhuizen
2020-08-04 21:31 ` Bas Nieuwenhuizen
2020-08-04 21:31 ` [PATCH 5/8] drm/amd/display: Refactor surface tiling setup Bas Nieuwenhuizen
2020-08-04 21:31 ` Bas Nieuwenhuizen
2020-08-04 21:31 ` [PATCH 6/8] drm/amd/display: Set DC options from modifiers Bas Nieuwenhuizen
2020-08-04 21:31 ` Bas Nieuwenhuizen
2020-08-05 7:32 ` daniel
2020-08-05 7:32 ` daniel
2020-08-10 12:28 ` Daniel Vetter
2020-08-10 12:28 ` Daniel Vetter
2020-08-10 12:49 ` Michel Dänzer
2020-08-10 12:49 ` Michel Dänzer
2020-08-10 13:09 ` Daniel Vetter
2020-08-10 13:09 ` Daniel Vetter
2020-08-10 14:13 ` Bas Nieuwenhuizen [this message]
2020-08-10 14:13 ` Bas Nieuwenhuizen
2020-08-10 14:20 ` Daniel Vetter
2020-08-10 14:20 ` Daniel Vetter
2020-08-04 21:31 ` [PATCH 7/8] drm/amd/display: Add formats for DCC with 2/3 planes Bas Nieuwenhuizen
2020-08-04 21:31 ` Bas Nieuwenhuizen
2020-08-04 21:31 ` [PATCH 8/8] drm/amd/display: Expose modifiers Bas Nieuwenhuizen
2020-08-04 21:31 ` Bas Nieuwenhuizen
2020-08-07 19:42 ` Marek Olšák
2020-08-07 19:42 ` Marek Olšák
2020-09-02 10:31 ` Bas Nieuwenhuizen
2020-09-02 10:31 ` Bas Nieuwenhuizen
2020-09-03 2:42 ` Marek Olšák
2020-09-03 2:42 ` Marek Olšák
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP+8YyH0ufOc34Bis3PqfUR6XdE+6kRMasfgz1E4XUWJbbmB+A@mail.gmail.com \
--to=bas@basnieuwenhuizen.nl \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=maraeo@gmail.com \
--cc=michel@daenzer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.