Re: [PATCH 17/24] drm/virtio: implement blob resources: implement vram object

From: kernel test robot <lkp@intel.com>
To: Gurchetan Singh <gurchetansingh@chromium.org>,
	dri-devel@lists.freedesktop.org, virtio-dev@lists.oasis-open.org
Cc: sebastien.boeuf@intel.com, kbuild-all@lists.01.org,
	kraxel@redhat.com, vgoyal@redhat.com, mst@redhat.com
Subject: Re: [PATCH 17/24] drm/virtio: implement blob resources: implement vram object
Date: Fri, 14 Aug 2020 13:39:14 +0800	[thread overview]
Message-ID: <202008141305.2qpKf9Bi%lkp@intel.com> (raw)
In-Reply-To: <20200814024000.2485-18-gurchetansingh@chromium.org>

[-- Attachment #1: Type: text/plain, Size: 2975 bytes --]

Hi Gurchetan,

I love your patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip linus/master next-20200814]
[cannot apply to tegra-drm/drm/tegra/for-next drm/drm-next drm-exynos/exynos-drm-next v5.8]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Gurchetan-Singh/Blob-prerequisites-blob-resources/20200814-104250
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: parisc-randconfig-s031-20200813 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.2-168-g9554805c-dirty
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

sparse warnings: (new ones prefixed by >>)

>> drivers/gpu/drm/virtio/virtgpu_vq.c:1210:23: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le64 [usertype] offset @@     got unsigned long long [usertype] offset @@
>> drivers/gpu/drm/virtio/virtgpu_vq.c:1210:23: sparse:     expected restricted __le64 [usertype] offset
>> drivers/gpu/drm/virtio/virtgpu_vq.c:1210:23: sparse:     got unsigned long long [usertype] offset

vim +1210 drivers/gpu/drm/virtio/virtgpu_vq.c

  1188	
  1189	int virtio_gpu_cmd_map(struct virtio_gpu_device *vgdev,
  1190			       struct virtio_gpu_object_array *objs, uint64_t offset)
  1191	{
  1192		struct virtio_gpu_resource_map_blob *cmd_p;
  1193		struct virtio_gpu_object *bo = gem_to_virtio_gpu_obj(objs->objs[0]);
  1194		struct virtio_gpu_vbuffer *vbuf;
  1195		struct virtio_gpu_resp_map_info *resp_buf;
  1196	
  1197		resp_buf = kzalloc(sizeof(*resp_buf), GFP_KERNEL);
  1198		if (!resp_buf) {
  1199			virtio_gpu_array_put_free(objs);
  1200			return -ENOMEM;
  1201		}
  1202	
  1203		cmd_p = virtio_gpu_alloc_cmd_resp(vgdev,
  1204			virtio_gpu_cmd_resource_map_cb, &vbuf, sizeof(*cmd_p),
  1205			sizeof(struct virtio_gpu_resp_map_info), resp_buf);
  1206		memset(cmd_p, 0, sizeof(*cmd_p));
  1207	
  1208		cmd_p->hdr.type = cpu_to_le32(VIRTIO_GPU_CMD_RESOURCE_MAP_BLOB);
  1209		cmd_p->resource_id = cpu_to_le32(bo->hw_res_handle);
> 1210		cmd_p->offset = offset;
  1211		vbuf->objs = objs;
  1212	
  1213		virtio_gpu_queue_ctrl_buffer(vgdev, vbuf);
  1214		return 0;
  1215	}
  1216	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28443 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel