Re: [PATCH 18/24] drm/virtio: implement blob resources: hypercall interface

From: kernel test robot <lkp@intel.com>
To: Gurchetan Singh <gurchetansingh@chromium.org>,
	dri-devel@lists.freedesktop.org, virtio-dev@lists.oasis-open.org
Cc: sebastien.boeuf@intel.com, kbuild-all@lists.01.org,
	kraxel@redhat.com, vgoyal@redhat.com, mst@redhat.com
Subject: Re: [PATCH 18/24] drm/virtio: implement blob resources: hypercall interface
Date: Fri, 14 Aug 2020 14:12:39 +0800	[thread overview]
Message-ID: <202008141444.30UC88Ew%lkp@intel.com> (raw)
In-Reply-To: <20200814024000.2485-19-gurchetansingh@chromium.org>

[-- Attachment #1: Type: text/plain, Size: 3411 bytes --]

Hi Gurchetan,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip linus/master next-20200814]
[cannot apply to tegra-drm/drm/tegra/for-next drm/drm-next drm-exynos/exynos-drm-next v5.8]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Gurchetan-Singh/Blob-prerequisites-blob-resources/20200814-104250
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: parisc-randconfig-s031-20200813 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.2-168-g9554805c-dirty
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

sparse warnings: (new ones prefixed by >>)

   drivers/gpu/drm/virtio/virtgpu_vq.c:1210:23: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le64 [usertype] offset @@     got unsigned long long [usertype] offset @@
   drivers/gpu/drm/virtio/virtgpu_vq.c:1210:23: sparse:     expected restricted __le64 [usertype] offset
   drivers/gpu/drm/virtio/virtgpu_vq.c:1210:23: sparse:     got unsigned long long [usertype] offset
>> drivers/gpu/drm/virtio/virtgpu_vq.c:1286:35: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le32 @@     got restricted __le64 [usertype] @@
>> drivers/gpu/drm/virtio/virtgpu_vq.c:1286:35: sparse:     expected restricted __le32
>> drivers/gpu/drm/virtio/virtgpu_vq.c:1286:35: sparse:     got restricted __le64 [usertype]

vim +1286 drivers/gpu/drm/virtio/virtgpu_vq.c

  1260	
  1261	void virtio_gpu_cmd_set_scanout_blob(struct virtio_gpu_device *vgdev,
  1262					     uint32_t scanout_id,
  1263					     struct virtio_gpu_object *bo,
  1264					     struct drm_framebuffer *fb,
  1265					     uint32_t width, uint32_t height,
  1266					     uint32_t x, uint32_t y)
  1267	{
  1268		uint32_t i;
  1269		struct virtio_gpu_set_scanout_blob *cmd_p;
  1270		struct virtio_gpu_vbuffer *vbuf;
  1271		uint32_t format = virtio_gpu_translate_format(fb->format->format);
  1272	
  1273		cmd_p = virtio_gpu_alloc_cmd(vgdev, &vbuf, sizeof(*cmd_p));
  1274		memset(cmd_p, 0, sizeof(*cmd_p));
  1275	
  1276		cmd_p->hdr.type = cpu_to_le32(VIRTIO_GPU_CMD_SET_SCANOUT_BLOB);
  1277		cmd_p->resource_id = cpu_to_le32(bo->hw_res_handle);
  1278		cmd_p->scanout_id = cpu_to_le32(scanout_id);
  1279	
  1280		cmd_p->format = cpu_to_le32(format);
  1281		cmd_p->width  = cpu_to_le32(fb->width);
  1282		cmd_p->height = cpu_to_le32(fb->height);
  1283	
  1284		for (i = 0; i < 4; i++) {
  1285			cmd_p->strides[i] = cpu_to_le32(fb->pitches[i]);
> 1286			cmd_p->offsets[i] = cpu_to_le64(fb->offsets[i]);

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28443 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel