From: Vladimir Oltean <olteanv@gmail.com> To: Landen Chao <landen.chao@mediatek.com> Cc: "andrew@lunn.ch" <andrew@lunn.ch>, "f.fainelli@gmail.com" <f.fainelli@gmail.com>, "vivien.didelot@savoirfairelinux.com" <vivien.didelot@savoirfairelinux.com>, "matthias.bgg@gmail.com" <matthias.bgg@gmail.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "mark.rutland@arm.com" <mark.rutland@arm.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-mediatek@lists.infradead.org" <linux-mediatek@lists.infradead.org>, "davem@davemloft.net" <davem@davemloft.net>, Sean Wang <Sean.Wang@mediatek.com>, "opensource@vdorst.com" <opensource@vdorst.com>, "frank-w@public-files.de" <frank-w@public-files.de>, "dqfext@gmail.com" <dqfext@gmail.com> Subject: Re: [PATCH net-next v2 7/7] arm64: dts: mt7622: add mt7531 dsa to bananapi-bpi-r64 board Date: Wed, 19 Aug 2020 11:51:22 +0300 [thread overview] Message-ID: <20200819085122.wiuq3fi23rebja6d@skbuf> (raw) In-Reply-To: <1597824901.31846.42.camel@mtksdccf07> On Wed, Aug 19, 2020 at 04:15:01PM +0800, Landen Chao wrote: > On Wed, 2020-08-19 at 00:24 +0800, Vladimir Oltean wrote: > > On Tue, Aug 18, 2020 at 03:14:12PM +0800, Landen Chao wrote: > > > Add mt7531 dsa to bananapi-bpi-r64 board for 5 giga Ethernet ports support. > > > > > > Signed-off-by: Landen Chao <landen.chao@mediatek.com> > > > --- > > > .../dts/mediatek/mt7622-bananapi-bpi-r64.dts | 44 +++++++++++++++++++ > > > 1 file changed, 44 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts > > > index d174ad214857..c57b2571165f 100644 > > > --- a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts > > > +++ b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts > > > @@ -143,6 +143,50 @@ > > > mdio: mdio-bus { > > > #address-cells = <1>; > > > #size-cells = <0>; > > > + > > > + switch@0 { > > > + compatible = "mediatek,mt7531"; > > > + > [snip] > > > + port@6 { > > > + reg = <6>; > > > + label = "cpu"; > > > + ethernet = <&gmac0>; > > > + phy-mode = "2500base-x"; > > > + }; > > > > Is there any reason why you're not specifying a fixed-link node here? > I got the below feedback in v1, so I follow the DSA common design in v2. > v2 can work with fixed-link node or without fixed-link node in CPU port > node. > > "This fixed-link should not be needed. The DSA driver is supposed to > configure the CPU port to its fastest speed by default. 2500 is > the fastest speed a 2500Base-X link can do..." See this discussion and the replies to it: https://www.spinics.net/lists/netdev/msg630102.html I think if mt7530 is using phylink for non-netdev ports (and it is), it would be good to have standard bindings that phylink can parse. For example, in lack of a "pause" specifier, will the CPU port use flow control or won't it? Why? I think there's simply no good reason why you'd omit 3 more lines now. > > > + }; > > > + }; > > > + > > > }; > > > }; > > > > > > -- > > > 2.17.1 > > > > Thanks, > > -Vladimir > -Vladimir
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Oltean <olteanv@gmail.com> To: Landen Chao <landen.chao@mediatek.com> Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>, "andrew@lunn.ch" <andrew@lunn.ch>, "frank-w@public-files.de" <frank-w@public-files.de>, "f.fainelli@gmail.com" <f.fainelli@gmail.com>, "dqfext@gmail.com" <dqfext@gmail.com>, "vivien.didelot@savoirfairelinux.com" <vivien.didelot@savoirfairelinux.com>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, Sean Wang <Sean.Wang@mediatek.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "opensource@vdorst.com" <opensource@vdorst.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "linux-mediatek@lists.infradead.org" <linux-mediatek@lists.infradead.org>, "matthias.bgg@gmail.com" <matthias.bgg@gmail.com>, "davem@davemloft.net" <davem@davemloft.net> Subject: Re: [PATCH net-next v2 7/7] arm64: dts: mt7622: add mt7531 dsa to bananapi-bpi-r64 board Date: Wed, 19 Aug 2020 11:51:22 +0300 [thread overview] Message-ID: <20200819085122.wiuq3fi23rebja6d@skbuf> (raw) In-Reply-To: <1597824901.31846.42.camel@mtksdccf07> On Wed, Aug 19, 2020 at 04:15:01PM +0800, Landen Chao wrote: > On Wed, 2020-08-19 at 00:24 +0800, Vladimir Oltean wrote: > > On Tue, Aug 18, 2020 at 03:14:12PM +0800, Landen Chao wrote: > > > Add mt7531 dsa to bananapi-bpi-r64 board for 5 giga Ethernet ports support. > > > > > > Signed-off-by: Landen Chao <landen.chao@mediatek.com> > > > --- > > > .../dts/mediatek/mt7622-bananapi-bpi-r64.dts | 44 +++++++++++++++++++ > > > 1 file changed, 44 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts > > > index d174ad214857..c57b2571165f 100644 > > > --- a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts > > > +++ b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts > > > @@ -143,6 +143,50 @@ > > > mdio: mdio-bus { > > > #address-cells = <1>; > > > #size-cells = <0>; > > > + > > > + switch@0 { > > > + compatible = "mediatek,mt7531"; > > > + > [snip] > > > + port@6 { > > > + reg = <6>; > > > + label = "cpu"; > > > + ethernet = <&gmac0>; > > > + phy-mode = "2500base-x"; > > > + }; > > > > Is there any reason why you're not specifying a fixed-link node here? > I got the below feedback in v1, so I follow the DSA common design in v2. > v2 can work with fixed-link node or without fixed-link node in CPU port > node. > > "This fixed-link should not be needed. The DSA driver is supposed to > configure the CPU port to its fastest speed by default. 2500 is > the fastest speed a 2500Base-X link can do..." See this discussion and the replies to it: https://www.spinics.net/lists/netdev/msg630102.html I think if mt7530 is using phylink for non-netdev ports (and it is), it would be good to have standard bindings that phylink can parse. For example, in lack of a "pause" specifier, will the CPU port use flow control or won't it? Why? I think there's simply no good reason why you'd omit 3 more lines now. > > > + }; > > > + }; > > > + > > > }; > > > }; > > > > > > -- > > > 2.17.1 > > > > Thanks, > > -Vladimir > -Vladimir _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-08-19 8:51 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-18 7:14 [PATCH net-next v2 0/7] net-next: dsa: mt7530: add support for MT7531 Landen Chao 2020-08-18 7:14 ` Landen Chao 2020-08-18 7:14 ` [PATCH net-next v2 1/7] net: dsa: mt7530: Refine message in Kconfig Landen Chao 2020-08-18 7:14 ` Landen Chao 2020-08-18 7:14 ` [PATCH net-next v2 2/7] net: dsa: mt7530: support full-duplex gigabit only Landen Chao 2020-08-18 7:14 ` Landen Chao 2020-08-18 15:49 ` Andrew Lunn 2020-08-18 15:49 ` Andrew Lunn 2020-08-18 7:14 ` [PATCH net-next v2 3/7] net: dsa: mt7530: Extend device data ready for adding a new hardware Landen Chao 2020-08-18 7:14 ` Landen Chao 2020-08-18 15:56 ` Andrew Lunn 2020-08-18 15:56 ` Andrew Lunn 2020-08-18 17:31 ` Frank Wunderlich 2020-08-18 17:31 ` Frank Wunderlich 2020-08-18 7:14 ` [PATCH net-next v2 4/7] dt-bindings: net: dsa: add new MT7531 binding to support MT7531 Landen Chao 2020-08-18 7:14 ` Landen Chao 2020-08-25 19:43 ` Rob Herring 2020-08-25 19:43 ` Rob Herring 2020-08-18 7:14 ` [PATCH net-next v2 5/7] net: dsa: mt7530: Add the support of MT7531 switch Landen Chao 2020-08-18 7:14 ` Landen Chao 2020-08-18 15:23 ` Jakub Kicinski 2020-08-18 15:23 ` Jakub Kicinski 2020-08-19 9:50 ` Landen Chao 2020-08-19 9:50 ` Landen Chao 2020-08-18 16:09 ` Andrew Lunn 2020-08-18 16:09 ` Andrew Lunn 2020-08-19 9:44 ` Landen Chao 2020-08-19 9:44 ` Landen Chao 2020-08-19 13:12 ` Andrew Lunn 2020-08-19 13:12 ` Andrew Lunn 2020-08-19 23:46 ` René van Dorst 2020-08-19 23:46 ` René van Dorst 2020-08-20 15:29 ` Chuanhong Guo 2020-08-20 15:29 ` Chuanhong Guo 2020-08-18 7:14 ` [PATCH net-next v2 6/7] arm64: dts: mt7622: add mt7531 dsa to mt7622-rfb1 board Landen Chao 2020-08-18 7:14 ` Landen Chao 2020-08-18 16:10 ` Andrew Lunn 2020-08-18 16:10 ` Andrew Lunn 2020-08-18 7:14 ` [PATCH net-next v2 7/7] arm64: dts: mt7622: add mt7531 dsa to bananapi-bpi-r64 board Landen Chao 2020-08-18 7:14 ` Landen Chao 2020-08-18 16:24 ` Vladimir Oltean 2020-08-18 16:24 ` Vladimir Oltean 2020-08-19 8:15 ` Landen Chao 2020-08-19 8:15 ` Landen Chao 2020-08-19 8:51 ` Vladimir Oltean [this message] 2020-08-19 8:51 ` Vladimir Oltean 2020-08-18 17:54 ` Aw: [PATCH net-next v2 0/7] net-next: dsa: mt7530: add support for MT7531 Frank Wunderlich 2020-08-18 17:54 ` Frank Wunderlich 2020-08-19 3:49 ` DENG Qingfang 2020-08-19 3:49 ` DENG Qingfang 2020-08-19 6:57 ` Frank Wunderlich 2020-08-19 7:38 ` Landen Chao 2020-08-19 7:38 ` Landen Chao
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200819085122.wiuq3fi23rebja6d@skbuf \ --to=olteanv@gmail.com \ --cc=Sean.Wang@mediatek.com \ --cc=andrew@lunn.ch \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=dqfext@gmail.com \ --cc=f.fainelli@gmail.com \ --cc=frank-w@public-files.de \ --cc=landen.chao@mediatek.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=mark.rutland@arm.com \ --cc=matthias.bgg@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=opensource@vdorst.com \ --cc=robh+dt@kernel.org \ --cc=vivien.didelot@savoirfairelinux.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.