From: Chuanhong Guo <gch981213@gmail.com>
To: "René van Dorst" <opensource@vdorst.com>
Cc: Landen Chao <landen.chao@mediatek.com>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
vivien.didelot@savoirfairelinux.com,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, netdev <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
"David S. Miller" <davem@davemloft.net>,
Sean Wang <Sean.Wang@mediatek.com>,
frank-w@public-files.de, DENG Qingfang <dqfext@gmail.com>
Subject: Re: [PATCH net-next v2 5/7] net: dsa: mt7530: Add the support of MT7531 switch
Date: Thu, 20 Aug 2020 23:29:45 +0800 [thread overview]
Message-ID: <CAJsYDVJM3A_5Fpp8ube-gOi-Nn-itf0MW6ePL0wM16_k67+x6g@mail.gmail.com> (raw)
In-Reply-To: <20200819234613.Horde.oQiJhMCnUINwnQP-5_MyHh-@www.vdorst.com>
Hi!
On Thu, Aug 20, 2020 at 7:55 AM René van Dorst <opensource@vdorst.com> wrote:
>
> With the current mainline code [1], the dsa code tries to detect how the MAC5
> is used. All the three modes are supported. MAC5 -> PHY0, MAC5 ->
> PHY4, MAC5 ->
> EXTERNAL PHY and MAC5 to external MAC.
>
> When MAC5 is a DSA port it skips settings the delay settings. See [2].
>
> Maybe you can use a similar concept.
Current detection relies on an incorrect assumption that mt753x switch
is always used with mtk_eth_soc. It's a really hacky solution to use
dt properties that don't belong to this switch at all and I think this
approach should not be followed further by future code.
The usage of mac5 should be explicitly defined as a dt property
under mt753x node.
--
Regards,
Chuanhong Guo
WARNING: multiple messages have this Message-ID (diff)
From: Chuanhong Guo <gch981213@gmail.com>
To: "René van Dorst" <opensource@vdorst.com>
Cc: Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
Landen Chao <landen.chao@mediatek.com>,
Florian Fainelli <f.fainelli@gmail.com>,
vivien.didelot@savoirfairelinux.com,
netdev <netdev@vger.kernel.org>,
Sean Wang <Sean.Wang@mediatek.com>,
open list <linux-kernel@vger.kernel.org>,
frank-w@public-files.de, DENG Qingfang <dqfext@gmail.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next v2 5/7] net: dsa: mt7530: Add the support of MT7531 switch
Date: Thu, 20 Aug 2020 23:29:45 +0800 [thread overview]
Message-ID: <CAJsYDVJM3A_5Fpp8ube-gOi-Nn-itf0MW6ePL0wM16_k67+x6g@mail.gmail.com> (raw)
In-Reply-To: <20200819234613.Horde.oQiJhMCnUINwnQP-5_MyHh-@www.vdorst.com>
Hi!
On Thu, Aug 20, 2020 at 7:55 AM René van Dorst <opensource@vdorst.com> wrote:
>
> With the current mainline code [1], the dsa code tries to detect how the MAC5
> is used. All the three modes are supported. MAC5 -> PHY0, MAC5 ->
> PHY4, MAC5 ->
> EXTERNAL PHY and MAC5 to external MAC.
>
> When MAC5 is a DSA port it skips settings the delay settings. See [2].
>
> Maybe you can use a similar concept.
Current detection relies on an incorrect assumption that mt753x switch
is always used with mtk_eth_soc. It's a really hacky solution to use
dt properties that don't belong to this switch at all and I think this
approach should not be followed further by future code.
The usage of mac5 should be explicitly defined as a dt property
under mt753x node.
--
Regards,
Chuanhong Guo
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-08-20 15:30 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 7:14 [PATCH net-next v2 0/7] net-next: dsa: mt7530: add support for MT7531 Landen Chao
2020-08-18 7:14 ` Landen Chao
2020-08-18 7:14 ` [PATCH net-next v2 1/7] net: dsa: mt7530: Refine message in Kconfig Landen Chao
2020-08-18 7:14 ` Landen Chao
2020-08-18 7:14 ` [PATCH net-next v2 2/7] net: dsa: mt7530: support full-duplex gigabit only Landen Chao
2020-08-18 7:14 ` Landen Chao
2020-08-18 15:49 ` Andrew Lunn
2020-08-18 15:49 ` Andrew Lunn
2020-08-18 7:14 ` [PATCH net-next v2 3/7] net: dsa: mt7530: Extend device data ready for adding a new hardware Landen Chao
2020-08-18 7:14 ` Landen Chao
2020-08-18 15:56 ` Andrew Lunn
2020-08-18 15:56 ` Andrew Lunn
2020-08-18 17:31 ` Frank Wunderlich
2020-08-18 17:31 ` Frank Wunderlich
2020-08-18 7:14 ` [PATCH net-next v2 4/7] dt-bindings: net: dsa: add new MT7531 binding to support MT7531 Landen Chao
2020-08-18 7:14 ` Landen Chao
2020-08-25 19:43 ` Rob Herring
2020-08-25 19:43 ` Rob Herring
2020-08-18 7:14 ` [PATCH net-next v2 5/7] net: dsa: mt7530: Add the support of MT7531 switch Landen Chao
2020-08-18 7:14 ` Landen Chao
2020-08-18 15:23 ` Jakub Kicinski
2020-08-18 15:23 ` Jakub Kicinski
2020-08-19 9:50 ` Landen Chao
2020-08-19 9:50 ` Landen Chao
2020-08-18 16:09 ` Andrew Lunn
2020-08-18 16:09 ` Andrew Lunn
2020-08-19 9:44 ` Landen Chao
2020-08-19 9:44 ` Landen Chao
2020-08-19 13:12 ` Andrew Lunn
2020-08-19 13:12 ` Andrew Lunn
2020-08-19 23:46 ` René van Dorst
2020-08-19 23:46 ` René van Dorst
2020-08-20 15:29 ` Chuanhong Guo [this message]
2020-08-20 15:29 ` Chuanhong Guo
2020-08-18 7:14 ` [PATCH net-next v2 6/7] arm64: dts: mt7622: add mt7531 dsa to mt7622-rfb1 board Landen Chao
2020-08-18 7:14 ` Landen Chao
2020-08-18 16:10 ` Andrew Lunn
2020-08-18 16:10 ` Andrew Lunn
2020-08-18 7:14 ` [PATCH net-next v2 7/7] arm64: dts: mt7622: add mt7531 dsa to bananapi-bpi-r64 board Landen Chao
2020-08-18 7:14 ` Landen Chao
2020-08-18 16:24 ` Vladimir Oltean
2020-08-18 16:24 ` Vladimir Oltean
2020-08-19 8:15 ` Landen Chao
2020-08-19 8:15 ` Landen Chao
2020-08-19 8:51 ` Vladimir Oltean
2020-08-19 8:51 ` Vladimir Oltean
2020-08-18 17:54 ` Aw: [PATCH net-next v2 0/7] net-next: dsa: mt7530: add support for MT7531 Frank Wunderlich
2020-08-18 17:54 ` Frank Wunderlich
2020-08-19 3:49 ` DENG Qingfang
2020-08-19 3:49 ` DENG Qingfang
2020-08-19 6:57 ` Frank Wunderlich
2020-08-19 7:38 ` Landen Chao
2020-08-19 7:38 ` Landen Chao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJsYDVJM3A_5Fpp8ube-gOi-Nn-itf0MW6ePL0wM16_k67+x6g@mail.gmail.com \
--to=gch981213@gmail.com \
--cc=Sean.Wang@mediatek.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dqfext@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=frank-w@public-files.de \
--cc=landen.chao@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=opensource@vdorst.com \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.