From: Pablo Neira Ayuso <pablo@netfilter.org> To: Casey Schaufler <casey@schaufler-ca.com> Cc: casey.schaufler@intel.com, jmorris@namei.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, linux-audit@redhat.com, keescook@chromium.org, john.johansen@canonical.com, penguin-kernel@i-love.sakura.ne.jp, paul@paul-moore.com, sds@tycho.nsa.gov, netdev@vger.kernel.org Subject: Re: [PATCH v20 17/23] LSM: security_secid_to_secctx in netlink netfilter Date: Tue, 8 Sep 2020 12:46:21 +0200 [thread overview] Message-ID: <20200908104621.GB4838@salvia> (raw) In-Reply-To: <20200826145247.10029-18-casey@schaufler-ca.com> On Wed, Aug 26, 2020 at 07:52:41AM -0700, Casey Schaufler wrote: > Change netlink netfilter interfaces to use lsmcontext > pointers, and remove scaffolding. > > Reviewed-by: Kees Cook <keescook@chromium.org> > Reviewed-by: John Johansen <john.johansen@canonical.com> > Acked-by: Stephen Smalley <sds@tycho.nsa.gov> > Signed-off-by: Casey Schaufler <casey@schaufler-ca.com> > cc: netdev@vger.kernel.org > --- > net/netfilter/nfnetlink_queue.c | 31 ++++++++++++------------------- > 1 file changed, 12 insertions(+), 19 deletions(-) > [...] > static u32 nfqnl_get_bridge_size(struct nf_queue_entry *entry) > @@ -401,8 +399,7 @@ nfqnl_build_packet_message(struct net *net, struct nfqnl_instance *queue, > enum ip_conntrack_info ctinfo; > struct nfnl_ct_hook *nfnl_ct; > bool csum_verify; > - struct lsmcontext scaff; /* scaffolding */ > - char *secdata = NULL; > + struct lsmcontext context = { }; > u32 seclen = 0; While at it, please introduce reverse xmas tree in variable definitions incrementally: struct lsmcontext context = { }; enum ip_conntrack_info ctinfo; struct nfnl_ct_hook *nfnl_ct; bool csum_verify; u32 seclen = 0; And Cc: netfilter-devel@vger.kernel.org for patches that update the Netfilter codebase. Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Pablo Neira Ayuso <pablo@netfilter.org> To: Casey Schaufler <casey@schaufler-ca.com> Cc: john.johansen@canonical.com, selinux@vger.kernel.org, netdev@vger.kernel.org, jmorris@namei.org, linux-security-module@vger.kernel.org, linux-audit@redhat.com, casey.schaufler@intel.com, sds@tycho.nsa.gov Subject: Re: [PATCH v20 17/23] LSM: security_secid_to_secctx in netlink netfilter Date: Tue, 8 Sep 2020 12:46:21 +0200 [thread overview] Message-ID: <20200908104621.GB4838@salvia> (raw) In-Reply-To: <20200826145247.10029-18-casey@schaufler-ca.com> On Wed, Aug 26, 2020 at 07:52:41AM -0700, Casey Schaufler wrote: > Change netlink netfilter interfaces to use lsmcontext > pointers, and remove scaffolding. > > Reviewed-by: Kees Cook <keescook@chromium.org> > Reviewed-by: John Johansen <john.johansen@canonical.com> > Acked-by: Stephen Smalley <sds@tycho.nsa.gov> > Signed-off-by: Casey Schaufler <casey@schaufler-ca.com> > cc: netdev@vger.kernel.org > --- > net/netfilter/nfnetlink_queue.c | 31 ++++++++++++------------------- > 1 file changed, 12 insertions(+), 19 deletions(-) > [...] > static u32 nfqnl_get_bridge_size(struct nf_queue_entry *entry) > @@ -401,8 +399,7 @@ nfqnl_build_packet_message(struct net *net, struct nfqnl_instance *queue, > enum ip_conntrack_info ctinfo; > struct nfnl_ct_hook *nfnl_ct; > bool csum_verify; > - struct lsmcontext scaff; /* scaffolding */ > - char *secdata = NULL; > + struct lsmcontext context = { }; > u32 seclen = 0; While at it, please introduce reverse xmas tree in variable definitions incrementally: struct lsmcontext context = { }; enum ip_conntrack_info ctinfo; struct nfnl_ct_hook *nfnl_ct; bool csum_verify; u32 seclen = 0; And Cc: netfilter-devel@vger.kernel.org for patches that update the Netfilter codebase. Thanks. -- Linux-audit mailing list Linux-audit@redhat.com https://www.redhat.com/mailman/listinfo/linux-audit
next prev parent reply other threads:[~2020-09-08 10:47 UTC|newest] Thread overview: 126+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20200826145247.10029-1-casey.ref@schaufler-ca.com> 2020-08-26 14:52 ` [PATCH v20 00/23] LSM: Module stacking for AppArmor Casey Schaufler 2020-08-26 14:52 ` Casey Schaufler 2020-08-26 14:52 ` [PATCH v20 01/23] LSM: Infrastructure management of the sock security Casey Schaufler 2020-08-26 14:52 ` Casey Schaufler 2020-08-26 14:52 ` [PATCH v20 02/23] LSM: Create and manage the lsmblob data structure Casey Schaufler 2020-08-26 14:52 ` Casey Schaufler 2020-09-04 21:50 ` Paul Moore 2020-09-04 21:50 ` Paul Moore 2020-08-26 14:52 ` [PATCH v20 03/23] LSM: Use lsmblob in security_audit_rule_match Casey Schaufler 2020-08-26 14:52 ` Casey Schaufler 2020-09-04 18:53 ` Paul Moore 2020-09-04 18:53 ` Paul Moore 2020-08-26 14:52 ` [PATCH v20 04/23] LSM: Use lsmblob in security_kernel_act_as Casey Schaufler 2020-08-26 14:52 ` Casey Schaufler 2020-09-04 19:46 ` Paul Moore 2020-09-04 19:46 ` Paul Moore 2020-08-26 14:52 ` [PATCH v20 05/23] net: Prepare UDS for security module stacking Casey Schaufler 2020-08-26 14:52 ` Casey Schaufler 2020-09-03 16:28 ` James Morris 2020-09-03 16:28 ` James Morris 2020-09-04 20:08 ` Paul Moore 2020-09-04 20:08 ` Paul Moore 2020-09-04 21:35 ` Casey Schaufler 2020-09-04 21:35 ` Casey Schaufler 2020-09-04 21:53 ` Paul Moore 2020-09-04 21:53 ` Paul Moore 2020-09-04 23:58 ` Casey Schaufler 2020-09-04 23:58 ` Casey Schaufler 2020-09-05 13:25 ` Paul Moore 2020-09-05 13:25 ` Paul Moore 2020-09-05 18:13 ` Casey Schaufler 2020-09-05 18:13 ` Casey Schaufler 2020-09-05 19:05 ` John Johansen 2020-09-05 19:05 ` John Johansen 2020-09-08 1:28 ` Stephen Smalley 2020-09-08 1:28 ` Stephen Smalley 2020-09-08 13:35 ` Stephen Smalley 2020-09-08 13:35 ` Stephen Smalley 2020-09-08 23:37 ` Casey Schaufler 2020-09-08 23:37 ` Casey Schaufler 2020-09-09 0:21 ` John Johansen 2020-09-09 0:21 ` John Johansen 2020-09-09 13:19 ` Stephen Smalley 2020-09-09 13:19 ` Stephen Smalley 2020-09-09 18:19 ` Casey Schaufler 2020-09-09 18:19 ` Casey Schaufler 2020-09-09 18:33 ` John Johansen 2020-09-09 18:33 ` John Johansen 2020-09-09 18:47 ` John Johansen 2020-09-09 18:47 ` John Johansen 2020-09-10 14:11 ` Paul Moore 2020-09-10 14:11 ` Paul Moore 2020-09-09 0:17 ` John Johansen 2020-09-09 0:17 ` John Johansen 2020-08-26 14:52 ` [PATCH v20 06/23] LSM: Use lsmblob in security_secctx_to_secid Casey Schaufler 2020-08-26 14:52 ` Casey Schaufler 2020-09-04 21:29 ` Paul Moore 2020-09-04 21:29 ` Paul Moore 2020-08-26 14:52 ` [PATCH v20 07/23] LSM: Use lsmblob in security_secid_to_secctx Casey Schaufler 2020-08-26 14:52 ` Casey Schaufler 2020-09-04 21:59 ` Paul Moore 2020-09-04 21:59 ` Paul Moore 2020-08-26 14:52 ` [PATCH v20 08/23] LSM: Use lsmblob in security_ipc_getsecid Casey Schaufler 2020-08-26 14:52 ` Casey Schaufler 2020-09-05 13:12 ` Paul Moore 2020-09-05 13:12 ` Paul Moore 2020-08-26 14:52 ` [PATCH v20 09/23] LSM: Use lsmblob in security_task_getsecid Casey Schaufler 2020-08-26 14:52 ` Casey Schaufler 2020-09-05 13:18 ` Paul Moore 2020-09-05 13:18 ` Paul Moore 2020-08-26 14:52 ` [PATCH v20 10/23] LSM: Use lsmblob in security_inode_getsecid Casey Schaufler 2020-08-26 14:52 ` Casey Schaufler 2020-09-05 13:20 ` Paul Moore 2020-09-05 13:20 ` Paul Moore 2020-08-26 14:52 ` [PATCH v20 11/23] LSM: Use lsmblob in security_cred_getsecid Casey Schaufler 2020-08-26 14:52 ` Casey Schaufler 2020-08-26 14:52 ` [PATCH v20 12/23] IMA: Change internal interfaces to use lsmblobs Casey Schaufler 2020-08-26 14:52 ` Casey Schaufler 2020-09-06 2:28 ` Paul Moore 2020-09-06 2:28 ` Paul Moore 2020-08-26 14:52 ` [PATCH v20 13/23] LSM: Specify which LSM to display Casey Schaufler 2020-08-26 14:52 ` Casey Schaufler 2020-08-26 14:52 ` [PATCH v20 14/23] LSM: Ensure the correct LSM context releaser Casey Schaufler 2020-08-26 14:52 ` Casey Schaufler 2020-09-06 2:45 ` Paul Moore 2020-09-06 2:45 ` Paul Moore 2020-08-26 14:52 ` [PATCH v20 15/23] LSM: Use lsmcontext in security_secid_to_secctx Casey Schaufler 2020-08-26 14:52 ` Casey Schaufler 2020-08-26 14:52 ` [PATCH v20 16/23] LSM: Use lsmcontext in security_inode_getsecctx Casey Schaufler 2020-08-26 14:52 ` Casey Schaufler 2020-09-06 2:55 ` Paul Moore 2020-09-06 2:55 ` Paul Moore 2020-08-26 14:52 ` [PATCH v20 17/23] LSM: security_secid_to_secctx in netlink netfilter Casey Schaufler 2020-08-26 14:52 ` Casey Schaufler 2020-09-06 3:11 ` Paul Moore 2020-09-06 3:11 ` Paul Moore 2020-09-08 10:46 ` Pablo Neira Ayuso [this message] 2020-09-08 10:46 ` Pablo Neira Ayuso 2020-08-26 14:52 ` [PATCH v20 18/23] NET: Store LSM netlabel data in a lsmblob Casey Schaufler 2020-08-26 14:52 ` Casey Schaufler 2020-09-06 3:27 ` Paul Moore 2020-09-06 3:27 ` Paul Moore 2020-08-26 14:52 ` [PATCH v20 19/23] LSM: Verify LSM display sanity in binder Casey Schaufler 2020-08-26 14:52 ` Casey Schaufler 2020-09-06 3:30 ` Paul Moore 2020-09-06 3:30 ` Paul Moore 2020-08-26 14:52 ` [PATCH v20 20/23] Audit: Add new record for multiple process LSM attributes Casey Schaufler 2020-08-26 14:52 ` Casey Schaufler 2020-09-03 16:32 ` James Morris 2020-09-03 16:32 ` James Morris 2020-09-03 17:00 ` John Johansen 2020-09-03 17:00 ` John Johansen 2020-09-03 21:49 ` Paul Moore 2020-09-03 21:49 ` Paul Moore 2020-09-06 16:32 ` Paul Moore 2020-09-06 16:32 ` Paul Moore 2020-08-26 14:52 ` [PATCH v20 21/23] Audit: Add a new record for multiple object " Casey Schaufler 2020-08-26 14:52 ` Casey Schaufler 2020-08-26 14:52 ` [PATCH v20 22/23] LSM: Add /proc attr entry for full LSM context Casey Schaufler 2020-08-26 14:52 ` Casey Schaufler 2020-08-26 18:02 ` Randy Dunlap 2020-08-26 18:02 ` Randy Dunlap 2020-08-26 14:52 ` [PATCH v20 23/23] AppArmor: Remove the exclusive flag Casey Schaufler 2020-08-26 14:52 ` Casey Schaufler 2020-08-26 15:27 ` [PATCH v20 00/23] LSM: Module stacking for AppArmor Casey Schaufler 2020-08-26 15:27 ` Casey Schaufler
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200908104621.GB4838@salvia \ --to=pablo@netfilter.org \ --cc=casey.schaufler@intel.com \ --cc=casey@schaufler-ca.com \ --cc=jmorris@namei.org \ --cc=john.johansen@canonical.com \ --cc=keescook@chromium.org \ --cc=linux-audit@redhat.com \ --cc=linux-security-module@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=paul@paul-moore.com \ --cc=penguin-kernel@i-love.sakura.ne.jp \ --cc=sds@tycho.nsa.gov \ --cc=selinux@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.