From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@lst.de>
Cc: iommu@lists.linux-foundation.org,
Russell King <linux@armlinux.org.uk>,
Santosh Shilimkar <ssantosh@kernel.org>,
Jim Quinlan <james.quinlan@broadcom.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Robin Murphy <robin.murphy@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-remoteproc@vger.kernel.org, linux-usb@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 5/6] usb: don't inherity DMA properties for USB devices
Date: Mon, 14 Sep 2020 07:51:40 +0000 [thread overview]
Message-ID: <20200914075140.GA1033580@kroah.com> (raw)
In-Reply-To: <20200914073343.1579578-6-hch@lst.de>
On Mon, Sep 14, 2020 at 09:33:42AM +0200, Christoph Hellwig wrote:
> As the comment in usb_alloc_dev correctly states, drivers can't use
> the DMA API on usb device, and at least calling dma_set_mask on them
> is highly dangerous. Unlike what the comment states upper level drivers
> also can't really use the presence of a dma mask to check for DMA
> support, as the dma_mask is set by default for most busses.
>
> Setting the dma_mask comes from "[PATCH] usbcore dma updates (and doc)"
> in BitKeeper times, as it seems like it was primarily for setting the
> NETIF_F_HIGHDMA flag in USB drivers, something that has long been
> fixed up since.
>
> Setting the dma_pfn_offset comes from commit b44bbc46a8bb
> ("usb: core: setup dma_pfn_offset for USB devices and, interfaces"),
> which worked around the fact that the scsi_calculate_bounce_limits
> functions wasn't going through the proper driver interface to query
> DMA information, but that function was removed in commit 21e07dba9fb1
> ("scsi: reduce use of block bounce buffers") years ago.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@lst.de>
Cc: iommu@lists.linux-foundation.org,
Russell King <linux@armlinux.org.uk>,
Santosh Shilimkar <ssantosh@kernel.org>,
Jim Quinlan <james.quinlan@broadcom.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Robin Murphy <robin.murphy@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-remoteproc@vger.kernel.org, linux-usb@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 5/6] usb: don't inherity DMA properties for USB devices
Date: Mon, 14 Sep 2020 09:51:40 +0200 [thread overview]
Message-ID: <20200914075140.GA1033580@kroah.com> (raw)
In-Reply-To: <20200914073343.1579578-6-hch@lst.de>
On Mon, Sep 14, 2020 at 09:33:42AM +0200, Christoph Hellwig wrote:
> As the comment in usb_alloc_dev correctly states, drivers can't use
> the DMA API on usb device, and at least calling dma_set_mask on them
> is highly dangerous. Unlike what the comment states upper level drivers
> also can't really use the presence of a dma mask to check for DMA
> support, as the dma_mask is set by default for most busses.
>
> Setting the dma_mask comes from "[PATCH] usbcore dma updates (and doc)"
> in BitKeeper times, as it seems like it was primarily for setting the
> NETIF_F_HIGHDMA flag in USB drivers, something that has long been
> fixed up since.
>
> Setting the dma_pfn_offset comes from commit b44bbc46a8bb
> ("usb: core: setup dma_pfn_offset for USB devices and, interfaces"),
> which worked around the fact that the scsi_calculate_bounce_limits
> functions wasn't going through the proper driver interface to query
> DMA information, but that function was removed in commit 21e07dba9fb1
> ("scsi: reduce use of block bounce buffers") years ago.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
devicetree@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
linux-pci@vger.kernel.org, Frank Rowand <frowand.list@gmail.com>,
linux-usb@vger.kernel.org, linux-remoteproc@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org,
Rob Herring <robh+dt@kernel.org>,
Jim Quinlan <james.quinlan@broadcom.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Nathan Chancellor <natechancellor@gmail.com>,
Robin Murphy <robin.murphy@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/6] usb: don't inherity DMA properties for USB devices
Date: Mon, 14 Sep 2020 09:51:40 +0200 [thread overview]
Message-ID: <20200914075140.GA1033580@kroah.com> (raw)
In-Reply-To: <20200914073343.1579578-6-hch@lst.de>
On Mon, Sep 14, 2020 at 09:33:42AM +0200, Christoph Hellwig wrote:
> As the comment in usb_alloc_dev correctly states, drivers can't use
> the DMA API on usb device, and at least calling dma_set_mask on them
> is highly dangerous. Unlike what the comment states upper level drivers
> also can't really use the presence of a dma mask to check for DMA
> support, as the dma_mask is set by default for most busses.
>
> Setting the dma_mask comes from "[PATCH] usbcore dma updates (and doc)"
> in BitKeeper times, as it seems like it was primarily for setting the
> NETIF_F_HIGHDMA flag in USB drivers, something that has long been
> fixed up since.
>
> Setting the dma_pfn_offset comes from commit b44bbc46a8bb
> ("usb: core: setup dma_pfn_offset for USB devices and, interfaces"),
> which worked around the fact that the scsi_calculate_bounce_limits
> functions wasn't going through the proper driver interface to query
> DMA information, but that function was removed in commit 21e07dba9fb1
> ("scsi: reduce use of block bounce buffers") years ago.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
devicetree@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
linux-pci@vger.kernel.org, Frank Rowand <frowand.list@gmail.com>,
linux-usb@vger.kernel.org, linux-remoteproc@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org,
Rob Herring <robh+dt@kernel.org>,
Jim Quinlan <james.quinlan@broadcom.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Nathan Chancellor <natechancellor@gmail.com>,
Robin Murphy <robin.murphy@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/6] usb: don't inherity DMA properties for USB devices
Date: Mon, 14 Sep 2020 09:51:40 +0200 [thread overview]
Message-ID: <20200914075140.GA1033580@kroah.com> (raw)
In-Reply-To: <20200914073343.1579578-6-hch@lst.de>
On Mon, Sep 14, 2020 at 09:33:42AM +0200, Christoph Hellwig wrote:
> As the comment in usb_alloc_dev correctly states, drivers can't use
> the DMA API on usb device, and at least calling dma_set_mask on them
> is highly dangerous. Unlike what the comment states upper level drivers
> also can't really use the presence of a dma mask to check for DMA
> support, as the dma_mask is set by default for most busses.
>
> Setting the dma_mask comes from "[PATCH] usbcore dma updates (and doc)"
> in BitKeeper times, as it seems like it was primarily for setting the
> NETIF_F_HIGHDMA flag in USB drivers, something that has long been
> fixed up since.
>
> Setting the dma_pfn_offset comes from commit b44bbc46a8bb
> ("usb: core: setup dma_pfn_offset for USB devices and, interfaces"),
> which worked around the fact that the scsi_calculate_bounce_limits
> functions wasn't going through the proper driver interface to query
> DMA information, but that function was removed in commit 21e07dba9fb1
> ("scsi: reduce use of block bounce buffers") years ago.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-14 7:51 UTC|newest]
Thread overview: 148+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 5:40 support range based offsets in dma-direct Christoph Hellwig
2020-09-10 5:40 ` Christoph Hellwig
2020-09-10 5:40 ` Christoph Hellwig
2020-09-10 5:40 ` Christoph Hellwig
2020-09-10 5:40 ` [PATCH 1/3] ARM/dma-mapping: move various helpers from dma-mapping.h to dma-direct.h Christoph Hellwig
2020-09-10 5:40 ` Christoph Hellwig
2020-09-10 5:40 ` Christoph Hellwig
2020-09-10 5:40 ` Christoph Hellwig
2020-09-10 18:02 ` Robin Murphy
2020-09-10 18:02 ` Robin Murphy
2020-09-10 18:02 ` Robin Murphy
2020-09-10 18:02 ` Robin Murphy
2020-09-11 6:25 ` Christoph Hellwig
2020-09-11 6:25 ` Christoph Hellwig
2020-09-11 6:25 ` Christoph Hellwig
2020-09-11 6:25 ` Christoph Hellwig
2020-09-10 5:40 ` [PATCH 2/3] ARM/keystone: move the DMA offset handling under ifdef CONFIG_ARM_LPAE Christoph Hellwig
2020-09-10 5:40 ` Christoph Hellwig
2020-09-10 5:40 ` Christoph Hellwig
2020-09-10 5:40 ` Christoph Hellwig
2020-09-11 11:12 ` Robin Murphy
2020-09-11 11:12 ` Robin Murphy
2020-09-11 11:12 ` Robin Murphy
2020-09-11 11:12 ` Robin Murphy
2020-09-11 11:15 ` Russell King - ARM Linux admin
2020-09-11 11:15 ` Russell King - ARM Linux admin
2020-09-11 11:15 ` Russell King - ARM Linux admin
2020-09-11 11:15 ` Russell King - ARM Linux admin
2020-09-11 11:27 ` Robin Murphy
2020-09-11 11:27 ` Robin Murphy
2020-09-11 11:27 ` Robin Murphy
2020-09-11 11:27 ` Robin Murphy
2020-09-11 18:00 ` santosh.shilimkar
2020-09-11 18:00 ` santosh.shilimkar
2020-09-11 18:00 ` santosh.shilimkar
2020-09-11 18:00 ` santosh.shilimkar
2020-09-10 5:40 ` [PATCH 3/3] dma-mapping: introduce DMA range map, supplanting dma_pfn_offset Christoph Hellwig
2020-09-10 5:40 ` Christoph Hellwig
2020-09-10 5:40 ` Christoph Hellwig
2020-09-10 5:40 ` Christoph Hellwig
2020-09-10 7:53 ` Greg KH
2020-09-10 7:53 ` Greg KH
2020-09-10 7:53 ` Greg KH
2020-09-10 7:53 ` Greg KH
2020-09-10 9:13 ` Christoph Hellwig
2020-09-10 9:13 ` Christoph Hellwig
2020-09-10 9:13 ` Christoph Hellwig
2020-09-10 9:13 ` Christoph Hellwig
2020-09-10 16:12 ` Greg KH
2020-09-10 16:12 ` Greg KH
2020-09-10 16:12 ` Greg KH
2020-09-10 16:12 ` Greg KH
2020-09-11 16:12 ` Robin Murphy
2020-09-11 16:12 ` Robin Murphy
2020-09-11 16:12 ` Robin Murphy
2020-09-11 16:12 ` Robin Murphy
2020-09-12 6:46 ` Christoph Hellwig
2020-09-12 6:46 ` Christoph Hellwig
2020-09-12 6:46 ` Christoph Hellwig
2020-09-12 6:46 ` Christoph Hellwig
2020-09-14 7:33 ` support range based offsets in dma-direct v2 Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` [PATCH 1/6] ARM/dma-mapping: remove a __arch_page_to_dma #error Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` [PATCH 2/6] ARM/dma-mapping: remove dma_to_virt Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` [PATCH 3/6] ARM/dma-mapping: move various helpers from dma-mapping.h to dma-direct.h Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` [PATCH 4/6] ARM/keystone: move the DMA offset handling under ifdef CONFIG_ARM_LPAE Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` [PATCH 5/6] usb: don't inherity DMA properties for USB devices Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:51 ` Greg Kroah-Hartman [this message]
2020-09-14 7:51 ` Greg Kroah-Hartman
2020-09-14 7:51 ` Greg Kroah-Hartman
2020-09-14 7:51 ` Greg Kroah-Hartman
2020-09-14 7:33 ` [PATCH 6/6] dma-mapping: introduce DMA range map, supplanting dma_pfn_offset Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 23:01 ` Mathieu Poirier
2020-09-14 23:01 ` Mathieu Poirier
2020-09-14 23:01 ` Mathieu Poirier
2020-09-14 23:01 ` Mathieu Poirier
2020-09-15 5:41 ` Christoph Hellwig
2020-09-15 5:41 ` Christoph Hellwig
2020-09-15 5:41 ` Christoph Hellwig
2020-09-15 5:41 ` Christoph Hellwig
2020-09-15 19:55 ` Mathieu Poirier
2020-09-15 19:55 ` Mathieu Poirier
2020-09-15 19:55 ` Mathieu Poirier
2020-09-15 19:55 ` Mathieu Poirier
2020-09-16 6:13 ` Christoph Hellwig
2020-09-16 6:13 ` Christoph Hellwig
2020-09-16 6:13 ` Christoph Hellwig
2020-09-16 6:13 ` Christoph Hellwig
2020-09-16 6:14 ` support range based offsets in dma-direct v3 Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` [PATCH 1/6] ARM/dma-mapping: remove a __arch_page_to_dma #error Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` [PATCH 2/6] ARM/dma-mapping: remove dma_to_virt Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` [PATCH 3/6] ARM/dma-mapping: move various helpers from dma-mapping.h to dma-direct.h Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` [PATCH 4/6] ARM/keystone: move the DMA offset handling under ifdef CONFIG_ARM_LPAE Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` [PATCH 5/6] usb: don't inherity DMA properties for USB devices Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` [PATCH 6/6] dma-mapping: introduce DMA range map, supplanting dma_pfn_offset Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 17:36 ` Mathieu Poirier
2020-09-16 17:36 ` Mathieu Poirier
2020-09-16 17:36 ` Mathieu Poirier
2020-09-16 17:36 ` Mathieu Poirier
2020-10-26 15:33 ` Geert Uytterhoeven
2020-10-26 15:33 ` Geert Uytterhoeven
2020-10-26 15:33 ` Geert Uytterhoeven
2020-10-26 15:33 ` Geert Uytterhoeven
2020-09-17 16:45 ` support range based offsets in dma-direct v3 Christoph Hellwig
2020-09-17 16:45 ` Christoph Hellwig
2020-09-17 16:45 ` Christoph Hellwig
2020-09-17 16:45 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914075140.GA1033580@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=james.quinlan@broadcom.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=natechancellor@gmail.com \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.