From: santosh.shilimkar@oracle.com
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>,
Christoph Hellwig <hch@lst.de>
Cc: iommu@lists.linux-foundation.org,
Santosh Shilimkar <ssantosh@kernel.org>,
Jim Quinlan <james.quinlan@broadcom.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Robin Murphy <robin.murphy@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org,
devicetree@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 2/3] ARM/keystone: move the DMA offset handling under ifdef CONFIG_ARM_LPAE
Date: Fri, 11 Sep 2020 18:00:52 +0000 [thread overview]
Message-ID: <f13c72b9-9efa-7b9d-6c23-19f87b151bc4@oracle.com> (raw)
In-Reply-To: <20200911111551.GG1551@shell.armlinux.org.uk>
On 9/11/20 4:15 AM, Russell King - ARM Linux admin wrote:
> On Thu, Sep 10, 2020 at 07:40:37AM +0200, Christoph Hellwig wrote:
>> The DMA offset notifier can only be used if PHYS_OFFSET is at least
>> KEYSTONE_HIGH_PHYS_START, which can't be represented by a 32-bit
>> phys_addr_t. Currently the code compiles fine despite that, a pending
>> change to the DMA offset handling would create a compiler warning for
>> this case. Add an ifdef to not compile the code except for LPAE
>> configs.
>
> However, to have use of the high physical offset, LPAE needs to be
> enabled, which ensures that phys_addr_t is 64-bit.
>
> I believe that DMA is non-coherent on this platform unless the high
> physical address is used. Or something like that.
>
Exactly. Higher address ranges needs to be used for DMA coherency.
Regards,
Santosh
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@oracle.com
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>,
Christoph Hellwig <hch@lst.de>
Cc: iommu@lists.linux-foundation.org,
Santosh Shilimkar <ssantosh@kernel.org>,
Jim Quinlan <james.quinlan@broadcom.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Robin Murphy <robin.murphy@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org,
devicetree@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 2/3] ARM/keystone: move the DMA offset handling under ifdef CONFIG_ARM_LPAE
Date: Fri, 11 Sep 2020 11:00:52 -0700 [thread overview]
Message-ID: <f13c72b9-9efa-7b9d-6c23-19f87b151bc4@oracle.com> (raw)
In-Reply-To: <20200911111551.GG1551@shell.armlinux.org.uk>
On 9/11/20 4:15 AM, Russell King - ARM Linux admin wrote:
> On Thu, Sep 10, 2020 at 07:40:37AM +0200, Christoph Hellwig wrote:
>> The DMA offset notifier can only be used if PHYS_OFFSET is at least
>> KEYSTONE_HIGH_PHYS_START, which can't be represented by a 32-bit
>> phys_addr_t. Currently the code compiles fine despite that, a pending
>> change to the DMA offset handling would create a compiler warning for
>> this case. Add an ifdef to not compile the code except for LPAE
>> configs.
>
> However, to have use of the high physical offset, LPAE needs to be
> enabled, which ensures that phys_addr_t is 64-bit.
>
> I believe that DMA is non-coherent on this platform unless the high
> physical address is used. Or something like that.
>
Exactly. Higher address ranges needs to be used for DMA coherency.
Regards,
Santosh
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@oracle.com
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>,
Christoph Hellwig <hch@lst.de>
Cc: devicetree@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
linux-sh@vger.kernel.org, Frank Rowand <frowand.list@gmail.com>,
linux-usb@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
iommu@lists.linux-foundation.org,
Rob Herring <robh+dt@kernel.org>,
Jim Quinlan <james.quinlan@broadcom.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Nathan Chancellor <natechancellor@gmail.com>,
Robin Murphy <robin.murphy@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] ARM/keystone: move the DMA offset handling under ifdef CONFIG_ARM_LPAE
Date: Fri, 11 Sep 2020 11:00:52 -0700 [thread overview]
Message-ID: <f13c72b9-9efa-7b9d-6c23-19f87b151bc4@oracle.com> (raw)
In-Reply-To: <20200911111551.GG1551@shell.armlinux.org.uk>
On 9/11/20 4:15 AM, Russell King - ARM Linux admin wrote:
> On Thu, Sep 10, 2020 at 07:40:37AM +0200, Christoph Hellwig wrote:
>> The DMA offset notifier can only be used if PHYS_OFFSET is at least
>> KEYSTONE_HIGH_PHYS_START, which can't be represented by a 32-bit
>> phys_addr_t. Currently the code compiles fine despite that, a pending
>> change to the DMA offset handling would create a compiler warning for
>> this case. Add an ifdef to not compile the code except for LPAE
>> configs.
>
> However, to have use of the high physical offset, LPAE needs to be
> enabled, which ensures that phys_addr_t is 64-bit.
>
> I believe that DMA is non-coherent on this platform unless the high
> physical address is used. Or something like that.
>
Exactly. Higher address ranges needs to be used for DMA coherency.
Regards,
Santosh
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@oracle.com
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>,
Christoph Hellwig <hch@lst.de>
Cc: devicetree@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
linux-sh@vger.kernel.org, Frank Rowand <frowand.list@gmail.com>,
linux-usb@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
iommu@lists.linux-foundation.org,
Rob Herring <robh+dt@kernel.org>,
Jim Quinlan <james.quinlan@broadcom.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Nathan Chancellor <natechancellor@gmail.com>,
Robin Murphy <robin.murphy@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] ARM/keystone: move the DMA offset handling under ifdef CONFIG_ARM_LPAE
Date: Fri, 11 Sep 2020 11:00:52 -0700 [thread overview]
Message-ID: <f13c72b9-9efa-7b9d-6c23-19f87b151bc4@oracle.com> (raw)
In-Reply-To: <20200911111551.GG1551@shell.armlinux.org.uk>
On 9/11/20 4:15 AM, Russell King - ARM Linux admin wrote:
> On Thu, Sep 10, 2020 at 07:40:37AM +0200, Christoph Hellwig wrote:
>> The DMA offset notifier can only be used if PHYS_OFFSET is at least
>> KEYSTONE_HIGH_PHYS_START, which can't be represented by a 32-bit
>> phys_addr_t. Currently the code compiles fine despite that, a pending
>> change to the DMA offset handling would create a compiler warning for
>> this case. Add an ifdef to not compile the code except for LPAE
>> configs.
>
> However, to have use of the high physical offset, LPAE needs to be
> enabled, which ensures that phys_addr_t is 64-bit.
>
> I believe that DMA is non-coherent on this platform unless the high
> physical address is used. Or something like that.
>
Exactly. Higher address ranges needs to be used for DMA coherency.
Regards,
Santosh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-11 18:00 UTC|newest]
Thread overview: 148+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 5:40 support range based offsets in dma-direct Christoph Hellwig
2020-09-10 5:40 ` Christoph Hellwig
2020-09-10 5:40 ` Christoph Hellwig
2020-09-10 5:40 ` Christoph Hellwig
2020-09-10 5:40 ` [PATCH 1/3] ARM/dma-mapping: move various helpers from dma-mapping.h to dma-direct.h Christoph Hellwig
2020-09-10 5:40 ` Christoph Hellwig
2020-09-10 5:40 ` Christoph Hellwig
2020-09-10 5:40 ` Christoph Hellwig
2020-09-10 18:02 ` Robin Murphy
2020-09-10 18:02 ` Robin Murphy
2020-09-10 18:02 ` Robin Murphy
2020-09-10 18:02 ` Robin Murphy
2020-09-11 6:25 ` Christoph Hellwig
2020-09-11 6:25 ` Christoph Hellwig
2020-09-11 6:25 ` Christoph Hellwig
2020-09-11 6:25 ` Christoph Hellwig
2020-09-10 5:40 ` [PATCH 2/3] ARM/keystone: move the DMA offset handling under ifdef CONFIG_ARM_LPAE Christoph Hellwig
2020-09-10 5:40 ` Christoph Hellwig
2020-09-10 5:40 ` Christoph Hellwig
2020-09-10 5:40 ` Christoph Hellwig
2020-09-11 11:12 ` Robin Murphy
2020-09-11 11:12 ` Robin Murphy
2020-09-11 11:12 ` Robin Murphy
2020-09-11 11:12 ` Robin Murphy
2020-09-11 11:15 ` Russell King - ARM Linux admin
2020-09-11 11:15 ` Russell King - ARM Linux admin
2020-09-11 11:15 ` Russell King - ARM Linux admin
2020-09-11 11:15 ` Russell King - ARM Linux admin
2020-09-11 11:27 ` Robin Murphy
2020-09-11 11:27 ` Robin Murphy
2020-09-11 11:27 ` Robin Murphy
2020-09-11 11:27 ` Robin Murphy
2020-09-11 18:00 ` santosh.shilimkar [this message]
2020-09-11 18:00 ` santosh.shilimkar
2020-09-11 18:00 ` santosh.shilimkar
2020-09-11 18:00 ` santosh.shilimkar
2020-09-10 5:40 ` [PATCH 3/3] dma-mapping: introduce DMA range map, supplanting dma_pfn_offset Christoph Hellwig
2020-09-10 5:40 ` Christoph Hellwig
2020-09-10 5:40 ` Christoph Hellwig
2020-09-10 5:40 ` Christoph Hellwig
2020-09-10 7:53 ` Greg KH
2020-09-10 7:53 ` Greg KH
2020-09-10 7:53 ` Greg KH
2020-09-10 7:53 ` Greg KH
2020-09-10 9:13 ` Christoph Hellwig
2020-09-10 9:13 ` Christoph Hellwig
2020-09-10 9:13 ` Christoph Hellwig
2020-09-10 9:13 ` Christoph Hellwig
2020-09-10 16:12 ` Greg KH
2020-09-10 16:12 ` Greg KH
2020-09-10 16:12 ` Greg KH
2020-09-10 16:12 ` Greg KH
2020-09-11 16:12 ` Robin Murphy
2020-09-11 16:12 ` Robin Murphy
2020-09-11 16:12 ` Robin Murphy
2020-09-11 16:12 ` Robin Murphy
2020-09-12 6:46 ` Christoph Hellwig
2020-09-12 6:46 ` Christoph Hellwig
2020-09-12 6:46 ` Christoph Hellwig
2020-09-12 6:46 ` Christoph Hellwig
2020-09-14 7:33 ` support range based offsets in dma-direct v2 Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` [PATCH 1/6] ARM/dma-mapping: remove a __arch_page_to_dma #error Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` [PATCH 2/6] ARM/dma-mapping: remove dma_to_virt Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` [PATCH 3/6] ARM/dma-mapping: move various helpers from dma-mapping.h to dma-direct.h Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` [PATCH 4/6] ARM/keystone: move the DMA offset handling under ifdef CONFIG_ARM_LPAE Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` [PATCH 5/6] usb: don't inherity DMA properties for USB devices Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:51 ` Greg Kroah-Hartman
2020-09-14 7:51 ` Greg Kroah-Hartman
2020-09-14 7:51 ` Greg Kroah-Hartman
2020-09-14 7:51 ` Greg Kroah-Hartman
2020-09-14 7:33 ` [PATCH 6/6] dma-mapping: introduce DMA range map, supplanting dma_pfn_offset Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 7:33 ` Christoph Hellwig
2020-09-14 23:01 ` Mathieu Poirier
2020-09-14 23:01 ` Mathieu Poirier
2020-09-14 23:01 ` Mathieu Poirier
2020-09-14 23:01 ` Mathieu Poirier
2020-09-15 5:41 ` Christoph Hellwig
2020-09-15 5:41 ` Christoph Hellwig
2020-09-15 5:41 ` Christoph Hellwig
2020-09-15 5:41 ` Christoph Hellwig
2020-09-15 19:55 ` Mathieu Poirier
2020-09-15 19:55 ` Mathieu Poirier
2020-09-15 19:55 ` Mathieu Poirier
2020-09-15 19:55 ` Mathieu Poirier
2020-09-16 6:13 ` Christoph Hellwig
2020-09-16 6:13 ` Christoph Hellwig
2020-09-16 6:13 ` Christoph Hellwig
2020-09-16 6:13 ` Christoph Hellwig
2020-09-16 6:14 ` support range based offsets in dma-direct v3 Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` [PATCH 1/6] ARM/dma-mapping: remove a __arch_page_to_dma #error Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` [PATCH 2/6] ARM/dma-mapping: remove dma_to_virt Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` [PATCH 3/6] ARM/dma-mapping: move various helpers from dma-mapping.h to dma-direct.h Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` [PATCH 4/6] ARM/keystone: move the DMA offset handling under ifdef CONFIG_ARM_LPAE Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` [PATCH 5/6] usb: don't inherity DMA properties for USB devices Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` [PATCH 6/6] dma-mapping: introduce DMA range map, supplanting dma_pfn_offset Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 6:14 ` Christoph Hellwig
2020-09-16 17:36 ` Mathieu Poirier
2020-09-16 17:36 ` Mathieu Poirier
2020-09-16 17:36 ` Mathieu Poirier
2020-09-16 17:36 ` Mathieu Poirier
2020-10-26 15:33 ` Geert Uytterhoeven
2020-10-26 15:33 ` Geert Uytterhoeven
2020-10-26 15:33 ` Geert Uytterhoeven
2020-10-26 15:33 ` Geert Uytterhoeven
2020-09-17 16:45 ` support range based offsets in dma-direct v3 Christoph Hellwig
2020-09-17 16:45 ` Christoph Hellwig
2020-09-17 16:45 ` Christoph Hellwig
2020-09-17 16:45 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f13c72b9-9efa-7b9d-6c23-19f87b151bc4@oracle.com \
--to=santosh.shilimkar@oracle.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=james.quinlan@broadcom.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=natechancellor@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.