Re: [RFC 2/2] ath10k: allow dynamic SAR power limits via common API

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC 2/2] ath10k: allow dynamic SAR power limits via common API
Date: Tue, 22 Sep 2020 15:33:25 +0800	[thread overview]
Message-ID: <202009221530.F3OXMbuT%lkp@intel.com> (raw)
In-Reply-To: <1600753775-4745-2-git-send-email-cjhuang@codeaurora.org>

[-- Attachment #1: Type: text/plain, Size: 2882 bytes --]

Hi Carl,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on ath6kl/ath-next]
[cannot apply to mac80211-next/master mac80211/master v5.9-rc6 next-20200921]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Carl-Huang/nl80211-add-common-API-to-configure-SAR-power-limitations/20200922-135108
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath-next
config: i386-randconfig-a006-20200921 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/wireless/ath/ath10k/mac.c:2906:5: warning: no previous prototype for 'ath10k_mac_set_sar_power' [-Wmissing-prototypes]
    2906 | int ath10k_mac_set_sar_power(struct ath10k *ar)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~

# https://github.com/0day-ci/linux/commit/194580acc67fccc13b7f388334db0ec31897ab5a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Carl-Huang/nl80211-add-common-API-to-configure-SAR-power-limitations/20200922-135108
git checkout 194580acc67fccc13b7f388334db0ec31897ab5a
vim +/ath10k_mac_set_sar_power +2906 drivers/net/wireless/ath/ath10k/mac.c

  2905	
> 2906	int ath10k_mac_set_sar_power(struct ath10k *ar)
  2907	{
  2908		int ret;
  2909	
  2910		if (!ar->hw_params.dynamic_sar_support)
  2911			return 0;
  2912	
  2913		if (ar->tx_power_2g_limit == 0 || ar->tx_power_5g_limit == 0)
  2914			return 0;
  2915	
  2916		if (!ath10k_mac_is_connected(ar))
  2917			return 0;
  2918	
  2919		ret = ath10k_wmi_pdev_set_param(ar,
  2920						ar->wmi.pdev_param->txpower_limit2g,
  2921						ar->tx_power_2g_limit);
  2922		if (ret) {
  2923			ath10k_warn(ar, "failed to set 2.4G txpower %d: %d\n",
  2924				    ar->tx_power_2g_limit, ret);
  2925			return ret;
  2926		}
  2927	
  2928		ret = ath10k_wmi_pdev_set_param(ar,
  2929						ar->wmi.pdev_param->txpower_limit5g,
  2930						ar->tx_power_5g_limit);
  2931		if (ret) {
  2932			ath10k_warn(ar, "failed to set 5G txpower %d: %d\n",
  2933				    ar->tx_power_5g_limit, ret);
  2934			return ret;
  2935		}
  2936	
  2937		ath10k_dbg(ar, ATH10K_DBG_MAC, "set txpower 2G:%d, 5G:%d successfully\n",
  2938			   ar->tx_power_2g_limit, ar->tx_power_5g_limit);
  2939	
  2940		return ret;
  2941	}
  2942	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32758 bytes --]