From: Brian Norris <briannorris@chromium.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Carl Huang <cjhuang@codeaurora.org>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
dianders@chromium.org, kuabhs@google.com
Subject: Re: [RFC 1/2] nl80211: add common API to configure SAR power limitations.
Date: Wed, 4 Nov 2020 15:18:38 -0800 [thread overview]
Message-ID: <20201104231838.GB3212577@google.com> (raw)
In-Reply-To: <6649b0c2ff988c2ae8723ea633f86cc12da43d95.camel@sipsolutions.net>
On Mon, Sep 28, 2020 at 02:36:09PM +0200, Johannes Berg wrote:
> > +#define NUM_MAX_NL80211_SAR_FREQ_RANGES 0xfe
>
> but I'm not sure what these are used for in the first place, they seem
> more like internal implementation details?
I think the MAX value does have some utility in the API -- as mentioned
in other comments, if we're requiring that user space must SET all
ranges at the same time, then we need an expected way for user space to
SET a "don't care" or "MAX" or "null" value for a band. So if there's
some new band (e.g., 6 GHz?) that user space was not previously aware
of, it will know to use this placeholder.
I think that's kind of approximately what the purpose of this was? It's
not super clear in the documentation, so maybe that should be clarified
in writing in v2.
Brian
WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <briannorris@chromium.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Carl Huang <cjhuang@codeaurora.org>,
linux-wireless@vger.kernel.org, dianders@chromium.org,
ath10k@lists.infradead.org, kuabhs@google.com
Subject: Re: [RFC 1/2] nl80211: add common API to configure SAR power limitations.
Date: Wed, 4 Nov 2020 15:18:38 -0800 [thread overview]
Message-ID: <20201104231838.GB3212577@google.com> (raw)
In-Reply-To: <6649b0c2ff988c2ae8723ea633f86cc12da43d95.camel@sipsolutions.net>
On Mon, Sep 28, 2020 at 02:36:09PM +0200, Johannes Berg wrote:
> > +#define NUM_MAX_NL80211_SAR_FREQ_RANGES 0xfe
>
> but I'm not sure what these are used for in the first place, they seem
> more like internal implementation details?
I think the MAX value does have some utility in the API -- as mentioned
in other comments, if we're requiring that user space must SET all
ranges at the same time, then we need an expected way for user space to
SET a "don't care" or "MAX" or "null" value for a band. So if there's
some new band (e.g., 6 GHz?) that user space was not previously aware
of, it will know to use this placeholder.
I think that's kind of approximately what the purpose of this was? It's
not super clear in the documentation, so maybe that should be clarified
in writing in v2.
Brian
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2020-11-04 23:18 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 5:49 [RFC 1/2] nl80211: add common API to configure SAR power limitations Carl Huang
2020-09-22 5:49 ` Carl Huang
2020-09-22 5:49 ` [RFC 2/2] ath10k: allow dynamic SAR power limits via common API Carl Huang
2020-09-22 5:49 ` Carl Huang
2020-09-22 7:33 ` kernel test robot
2020-09-22 13:32 ` kernel test robot
2020-11-04 23:11 ` Brian Norris
2020-11-04 23:11 ` Brian Norris
2020-11-05 11:27 ` Carl Huang
2020-11-05 11:27 ` Carl Huang
2020-11-05 17:49 ` Brian Norris
2020-11-05 17:49 ` Brian Norris
2020-09-28 12:36 ` [RFC 1/2] nl80211: add common API to configure SAR power limitations Johannes Berg
2020-09-28 12:36 ` Johannes Berg
2020-10-30 20:56 ` Abhishek Kumar
2020-10-30 20:56 ` Abhishek Kumar
2020-10-31 2:46 ` Abhishek Kumar
2020-11-03 2:34 ` Carl Huang
2020-11-03 2:34 ` Carl Huang
2020-11-03 13:15 ` Johannes Berg
2020-11-03 13:15 ` Johannes Berg
2020-11-04 1:17 ` Abhishek Kumar
2020-11-04 1:17 ` Abhishek Kumar
2020-11-04 6:18 ` Carl Huang
2020-11-04 6:18 ` Carl Huang
2020-11-04 8:44 ` Carl Huang
2020-11-04 8:44 ` Carl Huang
2020-11-04 17:48 ` Brian Norris
2020-11-04 17:48 ` Brian Norris
2020-11-05 11:37 ` Carl Huang
2020-11-05 11:37 ` Carl Huang
2020-11-04 23:18 ` Brian Norris [this message]
2020-11-04 23:18 ` Brian Norris
2020-11-04 23:27 ` Brian Norris
2020-11-04 23:27 ` Brian Norris
2020-11-05 11:30 ` Carl Huang
2020-11-05 11:30 ` Carl Huang
-- strict thread matches above, loose matches on Subject: below --
2020-09-22 5:36 Carl Huang
2020-09-22 5:36 ` Carl Huang
2020-09-22 5:47 ` cjhuang
2020-09-22 5:47 ` cjhuang
2020-09-22 8:09 ` Kalle Valo
2020-09-22 8:09 ` Kalle Valo
2020-11-04 2:00 ` Brian Norris
2020-11-04 2:00 ` Brian Norris
2020-11-04 7:32 ` Carl Huang
2020-11-04 7:32 ` Carl Huang
2020-11-04 17:44 ` Brian Norris
2020-11-04 17:44 ` Brian Norris
2020-11-04 17:44 ` Brian Norris
2020-11-05 8:35 ` Kalle Valo
2020-11-05 8:35 ` Kalle Valo
2020-11-05 8:35 ` Kalle Valo
2020-11-05 11:10 ` Carl Huang
2020-11-05 11:10 ` Carl Huang
2020-11-05 11:10 ` Carl Huang
2020-11-05 18:25 ` Brian Norris
2020-11-05 18:25 ` Brian Norris
2020-11-05 18:25 ` Brian Norris
2020-11-06 10:11 ` Carl Huang
2020-11-06 10:11 ` Carl Huang
2020-11-06 10:11 ` Carl Huang
2020-11-05 11:17 ` Carl Huang
2020-11-05 11:17 ` Carl Huang
2020-11-05 11:17 ` Carl Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104231838.GB3212577@google.com \
--to=briannorris@chromium.org \
--cc=ath10k@lists.infradead.org \
--cc=cjhuang@codeaurora.org \
--cc=dianders@chromium.org \
--cc=johannes@sipsolutions.net \
--cc=kuabhs@google.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.