From: Brian Norris <briannorris@chromium.org>
To: Carl Huang <cjhuang@codeaurora.org>
Cc: ath10k <ath10k@lists.infradead.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
Doug Anderson <dianders@chromium.org>,
Abhishek Kumar <kuabhs@google.com>
Subject: Re: [RFC 2/2] ath10k: allow dynamic SAR power limits via common API
Date: Thu, 5 Nov 2020 09:49:49 -0800 [thread overview]
Message-ID: <CA+ASDXMAqF=OWDoQBD=WbwG9WmZsJwmOcjLESkRnLBu6GgqyHQ@mail.gmail.com> (raw)
In-Reply-To: <6563d6ac38368de40cd07ae36f230a86@codeaurora.org>
On Thu, Nov 5, 2020 at 3:27 AM Carl Huang <cjhuang@codeaurora.org> wrote:
> On 2020-11-05 07:11, Brian Norris wrote:
> > On Tue, Sep 22, 2020 at 01:49:35PM +0800, Carl Huang wrote:
> >> + if (ar->tx_power_2g_limit == 0 || ar->tx_power_5g_limit == 0)
> >
> > ath10k_mac_txpower_recalc() doesn't care about this -- why should you?
> > This also seems especially weird, because one of the 2 could be valid
> > nonzero values, and yet you're silently rejecting it. Regardless, the
> > following seems wrong:
> >
> Per current design, it's required for userspace to always set meaningful
> power limitations.
Well, that wasn't specified anywhere (in the docs nor in the nl80211
implementation); if one wanted to enforce that, it should probably go
in the nl80211 layer, not the driver implementation. Otherwise, we're
very prone to varying driver implementations (not a good thing).
> Now in V2, 0 will be treated as "don't have SAR on this range".
OK... I guess that's reasonable, although that should be explicitly
called out in nl80211.h.
Brian
WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <briannorris@chromium.org>
To: Carl Huang <cjhuang@codeaurora.org>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Doug Anderson <dianders@chromium.org>,
ath10k <ath10k@lists.infradead.org>,
Abhishek Kumar <kuabhs@google.com>
Subject: Re: [RFC 2/2] ath10k: allow dynamic SAR power limits via common API
Date: Thu, 5 Nov 2020 09:49:49 -0800 [thread overview]
Message-ID: <CA+ASDXMAqF=OWDoQBD=WbwG9WmZsJwmOcjLESkRnLBu6GgqyHQ@mail.gmail.com> (raw)
In-Reply-To: <6563d6ac38368de40cd07ae36f230a86@codeaurora.org>
On Thu, Nov 5, 2020 at 3:27 AM Carl Huang <cjhuang@codeaurora.org> wrote:
> On 2020-11-05 07:11, Brian Norris wrote:
> > On Tue, Sep 22, 2020 at 01:49:35PM +0800, Carl Huang wrote:
> >> + if (ar->tx_power_2g_limit == 0 || ar->tx_power_5g_limit == 0)
> >
> > ath10k_mac_txpower_recalc() doesn't care about this -- why should you?
> > This also seems especially weird, because one of the 2 could be valid
> > nonzero values, and yet you're silently rejecting it. Regardless, the
> > following seems wrong:
> >
> Per current design, it's required for userspace to always set meaningful
> power limitations.
Well, that wasn't specified anywhere (in the docs nor in the nl80211
implementation); if one wanted to enforce that, it should probably go
in the nl80211 layer, not the driver implementation. Otherwise, we're
very prone to varying driver implementations (not a good thing).
> Now in V2, 0 will be treated as "don't have SAR on this range".
OK... I guess that's reasonable, although that should be explicitly
called out in nl80211.h.
Brian
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2020-11-05 17:50 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 5:49 [RFC 1/2] nl80211: add common API to configure SAR power limitations Carl Huang
2020-09-22 5:49 ` Carl Huang
2020-09-22 5:49 ` [RFC 2/2] ath10k: allow dynamic SAR power limits via common API Carl Huang
2020-09-22 5:49 ` Carl Huang
2020-09-22 7:33 ` kernel test robot
2020-09-22 13:32 ` kernel test robot
2020-11-04 23:11 ` Brian Norris
2020-11-04 23:11 ` Brian Norris
2020-11-05 11:27 ` Carl Huang
2020-11-05 11:27 ` Carl Huang
2020-11-05 17:49 ` Brian Norris [this message]
2020-11-05 17:49 ` Brian Norris
2020-09-28 12:36 ` [RFC 1/2] nl80211: add common API to configure SAR power limitations Johannes Berg
2020-09-28 12:36 ` Johannes Berg
2020-10-30 20:56 ` Abhishek Kumar
2020-10-30 20:56 ` Abhishek Kumar
2020-10-31 2:46 ` Abhishek Kumar
2020-11-03 2:34 ` Carl Huang
2020-11-03 2:34 ` Carl Huang
2020-11-03 13:15 ` Johannes Berg
2020-11-03 13:15 ` Johannes Berg
2020-11-04 1:17 ` Abhishek Kumar
2020-11-04 1:17 ` Abhishek Kumar
2020-11-04 6:18 ` Carl Huang
2020-11-04 6:18 ` Carl Huang
2020-11-04 8:44 ` Carl Huang
2020-11-04 8:44 ` Carl Huang
2020-11-04 17:48 ` Brian Norris
2020-11-04 17:48 ` Brian Norris
2020-11-05 11:37 ` Carl Huang
2020-11-05 11:37 ` Carl Huang
2020-11-04 23:18 ` Brian Norris
2020-11-04 23:18 ` Brian Norris
2020-11-04 23:27 ` Brian Norris
2020-11-04 23:27 ` Brian Norris
2020-11-05 11:30 ` Carl Huang
2020-11-05 11:30 ` Carl Huang
-- strict thread matches above, loose matches on Subject: below --
2020-09-22 5:36 Carl Huang
2020-09-22 5:36 ` [RFC 2/2] ath10k: allow dynamic SAR power limits via common API Carl Huang
2020-09-22 5:36 ` Carl Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+ASDXMAqF=OWDoQBD=WbwG9WmZsJwmOcjLESkRnLBu6GgqyHQ@mail.gmail.com' \
--to=briannorris@chromium.org \
--cc=ath10k@lists.infradead.org \
--cc=cjhuang@codeaurora.org \
--cc=dianders@chromium.org \
--cc=kuabhs@google.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.